Browse Source

Merge pull request #13753 from owncloud/use-403-instead-of-200

Use 403 instead of 200 response
remotes/origin/log-external-deletes
Morris Jobke 11 years ago
parent
commit
485e2a282b
  1. 4
      settings/middleware/subadminmiddleware.php
  2. 6
      tests/settings/middleware/subadminmiddlewaretest.php

4
settings/middleware/subadminmiddleware.php

@ -59,7 +59,9 @@ class SubadminMiddleware extends Middleware {
* @return TemplateResponse
*/
public function afterException($controller, $methodName, \Exception $exception) {
return new TemplateResponse('core', '403', array(), 'guest');
$response = new TemplateResponse('core', '403', array(), 'guest');
$response->setStatus(Http::STATUS_FORBIDDEN);
return $response;
}
}

6
tests/settings/middleware/subadminmiddlewaretest.php

@ -81,11 +81,9 @@ class SubadminMiddlewareTest extends \Test\TestCase {
$this->subadminMiddlewareAsSubAdmin->beforeController($this->controller, 'foo');
}
public function testAfterException() {
$expectedResponse = new TemplateResponse('core', '403', array(), 'guest');
$expectedResponse->setStatus(403);
$this->assertEquals($expectedResponse, $this->subadminMiddleware->afterException($this->controller, 'foo', new \Exception()));
}
}
}
Loading…
Cancel
Save