From 5d068ff5341b7af8c08c97fb77d90741c2f5f1e0 Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Thu, 2 Feb 2023 11:58:55 +0100 Subject: [PATCH 1/2] Fix autotest.sh execution Signed-off-by: Joas Schilling --- autotest.sh | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/autotest.sh b/autotest.sh index 84ffa0a1c78..09b983bbfa2 100755 --- a/autotest.sh +++ b/autotest.sh @@ -30,15 +30,15 @@ if [ -z "$PHP_EXE" ]; then fi PHP=$(which "$PHP_EXE") if [ -z "$PHPUNIT_EXE" ]; then - if [ -f "build/integration/vendor/bin/phpunit" ]; then - PHPUNIT_EXE="./build/integration/vendor/bin/phpunit" - else - PHPUNIT_EXE=phpunit - fi + if [ -f build/integration/vendor/bin/phpunit ]; then + PHPUNIT_EXE="./build/integration/vendor/bin/phpunit" + PHPUNIT=$(readlink -f "$PHPUNIT_EXE") + else + PHPUNIT_EXE=phpunit + PHPUNIT=$(which "$PHPUNIT_EXE") + fi fi -PHPUNIT=$(which "$PHPUNIT_EXE") - set -e _XDEBUG_CONFIG=$XDEBUG_CONFIG @@ -400,8 +400,8 @@ function execute_tests { echo "No coverage" fi - echo "$PHP" "${PHPUNIT[@]}" --configuration phpunit-autotest.xml $GROUP $COVER --log-junit "autotest-results-$DB.xml" "$2" "$3" - "$PHP" "${PHPUNIT[@]}" --configuration phpunit-autotest.xml $GROUP $COVER --log-junit "autotest-results-$DB.xml" "$2" "$3" + echo "$PHPUNIT" --configuration phpunit-autotest.xml $GROUP $COVER --log-junit "autotest-results-$DB.xml" "$2" "$3" + "$PHPUNIT" --configuration phpunit-autotest.xml $GROUP $COVER --log-junit "autotest-results-$DB.xml" "$2" "$3" RESULT=$? if [ "$PRIMARY_STORAGE_CONFIG" == "swift" ] ; then From 5096d4f5cbdcf9c4e4beeb8e234105a1cffe711b Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Thu, 2 Feb 2023 12:03:09 +0100 Subject: [PATCH 2/2] Align version number of PHPUnit and give a helping install hint Signed-off-by: Joas Schilling --- autotest.sh | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/autotest.sh b/autotest.sh index 09b983bbfa2..81123b40567 100755 --- a/autotest.sh +++ b/autotest.sh @@ -61,7 +61,8 @@ else fi if ! [ -x "$PHPUNIT" ]; then - echo "phpunit executable not found, please install phpunit version >= 9.0" >&2 + echo "phpunit executable not found, please install phpunit version >= 9.0 manually or via:" >&2 + echo " cd build/integration && composer install" >&2 exit 3 fi @@ -76,8 +77,8 @@ PHPUNIT_VERSION=$($PHPUNIT --version | cut -d" " -f2) PHPUNIT_MAJOR_VERSION=$(echo "$PHPUNIT_VERSION" | cut -d"." -f1) PHPUNIT_MINOR_VERSION=$(echo "$PHPUNIT_VERSION" | cut -d"." -f2) -if ! [ "$PHPUNIT_MAJOR_VERSION" -gt 6 -o \( "$PHPUNIT_MAJOR_VERSION" -eq 6 -a "$PHPUNIT_MINOR_VERSION" -ge 5 \) ]; then - echo "phpunit version >= 6.5 required. Version found: $PHPUNIT_VERSION" >&2 +if ! [ "$PHPUNIT_MAJOR_VERSION" -gt 6 -o \( "$PHPUNIT_MAJOR_VERSION" -eq 9 -a "$PHPUNIT_MINOR_VERSION" -ge 0 \) ]; then + echo "phpunit version >= 9.0 required. Version found: $PHPUNIT_VERSION" >&2 exit 4 fi