Merge pull request #5367 from nextcloud/better-share-error

Better error message on invalid sharing link

lib/private/Share20/Manager.php

@@ -1090,7 +1090,7 @@ class Manager implements IManager {
 		}
 
 		if ($share === null) {
-			throw new ShareNotFound();
+			throw new ShareNotFound($this->l->t('The requested share does not exist anymore'));
 		}
 
 		$this->checkExpireDate($share);
@@ -1110,7 +1110,7 @@ class Manager implements IManager {
 		if ($share->getExpirationDate() !== null &&
 			$share->getExpirationDate() <= new \DateTime()) {
 			$this->deleteShare($share);
-			throw new ShareNotFound();
+			throw new ShareNotFound($this->l->t('The requested share does not exist anymore'));
 		}
 
 	}

tests/lib/Share20/ManagerTest.php

@@ -2142,6 +2142,7 @@ class ManagerTest extends \Test\TestCase {
 
 	/**
 	 * @expectedException \OCP\Share\Exceptions\ShareNotFound
+	 * @expectedExceptionMessage The requested share does not exist anymore
 	 */
 	public function testGetShareByTokenExpired() {
 		$this->config
@@ -2150,6 +2151,10 @@ class ManagerTest extends \Test\TestCase {
 			->with('core', 'shareapi_allow_links', 'yes')
 			->willReturn('yes');
 
+		$this->l->expects($this->once())
+			->method('t')
+			->willReturnArgument(0);
+
 		$manager = $this->createManagerMock()
 			->setMethods(['deleteShare'])
 			->getMock();