Browse Source

Merge pull request #45789 from nextcloud/fix/cy-selector

pull/45811/head
John Molakvoæ 1 year ago
committed by GitHub
parent
commit
0b10f2d478
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 2
      apps/files/src/views/Sidebar.vue
  2. 2
      cypress/e2e/files/FilesUtils.ts
  3. 12
      cypress/e2e/files/files-sidebar.cy.ts
  4. 6
      dist/files-sidebar.js
  5. 2
      dist/files-sidebar.js.map

2
apps/files/src/views/Sidebar.vue

@ -6,7 +6,7 @@
<template>
<NcAppSidebar v-if="file"
ref="sidebar"
cy-data-sidebar
data-cy-sidebar
v-bind="appSidebar"
:force-menu="true"
@close="close"

2
cypress/e2e/files/FilesUtils.ts

@ -113,7 +113,7 @@ export const navigateToFolder = (dirPath: string) => {
export const closeSidebar = () => {
// {force: true} as it might be hidden behind toasts
cy.get('[cy-data-sidebar] .app-sidebar__close').click({ force: true })
cy.get('[data-cy-sidebar] .app-sidebar__close').click({ force: true })
}
export const clickOnBreadcrumbs = (label: string) => {

12
cypress/e2e/files/files-sidebar.cy.ts

@ -26,7 +26,7 @@ describe('Files: Sidebar', { testIsolation: true }, () => {
triggerActionForFile('file', 'details')
cy.get('[cy-data-sidebar]').should('be.visible')
cy.get('[data-cy-sidebar]').should('be.visible')
})
it('changes the current fileid', () => {
@ -35,7 +35,7 @@ describe('Files: Sidebar', { testIsolation: true }, () => {
triggerActionForFile('file', 'details')
cy.get('[cy-data-sidebar]').should('be.visible')
cy.get('[data-cy-sidebar]').should('be.visible')
cy.url().should('contain', `apps/files/files/${fileId}`)
})
@ -46,10 +46,10 @@ describe('Files: Sidebar', { testIsolation: true }, () => {
// open the sidebar
triggerActionForFile('file', 'details')
// validate it is open
cy.get('[cy-data-sidebar]').should('be.visible')
cy.get('[data-cy-sidebar]').should('be.visible')
triggerActionForFile('file', 'delete')
cy.get('[cy-data-sidebar]').should('not.exist')
cy.get('[data-cy-sidebar]').should('not.exist')
})
it('changes the fileid on delete', () => {
@ -65,11 +65,11 @@ describe('Files: Sidebar', { testIsolation: true }, () => {
// open the sidebar
triggerActionForFile('other', 'details')
// validate it is open
cy.get('[cy-data-sidebar]').should('be.visible')
cy.get('[data-cy-sidebar]').should('be.visible')
cy.url().should('contain', `apps/files/files/${otherFileId}`)
triggerActionForFile('other', 'delete')
cy.get('[cy-data-sidebar]').should('not.exist')
cy.get('[data-cy-sidebar]').should('not.exist')
// Ensure the URL is changed
cy.url().should('not.contain', `apps/files/files/${otherFileId}`)
})

6
dist/files-sidebar.js
File diff suppressed because it is too large
View File

2
dist/files-sidebar.js.map
File diff suppressed because it is too large
View File

Loading…
Cancel
Save