Browse Source

Cache registered autoloaders

This saves more than 20ms (!) on every request, the previous problem was that `\OC_App::registerAutoloading` calls `\OC\AppFramework\App::buildAppNamespace` which parses the appinfo.xml. Since that was also called multiple times (e.g. on cloud.nextcloud.com over 200 times) that had a significant performance impact. Also on simple PROPFIND requests.

https://blackfire.io/profiles/compare/65a53e6e-7f35-4974-b559-4c81abd01c3b/graph shows the difference nicely.
pull/1017/head
Lukas Reschke 10 years ago
parent
commit
0747e96b9c
No known key found for this signature in database GPG Key ID: B9F6980CF6E759B1
  1. 6
      lib/private/legacy/app.php

6
lib/private/legacy/app.php

@ -66,6 +66,7 @@ class OC_App {
static private $appTypes = array();
static private $loadedApps = array();
static private $altLogin = array();
static private $alreadyRegistered = [];
const officialApp = 200;
/**
@ -167,6 +168,11 @@ class OC_App {
* @param string $path
*/
public static function registerAutoloading($app, $path) {
$key = $app . '-' . $path;
if(isset(self::$alreadyRegistered[$key])) {
return;
}
self::$alreadyRegistered[$key] = true;
// Register on PSR-4 composer autoloader
$appNamespace = \OC\AppFramework\App::buildAppNamespace($app);
\OC::$composerAutoloader->addPsr4($appNamespace . '\\', $path . '/lib/', true);

Loading…
Cancel
Save