From 14b5b358a53c1ac6e51d54702fc0b4193dd77f4b Mon Sep 17 00:00:00 2001 From: www-data Date: Mon, 26 Aug 2013 15:19:28 +0200 Subject: [PATCH] change default log, adding comments --- bootstrap.php | 8 +++++++- index.php | 1 - system/Logs/Logs.php | 5 ++++- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/bootstrap.php b/bootstrap.php index aa6dc2083..db4fbb04f 100644 --- a/bootstrap.php +++ b/bootstrap.php @@ -185,7 +185,13 @@ class Bootstrap { } catch (Exception $e) { define('ENVIRONMENT','development');//default environment is production } - define('LOG_MANAGEMENT','log_folder');//'error_log' || 'log_folder' || 'syslog' + /** + * LOG_MANAGEMENT: define where logs are saved, prefer error_log, or log_folder if you use mutual server. + * 'error_log' : save in file defined on your file server + * 'log_folder' : save in log folder, in DOCUMENT_ROOT.'/log' + * 'syslog' : save in global system logs (not in file server logs) + */ + define('LOG_MANAGEMENT','error_log'); if (ENVIRONMENT === 'development') { ini_set('log_errors', 1); ini_set('display_errors', 0); diff --git a/index.php b/index.php index 15e1c7cbd..b0ff2728b 100644 --- a/index.php +++ b/index.php @@ -50,7 +50,6 @@ try { $rqst->handle(); WidgetWrapper::getInstance(false); - // Closing stuff WidgetWrapper::destroyInstance(); diff --git a/system/Logs/Logs.php b/system/Logs/Logs.php index 2a1a2db6e..2f35a98e6 100644 --- a/system/Logs/Logs.php +++ b/system/Logs/Logs.php @@ -263,7 +263,10 @@ class Logs error_log($this->getDisplayLog($log,true,true)); } else if (LOG_MANAGEMENT == 'syslog') { - syslog($log['level'], $this->getDisplayLog($log,true,true)); + if (!syslog($log['level'], $this->getDisplayLog($log,true,true))) { + throw new \Exception('Error, unable to use syslog'); + } + } }