mariadb

Tree: ce5c87a3d3

Konstantin Osipov ce5c87a3d3 Backport of: ---------------------------------------------------------- revno: 2617.69.20 committer: Konstantin Osipov <kostja@sun.com> branch nick: 5.4-4284-1-assert timestamp: Thu 2009-08-13 18:29:55 +0400 message: WL#4284 "Transactional DDL locking" A review fix. Since WL#4284 implementation separated MDL_request and MDL_ticket, MDL_request becamse a utility object necessary only to get a ticket. Store it by-value in TABLE_LIST with the intent to merge MDL_request::key with table_list->table_name and table_list->db in future. Change the MDL subsystem to not require MDL_requests to stay around till close_thread_tables(). Remove the list of requests from the MDL context. Requests for shared metadata locks acquired in open_tables() are only used as a list in recover_from_failed_open_table_attempt(), which calls mdl_context.wait_for_locks() for this list. To keep such list for recover_from_failed_open_table_attempt(), introduce a context class (Open_table_context), that collects all requests. A lot of minor cleanups and simplications that became possible with this change. sql/event_db_repository.cc: Remove alloc_mdl_requests(). Now MDL_request instance is a member of TABLE_LIST, and init_one_table() initializes it. sql/ha_ndbcluster_binlog.cc: Remove now unnecessary declaration and initialization of binlog_mdl_request. sql/lock.cc: No need to allocate MDL requests in lock_table_names() now. sql/log.cc: Use init_one_table() method, remove alloc_mdl_requests(), which is now unnecessary. sql/log_event.cc: No need to allocate mdl_request separately now. Use init_one_table() method. sql/log_event_old.cc: Update to the new signature of close_tables_for_reopen(). sql/mdl.cc: Update try_acquire_exclusive_lock() to be more easy to use. Function lock_table_name_if_not_cached() has been removed. Make acquire_shared_lock() signature consistent with try_acquire_exclusive_lock() signature. Remove methods that are no longer used. Update comments. sql/mdl.h: Implement an assignment operator that doesn't copy MDL_key (MDL_key::operator= is private and should remain private). This is a hack to work-around assignment of TABLE_LIST by value in several places. Such assignments violate encapsulation, since only perform a shallow copy. In most cases these assignments are a hack on their own. sql/mysql_priv.h: Update signatures of close_thread_tables() and close_tables_for_reopen(). sql/sp.cc: Allocate TABLE_LIST in thd->mem_root. Use init_one_table(). sql/sp_head.cc: Use init_one_table(). Remove thd->locked_tables_root, it's no longer needed. sql/sql_acl.cc: Use init_mdl_requests() and init_one_table(). sql/sql_base.cc: Update to new signatures of try_acquire_shared_lock() and try_acquire_exclusive_lock(). Remove lock_table_name_if_not_cached(). Fix a bug in open_ltable() that would not return ER_LOCK_DEADLOCK in case of a failed lock_tables() and a multi-statement transaction. Fix a bug in open_and_lock_tables_derived() that would not return ER_LOCK_DEADLOCK in case of a multi-statement transaction and a failure of lock_tables(). Move assignment of enum_open_table_action to a method of Open_table_context, a new class that maintains information for backoff actions. Minor rearrangements of the code. Remove alloc_mdl_requests() in functions that work with system tables: instead the patch ensures that callers always initialize TABLE_LIST argument. sql/sql_class.cc: THD::locked_tables_root is no more. sql/sql_class.h: THD::locked_tables_root is no more. Add a declaration for Open_table_context class. sql/sql_delete.cc: Update to use the simplified MDL API. sql/sql_handler.cc: TABLE_LIST::mdl_request is stored by-value now. Ensure that mdl_request.ticket is NULL for every request that is passed into MDL, to satisfy MDL asserts. @ sql/sql_help.cc Function open_system_tables_for_read() no longer initializes mdl_requests. Move TABLE_LIST::mdl_request initialization closer to TABLE_LIST initialization. sql/sql_help.cc: Function open_system_tables_for_read() no longer initializes mdl_requests. Move TABLE_LIST::mdl_request initialization closer to TABLE_LIST initialization. sql/sql_insert.cc: Remove assignment by-value of TABLE_LIST in TABLEOP_HOOKS. We can't carry over a granted MDL ticket from one table list to another. sql/sql_parse.cc: Change alloc_mdl_requests() -> init_mdl_requests(). @todo We can remove init_mdl_requests() altogether in some places: all places that call add_table_to_list() already have mdl requests initialized. sql/sql_plugin.cc: Use init_one_table(). THD::locked_tables_root is no more. sql/sql_servers.cc: Use init_one_table(). sql/sql_show.cc: Update acquire_high_priority_shared_lock() to use TABLE_LIST::mdl_request rather than allocate an own. Fix get_trigger_table_impl() to use init_one_table(), check for out of memory, follow the coding style. sql/sql_table.cc: Update to work with TABLE_LIST::mdl_request by-value. Remove lock_table_name_if_not_cached(). The code that used to delegate to it is quite simple and concise without it now. sql/sql_udf.cc: Use init_one_table(). sql/sql_update.cc: Update to use the new signature of close_tables_for_reopen(). sql/table.cc: Move re-setting of mdl_requests for prepared statements and stored procedures from close_thread_tables() to reinit_stmt_before_use(). Change alloc_mdl_requests() to init_mdl_requests(). init_mdl_requests() is a hack that can't be deleted until we don't have a list-aware TABLE_LIST constructor. Hopefully its use will be minimal sql/table.h: Change alloc_mdl_requests() to init_mdl_requests() TABLE_LIST::mdl_request is stored by value. sql/tztime.cc: We no longer initialize mdl requests in open_system_tables_for*() functions. Move this initialization closer to initialization of the rest of TABLE_LIST members. storage/myisammrg/ha_myisammrg.cc: Simplify mdl_request initialization.		16 years ago
..
.cvsignore	Changes to create storage directory for storage engines.	21 years ago
CMakeLists.txt	Backport http://lists.mysql.com/commits/57778	16 years ago
Makefile.am	Ensure that all dtrace files are properly removed during make clean	17 years ago
ha_myisammrg.cc	Backport of:	16 years ago
ha_myisammrg.h	Backport of:	16 years ago
make-ccc	Changes to create storage directory for storage engines.	21 years ago
myrg_close.c	Backport of:	16 years ago
myrg_create.c	Backport of:	16 years ago
myrg_def.h	Merge mysql.com:/home/svoj/devel/mysql/BUG26976/mysql-5.0-engines	19 years ago
myrg_delete.c	WL#3817: Simplify string / memory area types and make things more consistent (first part)	19 years ago
myrg_extra.c	Backport of:	16 years ago
myrg_info.c	null merge of the backport of Chad's fix for bug #39326 to 5.1-bugteam	16 years ago
myrg_locking.c	BUG#29806 - binlog_innodb.test creates a server log	19 years ago
myrg_open.c	Backport of:	16 years ago
myrg_panic.c	Merge mysql.com:/home/kent/bk/main/mysql-5.0	19 years ago
myrg_queue.c	WL#3817: Simplify string / memory area types and make things more consistent (first part)	19 years ago
myrg_range.c	Merge mysql.com:/home/kent/bk/main/mysql-5.0	19 years ago
myrg_records.c	Fixed bug#36006: Optimizer does table scan for SELECT COUNT(*)	18 years ago
myrg_rfirst.c	WL#3817: Simplify string / memory area types and make things more consistent (first part)	19 years ago
myrg_rkey.c	Merge from 5.0 for 43414	16 years ago
myrg_rlast.c	WL#3817: Simplify string / memory area types and make things more consistent (first part)	19 years ago
myrg_rnext.c	WL#3817: Simplify string / memory area types and make things more consistent (first part)	19 years ago
myrg_rnext_same.c	WL#3817: Simplify string / memory area types and make things more consistent (first part)	19 years ago
myrg_rprev.c	WL#3817: Simplify string / memory area types and make things more consistent (first part)	19 years ago
myrg_rrnd.c	WL#3817: Simplify string / memory area types and make things more consistent (first part)	19 years ago
myrg_rsame.c	WL#3817: Simplify string / memory area types and make things more consistent (first part)	19 years ago
myrg_static.c	Merge mysql.com:/home/kent/bk/main/mysql-5.0	19 years ago
myrg_update.c	WL#3817: Simplify string / memory area types and make things more consistent (first part)	19 years ago
myrg_write.c	WL#3817: Simplify string / memory area types and make things more consistent (first part)	19 years ago
plug.in	bug #23369 (Embedded library can't be linked)	19 years ago