mariadb

Tree: f4e5069f60

Author	SHA1	Message	Date
Marko Mäkelä	326d75bd41	Merge a contribution from Ryan Mack at Facebook: Bugfix for 53290, fast unique index creation fails on duplicate null values Summary: Bug in the fast index creation code incorrectly considers null values to be duplicates during block merging. Innodb policy is that multiple null values are allowed in a unique index. Null duplicates were correctly ignored while sorting individual blocks and with slow index creation. Test Plan: mtr, including new test, load dbs using deferred index creation DiffCamp Revision: 110840 Reviewed By: mcallaghan CC: mcallaghan, mysql-devel@lists Revert Plan: OK	16 years ago
Marko Mäkelä	3f8a812d7a	row_merge_drop_temp_indexes(): Load the table via the dictionary cache. Allow multiple indexes to be dropped. (Bug #53256)	16 years ago
Marko Mäkelä	a5b4285132	row_merge_drop_temp_indexes(): Remove a bogus char-to-ulint cast.	16 years ago
Sergey Vojtovich	17f8a9f2ac	Applying InnoDB snapshot Detailed revision comments: r6754 \| marko \| 2010-02-24 10:56:43 +0200 (Wed, 24 Feb 2010) \| 17 lines branches/zip: Allocate the merge sort buffers from a heap, not stack. The merge sort can use up to 48KiB of buffers when merging blocks. That can cause a stack overflow, especially on 64-bit systems when not building with inlined functions. This was reported as Issue #462. row_merge_dup_report(): Allocate buf and offsets from a heap. row_merge_heap_create(): Allocate space for buf[3] too. Fix bogus sizeof arithmetics that happened to work, because sizeof(ulint)==sizeof(void*). row_merge_blocks(), row_merge_blocks_copy(): Allocate buf[3] from heap. row_merge_insert_index_tuples(): Allocate buf from graph_heap. rb://258 approved and tested by Sunny Bains	16 years ago
Sergey Vojtovich	44a0ff6c76	Applying InnoDB snapshot Detailed revision comments: r6749 \| vasil \| 2010-02-20 18:45:41 +0200 (Sat, 20 Feb 2010) \| 5 lines Non-functional change: update copyright year to 2010 of the files that have been modified after 2010-01-01 according to svn. for f in $(svn log -v -r{2010-01-01}:HEAD \|grep "^ M " \|cut -b 16- \|sort -u) ; do sed -i "" -E 's/(Copyright $c$ [0-9]{4},) [0-9]{4}, (.*Innobase Oy.+All Rights Reserved)/\1 2010, \2/' $f ; done	16 years ago
Sergey Vojtovich	54ed7dc2bb	Applying InnoDB snapshot Detailed revision comments: r6610 \| marko \| 2010-02-09 13:53:59 +0200 (Tue, 09 Feb 2010) \| 17 lines branches/zip: When dropping temporary indexes and tables at startup, first load them to the data dictionary cache and use the normal routines for dropping tables or indexes. This should reduce the risk of bugs and also make the code compatible with the upcoming TablespaceDictionary implementation. DICT_SYS_INDEXES_NAME_FIELD: The clustered index position of SYS_INDEXES.NAME. row_merge_drop_temp_indexes(): Scan SYS_INDEXES for tables containing temporary indexes, and load the tables as needed. Invoke row_merge_drop_index() to drop the indexes. row_mysql_drop_temp_tables(): Scan SYS_TABLES for temporary tables, load them with dict_load_table() and drop them with row_drop_table_for_mysql(). rb://251, not yet reviewed	16 years ago
Sergey Vojtovich	1a9d1bf94a	Applying InnoDB snapshot Detailed revision comments: r6591 \| marko \| 2010-02-08 10:06:39 +0200 (Mon, 08 Feb 2010) \| 3 lines branches/zip: row_merge_drop_index(): Remove redundant condition on SYS_INDEXES.TABLE_ID. INDEX_ID must be instance-widely unique, because SYS_FIELDS is not indexed by TABLE_ID.	16 years ago
Sergey Vojtovich	af071005f9	Applying InnoDB snapshot Detailed revision comments: r6321 \| marko \| 2009-12-16 16:16:33 +0200 (Wed, 16 Dec 2009) \| 4 lines branches/zip: row_merge_drop_temp_indexes(): Revert a hack to transaction isolation level that was made unnecessary by r5826 (Issue #337). When this function is called, any active data dictionary transaction should have been rolled back.	16 years ago
Satya B	444c6d0d73	Applying InnoDB Plugin 1.0.6 snapshot, part 6. Add Testcase for BUG#46676 1. add testcase for BUG#46676 2. Allow CREATE INDEX to be interrupted 3. ha_innobase::change_active_index(): When the history is missing, report it to the client, not to the error log 4. ChangeLog entries appplied revisions:r6169, r6170, r6175, r6177, r6179 Detailed revision comments: r6169 \| calvin \| 2009-11-12 14:40:43 +0200 (Thu, 12 Nov 2009) \| 6 lines branches/zip: add test case for bug#46676 This crash is reproducible with InnoDB plugin 1.0.4 + MySQL 5.1.37. But no longer reproducible after MySQL 5.1.38 (with plugin 1.0.5). Add test case to catch future regression. r6170 \| marko \| 2009-11-12 15:49:08 +0200 (Thu, 12 Nov 2009) \| 4 lines branches/zip: Allow CREATE INDEX to be interrupted. (Issue #354) rb://183 approved by Heikki Tuuri r6175 \| vasil \| 2009-11-16 20:07:39 +0200 (Mon, 16 Nov 2009) \| 4 lines branches/zip: Wrap line at 78th char in the ChangeLog r6177 \| calvin \| 2009-11-16 20:20:38 +0200 (Mon, 16 Nov 2009) \| 2 lines branches/zip: add an entry to ChangeLog for r6065 r6179 \| marko \| 2009-11-17 10:19:34 +0200 (Tue, 17 Nov 2009) \| 2 lines branches/zip: ha_innobase::change_active_index(): When the history is missing, report it to the client, not to the error log.	16 years ago
Satya B	e011c02e2f	Applying InnoDB Plugin 1.0.5 snapshot ,part 12 From r5995 to r6043 Detailed revision comments: r5995 \| marko \| 2009-09-28 03:52:25 -0500 (Mon, 28 Sep 2009) \| 17 lines branches/zip: Do not write to PAGE_INDEX_ID after page creation, not even when restoring an uncompressed page after a compression failure. btr_page_reorganize_low(): On compression failure, do not restore those page header fields that should not be affected by the reorganization. Instead, compare the fields. page_zip_decompress(): Add the parameter ibool all, for copying all page header fields. Pass the parameter all=TRUE on block read completion, redo log application, and page_zip_validate(); pass all=FALSE in all other cases. page_zip_reorganize(): Do not restore the uncompressed page on failure. It will be restored (to pre-modification state) by the caller anyway. rb://167, Issue #346 r5996 \| marko \| 2009-09-28 07:46:02 -0500 (Mon, 28 Sep 2009) \| 4 lines branches/zip: Address Issue #350 in comments. lock_rec_queue_validate(), lock_rec_queue_validate(): Note that this debug code may violate the latching order and cause deadlocks. r5997 \| marko \| 2009-09-28 08:03:58 -0500 (Mon, 28 Sep 2009) \| 12 lines branches/zip: Remove an assertion failure when the InnoDB data dictionary is inconsistent with the MySQL .frm file. ha_innobase::index_read(): When the index cannot be found, return an error. ha_innobase::change_active_index(): When prebuilt->index == NULL, set also prebuilt->index_usable = FALSE. This is not needed for correctness, because prebuilt->index_usable is only checked by row_search_for_mysql(), which requires prebuilt->index != NULL. This addresses Issue #349. Approved by Heikki Tuuri over IM. r6005 \| vasil \| 2009-09-29 03:09:52 -0500 (Tue, 29 Sep 2009) \| 4 lines branches/zip: ChangeLog: wrap around 78th column, not earlier. r6006 \| vasil \| 2009-09-29 05:15:25 -0500 (Tue, 29 Sep 2009) \| 4 lines branches/zip: Add ChangeLog entry for the release of 1.0.4. r6007 \| vasil \| 2009-09-29 08:19:59 -0500 (Tue, 29 Sep 2009) \| 6 lines branches/zip: Fix the year, should be 2009. Pointed by: Calvin r6026 \| marko \| 2009-09-30 02:18:24 -0500 (Wed, 30 Sep 2009) \| 1 line branches/zip: Add some debug assertions for checking FSEG_MAGIC_N. r6028 \| marko \| 2009-09-30 08:55:23 -0500 (Wed, 30 Sep 2009) \| 3 lines branches/zip: recv_no_log_write: New debug flag for tracking down Mantis Issue #347. No modifications should be made to the database while recv_apply_hashed_log_recs() is about to complete. r6029 \| calvin \| 2009-09-30 15:32:02 -0500 (Wed, 30 Sep 2009) \| 4 lines branches/zip: non-functional changes Fix typo. r6031 \| marko \| 2009-10-01 06:24:33 -0500 (Thu, 01 Oct 2009) \| 49 lines branches/zip: Clean up after a crash during DROP INDEX. When InnoDB crashes while dropping an index, ensure that the index will be completely dropped during crash recovery. row_merge_drop_index(): Before dropping an index, rename the index to start with TEMP_INDEX_PREFIX_STR and commit the change, so that row_merge_drop_temp_indexes() will drop the index after crash recovery if the server crashes while dropping the index. fseg_inode_try_get(): New function, forked from fseg_inode_get(). Return NULL if the file segment index node is free. fseg_inode_get(): Assert that the file segment index node is not free. fseg_free_step(): If the file segment index node is already free, print a diagnostic message and return TRUE. fsp_free_seg_inode(): Write a nonzero number to FSEG_MAGIC_N, so that allocated-and-freed file segment index nodes can be better distinguished from uninitialized ones. This is rb://174, addressing Issue #348. Tested by restarting mysqld upon the completion of the added log_write_up_to() invocation below, during DROP INDEX. The index was dropped after crash recovery, and re-issuing the DROP INDEX did not crash the server. Index: btr/btr0btr.c =================================================================== --- btr/btr0btr.c (revision 6026) +++ btr/btr0btr.c (working copy) @@ -42,6 +42,7 @@ Created 6/2/1994 Heikki Tuuri #include "ibuf0ibuf.h" #include "trx0trx.h" +#include "log0log.h" /* Latching strategy of the InnoDB B-tree -------------------------------------- @@ -873,6 +874,8 @@ leaf_loop: goto leaf_loop; } + + log_write_up_to(mtr.end_lsn, LOG_WAIT_ALL_GROUPS, TRUE); top_loop: mtr_start(&mtr); r6033 \| calvin \| 2009-10-01 15:19:46 -0500 (Thu, 01 Oct 2009) \| 4 lines branches/zip: fix a typo in error message Reported as bug#47763. r6043 \| inaam \| 2009-10-05 09:45:35 -0500 (Mon, 05 Oct 2009) \| 12 lines branches/zip rb://176 Do not invalidate buffer pool while an LRU batch is active. Added code to buf_pool_invalidate() to wait for the running batches to finish. This patch also resets the state of buf_pool struct at invalidation. This addresses the concern where buf_pool->freed_page_clock becomes non-zero because we read in a system tablespace page for file format info at startup. Approved by: Marko	16 years ago
Satya B	963d2d432b	Applying InnoDB Plugin 1.0.5 snapshot, part 6 From revision r5748 to r5783 Detailed revision comments: r5748 \| marko \| 2009-09-03 06:05:44 -0500 (Thu, 03 Sep 2009) \| 1 line branches/zip: MLOG_MULTI_REC_END: Correct the comment. r5751 \| marko \| 2009-09-03 09:36:15 -0500 (Thu, 03 Sep 2009) \| 7 lines branches/zip: row_merge(): Remove a bogus debug assertion that was triggered when creating an index on an empty table. row_merge_sort(): Add debug assertions and comments that justify the loop termination condition. The bogus assertion ut_ad(ihalf > 0) was reported by Michael. r5752 \| marko \| 2009-09-03 09:55:51 -0500 (Thu, 03 Sep 2009) \| 10 lines branches/zip: recv_recover_page_func(): Write the log sequence number to the compressed page, if there is one. Previously, the function only wrote the LSN to the uncompressed page. It is not clear why recv_recover_page_func() is updating FIL_PAGE_LSN in the buffer pool. The log sequence number will be stamped on the page when it is flushed to disk, in buf_flush_init_for_writing(). I noticed this inconsistency when analyzing Issue #313, but this patch does not fix it. That is no surprise, since FIL_PAGE_LSN should only matter on disk files, not in the buffer pool. r5775 \| calvin \| 2009-09-07 16:15:05 -0500 (Mon, 07 Sep 2009) \| 13 lines branches/zip: Build InnoDB on Windows with UNIV_HOTBACKUP The changes are non-functional changes for normal InnoDB, but needed for building the Hot Backup on Windows (with UNIV_HOTBACKUP defined). - Define os_aio_use_native_aio for HB. - Do not acquire seek mutexes for backup since HB is single threaded. - Do not use srv_flush_log_at_trx_commit for HB build rb://155 Approved by: Marko r5777 \| marko \| 2009-09-08 10:50:25 -0500 (Tue, 08 Sep 2009) \| 2 lines branches/zip: Remove BUF_LRU_INITIAL_RATIO, which should have been removed together with buf_LRU_get_recent_limit(). r5779 \| marko \| 2009-09-09 01:17:19 -0500 (Wed, 09 Sep 2009) \| 2 lines branches/zip: buf_page_peek_if_too_old(): Make the bitmasking work when buf_pool->freed_page_clock is wider than 32 bits. r5780 \| marko \| 2009-09-09 01:50:50 -0500 (Wed, 09 Sep 2009) \| 1 line branches/zip: ut_time_ms(): Return ulint, not uint. r5782 \| marko \| 2009-09-09 02:00:59 -0500 (Wed, 09 Sep 2009) \| 2 lines branches/zip: buf_page_peek_if_too_old(): Silence a compiler warning that was introduced in r5779 on 32-bit systems. r5783 \| marko \| 2009-09-09 02:25:00 -0500 (Wed, 09 Sep 2009) \| 1 line branches/zip: buf_page_is_accessed(): Correct the function comment.	16 years ago
Satya B	abfdf76bbf	Applying InnoDB Plugin 1.0.5 snapshot, part 4 From revision r5703 to r5716 Detailed revision comments: r5703 \| marko \| 2009-08-27 02:25:00 -0500 (Thu, 27 Aug 2009) \| 41 lines branches/zip: Replace the constant 3/8 ratio that controls the LRU_old size with the settable global variable innodb_old_blocks_pct. The minimum and maximum values are 5 and 95 per cent, respectively. The default is 1003/8, in line with the old behavior. ut_time_ms(): New utility function, to return the current time in milliseconds. TODO: Is there a more efficient timestamp function, such as rdtsc divided by a power of two? buf_LRU_old_threshold_ms: New variable, corresponding to innodb_old_blocks_time. The value 0 is the default behaviour: no timeout before making blocks 'new'. bpage->accessed, bpage->LRU_position, buf_pool->ulint_clock: Remove. bpage->access_time: New field, replacing bpage->accessed. Protected by buf_pool_mutex instead of bpage->mutex. Updated when a page is created or accessed the first time in the buffer pool. buf_LRU_old_ratio, innobase_old_blocks_pct: New variables, corresponding to innodb_old_blocks_pct buf_LRU_old_ratio_update(), innobase_old_blocks_pct_update(): Update functions for buf_LRU_old_ratio, innobase_old_blocks_pct. buf_page_peek_if_too_old(): Compare ut_time_ms() to bpage->access_time if buf_LRU_old_threshold_ms && bpage->old. Else observe buf_LRU_old_ratio and bpage->freed_page_clock. buf_pool_t: Add n_pages_made_young, n_pages_not_made_young, n_pages_made_young_old, n_pages_not_made_young, for statistics. buf_print(): Display buf_pool->n_pages_made_young, buf_pool->n_pages_not_made_young. This function is only for crash diagnostics. buf_print_io(): Display buf_pool->LRU_old_len and quantities derived from buf_pool->n_pages_made_young, buf_pool->n_pages_not_made_young. This function is invoked by SHOW ENGINE INNODB STATUS. rb://129 approved by Heikki Tuuri. This addresses Bug #45015. r5704 \| marko \| 2009-08-27 03:31:17 -0500 (Thu, 27 Aug 2009) \| 32 lines branches/zip: Fix a critical bug in fast index creation that could corrupt the created indexes. row_merge(): Make "half" an in/out parameter. Determine the offset of half the output file. Copy the last blocks record-by-record instead of block-by-block, so that the records can be counted. Check that the input and output have matching n_rec. row_merge_sort(): Do not assume that two blocks of size N are merged into a block of size 2N. The output block can be shorter than the input if the last page of each input block is almost empty. Use an accurate termination condition, based on the "half" computed by row_merge(). row_merge_read(), row_merge_write(), row_merge_blocks(): Add debug output. merge_file_t, row_merge_file_create(): Add n_rec, the number of records in the merge file. row_merge_read_clustered_index(): Update n_rec. row_merge_blocks(): Update and check n_rec. row_merge_blocks_copy(): New function, for copying the last blocks in row_merge(). Update and check n_rec. This bug was discovered with a user-supplied test case that creates an index where the initial temporary file is 249 one-megabyte blocks and the merged files become smaller. In the test, possible merge record sizes are 10, 18, and 26 bytes. rb://150 approved by Sunny Bains. This addresses Issue #320. r5705 \| marko \| 2009-08-27 06:56:24 -0500 (Thu, 27 Aug 2009) \| 11 lines branches/zip: dict_index_find_cols(): On column name lookup failure, return DB_CORRUPTION (HA_ERR_CRASHED) instead of abnormally terminating the server. Also, disable the previously added diagnostic output to the error log, because mysql-test-run does not like extra output in the error log. (Bug #44571) dict_index_add_to_cache(): Handle errors from dict_index_find_cols(). mysql-test/innodb_bug44571.test: A test case for triggering the bug. rb://135 approved by Sunny Bains. r5706 \| inaam \| 2009-08-27 11:00:27 -0500 (Thu, 27 Aug 2009) \| 20 lines branches/zip rb://147 Done away with following two status variables: innodb_buffer_pool_read_ahead_rnd innodb_buffer_pool_read_ahead_seq Introduced two new status variables: innodb_buffer_pool_read_ahead = number of pages read as part of readahead since server startup innodb_buffer_pool_read_ahead_evicted = number of pages that are read in as readahead but were evicted before ever being accessed since server startup i.e.: a measure of how badly our readahead is performing SHOW INNODB STATUS will show two extra numbers in buffer pool section: pages read ahead/sec and pages evicted without access/sec Approved by: Marko r5707 \| inaam \| 2009-08-27 11:20:35 -0500 (Thu, 27 Aug 2009) \| 6 lines branches/zip Remove unused macros as we erased the random readahead code in r5703. Also fixed some comments. r5708 \| inaam \| 2009-08-27 17:43:32 -0500 (Thu, 27 Aug 2009) \| 4 lines branches/zip Remove redundant TRUE : FALSE from the return statement r5709 \| inaam \| 2009-08-28 01:22:46 -0500 (Fri, 28 Aug 2009) \| 5 lines branches/zip rb://152 Disable display of deprecated parameter innodb_file_io_threads in 'show variables'. r5714 \| marko \| 2009-08-31 01:10:10 -0500 (Mon, 31 Aug 2009) \| 5 lines branches/zip: buf_chunk_not_freed(): Do not acquire block->mutex unless block->page.state == BUF_BLOCK_FILE_PAGE. Check that block->page.state makes sense. Approved by Sunny Bains over the IM. r5716 \| vasil \| 2009-08-31 02:47:49 -0500 (Mon, 31 Aug 2009) \| 9 lines branches/zip: Fix Bug#46718 InnoDB plugin incompatible with gcc 4.1 (at least: on PPC): "Undefined symbol" by implementing our own check in plug.in instead of using the result from the check from MySQL because it is insufficient. Approved by: Marko (rb://154)	16 years ago
Satya B	a907756d21	Applying InnoDB Plugin 1.0.5 snapshot, part 2 From r5639 to r5685 Detailed revision comments: r5639 \| marko \| 2009-08-06 05:39:34 -0500 (Thu, 06 Aug 2009) \| 3 lines branches/zip: mem_heap_block_free(): If innodb_use_sys_malloc is set, do not tell Valgrind that the memory is free, to avoid a bogus warning in Valgrind's built-in free() hook. r5642 \| calvin \| 2009-08-06 18:04:03 -0500 (Thu, 06 Aug 2009) \| 2 lines branches/zip: remove duplicate "the" in comments. r5662 \| marko \| 2009-08-11 04:54:16 -0500 (Tue, 11 Aug 2009) \| 1 line branches/zip: Bump the version number to 1.0.5 after releasing 1.0.4. r5663 \| marko \| 2009-08-11 06:42:37 -0500 (Tue, 11 Aug 2009) \| 2 lines branches/zip: trx_general_rollback_for_mysql(): Remove the redundant parameter partial. If savept==NULL, partial==FALSE. r5670 \| marko \| 2009-08-12 08:16:37 -0500 (Wed, 12 Aug 2009) \| 2 lines branches/zip: trx_undo_rec_copy(): Add const qualifier to undo_rec. This is a non-functional change. r5671 \| marko \| 2009-08-13 03:46:33 -0500 (Thu, 13 Aug 2009) \| 5 lines branches/zip: ha_innobase::add_index(): Fix Bug #46557: after a successful operation, read innodb_table->flags from the newly created table object, not from the old one that was just freed. Approved by Sunny. r5681 \| sunny \| 2009-08-14 01:16:24 -0500 (Fri, 14 Aug 2009) \| 3 lines branches/zip: When building HotBackup srv_use_sys_malloc is #ifdef out. We move access to the this variable within a !UNIV_HOTBACKUP block. r5684 \| sunny \| 2009-08-20 03:05:30 -0500 (Thu, 20 Aug 2009) \| 10 lines branches/zip: Fix bug# 46650: Innodb assertion autoinc_lock == lock in lock_table_remove_low on INSERT SELECT We only store the autoinc locks that are granted in the transaction's autoinc lock vector. A transacton, that has been rolled back due to a deadlock because of an AUTOINC lock attempt, will not have added that lock to the vector. We need to check for that when we remove that lock. rb://145 Approved by Marko. r5685 \| sunny \| 2009-08-20 03:18:29 -0500 (Thu, 20 Aug 2009) \| 2 lines branches/zip: Update the ChangeLog with r5684 change.	16 years ago
Sergey Vojtovich	bae6276d45	Update to innoplug-1.0.4.	17 years ago
Satya B	3945d5e554	Adding innodb_plugin-1.0.4 as storage/innodb_plugin.	17 years ago

15 Commits (f4e5069f60719430218fa8f30e03ae0ecd98dc39)