mariadb

Tree: f4631d6f71

Author	SHA1	Message	Date
Sergey Petrunya	f2947f97a6	BUG#951283: Wrong result (missing rows) with semijoin+firstmatch, IN/ANY subquery - The problem was with execution strategy for cases where FirstMatch's inner tables were interleaved with outer-uncorrelated tables. - I was unable to find any cases where such join orders would be practically useful, so fixed it by disabling them.	14 years ago
Michael Widenius	3bfe3b5ef7	Bug fix for MySQL bug#61209 "auto_increment_offset != 1 + innodb_autoinc_lock_mode=1 => bulk inserts fail" Patch and test case by Patryk Pomykalski mysql-test/suite/innodb/r/innodb-autoinc.result: updated test case storage/innodb_plugin/handler/ha_innodb.cc: Fixed that we properly reserve values for auto_increment storage/xtradb/handler/ha_innodb.cc: Fixed that we properly reserve values for auto_increment	14 years ago
Michael Widenius	4e96c579ae	Sorted some test results that can be different on different machines mysql-test/t/subselect_sj2.test: Added --sorted_result	14 years ago
Sergey Petrunya	e2554b50cd	BUG#951937: Wrong result (missing rows) with semijoin+materialization, IN subquery, InnoDB, TEMPTABLE view - Fix equality propagation to work with SJM nests and OR clauses (full descirption of problem and solution in the comment in the patch) (The second commit with post-review fixes)	14 years ago
Sergey Petrunya	d054709827	BUG#962667: Assertion `0' failed in QUICK_INDEX_SORT_SELECT::need_sorted_output() - The problem was that = we've picked a LooseScan that used full index scan (tab->type==JT_ALL) on certain index. = there was also a quick select (tab->quick!=NULL), that used other indexes. = some old code assumes that (tab->type==JT_ALL && tab->quick) -> means that the quick select should be used, which is not true. Fixed by discarding the quick select as soon as we know we're using LooseScan without using the quick select.	14 years ago
Sergei Golubchik	619f67b1b4	mdev-200 set session dbug resets the output to stderr. it makes "./mtr --debug" unusable revert the mysql fix for bug#46165. implement shared FILE's with reference counting	14 years ago
Sergei Golubchik	92e2b80c76	MDEV-186 Client programs throw warnings about memory loss when executed with --help or alike suppress these harmless but confusing warnings. fix the program name (MY_INIT) in mysqldump client/mysqldump.c: for backward compatibility, prefix mysqldump error messages with "mysqldump", not with the full path of the executable	14 years ago
Igor Babaev	da9aabbbb6	Fixed LP bug #954900 . If the first component of a ref key happened to be a constant appeared after constant row substitution then no store_key element should be created for such a component. Yet create_ref_for_key() erroneously could create such an element that caused construction of invalid ref keys and wrong results for some joins.	14 years ago
Igor Babaev	357331af8a	Fixed LP bug #954262 . This bug in the constructor SEL_IMERGE::SEL_IMERGE could cause huge excessive memory requests.	14 years ago
Alexander Barkov	84727ba3c3	Bug#13832953 MY_STRNXFRM_UNICODE: ASSERTION `SRC' FAILED. \| MY_STRNXFRM_UNICODE/MAKE_SORTKEY Problem: Field_set::val_str in case of an empty SET value returned a String with str_length==0 and Ptr==0, which is not expected by some pieces of the code. Fix: Returning an empty string with str_length==0 and Ptr=="", like Field_enum does.	14 years ago
Davi Arnaut	9584cbe7fc	Make Replication filter settings dynamic. Make the slave options --replicate-* dynamic variables so that these options can be changed dynamically while the server is running, which enables users to modify replication filtering rules without having to stop and restart the server. This is accomplished by just requiring that the slave threads are stopped when these options are set dynamically. Since filtering rules are only used by the SQL slave thread, setting them while the thread is not running avoids the need for locking.	14 years ago
Vladislav Vaintroub	545d740ce6	Fix race condition in rpl_stop_start_slave. after kill connection, wait until it is gone in processlist	14 years ago
Michael Widenius	690d8cc6ba	Fixed lp:947474 "Assertion `table->file->stats.records > 0 \|\| error' failed in join_read_const_table on concurrent SELECT and ALTER, constant Aria table" Remove Aria state history for drop/rename mysql-test/suite/maria/r/maria-recovery2.result: Updated old (wrong) test result sql/handler.cc: Fixed wrong argument to implict_commit storage/maria/ha_maria.cc: Ensure that we don't use file->trn if THD_TRN is 0. (This means that implict_commit() has been called and the trn object is not ours anymore) storage/maria/ma_extra.c: Remove Aria state history for drop/rename storage/maria/ma_rename.c: Remove Aria state history for rename storage/maria/ma_state.c: More DBUG_PRINT	14 years ago
Sergey Petrunya	91d17a9c20	BUG#952583: Server crashes in Item_field::fix_after_pullout on INSERT .. SELECT - Take into account that there may exist Item_field objects with context==NULL.	14 years ago
Sergey Petrunya	5805908bf9	BUG#952372: Server crashes on 2nd execution of PS in find_field_in_tables with semijoin+materialization - The problem was that convert_subq_to_jtbm() attached the semi-join TABLE_LIST object into the wrong list: they used to attach it to the end of parent_lex->leaf_tables.head()->next_local->...->next_local. This was apparently inccorect, as one can construct an example where JTBM nest is attached to a table that is inside some mergeable VIEW, which breaks (causes crash) for name resolution on the subsequent statement re-execution. - Solution: Attach to the "right" list. The "wording" was copied from st_select_lex::handle_derived.	14 years ago
Vladislav Vaintroub	c5e1fb6720	Fix several buildot errors on Windows - do not attempt loading federatedx dynamically - does not work on Windows embedded - race condition in rpl_start_stop_slave - fix exclusion rule to catch warning in partition test	14 years ago
Annamalai Gurusami	08f051df04	Bug #11766634 59783: INNODB DATA GROWS UNEXPECTEDLY WHEN INSERTING, TRUNCATING, INSERTING THE The test case must insert all the records using a single transaction. Otherwise the test case takes more than 15 minutes and will time out in pb2 and mtr.	14 years ago
Dmitry Shulga	2b68b4bc1b	This patch fixes the bug#13737343 (formerly known as 64374): XA TRANSACTIONS AND SAVEPOINT. The bug was introduced by the patch for bug#11766752. This patch sets too strong condition on XA state for SAVEPOINT statement that disallows its execution during XA transaction. But since the statement SAVEPOINT doesn't imply implicit commit we can allow its handling during XA transaction. The patch explicitly check for transaction state against states XA_NOTR and XA_ACTIVE for which the handling of statement SAVEPOINT for XA transaction is allowed. mysql-test/t/xa.test: Testcase was adjusted for bug#13737343. Now SAVEPOINT is allowed for XA transactions in ACTIVE state.	14 years ago
Sergei Golubchik	69cb13602d	another fix for --innodb-trx* name conflict	14 years ago
Sergei Golubchik	c3c14a069b	another fix for --innodb-trx* name conflict	14 years ago
Tor Didriksen	13053fbe54	Bug#13721076 CRASH WITH TIME TYPE/TIMESTAMP() AND WARNINGS IN SUBQUERY The table contains one time value: '00:00:32' This value is converted to timestamp by a subquery. In convert_constant_item we call (item)->is_null() which triggers execution of the Item_singlerow_subselect subquery, and the string "0000-00-00 00:00:32" is cached by Item_cache_datetime. We continue execution and call update_null_value, which calls val_int() on the cached item, which converts the time value to ((longlong) 32) Then we continue to do (item)->save_in_field() which ends up in Item_cache_datetime::val_str() which fails, since (32 < 101) in number_to_datetime, and val_str() returns NULL. Item_singlerow_subselect::val_str isnt prepared for this: if exec() succeeds, and return !null_value, then val_str() must succeed. Solution: refuse to cache strings like "0000-00-00 00:00:32" in Item_cache_datetime::cache_value, and return NULL instead. This is similar to the solution for Bug#11766860 - 60085: CRASH IN ITEM::SAVE_IN_FIELD() WITH TIME DATA TYPE This patch is for 5.5 only. The issue is not present after WL#946, since a time value will be converted to a proper timestamp, with the current date rather than "0000-00-00" mysql-test/r/subselect.result: New test case. mysql-test/t/subselect.test: New test case. sql/item.cc: Verify proper date format before caching timestamps. sql/item_timefunc.cc: Use named constant for readability.	14 years ago
Tor Didriksen	a930e4745e	Bug#13832772 ASSERTION `THD->IS_ERROR() \|\| KILL_ERRNO' We are trying to sort a lot of text/blob fields, so the buffer is indeed too small. Memory available = thd->variables.sortbuff_size = 262144 min_sort_memory = param.sort_length*MERGEBUFF2 = 292245 So the decision to abort the query is correct. filesort() calls my_error(), the error is reported. But, since we have DELETE IGNORE ... the error is converted to a warning by THD::raise_condition filesort currently expects an error to be recorded in the THD diagnostics area. If we lift this restriction (remove the assert) we end up in the familiar void Protocol::end_statement() default: DBUG_ASSERT(0); The solution seems to be to call my_error(ME_FATALERROR) in filesort, so that the error is propagated as an error rather than a warning. mysql-test/r/filesort_debug.result: New test case. mysql-test/t/filesort_debug.test: New test case.	14 years ago
unknown	e638e60589	test suite for LP bug#694450	14 years ago
Alexey Botchkov	620d62ac3e	plugin.result fixed.	14 years ago
Chaithra Gopalareddy	e48afab412	Bug#12626844 : WE ARE NOT CHECKING VIEW TABLE NAMES ENOUGH - CONCAT() HACKS. ALSO WRONG ERROR MESSAGE WHILE TRYING TO CREATE A VIEW ON A NON EXISTING DATABASE PROBLEM: The first part of the problem is concluded as not a bug, as 'concat' is not a reserved word and it is completely valid to create a view with the name 'concat'. The second issue is, while trying to create a view on a non existing database, we are not giving a proper error message. FIX: We have added a check for the database existence while trying to create a view. This check would give an error as 'unknown database' when the database does not exist. This patch is a backport of the patch for Bug#13601606 mysql-test/r/view.result: Added test case result of Bug#12626844 mysql-test/t/view.test: Added test case for Bug#12626844 sql/sql_view.cc: Added a check for database existence in mysql_create_view	14 years ago
Igor Babaev	c1f5e25c04	Fixed LP bug #953649 . Do not call, directly or indirectly, SQL_SELECT::test_quick_select() for derived materialized tables / views when optimizing joins referring to these tables / views to get cost estimates of materialization. The current code does not create B-tree indexes for materialized derived tables / views. So now it's not possible to get any estimates for ranges conditions over the results of the materialization. The function mysql_derived_create() must take into account the fact that array of the KEY structures specifying the keys over a derived table / view may be moved after the optimization phase if the derived table / view is materialized.	14 years ago
Michael Widenius	6f06cef02b	Fixed bug lp:917689 "Archive table corruption crashing MariaDB signal 11" Added 'from_end' as extra parameter to Field::unpack() to detect wrong from data. Change ha_archive::unpack_row() to detect wrong field lengths. Replication code changed to detect wrong field information in events. mysql-test/r/archive.result: dded test case for lp:917689 sql/field.cc: Added 'from_end' as extra parameter to Field::unpack() to detect wrong from data. Removed not used 'unpack_key' functions. sql/field.h: Added 'from_end' as extra parameter to Field::unpack() to detect wrong from data. Removed not used 'unpack_key' functions. Removed some not needed unpack() functions. sql/filesort.cc: Added buffer end parameter to unpack_addon_fields() sql/log_event.h: Added end of buffer argument to unpack_row() sql/log_event_old.cc: Added end of buffer argument to unpack_row() sql/log_event_old.h: Added end of buffer argument to unpack_row() sql/records.cc: Added buffer end parameter to unpack_addon_fields() sql/rpl_record.cc: Added end of buffer argument to unpack_row() Added detection of wrong field information in events sql/rpl_record.h: Added end of buffer argument to unpack_row() sql/rpl_record_old.cc: Added end of buffer argument to unpack_row() Added detection of wrong field information in events sql/rpl_record_old.h: Added end of buffer argument to unpack_row() sql/table.h: Added buffer end parameter to unpack() storage/archive/ha_archive.cc: Change ha_archive::unpack_row() to detect wrong field lengths. This fixes lp:917689	14 years ago
Sergei Golubchik	262a2ab59d	monty's cleanup of my_thr_init.c and collateral changes	14 years ago
Sergei Golubchik	d32b537edf	broad suppression for dlsym "memory leak" - same as for dlclose	14 years ago
Luis Soares	7f84e70b86	BUG#12400313 Adding missing sync_slave_with_master to the test case.	14 years ago
Luis Soares	66a306e6e2	BUG#12400313 Fixing waiting condition. "enter_cond" text changed in 5.5+ (when the SQL thread is waiting for more events).	14 years ago
Luis Soares	9eedf9b452	BUG#12400313 Hardening the test case: - including a diff_tables at the end. - increasing the tolerance on the relay limit size.	14 years ago
Sergey Petrunya	d028d986a9	BUG#952297: Server crashes on 2nd execution of PS in Field::is_null with semijoin+materialization - The bug would show up - when using PS (so that we get re-execution) - the left_expr of the subquery is a reference to viewname.column_name, so that it crashes when one tries to use it without having called fix_fields for it. - when using SJ-Materialization, which makes use of sj_subq_pred->left_expr expression - The fix is to have setup_conds() fix sj_subq_pred->left_expr for semi-join nests it finds.	14 years ago
Luis Soares	4a6c4d8603	BUG#12400313 RELAY_LOG_SPACE_LIMIT IS NOT WORKING IN MANY CASES BUG#64503: mysql frequently ignores --relay-log-space-limit When the SQL thread goes to sleep, waiting for more events, it sets the flag ignore_log_space_limit to true. This gives the IO thread a chance to queue some more events and ultimately the SQL thread will be able to purge the log once it is rotated. By then the SQL thread resets the ignore_log_space_limit to false. However, between the time the SQL thread has set the ignore flag and the time it resets it, the IO thread will be queuing events in the relay log, possibly going way over the limit. This patch makes the IO and SQL thread to synchronize when they reach the space limit and only ask for one event at a time. Thus the SQL thread sets ignore_log_space_limit flag and the IO thread resets it to false everytime it processes one more event. In addition, everytime the SQL thread processes the next event, and the limit has been reached, it checks if the IO thread should rotate. If it should, it instructs the IO thread to rotate, giving the SQL thread a chance to purge the logs (freeing space). Finally, this patch removes the resetting of the ignore_log_space_limit flag from purge_first_log, because this is now reset by the IO thread every time it processes the next event when the limit has been reached. If the SQL thread is in a transaction, it cannot purge so, there is no point in asking the IO thread to rotate. The only thing it can do is to ask for more events until the transaction is over (then it can ask the IO to rotate and purge the log right away). Otherwise, there would be a deadlock (SQL would not be able to purge and IO thread would not be able to queue events so that the SQL would finish the transaction).	14 years ago
Norvald H. Ryeng	ad031d5110	Bug#13031606 VALUES() IN A SELECT STATEMENT CRASHES SERVER Problem: Grouping results by VALUES(alias for string literal) causes the server to crash. Item_insert_values is not constructed to handle other types of arguments than field and reference to field. In this case, the argument is an Item_string, and this causes Item_insert_values::fix_fields() to crash. Fix: Issue an error message when the argument to Item_insert_values is not a field or a reference to a field. This is slightly in breach with documentation, which states that VALUES should return NULL, but the error message is only issued in cases where the server otherwise would crash, so there is no change in behavior for queries that already work. Future versions will restrict syntax so that using VALUES in this way is illegal. mysql-test/r/errors.result: Add test case for bug #13031606. mysql-test/t/errors.test: Add test case for bug #13031606. sql/item.cc: Issue error message if argument is not field or reference to field.	14 years ago
unknown	8aebd44e0e	Implementation of MDEV-28 LIMIT ROWS EXAMINED https://mariadb.atlassian.net/browse/MDEV-28 This task implements a new clause LIMIT ROWS EXAMINED <num> as an extention to the ANSI LIMIT clause. This extension allows to limit the number of rows and/or keys a query would access (read and/or write) during query execution.	14 years ago
Dmitry Lenev	c48233c61e	Fixed test case for bug #13105873 "valgrind warning:possible crash in foreign key handling on subsequent create table if not exists". Do not leave current database unassigned after the end of the test case.	14 years ago
Igor Babaev	8c08349882	Fixed LP bug #930814 . This bug was introduced into mariadb 5.2 in the December 2010 with the patch that added a new engine property: the ability to support virtual columns. As a result of this bug the information from frm files for tables that contained virtual columns did not appear in the information schema tables.	14 years ago
Georgi Kodinov	bc7d8dc623	Bug #12408412 : GROUP_CONCAT + ORDER BY + INPUT/OUTPUT SAME USER VARIABLE = CRASH Moved the preparation of the variables that receive the output from SELECT INTO from execution time (JOIN:execute) to compile time (JOIN::prepare). This ensures that if the same variable is used in the SELECT part of SELECT INTO it will be properly marked as non-const for this query. Test case added. Used proper fast iterator.	14 years ago
Michael Widenius	028523e94d	Added test case for lp:905782 "Assertion `pageno < ((1ULL) << 40)' failed at ma_pagecache.c:3438: pagecache_read or table corruption on INSERT into a ucs2 table" The orignal bug has been fixed earlier	14 years ago
unknown	ea736c9375	Added ucs2 test moved from maria3.test. (MDEV-167)	14 years ago
Sergei Golubchik	96a21ab324	fix uninitialized warning in mysql-test-run.pl make the test to require sphinx 2.0.4 or later	14 years ago
Igor Babaev	af7213d5d4	Fixed LP bug #884175 . If in the where clause of the a query some comparison conditions on the field under a MIN/MAX aggregate function contained constants whose sizes exceeded the size of the field then the query could return a wrong result when the optimizer had chosen to apply the MIN/MAX optimization. With such conditions the MIN/MAX optimization still could be applied, yet it would require a more thorough analysis of the keys built to find the value of MIN/MAX aggregate functions with index look-ups. The current patch just prohibits using the MIN/MAX optimization in this situation.	14 years ago
Annamalai Gurusami	29aaa6588d	Bug #11766634 59783: InnoDB data grows unexpectedly when inserting, truncating, inserting the same set of rows. When a table is re-created with the same set of rows, the data file size must not grow. rb:968 Approved by Marko.	14 years ago
Manish Kumar	a54e6e002d	BUG#13812374 - RPL.RPL_REPORT_PORT FAILS OCCASIONALLY ON PB2 Fix - Changed the implementation of the condition check from the result file to using an assert. mysql-test/suite/rpl/r/rpl_report_port.result: Updated the result file. mysql-test/suite/rpl/t/rpl_report_port.test: Changed from the a condtional check to an assert.	14 years ago
Michael Widenius	aba6d06c34	Upgraded sphinx to version 2.0.4 Fixed memory leaks and compiler warnings in ha_sphinx.cc Added HA_MUST_USE_TABLE_CONDITION_PUSHDOWN so that an engine can force index condition to be used mysql-test/suite/sphinx/sphinx.result: Added testing of pushdown conditions and sphinx status variables. mysql-test/suite/sphinx/sphinx.test: Added testing of pushdown conditions and sphinx status variables. mysql-test/suite/sphinx/suite.pm: Print version number if sphinx version is too old. sql/handler.h: Added HA_MUST_USE_TABLE_CONDITION_PUSHDOWN so that an engine can force index condition to be used sql/sql_base.cc: Added 'thd' argument to check_unused() to be able to set 'entry->in_use' if we call handler->extra(). This was needed as sphinx (and possible other storage engines) assumes that 'in_use' is set if handler functions are called. sql/sql_select.cc: Test if handler is forcing pushdown condition to be used. storage/sphinx/ha_sphinx.cc: Updated to version 2.0.4 Fixed memory leaks and compiler warnings. storage/sphinx/ha_sphinx.h: Updated to version 2.0.4 storage/sphinx/snippets_udf.cc: Updated to version 2.0.4	14 years ago
Marko Mäkelä	4c74d96f51	Remove a duplicate mysql-test file innodb-index.inc.	14 years ago
Ramil Kalimullin	b15a8bf8a7	BUG#12537203 - CRASH WHEN SUBSELECTING GLOBAL VARIABLES IN GEOMETRY FUNCTION ARGUMENTS Fixed --ps-protocol gis test failure.	14 years ago
Igor Babaev	04ee30e75a	Fixed LP bug #946055 . The function create_hj_key_for_table() that builds the descriptor of the hash join key to access a table of a materialized subquery must ignore any equi-join predicate depending on the tables not belonging to the subquery.	14 years ago
Sergei Golubchik	1c530b36d1	mdev-20: INSTALL PLUGIN SONAME	14 years ago

... 3 4 5 6 7 ...

31736 Commits (f4631d6f71c19a98eccf4998eccb49dd69897661)