mariadb

Tree: f0ec34002a

Author	SHA1	Message	Date
Vladislav Vaintroub	019256c9fc	Fix numerous warnings introduced in the last pushes on Windows	15 years ago
Sergey Petrunya	e7aa18fb9c	Code cleanup (1)	15 years ago
Sergey Petrunya	f93b0bbebb	MWL#90: subquery optimizations - Remove redundant changes againist 5.3-main	15 years ago
Sergey Petrunya	e69c642920	Post-merge fixes part 5	15 years ago
Sergey Petrunya	716091e2a0	Post-merge fixes part 4	15 years ago
Sergey Petrunya	db7461783e	Post-merge fixes part 3	15 years ago
Sergey Petrunya	089d2e2ea3	Post-merge fixes part 2	15 years ago
Igor Babaev	4b24105df8	Introduced optimizer switch flag 'optimize_join_buffer_size'. When this flag is 'off' the size of the used join buffer is taken directly from the system variable 'join_buffer_size'. When this flag is 'on' then the size of the buffer depends on the estimated number of rows in the partial join whose records are to be stored in the buffer. By default this flag is set 'on'.	15 years ago
Igor Babaev	0aebdc115f	Ported the fix for LP bug #702310 / bug #59493 . An assertion failure was triggered for a 6-way join query that used two join buffers. The failure happened because every call of JOIN_CACHE::join_matching_records saved and restored status of all tables that were accessed before the table join_tab. It must do it only for those of them that follow the last table using a join buffer.	15 years ago
Sergey Petrunya	d2cbb10443	Backport of (see below) + temporary measures to make SJ-Materialization work with join buffering. Date: Mon, 01 Nov 2010 15:15:25 -0000 3272 Roy Lyseng 2010-11-01 Bug#52068: Optimizer generates invalid semijoin materialization plan When MaterializeScan semijoin strategy was used and there were one or more outer dependent tables before the semijoin tables, the scan over the materialized table was not properly reset for each row of the prefix outer tables. Example: suppose we have a join order: ot1 SJ-Mat-Scan(it2 it3) ot4 Notice that this is called a MaterializeScan, even though there is an outer table ahead of the materialized tables. Usually a MaterializeScan has the outer tables after the materialized table, but this is a special (but legal) case with outer dependent tables both before and after the materialized table. For each qualifying row from ot1, a new scan over the materialized table must be set up. The code failed to do that, so all scans after the first one returned zero rows from the materialized table.	15 years ago
Igor Babaev	af800fd92f	The patch adds the code that allows to use equi-join conditions for hash join in the cases when there are no suitable indexes for these conditions.	15 years ago
Igor Babaev	18dc64eca2	Fixed LP bug #694443 . One of the hash functions employed by the BNLH join algorithm calculates the the value of hash index for key value utilizing every byte of the key buffer. To make this calculation valid one has to ensure that for any key value unused bytes of the buffer are filled with with a certain filler. We choose 0 as a filler for these bytes. Added an optional boolean parameter with_zerofill to the function key_copy. If the value of the parameter is TRUE all unused bytes of the key buffer is filled with 0.	15 years ago
Igor Babaev	a095346a9d	Fixed LP bug #670380 . Lifted the limitation that hash join could not be used over varchar fields with non-binary collation.	15 years ago
Sergey Petrunya	eafc4bef33	MWL#121-125 DS-MRR improvements - Address review feedback: change return type of RANGE_SEQ_IF::next()	15 years ago
Igor Babaev	419d524ff9	Fixed compiler warnings.	15 years ago
Sergey Petrunya	44be131cd3	MWL#121-125 DS-MRR improvements - Address Monty's review feedback, part 5	15 years ago
Sergey Petrunya	a6c1d56e08	MWL#121-125 DS-MRR improvements - Address Monty's review feedback, part 1 - Fix buildbot failure	15 years ago
Igor Babaev	ae4b5a32a6	Fixed LP bug #675922 . The bug happened when BKA join algorithm used an incremental buffer and some of the fields over which access keys were constructed - were allocated in the previous join buffers - were non-nullable - belonged to inner tables of outer joins. For such fields an offset to the field value in the record is saved in the postfix of the record, and a zero offset indicates that the value is null. Before the key using the field value is constructed the value is read into the corresponding field of the record buffer and the null bit is set for the field if the offset is 0. However if the field is non-nullable the table->null_row must be set to 1 for null values and to 0 for non-null values to ensure proper reading of the value from the record buffer.	15 years ago
Igor Babaev	9441a9cc28	Fixed LP bug #674423 . The patch that introduced the new enumeration type Match_flag for the values of match flags in the records put into join buffers missed the necessary modifications in JOIN_CACHE::set_match_flag_if_none. This could cause wrong results for outer joins with on expressions only over outer tables.	15 years ago
Igor Babaev	92772d6d46	Fixed LP bug#672497. Miscalculation of the minimum possible buffer size could trigger an assert in JOIN_CACHE_HASHED::put_record when if join_buffer_size was set to the values that is less than the length of one record to stored in the join buffer. It happened due to the following mistakes: - underestimation of space needed for a key in the hash table (we have to take into account that hash table can have more buckets than the expected number of records). - the value of maximum total length of all records stored in the join buffer was not saved in the field max_used_fieldlength by the function calc_used_field_length.	15 years ago
Igor Babaev	615d756721	Fixed LP bug #669382 . When probing into the hash table of a hashed join cache is performed the key value should not constructed in the buffer used to build keys in the hash tables. The constant parts of these keys copied only once, so they should not be ever overwritten. Otherwise wrong results can be produced by queries that employ hashed join buffers.	15 years ago
Igor Babaev	73898792da	Fixed LP bug #664594 and other bugs leading to invalid execution plans or wrong results due to the fact that JOIN_CACHE functions ignored the possibility of interleaving materialized semijoin tables with tables whose records were stored in join buffers. This fixes would become mostly unnecessary if the new code of mwl 90 was merged into 5.3 right now. Yet the fix the code of optimize_wo_join_buffering was needed in any case.	15 years ago
Igor Babaev	8d8170f1a4	Changed properties changed: +x to -x	15 years ago
Igor Babaev	de69dbae0c	Fixed LP bug #663818 . After the patch for bug 663840 had been applied the test case for bug 663818 triggered the assert introduced by this patch. It happened because the the patch turned out to be incomplete: the space needed for a key entry must be taken into account for the record written into the buffer, and, for the next record as well, when figuring out whether the record being written is the last for the buffer or not.	15 years ago
Igor Babaev	ca862231f7	Fixed LP bug #663840 . When adding a new record into the join buffer that is employed by BNLH join algorithm the writing procedure JOIN_CACHE::write_record_data checks whether there is enough space for the record in the buffer. When doing this it must take into account a possible new key entry added to the buffer. It might happen, as it has been demonstrated by the bug test case, that there is enough remaining space in the buffer for the record, but not for the additional key entry for this record. In this case the key entry overwrites the end of the record that might cause a crash or wrong results. Fixed by taking into account a possible addition of new key entry when estimating the remaining free space in the buffer.	15 years ago
Igor Babaev	25f5debdc7	MWL#128: Added into EXPLAIN output info about types of the used join buffers and about the employed join algorithms. Refactored constructors of the JOIN_CACHE* classes.	15 years ago
Sergey Petrunya	51294f5948	Remove garbage comments	15 years ago
Sergey Petrunya	a285ce3e58	Post-merge fixes part 1	15 years ago
Igor Babaev	79087c9e07	Ported the fix for bug #57024 (a performance issue for outer joins). Employed the same kind of optimization as in the fix for the cases when join buffer is used. The optimization performs early evaluation of the conditions from on expression with table references to only outer tables of an outer join.	15 years ago
Igor Babaev	f1d42ec940	Applied the fix for bug #54235 taken from one of the mysql trees. The fix aligns join_null_complements() with join_matching_records() making both call generate_full_extensions(). There should not be any difference between how the WHERE clause is applied to NULL-complemented records from a partial join and how it is applied to other partially joined records:the latter happens in join_matching_records(), precisely in generate_full_extensions().	15 years ago
Igor Babaev	f4503f39ee	Fixed bug #52394 / LP bug #623209 . When an incremental join cache is used to join a table whose fields are not referenced anywhere in the query the association pointer to the last record in the such cache can be the same as the pointer to the end of the buffer. The function JOIN_CACHE_BKA::get_next_key must take into consideration this when iterating over the keys of the records from the join buffer. The assertion in JOIN_TAB_SCAN_MRR::next also must take this into consideration. Borrowed a slightly changed test case from a patch attached to the bug #52394.	15 years ago
Igor Babaev	61e96a75a6	Fixed a typo bug in JOIN_CACHE::shrink_join_buffer_in_ratio.	15 years ago
Igor Babaev	4a9696a451	Made sure that JOIN_CACHE::max_records is not less than 10.	15 years ago
Igor Babaev	f83cc50793	Fixed an incorrect calculation of JOIN_CACHE::max_buff_size.	15 years ago
Igor Babaev	e268f224fb	Fixes in function specs.	15 years ago
Igor Babaev	8e22885007	Fixes in function specs.	15 years ago
Igor Babaev	94cfcbd9df	The main patch for MWL#128: Implement Block Nested Loop Hash Join.	15 years ago
Sergey Petrunya	e0999cdf7c	DS-MRR support improvements (MWL#123, MWL#124, MWL#125) - Lots of TODO comments - add mrr_sort_keys flag to @@optimizer_switch - [from Igor] SQL layer part passes HA_MRR_MATERIALIZED_KEYS flag - Don't call rnd_pos() many times in a row if sorted rowid buffer has the same rowid value for multiple consequive (rowid, range_id) pairs.	15 years ago
psergey	946aef4a58	MWL#90: code cleanup - Remove deadcode - Improve comments - Do small several small TODOs	15 years ago
Igor Babaev	0d734037cc	Added missing calls of update_virtual_fields() in the join cache module. Without these calls SELECTs over tables with virtual columns that used join cache could return wrong results. This could be seen with the test case added into vcol_misc.test	16 years ago
Sergey Petrunya	488d352a66	MWL#121: DS-MRR support for clustered primary keys - Remove back key_parts from multi_range_read_init() parameters - Related code simplification/cleanup	16 years ago
Sergey Petrunya	925e508a2e	MWL#121: DS-MRR support for clustered primary keys - First code (will need code cleanup)	16 years ago
Sergey Petrunya	26c3dc455b	MWL#90: Subqueries: Inside-out execution for non-semijoin materialized subqueries that are AND-parts of the WHERE - Address feedback - Code cleanup (not finished)	16 years ago
Sergey Petrunya	ef27f6c339	Buildbot fixes: - Make join buffering take into account that join_tabs are not a single linear array anymore - Remove outer join + SJ-Materialization crash (OJ+SJ the processing is most likely still incorrect)	16 years ago
Sergey Petrunya	49568aefe7	MWL#90: Code cleanup: Unification of merged and non-merged SJM nests processing - Make join buffering code to take into account that JOIN_TABs are not a linear array anymore.	16 years ago
Sergey Petrunya	dad93f2c82	MWL#90, code movearound to unify merged and non-merged semi-join materialization processing - First code, needs cleanup.	16 years ago
Igor Babaev	709a0a1310	MWL#106: Backport optimizations for derived tables and views. The main consolidated patch.	16 years ago
Sergey Petrunya	b9688830ec	Subquery optimizations: - Better comments - Use more appropriate return types for functions - Provide handling where it was missing.	16 years ago
Sergey Petrunya	2775f80f7d	MWL#90: Subqueries: Inside-out execution for non-semijoin materialized subqueries that are AND-parts of the WHERE - First code (needs cleanup).	16 years ago
Sergey Petrunya	c2924e155e	BUG#49129: Wrong result with IN-subquery with join_cache_level=6 and firstmatch=off - The problem was that DuplicateWeedout strategy setup code wasn't aware of the fact that join buffering will be used and applied optimization that doesn't work together with join buffering. Fixed by making DuplicateWeedout setup code to have a pessimistic check about whether there is a chance that join buffering will be used. - Make JOIN_CACHE_BKA::init() correctly process Copy_field elements that denote saving current rowids in the join buffer. mysql-test/r/subselect_sj2.result: Update test results mysql-test/r/subselect_sj2_jcl6.result: Update test results mysql-test/r/subselect_sj_jcl6.result: Testcase mysql-test/t/subselect_sj2.test: Update test results mysql-test/t/subselect_sj_jcl6.test: Testcase sql/opt_subselect.cc: - The problem was that DuplicateWeedout strategy setup code wasn't aware of the fact that join buffering will be used and applied optimization that doesn't work together with join buffering. Fixed by making DuplicateWeedout setup code to have a pessimistic check about whether there is a chance that join buffering will be used. sql/sql_join_cache.cc: Make JOIN_CACHE_BKA::init() correctly process Copy_field elements that denote saving current rowids in the join buffer. sql/sql_select.cc: Added a question note	16 years ago

1 2 3

150 Commits (f0ec34002a98eeb669cb254eaba6a3d678a58cc1)