mariadb

Tree: f0c883f3fb

Author	SHA1	Message	Date
kostja@bodhi.(none)	d63d8cb1a3	Add a test case for Bug#18287 create federated table always times out, error 1159 ' ' (fixed by the patch for Bug 25679)	19 years ago
acurtis/antony@xiphis.org/ltamd64.xiphis.org	fbcd70a494	Bug#25679 "Federated Denial of Service" Federated storage engine used to attempt to open connections within the ::create() and ::open() methods which are invoked while LOCK_open mutex is being held by mysqld. As a result, no other client sessions can open tables while Federated is attempting to open a connection. Long DNS lookup times would stall mysqld's operation and a rogue connection string which connects to a remote server which simply stalls during handshake can stall mysqld for a much longer period of time. This patch moves the opening of the connection much later, when the federated actually issues queries, by which time the LOCK_open mutex is no longer being held.	19 years ago
ramil/ram@mysql.com/ramil.myoffice.izhnet.ru	4a52b5c885	Fixed #29923 : federated.test fails in 5.0-maint, 5.1-maint Result adjusted.	19 years ago
cmiller@zippy.cornsilk.net	832fd24c41	Bug#26909: Specified key was too long; max key length is 255 bytes \ when creating table Federated tables had an artificially low maximum of key length, because the handler failed to implement a method to return it and the default value is taked from the prototype handler. Now, implement that method and return the maximum possible key length, which is that of InnoDB.	19 years ago
antony@ppcg5.local	b0b0b0fbc4	Bug#25511 "Federated INSERT failures" Federated does not correctly handle "INSERT...ON DUPLICATE KEY UPDATE" However, implementing such support is not reasonably possible without increasing complexity of the storage engine: checking that constraints on remote server match local server and parsing error messages. This patch causes 'ON DUPLICATE KEY' to fail with ER_DUP_KEY message if a conflict occurs and not to fail silently.	19 years ago
antony@ppcg5.local	b3e29fbd1d	Bug#29019 "REPLACE/INSERT IGNORE/UPDATE IGNORE doesn't work" Federated does not record neccessary HA_EXTRA flags in order to support REPLACE/INSERT IGNORE/UPDATE IGNORE. Implement ::extra() to capture flags neccessary for functionality. New function append_ident() to better escape identifiers consistantly.	19 years ago
patg@radha.local	7ce83bc36a	federated.test: fixed test to replace port to SLAVE_PORT in result file federated.result: new result file	19 years ago
patg@radha.local	5f0fe17796	BUG# 17044 Federated Storage Engine not UTF8 clean - Added 'SET NAMES <charset>" upon ::open - Added test and results for simple UTF test federated.test: BUG #17044 Federated Storage Engine not UTF8 clean New test. Using hex - pasting various charsets in the terminal doesn't work. federated.result: BUG# 17044 Federated Storage Engine not UTF8 clean New test results ha_federated.cc: BUG# 17044 Federated Storage Engine not UTF8 clean Upon ::open, set names to table's charset	19 years ago
pgalbraith/patg@buffy.netfrastructure.com	cf8b64a114	BUG #15133 "unique index with nullable value not accepted in federated table" Added HA_NULL_IN_KEY to table flags to allow for nullable unique indexes and added test to verify ha_federated.h: BUG #15133 "unique index with nullable value not accepted in federated table" added HA_NULL_IN_KEY to table flags to allow for nullable unique indexes federated.test: BUG #15133 "unique index with nullable value not accepted in federated table" New test to show that nullable unique indexes work federated.result: BUG #15133 "unique index with nullable value not accepted in federated table" New results for new test	20 years ago
patg@govinda.patg.net	71f5b4997a	"BUG #18764 : Delete conditions causing inconsistencies in Federated tables" Post merge changes.	20 years ago
jimw@rama.(none)	d18eacc71d	Bug #19498 : Inconsistent support for DEFAULT in TEXT columns When a default of '' was specified for TEXT/BLOB columns, the specification was silently ignored. This is presumably to be nice to applications (or people) who generate their column definitions in a not-very-clever fashion. For clarity, doing this now results in a warning, or an error in strict mode.	20 years ago
patg@govinda.patg.net	51d8bcf627	"BUG #18764 : Delete conditions causing inconsistencies in Federated tables" Removed logic in ha_federated::write_row, which checks field query ids in the loop which builds the query to run on the remote server.	20 years ago
jimw@rama.(none)	c2d8b605f2	Bug #17608 : String literals lost during INSERT query on FEDERATED table The Federated storage engine used Field methods that had arbitrary limits on the amount of data they could process, which caused problems with data over that limit (4K). By removing those Field methods and just using features of the String class, we can avoid this problem.	20 years ago
dlenev@mysql.com	d4450e6696	Fix for bug#18437 "Wrong values inserted with a before update trigger on NDB table". SQL-layer was not marking fields which were used in triggers as such. As result these fields were not always properly retrieved/stored by handler layer. So one might got wrong values or lost changes in triggers for NDB, Federated and possibly InnoDB tables. This fix solves the problem by marking fields used in triggers appropriately. Also this patch contains the following cleanup of ha_ndbcluster code: We no longer rely on reading LEX::sql_command value in handler in order to determine if we can enable optimization which allows us to handle REPLACE statement in more efficient way by doing replaces directly in write_row() method without reporting error to SQL-layer. Instead we rely on SQL-layer informing us whether this optimization applicable by calling handler::extra() method with HA_EXTRA_WRITE_CAN_REPLACE flag. As result we no longer apply this optimzation in cases when it should not be used (e.g. if we have on delete triggers on table) and use in some additional cases when it is applicable (e.g. for LOAD DATA REPLACE). Finally this patch includes fix for bug#20728 "REPLACE does not work correctly for NDB table with PK and unique index". This was yet another problem which was caused by improper field mark-up. During row replacement fields which weren't explicity used in REPLACE statement were not marked as fields to be saved (updated) so they have retained values from old row version. The fix is to mark all table fields as set for REPLACE statement. Note that in 5.1 we already solve this problem by notifying handler that it should save values from all fields only in case when real replacement happens.	20 years ago
joerg@mysql.com	6f6b966d16	Test "federated" failed because the log contains fixed port numbers. Re-apply a patch by Knielsen in the 5.0.23 build clone: Replace port number by "SLAVE_PORT".	20 years ago
ingo@mysql.com	02c8e6b000	Fixed yet another forgotten port number replacement.	20 years ago
knielsen@mysql.com	86268a54df	Fix test files to work with non-standard ports (MTR_BUILD_THREAD).	20 years ago
knielsen@mysql.com	dad0d8caca	Fix test files to work with non-standard ports (MTR_BUILD_THREAD).	20 years ago
patg@govinda.patg.net	18d264a1ea	BUG #19773 Pushbuild fixes to result file, test, and header file for federated.	20 years ago
patg@govinda.patg.net	d2df283b78	BUG #19773 Final-review fixes per Monty, pre-push. OK'd for push. Please see each file's comments.	20 years ago
jimw@mysql.com	a1c2dc5e6f	Bug #16494 : Updates that set a column to NULL fail sometimes When building the UPDATE query to send to the remote server, the federated storage engine built the query incorrectly if it was updating a field to be NULL. Thanks to Bjrn Steinbrink for an initial patch for the problem.	20 years ago
msvensson@devsrv-b.mysql.com	f2444c50fc	Bug#17377 Federated Engine returns wrong Data, always the rows with the highest ID - Always make rnd_pos reposition the cursor in the fetched result set.	20 years ago
knielsen@mysql.com	a002d316ed	Fix missing --replace_result on $SLAVE_MYPORT in federated.	20 years ago
patg@govinda.patg.net	15ec4431bc	BUG# 14768 Added fixes to make last_insert_id() to work.	20 years ago
monty@mysql.com	f5804869e3	Don't use PATH_MAX for FN_REFLEN as this uses too much stack space Larger stack size neaded for open table on x86 64 bit Fix failing test cases Deleted symlink from bk	20 years ago
patg@krsna.patg.net	d5b252e630	BUG# 14532 Post-review fixes	20 years ago
patg@krsna.patg.net	7b611b33f2	BUG #14532 Added FIELD_TYPE_BIT to field method 'needs_quotes' to make BIT columns work.	20 years ago
bar@mysql.com	39b0712cf7	type_binary.result, type_binary.test: new file mysql_fix_privilege_tables.sql, mysql_create_system_tables.sh: Adding true BINARY/VARBINARY: fixing "password" type, not to be 0x00-padding. Many files: Adding true BINARY/VARBINARY: fixing tests not to output 0x00 bytes. Adding true BINARY/VARBINARY: new pad_char structure member. ctype-bin.c: Adding true BINARY/VARBINARY: new pad_char structure member. New strnxfrm, with two trailing length bytes. field.cc: Adding true BINARY/VARBINARY.	20 years ago
eric@mysql.com	06043b519a	replace port number with string identifier so that it may have different ports and still run (problem found by kent)	20 years ago
eric@mysql.com	215ecd3322	BUG#13724 conditionally added CONNECTION='connect string' for SHOW CREATE TABLE	20 years ago
eric@mysql.com	5008a5f208	Move handler specific options into handlerton flag check BUG#13108	20 years ago
eric@mysql.com	84534bc629	Fixed minor error message bug from work for WL#2414	20 years ago
eric@mysql.com	1a79e25537	Made changes to add federated CONNECTION information to the .frm file (per Monty's patch). Remove references to the "COMMENT" field. WL#2414	20 years ago
patg@radha.local	e2d8644053	Eric's implentation of OPTIMIZE TABLE and REPAIR TABLE, as well as changes to the test.	21 years ago
patg@krsna.patg.net	db1fb6a7e5	This is the same patch as 1.1937, with small variable declaration changes, memory deallocation cleanup	21 years ago
patg@radha.local	d3d727e328	Comment and test changes per review request by Timour. All tests pass on production with this code.	21 years ago
patg@radha.local	a6af23a046	changes to fix joins not working (bug #10848 ). New tests, as well as table->status being set in index_read_idx	21 years ago
patg@krsna.	0ae33dfd36	Federated Storage Handler - test and result fix.	21 years ago
monty@mysql.com	594ef41b2d	Cleanup during reviews Removed some optional arguments Fixed portability problem in federated tests	21 years ago
patg@krsna.	dd669983db	WL #2094 Federated Storage Engine Changes to a test with a update to a table with 1001 columns, the last being a blob. On HP, the test worked properly, but on other OSs, there's a problem with using the blob column in an update where clause. The field method val_string(String , char ) should work, but doesn't seem to deal with blobd, and for some reason, cannot get the correct value of the blob column from the byte pointer in update_row, "old_data" which is a byte pointer to the row in mysql format, that will be replaced with "new_data" (which conveniently has a field pointer to use to get values from). Will document this.	21 years ago
patg@krsna.	24bc862456	This changeset contains changes approved in code review by Konstja and Georg, change sets 1.1806, 1.1805. These changes has been successfully tested on both my own workstation (Suse 9.0) and production.mysql.com.	21 years ago
patg@krsna.patg.net	02a25fd48a	WL# 2094 Federated Storage Handler Patch #2, all coding style changes per Kostja's review (as requested to keep style changes separate from functionality changes), as well as changes to the test suit to no longer use hard-coded port values in foreign table creation statement	21 years ago
patg@krsna.patg.net	0a48c5b5c2	WL# 2094 This patch contains all that my previous patch (1.1814) contained, with the addition of using cli_fetch_lengths for handling binary data (Bar noted this on the review of 1.1814, Guilhem suggested using cli_fetch_lenghts by making available via removal of static in method definition and declaration in mysql.h, but Konstantin had some reservations, but he said to commit the patch using this anyway, and I suppose this can be discussed. I abandoned 1.1814 because Monty made a couple fixes to my code as well as formatting changes, and I thought it would just be easier to hand-edit my changes into a fresh clone and then make a patch. The reason for using cli_fetch_lengths is so that I can correctly get the length of the field I am setting into the field. I was previously using 'strlen' but Bar pointed out this won't correctly get the length of binary data and is also less effecient. Upon testing, it was in fact verified that binary data in a blob table was being inserted correctly, but not being retrieved correctly, all due to not having the correct value for the field: (field)->store(row[x], strlen(row[x]), &my_charset_bin); was changed to: (field)->store(row[x], lengths[x], &my_charset_bin); lengths being a unsigned long pointer to the values of the field lengths from a MYSQL_ROW. Since the server doesn't have the function "mysql_fetch_lengths" available, I tried to use "result->lengths", but this isn't set, so I finally successfully used cli_fetch_lenghts, which does give the correct lengths, and now the binary data gets retrieved correctly. I've also run the code through indent-ex and am using Brian's vimrc to ensure correct formatting! This code passes the entire test suite, without any errors or warning on both my workstation and build.mysql.com	21 years ago
patg@pc248.lfp.kcls.org	1da60b9f45	-Added quote_data and needs_quotes (moved from federated handler. -New tests and results logging_ok: Logging to logging@openlogging.org accepted ha_federated.h: removed quote_data and type_quote (now in the Field class) ha_federated.cc: moved quote_data and type_quote to field class field.h: new methods quote_data and needs_quotes declared field.cc: new field class methods quote_data and needs_quotes (per Monty's request) federated.test: more tests, joins, index tests have_federated_db.require: new name of federated system var federated.result: new test results for federated handler have_federated_db.inc: changed name of variable in test due to change in vars sql_analyse.cc: over-ridden append_escaped to take (String , char , uint) per requirements of 'create_where_from_key' method in federated handler. mysql_priv.h: define over-ridden append_escaped to take arguments from 'create_where_from_key' method in federated handler ha_federated.cc: implemented "create_where_from_key" to deal properly with two-byte prefix and multi keys. Initial testing shows it works, but I still need to move quoting to field class and also look at changes per Segei's suggestions.	21 years ago
patg@patrick-galbraiths-computer.local	dac98f9b45	WL# 2094 Federated Storage Handler, added fixes per suggestions by Bar and Antony	21 years ago
patg@patrick-galbraiths-computer.local	301c493252	First commit to mysql-5.0 tree to include MySQL Federated Storage Handler. This includes both the source and header files, test (results, test, require), and modifications to server and handler base files, and autoconf modifications to properly build federated handler.	21 years ago

1 2

57 Commits (f0c883f3fbaecef6934e23a674840cc4fa802ebc)