mariadb

Tree: ed77ee1aab

Author	SHA1	Message	Date
Sergei Golubchik	ed77ee1aab	cleanup: change Item::walk() to take void* not uchar* and remove all related casts to uchar* also remove a couple of unused methods	9 years ago
Michael Widenius	fb67cde237	Use default character set for expressions - Force usage of () around complex DEFAULT expressions - Give error if DEFAULT expression contains invalid characters - Don't use const_charset_conversion for stored Item_func_sysconf expressions as the result is not constaint over different executions - Fixed Item_func_user() to not store calculated value in str_value	9 years ago
Michael Widenius	2fe8dd0f90	various cleanups	9 years ago
Michael Widenius	db7edfed17	MDEV-7563 Support CHECK constraint as in (or close to) SQL Standard MDEV-10134 Add full support for DEFAULT - Added support for using tables with MySQL 5.7 virtual fields, including MySQL 5.7 syntax - Better error messages also for old cases - CREATE ... SELECT now also updates timestamp columns - Blob can now have default values - Added new system variable "check_constraint_checks", to turn of CHECK constraint checking if needed. - Removed some engine independent tests in suite vcol to only test myisam - Moved some tests from 'include' to 't'. Should some day be done for all tests. - FRM version increased to 11 if one uses virtual fields or constraints - Changed to use a bitmap to check if a field has got a value, instead of setting HAS_EXPLICIT_VALUE bit in field flags - Expressions can now be up to 65K in total - Ensure we are not refering to uninitialized fields when handling virtual fields or defaults - Changed check_vcol_func_processor() to return a bitmap of used types - Had to change some functions that calculated cached value in fix_fields to do this in val() or getdate() instead. - store_now_in_TIME() now takes a THD argument - fill_record() now updates default values - Add a lookahead for NOT NULL, to be able to handle DEFAULT 1+1 NOT NULL - Automatically generate a name for constraints that doesn't have a name - Added support for ALTER TABLE DROP CONSTRAINT - Ensure that partition functions register virtual fields used. This fixes some bugs when using virtual fields in a partitioning function	9 years ago
Alexander Barkov	afbd28aeff	Preparing the CAST(..AS [UN]SIGNED) related code to fix a number of bugs easier (MDEV-8919, MDEV-10304, MDEV-10305, MDEV-10307) - Adding Item::push_note_converted_to_negative_complement() and Item::push_note_converted_to_positive_complement() - Adding virtual methods Item::val_int_signed_typecast() and Item::val_int_unsigned_typecast() - Moving COLUMN_GET() related code from Item_func_signed::val_int() and Item_func_unsigned::val_int() to Item_dyncol_get::val_int_signed_typecast() and Item_dyncol_get::val_int_unsigned_typecast() - Moving Item_func_signed::val_int_from_str() to Item::val_int_from_str() and changing it to get the value from "this" instead of args[0]. The patch does not change behaviour. It's only to simplify fixing of the mentioned bugs. It will also simplify switching the CAST related code to use the type handler infrastructure easier (soon).	9 years ago
Alexander Barkov	b25373beb5	MDEV-9653 Assertion `length \|\| !scale' failed in uint my_decimal_length_to_precision(uint, uint, bool) MDEV-9752 Wrong data type for COALEASCE(?,1) in prepared statements	10 years ago
Igor Babaev	2cfc450bf7	This is the consolidated patch for mdev-8646: "Re-factor the code for post-join operations". The patch mainly contains the code ported from mysql-5.6 and created for two essential architectural changes: 1. WL#5558: Resolve ORDER BY execution method at the optimization stage 2. WL#6071: Inline tmp tables into the nested loops algorithm The first task was implemented for mysql-5.6 by Ole John Aske. It allows to make all decisions on ORDER BY operation at the optimization stage. The second task implemented for mysql-5.6 by Evgeny Potemkin adds JOIN_TAB nodes for post-join operations that require temporary tables. It allows to execute these operations within the nested loops algorithm that used to be used before this task only for join queries. Besides these task moves all planning on the execution of these operations from the execution phase to the optimization phase. Some other re-factoring changes of mysql-5.6 were pulled in, mainly because it was easier to pull them in than roll them back. In particular all changes concerning Ref_ptr_array were incorporated. The port required some changes in the MariaDB code that concerned the functionality of EXPLAIN and ANALYZE. This was done mainly by Sergey Petrunia.	10 years ago
Alexander Barkov	7b50447aa6	MDEV-9407 Illegal mix of collation when using GROUP_CONCAT in a VIEW MDEV-9408 CREATE TABLE SELECT MAX(int_column) creates different columns for table vs view There were three almost identical pieces of the code: - Field Item_func::tmp_table_field(); - Field Item_sum::create_tmp_field(); - Field *create_tmp_field_from_item(); with a difference in very small details (hence the bugs): Only Item_func::tmp_table_field() was correct, the other two were not. Removing the two incorrect pieces of the redundant code. Joining these three functions/methods into a single virtual method Item::create_tmp_field(). Additionally, moving Item::make_string_field() and Item::tmp_table_field_from_field_type() from the public into the protected section of the class declaration, as they are now not needed outside of Item.	10 years ago
Alexander Barkov	c3494e19cb	MDEV-9215 Detect cmp_type() and result_type() from field_type() A cleanup: removing members and functions that become unused: - Item_func_hybrid_field_type::cached_result_type - sp_map_result_type()	10 years ago
Alexander Barkov	607ef786fc	MDEV-9215 Detect cmp_type() and result_type() from field_type() (A dependency task for MDEV-4912 Add a plugin to field types)	10 years ago
Sergey Vojtovich	0746a07708	MDEV-8718 - Obsolete sql_strmake() in favor of THD::strmake() and thd_strmake()	10 years ago
Alexander Barkov	d73cf394a5	MDEV-9170 Get rid of LEX::length and LEX::dec A preparatory task for: MDEV-4912 Add a plugin to field types (column types)	10 years ago
Oleksandr Byelkin	fb4358f432	MDEV-7949: Item_field::used_tables() takes 0.29% in OLTP RO small sixes of used_tables() usage	11 years ago
Alexander Barkov	b867ade591	Removing Used_tables_and_const_cache from "class udf_handler". It was used only temporary, during udf_handler::fix_fields() time, and then copied to the owner Item_func_or_sum object. Changing the code to use the Used_tables_and_const_cache part of the owner Item_sum_or_func object directly.	10 years ago
Alexander Barkov	0b4c3ad818	Moving Used_tables_and_const_chache from Item_func to Item_func_or_sum and thus reusing Used_tables_and_const_cache for Item_sum instead of declaring the same members inside Item_sum.	10 years ago
Alexander Barkov	de1a48e7d9	A clean-up for a few recent result set metadata related bug fixes: - MDEV-8875 Wrong metadata for MAX(CAST(time_column AS DATETIME)) - MDEV-8873 Wrong field type or metadata for LEAST(int_column,string_column) - MDEV-8912 Wrong metadata or type for @c:=string_or_blob_field Adding Item_hybrid_func as a common parent for Item_func_hybrid_field_type, Item_func_min_max, Item_func_user_var. This removes some duplicate code.	10 years ago
Alexander Barkov	8777724901	MDEV-8912 Wrong metadata or type for @c:=string_or_blob_field	10 years ago
Alexander Barkov	ba0b668551	A clean-up for MDEV-7950: - Turning get_mm_tree_for_const() from a static function into a protected method in Item. - Adding a new class Item_bool_func2_with_rev, for the functions and operators that have a reverse function and can use the range optimizer for to optimize "value OP field" as "field REV_OP value". Deriving Item_bool_rowready_func2 and Item_funt_spatial_rel from the new class. - Removing Item_bool_func2::have_rev_func().	10 years ago
Alexander Barkov	accf9b5675	MDEV-5694 GREATEST(date, time) returns a wrong data type	10 years ago
Alexander Barkov	b50c607056	MDEV-4848 Wrong metadata or column type for LEAST(1.0,'10') MDEV-8873 Wrong field type or metadata for LEAST(int_column,string_column)	10 years ago
Alexander Barkov	cc9cfecab7	MDEV-8865 Wrong field type or metadata for COALESCE(signed_int_column, unsigned_int_column) Item_func_hybrid_field_type did not return correct field_type(), cmp_type() and result_type() in some cases, because cached_result_type and cached_field_type were set in independent pieces of the code and did not properly match to each other. Fix: - Removing Item_func_hybrid_result_type - Deriving Item_func_hybrid_field_type directly from Item_func - Introducing a new class Type_handler which guarantees that field_type(), cmp_type() and result_type() are always properly synchronized and using the new class in Item_func_hybrid_field_type.	10 years ago
Oleksandr Byelkin	02a38fd27e	MDEV-8624: MariaDB hangs on query with many logical condition Made no_rows_in_result()/restore_to_before_no_rows_in_result() not looking annecessary deep with walk() method.	10 years ago
Alexander Barkov	22cc8f990b	Changing a number of functions to aggregate argument character sets and collations from the global name space into private and protected methods in Item_func_or_sum.	10 years ago
Alexander Barkov	2dc32c02ab	Removing "DTCollation user_var_entry::collation", using a CHARSET_INFO pointer instread, as the "derivation" and "repertoire" parts of DTCollation were not really used by user_var_entry.	10 years ago
Alexander Barkov	1956340247	Removing global function agg_item_charsets_for_string_result(). Moving agg_arg_charsets_for_string_result() and agg_arg_charsets_for_string_result_with_comparison() inside "protected" section in Item_func_or_sum.	10 years ago
Alexander Barkov	c108019a48	MDEV-8747 Wrong result for SELECT..WHERE derived_table_column='a' AND derived_table_column<>_latin1'A' COLLATE latin1_bin MDEV-8749 Wrong result for SELECT..WHERE derived_table_enum_column='number' AND derived_table_enum_column OP number	10 years ago
Oleksandr Byelkin	102a85f9f3	MDEV-8663: IF Statement returns multiple values erroneously (or Assertion `!null_value' failed in Item::send(Protocol, String)) Postreview addons by Bar Fix: keeping contract: NULL value mean NULL pointer in val_str and val_deciman.	10 years ago
Alexander Barkov	aa1002a35c	MDEV-8723 Wrong result for SELECT..WHERE COLLATION(a)='binary' AND a='a'	10 years ago
Monty	3bca8db4f9	MDEV-6152: Remove calls to current_thd while creating Item - Part 4: Removing calls to sql_alloc() and sql_calloc() Other things: - Added current_thd in some places to make it clear that it's called (easier to remove later) - Move memory allocation from Item_func_case::fix_length_and_dec() to Item_func_case::fix_fields() - Added mem_root to some new calls - Fixed some wrong UNINIT_VAR() calls - Fixed a bug in generate_partition_syntax() in case of errors - Added mem_root to argument to new thread_info - Simplified my_parse_error() call in sql_yacc.yy	10 years ago
Alexander Barkov	1b6b44b6b5	MDEV-8661 Wrong result for SELECT..WHERE a='a' AND a='a' COLLATE latin1_bin MDEV-8679 Equal field propagation is not used for VARCHAR when it safely could	10 years ago
Sergey Vojtovich	31e365efae	MDEV-8010 - Avoid sql_alloc() in Items (Patch #1 ) Added mandatory thd parameter to Item (and all derivative classes) constructor. Added thd parameter to all routines that may create items. Also removed "current_thd" from Item::Item. This reduced number of pthread_getspecific() calls from 290 to 177 per OLTP RO transaction.	10 years ago
Monty	86377d078e	Fixes done while working on MDEV-4119: Fixed several optimizer issues relatied to GROUP BY: a) Refering to a SELECT column in HAVING sometimes calculated it twice, which caused problems with non determinstic functions b) Removing duplicate fields and constants from GROUP BY was done too late for "using index for group by" optimization to work c) EXPLAIN SELECT ... GROUP BY did wrongly show 'Using filesort' in some cases involving "Using index for group-by" a) was fixed by: - Changed last argument to Item::split_sum_func2() from bool to int to allow more flags - Added flag argument to Item::split_sum_func() to allow on to specify if the item was in the SELECT part - Mark all split_sum_func() calls from SELECT with SPLIT_SUM_SELECT - Changed split_sum_func2() to do nothing if called with an argument that is not a sum function and doesn't include sum functions, if we are not an argument to SELECT. This ensures that in a case like select a*sum(b) as f1 from t1 where a=1 group by c having f1 <= 10; That 'a' in the SELECT part is stored as a reference in the temporary table togeher with sum(b) while the 'a' in having isn't (not needed as 'a' is already a reference to a column in the result) b) was fixed by: - Added an extra remove_const() pass for GROUP BY arguments before make_join_statistics() in case of one table SELECT. This allowes get_best_group_min_max() to optimize things better. c) was fixed by: - Added test for group by optimization in JOIN::exec_inner for select->quick->get_type() == QUICK_SELECT_I::QS_TYPE_GROUP_MIN_MAX item.cc: - Simplifed Item::split_sum_func2() - Split test to make them faster and easier to read - Changed last argument to Item::split_sum_func2() from bool to int to allow more flags - Added flag argument to Item::split_sum_func() to allow on to specify if the item was in the SELECT part - Changed split_sum_func2() to do nothing if called with an argument that is not a sum function and doesn't include sum functions, if we are not an argument to SELECT. opt_range.cc: - Simplified get_best_group_min_max() by calcuating first how many group_by elements. - Use join->group instead of join->group_list to test if group by, as join->group_list may be NULL if everything was optimized away. sql_select.cc: - Added an extra remove_const() pass for GROUP BY arguments before make_join_statistics() in case of one table SELECT. - Use group instead of group_list to test if group by, as group_list may be NULL if everything was optimized away. - Moved printing of "Error in remove_const" to remove_const() instead of having it in caller. - Simplified some if tests by re-ordering code. - update_depend_map_for_order() and remove_const() fixed to handle the case where make_join_statistics() has not yet been called (join->join_tab is 0 in this case)	10 years ago
Alexander Barkov	ee0237fe89	MDEV-8330 Get rid of Item_func::select_optimize() and Item_func::optimize_type	10 years ago
Alexander Barkov	40e5aceaff	Removing Item_int_func::sargable. Adding virtual implementations of count_sargable_conds() instead for Item_func_in, Item_func_null_predicate, Item_bool_func2. There other Item_int_func descendants that used to set "sargable" to true (Item_func_between, Item_equal) already have their own implementation of count_sargable_conds(). There is no sense to have two parallel coding models for the same thing.	10 years ago
Alexander Barkov	5991efc382	MDEV-7950 Item_func::type() takes 0.26% in OLTP RO Step #8: Adding get_mm_tree() in Item_func, Item_func_between, Item_func_in, Item_equal. This removes one virtual call item->type() in queries like: SELECT * FROM t1 WHERE c BETWEEN const1 AND const2; SELECT * FROM t1 WHERE c>const; SELECT * FROM t1 WHERE c IN (const_list);	11 years ago
Alexander Barkov	be2038e3cb	MDEV-7950 Item_func::type() takes 0.26% in OLTP RO Step 4 (there will be more)	11 years ago
Alexander Barkov	462bca365a	MDEV-7950 Item_func::type() takes 0.26% in OLTP RO Step 2c: After discussion with Igor, it appeared that Item_field and Item_ref could not appear in this context in the old function build_equal_item_for_cond: else if (cond->type() == Item::FUNC_ITEM \|\| cond->real_item()->type() == Item::FIELD_ITEM) The part of the condition checking for Item_field::FIELD_ITEM was a dead code. - Moving implementation of Item_ident_or_func_or_sum::build_equal_items() to Item_func::build_equal_items() - Restoring deriving of Item_ident and Item_sum_or_func from Item_result_field. Removing Item_ident_or_func_or_sum.	11 years ago
Alexander Barkov	04fb09d781	Deriving Item_row from Item_args and sharing more code between Item_func, Item_sum, Item_row.	11 years ago
Alexander Barkov	fc1f301e91	MDEV-8024 Remove excessive update_used_tables() calls	11 years ago
Alexander Barkov	99898c6f76	Minor reorganization in Item hierarchy, to remove duplicate code. - Adding a new class Item_args, represending regular function or aggregate function arguments array. - Adding a new class Item_func_or_sum, a parent class for Item_func and Item_sum - Moving Item_result_field::name() to Item_func_or_sum(), as name() is not needed on Item_result_field level.	11 years ago
Alexander Barkov	e91bc2e91d	MDEV-7759 NULLIF(x,y) is not equal to CASE WHEN x=y THEN NULL ELSE x END	11 years ago
Alexey Botchkov	d0d6284cab	MDEV-4045 Missing OGC Spatial functions. Missing GIS functions added: IsRing() PointOnSurface PointOnSurface Relate Distance Intersection ConvexHull Other old OpenGis standard inconsistencies fixed.	11 years ago
Alexander Barkov	969f491845	MDEV-7005 NULLIF does not work as documented MDEV-7146 NULLIF returns unexpected result with a YEAR field	11 years ago
Sergei Golubchik	5d0122bd77	MDEV-7113 difference between check_vcol_func_processor and check_partition_func_processor MDEV-6789 segfault in Item_func_from_unixtime::get_date on updating table with virtual columns * prohibit VALUES in partitioning expression * prohibit user and system variables in virtual column expressions * fix Item_func_date_format to cache locale (for %M/%W to return the same as MONTHNAME/DAYNAME) * fix Item_func_from_unixtime to cache time_zone directly, not THD (and not to crash) * added tests for other incorrectly allowed (in vcols) functions to see that they don't crash	11 years ago
mithun	c5dfdec568	Bug #19372926 : 5.5.38 FAILS FUNC_MATH MTR TEST. Issue : ------- This seems for some platform -(LONGLONG_MIN) is not flagged as out of range. Fix: ---- Fix is backported from mysql-5.6 bug 14314156. Fixed by adding an explicit test for this value in Item_func_neg::int_op().	11 years ago
mithun	73b99f055e	Bug #19372926 : 5.5.38 FAILS FUNC_MATH MTR TEST. Issue : ------- This seems for some platform -(LONGLONG_MIN) is not flagged as out of range. Fix: ---- Fix is backported from mysql-5.6 bug 14314156. Fixed by adding an explicit test for this value in Item_func_neg::int_op(). sql/item_func.cc: For some platforms we need special handling of LONGLONG_MIN to guarantee overflow.	11 years ago
Alexander Barkov	5b452ae027	MDEV-4511 Assertion `scale <= precision' fails on GROUP BY TIMEDIFF with incorrect types MDEV-6302 Wrong result set when using GROUP BY FROM_UNIXTIME(...)+0 Fixed.	11 years ago
Alexander Barkov	1449d1d54f	Moving implementation of INET_ATON() INET_NTOA() into separate files item_inetfunc.h and item_inetfunc.cc.	12 years ago
Alexander Barkov	89e1715355	MDEV-5372 Make "CAST(time_expr AS DATETIME)" compatible with MySQL-5.6 (and the SQL Standard)	12 years ago
unknown	982607508d	MDEV-4309: DBT-3 Q1 benchmark: Benchmark + profile a patch Removed repetative calls of virtual functions. Removed check of posibility just copy field for every record.	12 years ago

1 2 3 4 5 ...

739 Commits (ed77ee1aab1c41584bccfc62bee77d7c4d9af8d4)