mariadb

Commit Graph

Author	SHA1	Message	Date
Alexander Barkov	df1448801c	MDEV-10181 Illegal mix of collation for a field and an ASCII string as a view field	10 years ago
Sergei Golubchik	95fe71afa6	MDEV-9707 MAX(timestamp(6) column) in correlated sub-query returns non-existent row data in original table special treatment for temporal values in create_tmp_field_from_item(). old code only did it when result_type() was STRING_RESULT, but Item_cache_temporal::result_type() is INT_RESULT	10 years ago
Vicențiu Ciorbaru	3c5c04bd2b	MDEV-7122: Assertion `0' failed in subselect_hash_sj_engine::init Fix test failure when using maria small-block size. We need to query the max_key_length and max_key_parts based on the the tmp table engine.	10 years ago
Vicențiu Ciorbaru	775cccca9f	MDEV-7122: Assertion `0' failed in subselect_hash_sj_engine::init The select mentioned in the bug attempted to create a temporary table using the maria storage engine. The table needs to have primary keys such that duplicates can be removed. Unfortunately this use case has a longer than allowed key and the tmp table got created without a temporary key. We must not allow materialization for the subquery if the total key length and key parts is greater than what the storage engine supports.	10 years ago
Sergei Petrunia	b17a435069	MDEV-6859: scalar subqueries in a comparison produced unexpected result When one evaluates row-based comparison like (X, Y) = (A,B), one should first call bring_value() for the Item that returns row value. If you don't do that and just attempt to read values of X and Y, you get stale values. Semi-join/Materialization can take a row-based comparison apart and make ref access from it. In that case, we need to call bring_value() to get the index lookup components.	10 years ago
Knut Anders Hatlen	95825fa28a	Bug#21682356: STOP INJECTING DATA ITEMS IN AN ERROR MESSAGE GENERATED BY THE EXP() FUNCTION When generating the error message for numeric overflow, pass a flag to Item::print() that prevents it from expanding constant expressions and parameters to the values they evaluate to. For consistency, also pass the flag to Item::print() when Item_func_spatial_collection::fix_length_and_dec() generates an error message. It doesn't make any difference at the moment, since constant expressions haven't been evaluated yet when this function is called.	10 years ago
Sergei Golubchik	f560c1ba42	revert `5e9a50efc3` that was mistakenly merged from mysql-5.5.47 (introduces valgrind failures in main.sp, because Field_varstring columns are created as FIELD_NORMAL and that causes aria to read bytes between the actual value length and field max length)	10 years ago
Sergei Golubchik	265e833fdd	revert `415faa122b` that was mistakenly merged from mysql-5.5.47	10 years ago
Chaithra Gopalareddy	a7fb5aecfd	Bug#19941403: FATAL_SIGNAL(SIG 6) IN BUILD_EQUAL_ITEMS_FOR_COND \| IN SQL/SQL_OPTIMIZER.CC:1657 Problem: At the end of first execution select_lex->prep_where is pointing to a runtime created object (temporary table field). As a result server exits trying to access a invalid pointer during second execution. Analysis: While optimizing the join conditions for the query, after the permanent transformation, optimizer makes a copy of the new where conditions in select_lex->prep_where. "prep_where" is what is used as the "where condition" for the query at the start of execution. W.r.t the query in question, "where" condition is actually pointing to a field in the temporary table. As a result, for the second execution the pointer is no more valid resulting in server exit. Fix: At the end of the first execution, select_lex->where will have the original item of the where condition. Make prep_where the new place where the original item of select->where has to be rolled back. Fixed in 5.7 with the wl#7082 - Move permanent transformations from JOIN::optimize to JOIN::prepare Patch for 5.5 includes the following backports from 5.6: Bugfix for Bug12603141 - This makes the first execute statement in the testcase pass in 5.5 However it was noted later in in Bug16163596 that the above bugfix needed to be modified. Although Bug16163596 is reproducible only with changes done for Bug12582849, we have decided include the fix. Considering that Bug12582849 is related to Bug12603141, the fix is also included here. However this results in Bug16317817, Bug16317685, Bug16739050. So fix for the above three bugs is also part of this patch.	10 years ago
Oleksandr Byelkin	7e4da9b370	DEV-8632 Segmentation fault on INSERT View/derived fields should be taken into account when we build ref_pointer_array constructed. DBUG_ASSERTs added to avoid memory overrun.	10 years ago
Sreeharsha Ramanavarapu	5e9a50efc3	Bug #22023218 : MYSQL 5.5: MAIN.FULLTEXT HAS VALGRIND ISSUES. Issue ----- This problem occurs when varchar columns are used in a internal temporary table. The type of the field is set incorrectly to the generic FIELD_NORMAL type. This in turn results in an inaccurate calculation of the record length. Valgrind issues will occur since initialization has not happend for some bytes. Fix ---- While creating the temporary table, the type of the field needs to be to set FIELD_VARCHAR. This will allow myisam to calculate the record length accurately. This fix is a backport of BUG#13350136.	10 years ago
Sreeharsha Ramanavarapu	415faa122b	Bug #19434916 : FATAL_SIGNAL IN ADD_KEY_EQUAL_FIELDS() WITH UPDATE VIEW USING OUTER SUBQUERY Issue: ----- While resolving a column which refers to a table/view in an outer query, it's respecitve item object is marked with the outer query's select_lex object. But when the column refers to a view or if the column is part of a subquery in the HAVING clause, an Item_ref object is created. While the reference to the outer query is stored by the Item_ref object, the same is not stored in it's real_item. This creates a problem with the IN-TO-EXISTS optmization. When there is an index over the column in the inner query, it will be considered since the column's real_item object will be mistaken for a local field. This will lead to a crash. SOLUTION: --------- Under the current design, the only way to fix this issue is to check the reginfo.join_tab for a NULL value. If yes, the query should not be worrying about the key use. The testcase and comments added as part of the fix for Bug#17766653 have been backported.	10 years ago
Ajo Robert	f3dce250f4	Bug #20760261 mysqld crashed in materialized_cursor:: send_result_set_metadata Analysis -------- Cursor inside trigger accessing NEW/OLD row leads server exit. The reason for the bug was that implementation of function create_tmp_table() was not considering Item::TRIGGER_FIELD_ITEM as possible alternative for type of class being instantiated. This was resulting in a mismatch between a number of columns in result list and temp table definition. This mismatch leads to the failure of assertion DBUG_ASSERT(send_result_set_metadata.elements == item_list.elements) in the method Materialized_cursor::send_result_set_metadata in debug mode. Fix: --- Added code to consider Item::TRIGGER_FIELD_ITEM as valid type while creating fields.	10 years ago
Mithun C Y	c28626d0af	Bug #21096444 : MYSQL IS TRYING TO PERFORM A CONSISTENT READ BUT THE READ VIEW IS NOT ASSIGNED! Issue: A select for update subquery in having clause resulted deadlock and its transaction was rolled back by innodb. val_XXX interfaces do not handle errors and it do not propogate errors to its caller. sub_select did not see this error when it called evaluate_join_record and later made a call to innodb. As transaction is rolled back innodb asserted. Fix: Now evaluate_join_record checks if there is any error reported and then return the same to its caller.	10 years ago
Monty	8c815751c9	Problem was that for cases like: SELECT ... WHERE XX IN (SELECT YY) this was transformed to something like: SELECT ... WHERE IF_EXISTS(SELECT ... HAVING XX=YY) The bug was that for normal execution XX was fixed in the original outer SELECT context while in PS it was fixed in the sub query context and this confused the optimizer. Fixed by ensuring that XX is always fixed in the outer context.	11 years ago
Monty	2e941fe9fc	Fixed crashing bug when using ONLY_FULL_GROUP_BY in a stored procedure/trigger that is repeatedly executed. This is MDEV-7601, including it's sub tasks MDEV-7594, MDEV-7555, MDEV-7590, MDEV-7581, MDEV-7589 The problem was that select_lex->non_agg_fields was not properly reset for re-execution and this caused an overwrite of a random memory position. The fix was move non_agg_fields from select_lext to JOIN, which is properly reset.	11 years ago
Sergei Petrunia	992d782d78	MDEV-6735: Range checked for each record used with key (also MDEV-7786, MDEV-7923) "Range Checked for Each Record" should be only employed when the other option would be cross-product join (i.e. the other option is so bad that we hardly risk anything). Previous logic was: use RCfER if there are no possible quick selects, or quick select would read > 100 rows. Also, it didn't always work as expected due to range optimizer changing table->quick_keys and us looking at sel->quick_keys. Another angle is that recent versions have enabled use of Join Buffering in e.g. outer joins. This further reduces the range of cases where RCfER should be used. We are still unable to estimate the cost of RCfER with any precision, so now changing the condition of "no quick select or quick->records> 100" to a hopefully better condition "no quick select or quick would cost more than full table scan".	11 years ago
Oleksandr Byelkin	b9a75862ea	MDEV-7613: MariaDB 5.5.40 server crash on update table left join with a view Multi-update do not need full list of leaf tables. It also do not use it on prepare (mysql_multi_update_prepare()).	11 years ago
Chaithra Gopalareddy	044060fe16	Bug #20730220 : BACKPORT BUG#19880368 TO 5.1 Backport from mysql-5.5 to mysql-5.1 Bug#19880368 : GROUP_CONCAT CRASHES AFTER DUMP_LEAF_KEY Problem: find_order_by_list does not update the address of order_item correctly after resolving. Solution: Change the ref_by address for a order_by field if its SUM_FUNC_ITEM to the address of the field present in all_fields.	11 years ago
Chaithra Gopalareddy	a2cd622f3a	Bug #20730129 : BACKPORT BUG#19612819 TO 5.1 Backport from mysql-5.5 to mysql-5.1 Bug #19612819 : FILESORT: ASSERTION FAILED: POS->FIELD != 0 \|\| POS->ITEM != 0 Problem: While getting the temp table field for a REF_ITEM make_sortorder is using the real_item. As a result server fails later with an assert. Solution: Do not use real_item to get the temp table field. Instead use the REF_ITEM itself as temp table fields are created for REF_ITEM not the real_item.	11 years ago
Sergei Petrunia	c020d362b6	MDEV-7474: Semi-Join's DuplicateWeedout strategy skipped ... JOIN::cur_dups_producing_tables was not maintained correctly in the cases of greedy optimization (search_depth < n_tables). Moved it to POSITION structure where it will be maintained automatically. Removed POSITION::prefix_dups_producing_tables since its value can now be calculated.	11 years ago
Vicențiu Ciorbaru	45b6edb158	MDEV-6838: Using too big key for internal temp tables This bug manifests due to wrong computation and evaluation of keyinfo->key_length. The issues were: * Using table->file->max_key_length() as an absolute value that must not be reached for a key, while it represents the maximum number of bytes possible for a table key. * Incorrectly computing the keyinfo->key_length size during KEY_PART_INFO creation. The metadata information regarding the key such the field length (for strings) was added twice.	11 years ago
Chaithra Gopalareddy	674367afd5	Bug#19880368 : GROUP_CONCAT CRASHES AFTER DUMP_LEAF_KEY Problem: find_order_by_list does not update the address of order_item correctly after resolving. Solution: Change the ref_by address for a order_by field if its SUM_FUNC_ITEM to the address of the field present in all_fields.	11 years ago
Chaithra Gopalareddy	1a5b8122b6	Bug #19612819 : FILESORT: ASSERTION FAILED: POS->FIELD != 0 \|\| POS->ITEM != 0 Problem: While getting the temp table field for a REF_ITEM make_sortorder is using the real_item. As a result server fails later with an assert. Solution: Do not use real_item to get the temp table field. Instead use the REF_ITEM itself as temp table fields are created for REF_ITEM not the real_item.	11 years ago
Sergey Petrunya	b75090c7de	MDEV-6830: Server crashes in best_access_path after a sequence of SELECTs ... generate_derived_keys_for_table() did not work correctly in the case where - it had a potential index on derived table - however, TABLE::check_tmp_key() would disallow creation of this index after looking at its future key parts (because of the key parts exceeding max. index length) - the code would leave a KEYUSE structure that refers to a non-existant index. Depending on further optimizer calculations, this could cause a crash.	11 years ago
Nisha Gopalakrishnan	5a587b6d28	BUG#11747548: DETECT ORPHAN TEMP-POOL FILES, AND HANDLE GRACEFULLY Analysis: -------- Certain queries using intrinsic temporary tables may fail due to name clashes in the file name for the temporary table when the 'temp-pool' enabled. 'temp-pool' tries to reduce the number of different filenames used for temp tables by allocating them from small pool in order to avoid problems in the Linux kernel by using a three part filename: <tmp_file_prefix>_<pid>_<temp_pool_slot_num>. The bit corresponding to the temp_pool_slot_num is set in the bit map maintained for the temp-pool when it used for the file name. It is cleared after the temp table is deleted for re-use. The 'create_tmp_table()' function call under error condition tries to clear the same bit twice by calling 'free_tmp_table()' and 'bitmap_lock_clear_bit()'. 'free_tmp_table()' does a delete of the table/file and clears the bit by calling the same function 'bitmap_lock_clear_bit()'. The issue reported can be triggered under the timing window mentioned below for an error condition while creating the temp table: a) THD1: Due to an error clears the temp pool slot number used by it by calling 'free_tmp_table'. b) THD2: In the process of creating the temp table by using an unused slot number in the bit map. c) THD1: Clears the slot number used THD2 by calling 'bitmap_lock_clear_bit()' after completing the call 'free_tmp_table'. d) THD3: Uses the slot number used the THD2 since it is freed by THD1. When it tries to create the temp file using that slot number, an error is reported since it is currently in use by THD2. [The error: Error 'Can't create/write to file '/tmp/#sql_277e_0.MYD' (Errcode: 17)'] Another issue which may occur in 5.6 and trunk is that: When the open temporary table fails after its creation(due to ulimit or OOM error), the file is not deleted. Thus further attempts to use the same slot number in the 'temp-pool' results in failure. Fix: --- a) Under the error condition calling the 'bitmap_lock_clear_bit()' function to clear the bit is unnecessary since 'free_tmp_table()' deletes the table/file and clears the bit. Hence removed the redundant call 'bitmap_lock_clear_bit()' in 'create_tmp_table()' This prevents the timing window under which the issue reported can be seen. b) If open of the temporary table fails, then the file is deleted thus allowing the temp-pool slot number to be utilized for the subsequent temporary table creation. c) Also if the attempt to create temp table fails since it already exists, the temp-pool slot for it is marked as used, to avoid the problem from re-appearing.	11 years ago
Sergey Petrunya	a8341dfd6e	MDEV-6879: Dereference of NULL primary_file->table in DsMrr_impl::get_disk_sweep_mrr_cost() (Backport to 5.3) (Attempt #2) - Don't attempt to use BKA for materialized derived tables. The table is neither filled nor fully opened yet, so attempt to call handler->multi_range_read_info() causes crash.	11 years ago
Sergey Petrunya	94c8f33569	MDEV-6888: Query spends a long time in best_extension_by_limited_search with mrr enabled - TABLE::create_key_part_by_field() should not set PART_KEY_FLAG in field->flags = The reason is that it is used by hash join code which calls it to create a hash table lookup structure. It doesn't create a real index. = Another caller of the function is TABLE::add_tmp_key(). Made it to set the flag itself. - The differences in join_cache.result could also be observed before this patch: one could put "FLUSH TABLES" before the queries and get exactly the same difference.	11 years ago
Igor Babaev	1e1a8a7fc9	Fixed bug mdev-6705. After constant row substitution the WHERE condition may be simplified and its multiple equality may be changed. In this case the references to these multiple equalities from the COND_EQUAL objects associated with ON expressions must be updated. Also we have to take into account that this simplification may lead to equalities of the form field=const that are mutually exclusive with some of the equalities in ON expressions.	11 years ago
Sergey Petrunya	b261ec393a	MDEV-6484: Assertion `tab->ref.use_count' failed on query with joins, constant table, multi-part key - test_if_skip_sort_order()/create_ref_for_key() may change table access from EQ_REF(index1) to REF(index2). - Doing so doesn't make much sense from optimization POV, but since they are doing it, they should update tab->read_record.unlock_row accordingly.	11 years ago
Sergei Golubchik	fc58ba6c76	MDEV-5553 A view or procedure with a non existing definer can block "SHOW TABLE STATUS" with an unclear error message Don't double-check privileges for a column in the GROUP BY that refers to the same column in SELECT clause. Privileges were already checked for SELECT clause.	11 years ago
Sergei Golubchik	c0977073e1	MDEV-6743 crash in GROUP_CONCAT(IF () ORDER BY 1) backport the new fix from 10.0	11 years ago
Igor Babaev	f735822720	Fixed bug mdev-5721. Do not define a look-up key for a temporary table if its length exceeds the maximum length of such keys.	11 years ago
Sergey Petrunya	6b353dd1de	MDEV-6289 : Unexpected results when querying information_schema - When traversing JOIN_TABs with first_linear_tab/next_linear_tab(), don't forget to enter the semi-join nest when it is the first table in the join order. Failure to do so could cause e.g. I_S tables not to be filled.	12 years ago
Sergey Petrunya	d533a64bf3	MDEV-6239: Partition pruning is not working as expected in an inner query - Make partition pruning work for tables inside semi-join nests (the new condition is the same that range optimizer uses so it should be ok)	12 years ago
Sergey Petrunya	dedc76b7d9	MDEV-6263: Wrong result when using IN subquery with order by - When the optimizer chose LooseScan, make_join_readinfo() should use the index that was chosen for LooseScan, and should not try to find a better (shortest) index.	12 years ago
unknown	285160dee2	MDEV-5981: name resolution issues with views and multi-update in ps-protocol It is triple bug with one test suite: 1. Incorrect outer table detection 2. Incorrect leaf table processing for multi-update (should be full like for usual updates and inserts) 3. ON condition fix_fields() fould be called for all tables of the query.	12 years ago
mithun	3d6d85b40d	Bug #18167356 : EXPLAIN W/ EXISTS(SELECT* UNION SELECT) WHERE ONE OF SELECT IS DISTINCT FAILS. ISSUE: ------ There are 2 issues related to explain union. 1. If we have subquery with union of selects. And, one of the select need temp table to materialize its results then it will replace its query structure with a simple select from temporary table. Trying to display new internal temporary table scan resulted in crash. But to display the query plan, we should save the original query structure. 2. Multiple execution of prepared explain statement which have union of subqueries resulted in crash. If we have constant subqueries, fake select used in union operation will be evaluated once before using it for explain. During first execution we have set fake select options to SELECT_DESCRIBE, but did not reset after the explain. Hence during next execution of prepared statement during first time evaluation of fake select we had our select options as SELECT_DESCRIBE this resulted in improperly initialized data structures and crash. SOLUTION: --------- 1. If called by explain now we save the original query structure. And this will be used for displaying. 2. Reset the fake select options after it is called for explain of union. sql/sql_select.cc: Reset the fake select options after it is called for explain of union sql/sql_union.cc: If called by explain but not from select_describe and we need a temp table, then we create a temp join to preserve original query structure.	12 years ago
mithun	11f5d757d3	Bug #18167356 : EXPLAIN W/ EXISTS(SELECT* UNION SELECT) WHERE ONE OF SELECT IS DISTINCT FAILS. ISSUE: ------ There are 2 issues related to explain union. 1. If we have subquery with union of selects. And, one of the select need temp table to materialize its results then it will replace its query structure with a simple select from temporary table. Trying to display new internal temporary table scan resulted in crash. But to display the query plan, we should save the original query structure. 2. Multiple execution of prepared explain statement which have union of subqueries resulted in crash. If we have constant subqueries, fake select used in union operation will be evaluated once before using it for explain. During first execution we have set fake select options to SELECT_DESCRIBE, but did not reset after the explain. Hence during next execution of prepared statement during first time evaluation of fake select we had our select options as SELECT_DESCRIBE this resulted in improperly initialized data structures and crash. SOLUTION: --------- 1. If called by explain now we save the original query structure. And this will be used for displaying. 2. Reset the fake select options after it is called for explain of union.	12 years ago
Igor Babaev	13dc299a4f	Fixed bugs mdev-5927 and mdev-6116. Both bugs are caused by the same problem: the function optimize_cond() should update the value of *cond_equal rather than the value of join->cond_equal, because it is called not only for the WHERE condition, but for the HAVING condition as well.	12 years ago
unknown	05722f06b2	MDEV-5991: crash in Item_field::used_tables Units of subqueroes from excluded expressions should be excluded from select_lex/select_unit tree.	12 years ago
Sergey Petrunya	8c04dd33dd	MDEV-5811: Server crashes in best_access_path with materialization+semijoin and big_tables=ON - With big_tables=ON, materialized table will use Aria (or MyISAM) SE, which allows prefix key reads. However, the temp.table has rec_per_key=NULL which causes the optimizer to crash when attempting to read index statistics for a prefix index read. - Fixed by providing a rec_per_key array with zeros (i.e. "no statistics data")	12 years ago
Igor Babaev	1f2ef57403	Fixed bug mdev-5686. The calls of the function remove_eq_conds() may change the and/or structure of the where conditions. So JOIN::equal_cond should be updated for non-recursive calls of remove_eq_conds().	12 years ago
Igor Babaev	3e03c9eae9	After constant row substitution the optimizer should call the method update_used_tables for the the where condition to update cached indicators of constant subexpressions. It should be done before further possible simplification of the where condition. This change caused simplification of the executed where conditions in many test cases.	12 years ago
Sergey Petrunya	8c9b2f3429	MDEV-5581: Server crashes in in JOIN::prepare on 2nd execution of PS with materialization+semijoin - The problem was that JOIN::prepare() tried to set TABLE::maybe_null for a table in join. Non-merged semi-join tables 1) are present as join's base tables on second EXECUTE, but 2) do not yet have a TABLE object. Worked around the problem by putting mixed_implicit_grouping into JOIN object, and then passing it to JTBM tables in setup_jtbm_semi_joins().	12 years ago
Sergei Golubchik	4b57720caa	use a different error for MySQL bug#11747970 - kill the query, as it was supposed to be in bug#11747970, don't fake an error. (this kill can be useful for other bugs too)	12 years ago
unknown	528df1df45	MDEV-5505: Assertion `! is_set()' fails on PREPARE SELECT with out of range in GROUP BY Fixed error processing in find_order_in_list(): if an error reported to user there is no sens to continue.	12 years ago
Sergey Petrunya	34b6f51dab	MDEV-5582: Plugin 'MEMORY' has ref_count=1 after shutdown with materialization+semijoin - Let cleanup_empty_jtbm_semi_joins() walk into semi-join nests.	12 years ago
Igor Babaev	5b441013e1	Fixed bug mdev-5468. The field JOIN::select_lex->where should be updated after the call of remove_eq_conds() in the function make_join_statistics(). This matters for subselects.	12 years ago
Sergei Golubchik	90e2240869	MDEV-5461 Assertion `length <= column->length' fails in write_block_record with functions in select list, GROUP BY, ORDER BY Old code in create_tmp_table(), that created an extra one-byte field (recinfo) before every NULL-able grouping field (Field) in the tmp table, did not actually work. Because the matching code in end_update(), that was supposed to update this byte, was using a wrong offset, updating the first byte of the Field, not a byte before it. Normally this wasn't an issue, because the Field value (written later in end_update) was overwriting this byte anyway. But in this bug the Field was Field_null, with zero length, so end_update() was overwriting the first byte of the following field. And the following field was not-nullable constant, which was stored only once in create_tmp_table and never updated later. Fixed by removing the code that didn't do any useful work anyway.	12 years ago

1 2 3 4 5 ...

6424 Commits (ecdb2b6e86d4bef2718eaec61f1edd1c11e41e1a)