mariadb

Tree: e9259d50f0

Author	SHA1	Message	Date
Jan Lindström	e9259d50f0	MDEV-21335 : Galera test failure on suite wsrep Problem was that wsrep_on was OFF.	6 years ago
Vladislav Vaintroub	189fa30085	MDEV-21343 Threadpool/Unix- wait_begin() function does not wake/create threads, when it should Fixed the condition for waking up/creating another thread. If there is some work to do (if the request queue is not empty), a thread should be woken or created. The condition was incorrect since `18c9b345b4`	6 years ago
Sergei Golubchik	0d70f40bdb	Disable -Werror for rocksdb submodule We cannot have -Werror for third-party submodules because whenever they break the build we cannot fix it as needed.	6 years ago
Varun Gupta	164cf4f463	MDEV-16579: Wrong result of query using DISTINCT COUNT() OVER () The query requires 2 temporary tables for execution, the window function is always attached to the last temporary table, but in this case the result field of the window function points to the first temporary table rather than the last one. Fixed this by not changing window function items with temporary table items of the first temporary table.	6 years ago
Anel Husakovic	8129ff1440	PR #1127 and PR #1150 PR#1127: Fix is_check_constraints.result to be compatibile with 10.3 The patch is done according to the original patch for MDEV-14474 `1edd09c325` and not one which is merged on server `d526679efd`. This patch includes: - Rename from `is_check_constraint` to `is_check_constraints` to tests and results - Per review, change the order of fields in IS check_constraints table by adding the column `table_name` before `constraint_name`. According to the standard 2006 there is no `table_name` column. - Original patch and one in `10.3` supports embedded server this patch doesn't support. After the merge `10.3` will not support also. - Don't use patch `c8b8b01b61` to change the length of `CHECK_CLAUSE` field PR#1150: MDEV-18440: Information_schema.check_constraints possible data leak This patch is extension of PR 1127 and includes: - Check for table grants - Additional test according to the MDEV specification Signed-off-by: Vicențiu Ciorbaru <vicentiu@mariadb.org>	7 years ago
Eugene Kosov	f0aa073f2b	MDEV-20950 Reduce size of record offsets offset_t: this is a type which represents one record offset. It's unsigned short int. a lot of functions: replace ulint with offset_t btr_pcur_restore_position_func(), page_validate(), row_ins_scan_sec_index_for_duplicate(), row_upd_clust_rec_by_insert_inherit_func(), row_vers_impl_x_locked_low(), trx_undo_prev_version_build(): allocate record offsets on the stack instead of waiting for rec_get_offsets() to allocate it from mem_heap_t. So, reducing memory allocations. RECORD_OFFSET, INDEX_OFFSET: now it's less convenient to store pointers in offset_t* array. One pointer occupies now several offset_t. And those constant are start indexes into array to places where to store pointer values REC_OFFS_HEADER_SIZE: adjusted for the new reality REC_OFFS_NORMAL_SIZE: increase size from 100 to 300 which means less heap allocations. And sizeof(offset_t[REC_OFFS_NORMAL_SIZE]) now is 600 bytes which is smaller than previous 800 bytes. REC_OFFS_SEC_INDEX_SIZE: adjusted for the new reality rem0rec.h, rem0rec.ic, rem0rec.cc: various arguments, return values and local variables types were changed to fix numerous integer conversions issues. enum field_type_t: offset types concept was introduces which replaces old offset flags stuff. Like in earlier version, 2 upper bits are used to store offset type. And this enum represents those types. REC_OFFS_SQL_NULL, REC_OFFS_MASK: removed get_type(), set_type(), get_value(), combine(): these are convenience functions to work with offsets and it's types rec_offs_base()[0]: still uses an old scheme with flags REC_OFFS_COMPACT and REC_OFFS_EXTERNAL rec_offs_base()[i]: these have type offset_t now. Two upper bits contains type.	6 years ago
Vlad Lesin	beec9c0e19	MDEV-21255: Deadlock of parallel slave and mariabackup (with failed log copy thread) mariabackup hangs waiting until innodb redo log thread read log till certain LSN, and it waits under FTWRL. If there is redo log read error in the thread, it is finished, and main thread knows nothing about it, what leads to hanging. As it hangs under FTWRL, slave threads on server side can be blocked due to MDL lock conflict. The fix is to finish mariabackup with error message on innodb redo log read failure.	6 years ago
Varun Gupta	808036a61d	MDEV-19380: ASAN heap-use-after-free in Protocol::net_store_data The issue here is window function makes the passed string object to point to an area in a temporary table's record buffer. Then, the temporary table is freed, together with its record buffer. Then, Item_cache_str attempts to read this value. The fix is to call value_buff.copy(). This will make the value_buff to store its string in a buffer that it owns, which will not disappear unexpectedly.	6 years ago
Daniel Bartholomew	546644f1cc	bump the VERSION	6 years ago
Vladislav Vaintroub	202a62deb0	MDEV-11345 Compile english error messages into mysqld executable. Simplify loading messages into mariabackup. Do the same as server does We're forcing english, so there is no attempt to load errmsg.sys	6 years ago
Vladislav Vaintroub	280f1c2605	MDEV-11345 Compile english error messages into mysqld executable.	6 years ago
Marko Mäkelä	f2d3b2eede	Cleanup test sys_vars.innodb_buffer_pool_size_basic When using huge pages, the innodb_buffer_pool_size cannot necessarily be restored. Simplify things by restarting the server.	6 years ago
Marko Mäkelä	41e6a154ec	MDEV-14482 - Cache line contention on ut_rnd_interval() InnoDB RNG maintains global state, causing otherwise unnecessary bus traffic. Even worse, this is cross-mutex traffic. That is, different mutexes suffer from contention. Fixed delay of 4 was verified to give best throughput by OLTP update index and read-write benchmarks on Intel Broadwell (2/20/40) and ARM (1/46/46). This is a backport of `ce04790065` from MariaDB Server 10.3.	6 years ago
Marko Mäkelä	b1f2d3a8c8	MDEV-21256: Replace the 64-bit LCG with a 32-bit Galois LFSR We should not need anywhere near 32 bits of entropy, so we might just limit ourselves to a 32-bit random number generator. Also, it might be cheaper to use exclusive-or, bit shifting and conditional jumps, instead of multiplication and addition. We use relaxed atomic operations on the global random number generator state in order in an attempt to silence any warnings about race conditions. There is an obvious race condition between the load and store in ut_rnd_gen(), but we do not think that it matters much that the state of the random number generator could 'stutter'. This change seems makes the 'uncompress_ops' nondeterministic in innodb_zip.cmp_per_index after the restart. It looks like there is an inherent race condition in the test, because the table could be opened for InnoDB statistics recalculation already before innodb_cmp_per_index_enabled was set. We might end up having uncompress_ops anywhere between 0 and 9, or perhaps even more. Let us remove that part of the test.	6 years ago
Marko Mäkelä	d146e3dcfe	MDEV-21256: Simplify ut_rnd_interval() ut_rnd_interval(): Remove the first parameter, which was mostly passed as 0. Implement as a simple wrapper around ut_rnd_gen(). Trivially return 0 if the size of the interval is smaller than 2. ut_rnd_ulint_counter, ut_rnd_gen_next_ulint(), ut_rnd_gen_ulint(): Remove.	6 years ago
Marko Mäkelä	51fc8ab73e	MDEV-21256: Reduce the use of ut_rnd_gen_next_ulint() ut_rnd_set_seed(): Unused function; remove. ut_rnd_gen(): Renamed from page_cur_lcg_prng(). ut_rnd_current: The internal state of ut_rnd_gen(). page_cur_open_on_rnd_user_rec(): Replace linear search with page_rec_get_nth().	6 years ago
Eugene Kosov	4c0854f221	MDEV-21223 innodb_fts.sync_ddl fails in buildbot, server crashed in que_thr_step FreeState(): replace pointer to freed memory with NULL. This actually fixes a crash which is use-after-free as reported by ASAN DbugParse(): unconditionally lock mutex because we're touching shared init_settings.keywords	6 years ago
Oleksandr Byelkin	af650c76a6	MDEV-18460: Server crashed in strmake / tdc_create_key / THD::create_tmp_table_def_key When there is a WITH clause we postpone check for tables without database for later stages when tables in WITH will be defined. But we should not try to open such tables as temporary tables because temporary tables always belong to a some database.	6 years ago
Marko Mäkelä	425748f1b5	Cleanup: Replace a redundant statement with an assertion	6 years ago
Marko Mäkelä	292015d486	MDEV-21254 Remove unused keywords from the InnoDB SQL parser The InnoDB internal SQL parser, which is used for updating the InnoDB data dictionary tables (to be removed in MDEV-11655), persistent statistics (to be refactored in MDEV-15020) and fulltext indexes, implements some unused keywords and built-in functions: OUT BINARY BLOB INTEGER FLOAT SUM DISTINCT READ COMPACT BLOCK_SIZE TO_CHAR TO_NUMBER BINARY_TO_NUMBER REPLSTR SYSDATE PRINTF ASSERT RND RND_STR ROW_PRINTF UNSIGNED Also, procedures are never declared with parameters. Only one top-level procedure is declared and invoked at a time, and parameters are being passed via pars_info_t.	6 years ago
Jan Lindström	59e14b9684	MDEV-21189: Dropping partition with 'wsrep_OSU_method=RSU' and 'SESSION sql_log_bin = 0' cases the galera node to hang Found two bugs (1) have_committing_connections was missing mutex unlock on one exit case. As this function is called on a loop it caused mutex lock when we already owned the mutex. This could cause hang. (2) wsrep_RSU_begin did set up error code when partition to be dropped could not be MDL-locked because of concurrent operations but wrong error code was propagated to upper layer causing error to be ignored. This could have also caused the hang.	6 years ago
Alexey Botchkov	fd1979bc9a	MDEV-18463 Don't allow multiple table CONSTRAINTs with the same name. Add necessary checks.	6 years ago
Vladislav Vaintroub	6aa0fa3897	CONC-417 Windows clients using Schannel often encounter error SEC_E_INVALID_TOKEN reenable ssl_8k_key on Windows, which was affected by this bug	6 years ago
Vladislav Vaintroub	6484288cd2	CONC-447 ERROR 2026 (HY000): SSL connection error: Certificate signature check failed Enable CRL checking on Windows. Enable certificate verification testing in client testing.	6 years ago
Elena Stepanova	3cc0e0befb	List of unstable tests for 10.2.30 release	6 years ago
Jan Lindström	c9b9eb3315	MDEV-18497 : CTAS async replication from mariadb master crashes galera nodes (#1410 ) In MariaDB 10.2 master could have been configured so that there is extra annotate events. When we peak next event type for CTAS we need to skip annotate events.	6 years ago
Oleksandr Byelkin	f7d35ffc76	Galera test fix after merge.	6 years ago
Oleksandr Byelkin	ccc5e57730	vew CC v 3.1	6 years ago
Oleksandr Byelkin	425437b290	Merge remote-tracking branch 'connect/10.2' into 10.2	6 years ago
Oleksandr Byelkin	f8b5e147da	Merge branch '10.1' into 10.2	6 years ago
Oleksandr Byelkin	117c8146de	Merge branch '5.5' into 10.1	6 years ago
Eugene Kosov	543f22a2d0	check parameters of io_submit() and LinuxAIOHandler::reserve_slot() Ensure that pointer to a buffer which is used for both reads and writes is properly aligned. I've intentially put permanent check right before io_submit() call instead of the time of setting iocb date. I think that'll make check better. LinuxAIOHandler::resever_slot(): check arguments alignment in debug builds	6 years ago
Jan Lindström	88073dae79	MDEV-21198 : Galera test failure on galera_var_notify_cmd Add proper wsrep sync wait.	6 years ago
Marko Mäkelä	3ff8fb5141	InnoDB: Remove unused get_wkb_of_default_point() The function get_wkb_of_default_point() should never have been added, and the cleanup in commit `56ff6f1b0b` should have removed it. The unnecessary code was added in mysql/mysql-server@0a27b72171c4449f506ad4e93df8c29fead1ed72 and mostly disabled in mysql/mysql-server@8f11af7734509821b654f2c330dff5374c89073c. In MariaDB, the types DATA_POINT and DATA_VAR_POINT are never used. Instead, DATA_GEOMETRY continues to be used since 10.2.2, introduced by mysql/mysql-server@673bad7c7e17701b69e29d0fbc4e2d68c1a7b613 in MySQL 5.7.1.	6 years ago
Anel Husakovic	e3d3bbf598	Using `variables` instead of `values` in mysqld --help documentation would be more accurate	6 years ago
Faustin Lammler	d930422e9e	Fix the line break warning (groff/lintian). The lintian Debian tool is complaining about: 'W: mariadb-test: manpage-has-errors-from-man usr/share/man/man1/mysql-test-run.pl.1.gz 246: warning [p 2, 6.0i, div '3tbd1,1', 0.3i]: can't break line' See: https://salsa.debian.org/faust-guest/mariadb-10.3/-/jobs/431900 The following command permits to catch the problematic lines: $ groff -man -Tascii ./mysql-test-run.pl.1 \| less Closes #1419	6 years ago
Jan Lindström	c6ed37b88a	MDEV-21182: Galera test failure on MW-284 galera_2nodes.cnf did not contain wsrep_on=1 on correct places. Fixed restart options to use correct configuration.	6 years ago
Eugene Kosov	33cf4da183	cleanup: replace exit(1) with abort()	6 years ago
Eugene Kosov	6fe2aae3ce	InnoDB: log unsuccessful calls to pthread_attr_init() and pthread_create() before crash	6 years ago
HF	3fb0fe400c	MENT-510 Failing test(s): perfschema.threads_insert_delayed. orig_test_id should be set properly. Also fixed sporadic test failure.	6 years ago
Anel Husakovic	3cb60ec2c3	Update `stracer` description in `mtr`. `strace-client` is not used	6 years ago
Daniel Black	866e5c250e	MDEV-15503: mtr fix --strace $glob_mysql_test_dir was the wrong directory for strace output as it was for in-tree builds only so failed for: * out of tree builds * --parallel; and * --mem strace output wasn't saved. strace-option never replaced existing arguments (so ammended documentation). strace-client didn't accept an argument as described. Replaced specification of client with this with 'stracer' to be consistent with --debugger option. For consistency with debugger options, --client-strace was added to execute the strace on the mysqltest. Example: Running one test $ ./mtr --strace --client-strace funcs_1.is_table_constraints Logging: ./mtr --strace --client-strace funcs_1.is_table_constraints vardir: /home/anel/mariadb/5.5/mysql-test/var Checking leftover processes... Removing old var directory... - WARNING: Using the 'mysql-test/var' symlink Creating var directory '/home/anel/mariadb/5.5/mysql-test/var'... Checking supported features... MariaDB Version 5.5.67-MariaDB-debug Installing system database... - SSL connections supported - binaries are debug compiled Collecting tests... ============================================================================== TEST RESULT TIME (ms) or COMMENT -------------------------------------------------------------------------- worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 16000..16019 funcs_1.is_table_constraints [ pass ] 1270 -------------------------------------------------------------------------- The servers were restarted 0 times Spent 1.270 of 3 seconds executing testcases Completed: All 1 tests were successful $ find -L . -name \strace -ls 653 56 -rw-r--r-- 1 anel anel 57147 Nov 29 15:08 ./var/log/mysqltest.strace 646 1768 -rw-r--r-- 1 anel anel 1809855 Nov 29 15:08 ./var/log/mysqld.1.strace Example: Running test in parallel $ mysql-test/mtr --strace --client-strace --mem --parallel=3 main.select Logging: /home/dan/software_projects/mariadb-server/mysql-test/mysql-test-run.pl --strace --client-strace --mem --parallel=3 main.select vardir: /home/dan/software_projects/build-mariadb-10.3/mysql-test/var Checking leftover processes... Removing old var directory... Creating var directory '/home/dan/software_projects/build-mariadb-10.3/mysql-test/var'... - symlinking 'var' to '/dev/shm/var_auto_0v2E' Checking supported features... MariaDB Version 5.5.67-MariaDB - SSL connections supported Collecting tests... Installing system database... ============================================================================== TEST WORKER RESULT TIME (ms) or COMMENT -------------------------------------------------------------------------- worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 16000..16019 worker[3] - 'localhost:16040' was not free worker[2] Using MTR_BUILD_THREAD 301, with reserved ports 16020..16039 worker[3] Using MTR_BUILD_THREAD 303, with reserved ports 16060..16079 main.select w1 [ pass ] 7310 -------------------------------------------------------------------------- The servers were restarted 0 times Spent 7.310 of 11 seconds executing testcases Completed: All 1 tests were successful. $ find mysql-test/var/ -name \strace -ls 5213766 1212 -rw-r--r-- 1 dan dan 1237817 May 20 16:47 mysql-test/var/1/log/mysqltest.strace 5214733 13016 -rw-r--r-- 1 dan dan 13328335 May 20 16:47 mysql-test/var/1/log/mysqld.1.strace $ mysql-test/mtr --strace --client-strace --strace-option='-e' --strace-option='trace=openat' --mem --parallel=3 main.select ... $ find mysql-test/var/ -name \*strace -ls 5220790 8 -rw-r--r-- 1 dan dan 6291 May 20 17:02 mysql-test/var/3/log/mysqltest.strace 5224140 308 -rw-r--r-- 1 dan dan 314356 May 20 17:02 mysql-test/var/3/log/mysqld.1.strace $ more mysql-test/var/3/mysqltest.strace 1692 openat(AT_FDCWD, "/home/dan/software_projects/mariadb-server/libmysql/.libs/tls/x86_64/x86_64/libpthread.so.0", O_RDONLY\|O_CLOEXEC) = -1 ENOENT (No such file or directory) 1692 openat(AT_FDCWD, "/home/dan/software_projects/mariadb-server/libmysql/.libs/tls/x86_64/libpthread.so.0", O_RDONLY\|O_CLOEXEC) = -1 ENOE NT (No such file or directory) Closes #600	8 years ago
Vlad Lesin	bd11bd63cc	MDEV-18310: Aria engine: Undo phase failed with "Got error 121 when executing undo undo_key_delete" upon startup on datadir restored from incremental backup aria_log* files were not copied on --prepare --incremental-dir step from incremental to destination backup directory.	6 years ago
Vladislav Vaintroub	32ce5301a9	Update libmariadb	6 years ago
Eugene Kosov	2855edf9ee	try to fix data races in DBUG init_settings.keywords and it's pointee are shared data. Protect them with mutex too.	6 years ago
Alexey Botchkov	bfa6db38cd	MENT-510 Failing test(s): perfschema.threads_insert_delayed. The thread_id of the INSERT DELAYED thread should not be set to 0.	6 years ago
Alexey Botchkov	0e403db2c8	MENT-237 Audit to show INSERT DELAYED for the executing user. Add notifications about the user and connection that actually did the DELAYED insert.	6 years ago
Vicențiu Ciorbaru	6218bf1b41	cracklib-runtime needs a comma after to parse properly	6 years ago
Olivier Bertrand	f0da39be7f	- Fix MDEV-13782 Problem with NOT LIKE queries. modified: storage/connect/ha_connect.cc modified: sql/item_cmpfunc.h - Fix MDEV-21084 Misusage of strncat could cause buffer overflow. modified: storage/connect/reldef.cpp modified: storage/connect/tabcmg.cpp modified: storage/connect/tabjson.cpp modified: storage/connect/tabrest.cpp modified: storage/connect/tabxml.cpp	6 years ago
Vicențiu Ciorbaru	427eedd012	MDEV-13288: Proper fix for cracklib-runtime The required dependencies should be added through the autobake script, to also cover distributions that do not support libcrack2.	6 years ago

1 2 3 4 5 ...

182965 Commits (e9259d50f0447374764d05df50719aca352989b3) All Branches Search

182965 Commits (e9259d50f0447374764d05df50719aca352989b3)

All Branches