mariadb

Tree: e498a1bf65

Author	SHA1	Message	Date
Sunny Bains	61c2b12da7	Fix bug# 18274 InnoDB auto_increment field reset on OPTIMIZE TABLE OPTIMIZE TABLE recreates the whole table. That is why the counter gets reset. Making the next autoinc column persistent is a separate issue from resetting the value after an OPTIMIZE TABLE. We already have a check for ALTER TABLE and CREATE INDEX to preserve the value on table recreate. We should be able to add an additional check for OPTIMIZE TABLE to preserve the next value. rb://519 Approved by Jimmy Yang.	15 years ago
Marko Mäkelä	4bb4eb800e	Fix a debug assertion failure in the Bug#57802 fix. thr_local_create(): Initialize local->slot_no to ULINT_UNDEFINED. thr_local_validate(): Allow local->slot_no to be ULINT_UNDEFINED.	15 years ago
Vasil Dimov	f9c2f7cd01	Remove unused parameter has_dict_mutex of dict_update_statistics_low() Also delete dict_update_statistics() and rename dict_update_statistics_low() to dict_update_statistics() because the only thing that distinguished those two functions was the removed parameter.	15 years ago
Marko Mäkelä	db054043ac	Bug#57802 Empty ASSERTION parameter passed to the HASH_SEARCH macro thr_local_validate(), i_s_locks_row_validate(): New validate functions, used in UNIV_DEBUG code for checking the state of internal memory structures.	15 years ago
Marko Mäkelä	298717f419	Declarations and code do not mix in C90, not even within UNIV_DEBUG.	15 years ago
Jimmy Yang	f2215a11ac	Fix Bug #48026 Log start and end of InnoDB buffer pool initialization to the error log rb://513 approved by Sunny Bains	15 years ago
Jimmy Yang	7ade161589	Port fix for Bug #48026 to 5.1 built-in and plugin: Log start and end of InnoDB buffer pool initialization to the error log	15 years ago
Marko Mäkelä	57cb45514d	row_ins_index_entry(): Note that only CREATE INDEX sets foreign=FALSE.	15 years ago
Sunny Bains	1f0f542a42	Add change log entry for bug#54538 fix.	15 years ago
Marko Mäkelä	dfe39f68a9	rw_lock_debug_print(): Output the thread ID in unsigned format.	15 years ago
Vasil Dimov	a491492f15	Add ChangeLog entry for Bug#53046	15 years ago
Marko Mäkelä	bfc7040355	Bug#57947 InnoDB diagnostics shows btr_block_get calls instead of real callers Improve the diagnostics of buffer pool accesses for B-trees, so that the file names and line numbers of the real calls are shown instead of the line of the buf_page_get() call in btr_block_get(). btr_page_get(): Replaced with a macro. btr_block_get_func(): Renamed from btr_block_get(). Add file, line. btr_block_get(): A macro that passes the __FILE__, __LINE__ to btr_block_get_func(). dict_truncate_index_tree(): Replace a btr_page_get() call with btr_block_get(), since we are only latching the page, not accessing it.	15 years ago
Marko Mäkelä	eab53d4e80	Non-functional change: Remove bogus const qualifiers and make some function comments more accurate.	15 years ago
Sunny Bains	c64f952699	Fix Bug #54538 - use of exclusive innodb dictionary lock limits performance. This patch doesn't get rid of the need to acquire the dict_sys->mutex but reduces the need to keep the mutex locked for the duration of the query to fsp_get_available_space_in_free_extents() from ha_innobase::info(). This is a port of revno:3548 from the builtin to the plugin. rb://501 Approved by Jimmy Yang and Marko Makela.	15 years ago
unknown	64e476e070	In this patch, existing tests innodb_bug54679.test and innodb_bug56632.test are removed and replaced by the comprehensive innodb-create-options.test. It uses the rules listed in the comments at the top of that test. This patch introduces these differences from previous behavior; 1) KEY_BLOCK_SIZE=0 is allowed by Innodb in both strict and non-strict mode with no errors or warnings. It was previously used by the server to set KEY_BLOCK_SIZE to undefined. (Bug#56628) 2) An explicit valid non-DEFAULT ROW_FORMAT always takes priority over a valid KEY_BLOCK_SIZE. (bug#56632) 3) Automatic use of COMPRESSED row format is only done if the ROW_FORMAT is DEFAULT or unspecified. 4) ROW_FORMAT=FIXED is prevented in strict mode. This patch also includes various formatting changes for consistency with InnoDB coding standards. Related Bugs Bug#54679: ALTER TABLE causes compressed row_format to revert to compact Bug#56628: ALTER TABLE .. KEY_BLOCK_SIZE=0 produces untrue warning or unnecessary error Bug#56632: ALTER TABLE implicitly changes ROW_FORMAT to COMPRESSED	15 years ago
Vasil Dimov	49cbbf6ea4	Fix Bug#53046 dict_update_statistics_low can still be run concurrently on same table Replace the array of mutexes that used to protect dict_index_t::stat_n_diff_key_vals[] with an array of rw locks that protects all the stats related members in dict_table_t and all of its indexes. Approved by: Jimmy (rb://503)	15 years ago
Vasil Dimov	addb147533	Increment InnoDB Plugin version to 1.0.14. InnoDB Plugin 1.0.13 has been released with MySQL 5.1.52.	15 years ago
Marko Mäkelä	004bb1b15e	Bug#57799 READ UNCOMMITTED access failure of off-page DYNAMIC or COMPRESSED columns again This is follow-up to Bug #54358. Not all occurrences of the bug were fixed. We need to check all calls to btr_copy_externally_stored_field_prefix_low() and do the right thing when the pointer to the off-page column is null (full of zero bytes). It turns out that only the call to btr_copy_externally_stored_field_prefix() in row_sel_sec_rec_is_for_blob() needs to be changed. For fetching complete off-page columns rather than prefixes, the function btr_rec_copy_externally_stored_field() already checks if the pointer is null (all-zero). Two of its callers (row_merge_copy_blobs() and row_sel_fetch_columns()) are never executed as READ COMMITTED and can rightfully assert that the fetch succeeded. The third caller, row_sel_store_mysql_rec(), already does the right thing. The calls in row_upd_ext_fetch() and trx_undo_page_fetch_ext() must expect that the off-page column exists. Update and rollback are locking operations, never READ UNCOMMITTED.	15 years ago
Marko Mäkelä	6c802b3c43	White-space corrections in the InnoDB Plugin ChangeLog	15 years ago
Calvin Sun	460ad14e04	Bug#52062: Compiler warning in os0file.c on windows 64-bit On Windows, the parameter for number of bytes passed into WriteFile() and ReadFile() is DWORD. Casting is needed to silence the warning on 64-bit Windows. Also, adding several asserts to ensure the variable for number of bytes is no more than 32 bits, even on 64-bit Windows. This is for InnoDB Plugin. rb://415 Approved by: Inaam	15 years ago
Inaam Rana	26738c280f	Bug #57611 ibdata file and continuous growing undo logs rb://498 Fix handling of update_undo_logs at trx commit. Previously, when rseg->update_undo_list grows beyond 500 the update_undo_logs were marked with state TRX_UNDO_TO_FREE which should have been TRX_UNDO_TO_PURGE. Approved by: Sunny Bains	15 years ago
Jimmy Yang	112684b0ba	Fix bug #57700 Latching order violation in row_truncate_table_for_mysql(). Approved by Sunny Bains	15 years ago
Jimmy Yang	ed2e88e66c	Fix bug #57700 Latching order violation in row_truncate_table_for_mysql(). Approved by Sunny Bains	15 years ago
Jimmy Yang	e8f228e7eb	Fix Bug #57616 Sig 11 in dict_load_table() when failed to load index or foreign key Approved by Sunny Bains	15 years ago
Jimmy Yang	1e09ea9549	Fix bug #57616 Sig 11 in dict_load_table() when failed to load index or foreign key Fix approved by Sunny Bains	15 years ago
Vasil Dimov	cb01050661	Fix Bug#53916 storage/innodb_plugin does not compile on NetBSD/sparc64 Just check for all the functions that we are going to use, not a subset of them. Reviewed by: Davi (via IRC)	15 years ago
Davi Arnaut	be170c213f	Bug#45288: pb2 returns a lot of compilation warnings on linux Tag unused arguments. Approved by: Marko (via IRC)	15 years ago
Marko Mäkelä	c38071ec18	Bug #56680 wrong InnoDB results from a case-insensitive covering index row_search_for_mysql(): When a secondary index record might not be visible in the current transaction's read view and we consult the clustered index and optionally some undo log records, return the relevant columns of the clustered index record to MySQL instead of the secondary index record. ibuf_insert_to_index_page_low(): New function, refactored from ibuf_insert_to_index_page(). ibuf_insert_to_index_page(): When we are inserting a record in place of a delete-marked record and some fields of the record differ, update that record just like row_ins_sec_index_entry_by_modify() would do. btr_cur_update_alloc_zip(): Make the function public. mysql_row_templ_t: Add clust_rec_field_no. row_sel_store_mysql_rec(), row_sel_push_cache_row_for_mysql(): Add the flag rec_clust, for returning data at clust_rec_field_no instead of rec_field_no. Resurrect the debug assertion that the record not be marked for deletion. (Bug #55626) [UNIV_DEBUG \|\| UNIV_IBUF_DEBUG] ibuf_debug, buf_page_get_gen(), buf_flush_page_try(): Implement innodb_change_buffering_debug=1 for evicting pages from the buffer pool, so that change buffering will be attempted more frequently.	15 years ago
Vasil Dimov	78804bc8bd	Fix Bug#57252 disabling innobase_stats_on_metadata disables ANALYZE This is a merge from 5.1/builtin to 5.1/plugin of: -------------- revision-id: vasil.dimov@oracle.com-20101018104811-nwqhg9vav17kl5s1 committer: Vasil Dimov <vasil.dimov@oracle.com> timestamp: Mon 2010-10-18 13:48:11 +0300 message: Fix Bug#57252 disabling innobase_stats_on_metadata disables ANALYZE In order to fix this bug we need to distinguish whether ha_innobase::info() has been called from ::analyze() or not. Rename ::info() to ::info_low() and add a boolean parameter that tells whether the call is from ::analyze() or not. Create a new simple ::info() that just calls ::info_low(false => not called from analyze). From ::analyze() instead of ::info() call ::info_low(true => called from analyze). Approved by: Jimmy (rb://487) --------------	15 years ago
Vasil Dimov	ef858cc463	Remove leftover conflict marker It was added in jimmy.yang@oracle.com-20100902004302-m5ax9qo0ne2msdfx	15 years ago
Vasil Dimov	74b42d8daa	Add InnoDB Plugin ChangeLog entry for Bug#56143	15 years ago
Vasil Dimov	3ce802d5d8	Fix the formatting in storage/innodb_plugin/ChangeLog	15 years ago
Jimmy Yang	27c80dd424	Remove an unused counter variable in io_handler_thread().	15 years ago
Vasil Dimov	f918ad4381	Fix Bug#56143 too many foreign keys causes output of show create table to become invalid This is a port of the following changeset from 5.1/storage/innobase to 5.1/storage/innodb_plugin: ------------------------------------------------------------ revno: 3626 revision-id: vasil.dimov@oracle.com-20101013171859-gi9n558yj89x9v3w parent: klewis@mysql.com-20101012175933-ce9kkgl0z8oeqffa committer: Vasil Dimov <vasil.dimov@oracle.com> branch nick: mysql-5.1-innodb timestamp: Wed 2010-10-13 20:18:59 +0300 message: Fix Bug#56143 too many foreign keys causes output of show create table to become invalid Just remove the check whether the file is "too big". A similar code exists in ha_innobase::update_table_comment() but that method does not seem to be used. Also use a CREATE statement with all the FKs instead of ALTERing the table 550 times because it is faster.	15 years ago
Jimmy Yang	d5055f4e8a	Fix Bug #57397 io_handler_thread() will never cleanup rb://483 approved by Inaam	15 years ago
unknown	891bbf224a	Bug#56632 - The warning code related to KEY_BLOCK_SIZE and ROW_FORMAT when innodb_strict_mode=OFF is improved in order to take into account whether the KEY_BLOCK_SIZE is specified on the current ALTER statement or the previous CREATE statement. The testcase shows the expected results of 12 different combinations of these settings.	15 years ago
unknown	498ee6bd19	Fix bug #57345	15 years ago
Jimmy Yang	820e1bc6f4	A more complete fix for bug #57345 btr_pcur_store_position abort for load with concurrent lock/unlock tables Approved by Marko	15 years ago
Marko Mäkelä	a8da1a3a58	Bug #56947 InnoDB leaks memory when failing to create a table row_create_table_for_mysql(): When the table creation fails, free the dict_table_t object.	15 years ago
Sunny Bains	7ee98d4fea	Bug# 56982 Assertion Failure from ha_innobase::innobase_peek_autoinc() when auto_inc > 0 Print an error message to stderr an get rid of the assertion. Approved by: Jimmy Yang (over IM)	15 years ago
Martin Hansson	30f57b3323	Bug#56423: Different count with SELECT and CREATE SELECT queries This is a regression from the fix for bug no 38999. A storage engine capable of reading only a subset of a table's columns updates corresponding bits in the read buffer to signal that it has read NULL values for the corresponding columns. It cannot, and should not, update any other bits. Bug no 38999 occurred because the implementation of UPDATE statements compare the NULL bits using memcmp, inadvertently comparing bits that were never requested from the storage engine. The regression was caused by the storage engine trying to alleviate the situation by writing to all NULL bits, even those that it had no knowledge of. This has devastating effects for the index merge algorithm, which relies on all NULL bits, except those explicitly requested, being left unchanged. The fix reverts the fix for bug no 38999 in both InnoDB and InnoDB plugin and changes the server's method of comparing records. For engines that always read entire rows, we proceed as usual. For engines capable of reading only select columns, the record buffers are now compared on a column by column basis. An assertion was also added so that non comparable buffers are never read. Some relevant copy-pasted code was also consolidated in a new function.	15 years ago
Jimmy Yang	cf2c8701b4	Fix Bug #57255 Cascade Delete results in "Got error -1 from storage engine". rb://477 approved by Marko	15 years ago
Marko Mäkelä	190ebda206	Bug#56716 InnoDB locks a record gap without locking the table row_search_for_mysql(): Acquire an intention lock on the table before locking the first record gap.	15 years ago
Vasil Dimov	eaaea8eb7d	Fix Bug#56340 innodb updates index stats too frequently after non-index updates This is a simple optimization issue. All stats are related to only indexed columns, index size or number of rows in the whole table. UPDATEs that touch only non-indexed columns cannot affect stats and we can avoid calling the function row_update_statistics_if_needed() which may result in unnecessary I/O. Approved by: Marko (rb://466)	15 years ago
Vasil Dimov	51cdf59546	Fix a potential bug when using __sync_lock_test_and_set() TYPE __sync_lock_test_and_set (TYPE *ptr, TYPE value, ...) it is not documented what happens if the two arguments are of different type like it was before: the first one was lock_word_t (byte) and the second one was 1 or 0 (int). Approved by: Marko (via IRC)	15 years ago
Vasil Dimov	3de0aa061b	Increment InnoDB Plugin version to 1.0.13. InnoDB Plugin 1.0.12 has been released with MySQL 5.1.51.	15 years ago
Vasil Dimov	9f3660c6e5	Silence a GCC warning about reaching the end of non-void func Spotted by: Marko	15 years ago
Vasil Dimov	844a8098aa	Fix typo, should be UNIV_SYNC_DEBUG.	15 years ago
Vasil Dimov	da98776bfb	(partially) Fix Bug#55227 Fix compiler warnings in innodb with gcc 4.6 Fix compiler warning: trx/trx0undo.c: In function 'trx_undo_truncate_end': trx/trx0undo.c:1069:14: error: variable 'rseg' set but not used [-Werror=unused-but-set-variable]	15 years ago
Vasil Dimov	e4996035b2	(partially) Fix Bug#55227 Fix compiler warnings in innodb with gcc 4.6 Fix compiler warning: trx/trx0undo.c: In function 'trx_undo_set_state_at_prepare': trx/trx0undo.c:1871:16: error: variable 'page_hdr' set but not used [-Werror=unused-but-set-variable]	15 years ago

1 2 3 4 5 ...

534 Commits (e498a1bf65101878f51d0b2ca3eb0d05a8d3d01c)