mariadb

Tree: de2b5795f4

Author	SHA1	Message	Date
Marko Mäkelä	cce33787c3	MDEV-16264 fixup: Add missing 'static'	4 years ago
Marko Mäkelä	dc58303cf8	MDEV-26372 enforce-storage-engine=InnoDB has no usability as an option to mysqld-install-db Creation of tables by the three names mysql.user, mysql.host, mysql.db was being blocked in the function row_mysql_is_system_table(). Since commit `4abb8216a0` (MDEV-17658), mysql.user is a view, not a table. Since commit `ead9a34a3e` (MDEV-15851), mysql.host is not being created at all. Let us remove the special handling of table names in InnoDB, and allow mysql.db to be created in InnoDB. The special handling was originally added in commit `e84ef2b747` without any explanation. Reviewed by: Sergei Golubchik	4 years ago
Thirunarayanan Balathandayuthapani	255313048c	MDEV-26273 InnoDB FTS DDL fails when innodb_force_recovery is set to 2 InnoDB DDL fails when it tries to sync the table when innodb_force_recovery is set to 2. Problem is that fts_optimize_wq is not initialized when there are no background threads. fts_sync_during_ddl() should check whether fts_optimize_wq is initialized.	4 years ago
Thirunarayanan Balathandayuthapani	89445b64fe	MDEV-26131 SEGV in ha_innobase::discard_or_import_tablespace Import operation without .cfg file fails when there is mismatch of index between metadata table and .ibd file. Moreover, MDEV-19022 shows that InnoDB can end up with index tree where non-leaf page has only one child page. So it is unsafe to find the secondary index root page. This patch does the following when importing the table without .cfg file: 1) If the metadata contains more than one index then InnoDB stops the import operation and report the user to drop all secondary indexes before doing import operation. 2) When the metadata contain only clustered index then InnoDB finds the index id by reading page 0 & page 3 instead of traversing the whole tablespace.	4 years ago
Marko Mäkelä	4cd063b9e4	MDEV-26376 pars_info_bind_id() unnecessarily copies strings pars_info_bind_id(): Remove the parameter copy_name. It was always being passed as constant TRUE or true. It turns out that copying the string is completely unnecessary. In all calls except the one in fts_get_select_columns_str() and fts_doc_fetch_by_doc_id(), the parameter is being passed as a compile-time constant, and therefore the pointer cannot become stale. In that special call, the string that is being passed is allocated from the same memory heap that pars_info_bind_id() would have been using. pars_info_add_id(): Remove (unused declaration).	4 years ago
Daniel Black	3d16e0e16c	deb: columnstore not 32bit (fix) Fix for previous commit, shell logic for repeat configure stages corrected to use subshell.	4 years ago
Julius Goryavsky	50428b3995	MDEV-26101: Galera WSREP SST broken on 10.6 under FreeBSD This commit fixes a call to the sockstat utility for FreeBSD, where this utility requires an extra "-s" parameter to display the connection status and prints one extra column.	4 years ago
Julius Goryavsky	094e039166	MDEV-26340: rsync uses `--whole-file` only in wan mode This commit fixes a mistake where the --whole-file option is used by rsync SST in WAN mode instead of LAN.	4 years ago
Julius Goryavsky	d1a948cfaa	MDEV-26211: Cluster joiner node is failed to start when using TLS This commit adds support for reading new SSL configuration options (ssl-ca, ssl-cert and ssl-key) if the [sst] section with old options (tca, tcert and tkey) is missing in the config file, even if not specified authentication mode via the ssl-mode option. Before this change, new parameters were read only if the ssl-mode option was present in the configuration file and it was not equal to the 'DISABLED' value. Also added diagnostics (information level) which warns the user that due to the presence of the tca, tcert and/or tkey parameters in the [sst] section, new SSL configuration options will be ignored (if their values do not match the old ones).	4 years ago
Daniel Black	3b29315fde	mysql_client_test: test_bug40365 gcc-11.2.1 indentation complaint Observed in 10.4 however same code in 10.2 mariadb-server-10.4/tests/mysql_client_test.c:18209:5: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation] 18209 \| if (!opt_silent) \| ^~ In file included from mariadb-server-10.4/tests/mysql_client_test.c:38: mariadb-server-10.4/tests/mysql_client_fw.c:133:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’ 133 \| ((void) ((expr) ? 0 : (die(__FILE__, __LINE__, #expr), 0))) \| ^ mariadb-server-10.4/tests/mysql_client_test.c:18212:7: note: in expansion of macro ‘DIE_UNLESS’ 18212 \| DIE_UNLESS(tm[i].year == 0); \| ^~~~~~~~~~ $ /usr/bin/cc --version cc (GCC) 11.2.1 20210728 (Red Hat 11.2.1-1)	4 years ago
Brandon Nesterenko	46c3e7e353	MDEV-20215: binlog.show_concurrent_rotate failed in buildbot with wrong result Problem: ======= There are two issues that are addressed in this patch: 1) SHOW BINARY LOGS uses caching to store the binary logs that exist in the log directory; however, if new events are written to the logs, the caching strategy is unaware. This is okay for users, as it is okay for SHOW to return slightly old data. The test, however, can result in inconsistent data. It runs two connections concurrently, where one shows the logs, and the other adds a new file. The output of SHOW BINARY LOGS then depends on when the cache is built, with respect to the time that the second connection rotates the logs. 2) There is a race condition between RESET MASTER and SHOW BINARY LOGS. More specifically, where they both need the binary log lock to begin, SHOW BINARY LOGS only needs the lock to build its cache. If RESET MASTER is issued after SHOW BINARY LOGS has built its cache and before it has returned the results, the presented data may be incorrect. Solution: ======== 1) As it is okay for users to see stale data, to make the test consistent, use DEBUG_SYNC to force the race condition (problem 2) to make SHOW BINARY LOGS build a cache before RESET MASTER is called. Then, use additional logic from the next part of the solution to rebuild the cache. 2) Use an Atomic_counter to keep track of the number of times RESET MASTER has been called. If the value of the counter changes after building the cache, the cache should be rebuilt and the analysis should be restarted. Reviewed By: ============ Andrei Elkin: <andrei.elkin@mariadb.com>	4 years ago
Daniel Black	0268b87122	deb: columnstore not 32bit Columnstore badly failed on 32bit. The way Debian triggers somehow doesn't detect the amd64 in the architecture of columnstore so we explicitly disable it to prevent failures on x86_32. The architecture from the control file is sufficient to not build of arm64 and other unsupported achitectures so we don't need to disable columnstore by default. The logic around not building columnstore on Travis/Gitlab ci can be preserved with a autobake-deb.sh restructure.	4 years ago
Daniel Black	30d33d85cb	deb: s390x no WolfSSL workaround as upstream fixed in 4.6.0 https://github.com/wolfSSL/wolfssl/issues/2828 lists 4.6.0 a as the fixed version as we currently have 4.8.0. Since the time of the above issue, Debian has allowed OpenSSL linking.	4 years ago
Vladislav Vaintroub	070183cfc0	MDEV-26325 Shutdown hangs whenever named pipes were used for connections. This was a regression introduced in MDEV-18353, where to CONNECT objects were incorrectly counted for named pipes.	4 years ago
Alexey Botchkov	38b79d7295	MENT-1019. Audit-plugin related fixes.	4 years ago
Vladislav Vaintroub	582cf12f94	mariabackup - fix string format in error message	4 years ago
Alexey Botchkov	10db7fcfa6	MENT-977 log priv host / priv user. Add server functions to provide necessary data.	4 years ago
Vladislav Vaintroub	f725020ff7	Fix cmake warning caused by `751ebe44fd` CMake Warning (dev) at cmake/plugin.cmake:288 (GET_TARGET_PROPERTY): Policy CMP0045 is not set: Error on non-existent target... Also, fix condition argument in ADD_FEATURE_INFO. It is not a string but boolean	4 years ago
Jan Lindström	74cb160992	Fix test failure on galera_as_slave_replay by adding wait_conditions	4 years ago
Aleksey Midenkov	160d97a4aa	MDEV-18734 ASAN heap-use-after-free upon sorting by blob column from partitioned table ha_partition stores records in array of m_ordered_rec_buffer and uses it for prio queue in ordered index scan. When the records are restored from the array the blob buffers may be already freed or rewritten. The solution is to take temporary ownership of cached blob buffers via String::swap(). When the record is restored from m_ordered_rec_buffer the ownership is returned to table fields. Cleanups: init_record_priority_queue(): removed needless !m_ordered_rec_buffer check as there is same assertion few lines before. dbug_print_row() for arbitrary row pointer	4 years ago
Daniel Bartholomew	20a9f0b511	bump the VERSION	4 years ago
Daniel Bartholomew	527be044d5	bump the VERSION	4 years ago
Daniel Bartholomew	d9526ae608	bump the VERSION	4 years ago
Daniel Bartholomew	b8deb02859	bump the VERSION	4 years ago
Yongxin Xu	fa6eaead21	MDEV-24523 Execution of JSON_REPLACE failed on Spider JSON_REPLACE() function executed with an error on Spider SE. This patch fixes the problem, and it also fixes the MDEV-24541. The problem is that Item_func_json_insert::func_name() returns the wrong function name "json_update". The Spider SE reconstructs a query based on the return value in some cases. Thus, if the return value is wrong, the Spider SE may generate a wrong query.	4 years ago
Sergei Golubchik	175c9fe1d5	cleanup: specifying plugin dependencies in CMakeLists.txt 1. rename option DEPENDENCIES in MYSQL_ADD_PLUGIN() to DEPENDS to be consistent with other cmake commands and macros 2. use this DEPENDS option in plugins 3. add dependencies to the plugin embedded target too 4. plugins don't need to add GenError dependency explicitly, all plugins depend on it automatically	4 years ago
Oleksandr Byelkin	b5569b6240	Update columnstore	4 years ago
Oleksandr Byelkin	42bf65177a	update PCRE2	4 years ago
Oleksandr Byelkin	850b2ba15d	Merge branch '10.4' into 10.5	4 years ago
Oleksandr Byelkin	4902b0fdc9	Merge branch '10.3' into 10.4	4 years ago
Marko Mäkelä	89cc633853	MDEV-13564 fixup: Remove unused function fts_check_corrupt() The call to the function fts_check_corrupt() was removed in commit `09af00cbde` already.	4 years ago
Oleksandr Byelkin	7f264997dd	Merge branch '10.2' into 10.3	4 years ago
Nikita Malyavin	b549af6913	MDEV-26220 Server crashes with indexed by prefix virtual column Server crashes in Field::register_field_in_read_map upon select from partitioned table with indexed by prefix virtual column. After several read-mark fixes a problem has surfaced: Since KEY (c(10),a) uses only a prefix of c, a new field is created, duplicated from table->field[3], with a new length. However, vcol_inco->expr is not copied. Therefore, (*key_info)->key_part[i].field->vcol_info->expr was left NULL in ha_partition::index_init(). Solution: copy vcol_info from table field when it's set up.	4 years ago
Oleksandr Byelkin	8b6c8a6ce9	Revert "MDEV-26220 Server crashes with indexed by prefix virtual column" This reverts commit `9b8e207ce0`.	4 years ago
Sergei Golubchik	ec8882b9dd	suppress galera error "Failed to report last committed" according to MDEV-17550 it's informational, not fatal. "last committed" is part of the certification index purge process. depending on what tests and in what order are run it can be triggered at unspecified times during the testing. If the test is happen to shut down the server at this very time, the log will have: [Warning] WSREP: Failed to report last committed XXXYYYZZZ, -77 (File descriptor in bad state)	4 years ago
Oleksandr Byelkin	ae6bdc6769	Merge branch '10.4' into 10.5	4 years ago
Oleksandr Byelkin	7841a7eb09	Merge branch '10.3' into 10.4	4 years ago
Sergei Golubchik	2cdf8a9327	MDEV-23752 SHOW EXPLAIN FOR thd waits for sleep fix main.processlist_notembedded test * before EXPLAINing `select sleep` wait for select to start (fixes "Target is not running an EXPLAINable command") * after killing sleep, wait for it to die (fixes test failures on --repeat when old sleep shows on a test rerun) * unify with 10.3, copy minor changes from there (`--echo End of 5.5` vs `--echo # End of 5.5`, etc)	4 years ago
Oleksandr Byelkin	1423cf5e3d	fix MDEV-16026 MDEV-16481 embedded server results and rests	4 years ago
Oleksandr Byelkin	83d7e4faf6	Merge branch '10.2' into 10.3	4 years ago
Nikita Malyavin	22709897b0	MDEV-20154 Assertion `len <= col->len \| ...` failed in row_merge_buf_add len was containing garbage, since vctempl->mysql_col_offset was containing old value while calling row_mysql_store_col_in_innobase_format from innobase_get_computed_value(). It was not updated after the first ALTER TABLE call, because it's INPLACE logic considered there's nothing to update, and exited immediately from ha_innobase::inplace_alter_table(). However, vcol metadata needs an update, since vcols structure is changed in mysql record. The regression was introduced by `12614af1fe`. There, refcount==1 condition was removed, which turned out to be crucial, though racy. The idea was to update vc_templ after each (sequencing) ALTER TABLE. We should do the same another way, and there may be a plenty of solutions, but the simplest one is to add a following condition: if vcol structure is changed, drop vc_templ; it will be recreated on next ha_innobase::open() call. in prepare_inplace_alter_table. It is safe, since innodb inplace changes require at least HA_ALTER_INPLACE_SHARED_LOCK_AFTER_PREPARE, which guarantee MDL_EXCLUSIVE on this stage. alter_templ_needs_rebuild() also has to track the columns not indexed, to keep vc_templ correct. Note that vc_templ is always kept constructed and available after ha_innobase::open() call, even on INSERT, though no virtual columns are evaluated during that statement inside innodb. In the test case suplied, it will be recreated on the second ALTER TABLE.	4 years ago
Marko Mäkelä	0e8981ef93	Cleanup: Remove redundant conditions ha_innobase::prepare_inplace_alter_table(): Remove always-true conditions. Near the start of the function, we would already have returned if no ALTER TABLE operation flags were set that would require special action from InnoDB. It turns out that the conditions were redundant already when they were introduced in mysql/mysql-server@241387a2b6b61fb8a4f78dc4ad0aaa289400c694 and in commit `068c61978e`. Thanks to Nikita Malyavin for noticing this.	4 years ago
Sergei Golubchik	6152ab7b42	MDEV-24511 null field is created with CREATE..SELECT When creating fields for UNION results, Field_null is not allowed. Should create binary(0) instead.	4 years ago
Alexander Barkov	c86f813afe	MDEV-9234 Add Type_handler::union_element_finalize()	7 years ago
Nikita Malyavin	9d5967f74b	fixup `0bd9f755b` MDEV-26062 Pass char* to WSREP_LOG and others, instead of non-POD objects	4 years ago
Sergei Golubchik	a49f5525bb	MDEV-26226 Change Maturity of plugins inet6 and s3 to stable from gamma	4 years ago
Sergei Golubchik	07df0c948d	MDEV-25716 Building failure in S3 engine on MacOS update libmarias3 to get the fix	4 years ago
Vladislav Vaintroub	77992bc710	MDEV-26092 Remove things we do not use in wolfssl Add a couple of NO_XXX prprocessor constants to wolfssl build. Looked into cmake defaults, those are set there too. Some of these are (supposedly) weak ciphers, and some just fallen out from wide use.	4 years ago
Yongxin Xu	43099af95b	MDEV-24020: Trim with remove_str Fails on Spider This patch fixes the bug that TRIM(BOTH ... FROM $str), TRIM(LEADING ... FROM $str), and TRIM(TRAILING ... FROM $str) failed with errors when executing on Spider.	4 years ago
mkaruza	093227c05e	MDEV-25410 Assertion `state_ == s_exec' failed - mysqld got signal 6 Victim threads which are in currently in process of aborting or already aborted should be skipped for another kill process. Reviewed-by: Jan Lindström <jan.lindstrom@mariadb.com>	4 years ago

... 2 3 4 5 6 ...

192920 Commits (de2b5795f45a4e35a75d640bdc3b9f3f0e919bf6) All Branches Search

192920 Commits (de2b5795f45a4e35a75d640bdc3b9f3f0e919bf6)

All Branches