mariadb

Tree: da9201dd5b

Author	SHA1	Message	Date
Marko Mäkelä	da9201dd5b	Merge 10.2 into 10.3	6 years ago
Nikita Malyavin	aabd1c8fcb	MDEV-16490 fix versioning.partition failure	6 years ago
Vladislav Vaintroub	879c9ddce7	MDEV-20542 Windows enable/d2OptimizeHugeFunctions	6 years ago
Nikita Malyavin	f6a7730c45	MDEV-16490: It's possible to make a system versioned table without any versioning field * do not allow versioned table to be without versioned (non-system) fields * prohibit changing field versioning, when removing table versioning * handle CREATE...SELECT as well	7 years ago
Marko Mäkelä	43a6e81ccb	MDEV-19514 preparation: Remove innodb_change_buffering_debug=2 The setting innodb_change_buffering_debug=2 was supposed to inject a crash during change buffer merge. There is no public test for that functionality, and even if there were, it would be better to use DEBUG_SYNC to halt the thread that does change buffer merge, force a redo log flush from another thread, and finally kill the server externally.	6 years ago
Vladislav Vaintroub	2336e0b394	MDEV-20206 : Crash inside timer_callback()[threadpool_win.cc:419] The most likely cause of the crash is that a timer fired, after it was closed. MSDN documents such a possibility, in the documentation for CloseThreadpoolTimer() function, and recommends disabling the timer before calling WaitForThreadpoolTimerCallbacks()/CloseThreadpoolTimer(). The fix follows this recommendation. Note, that 5.5-10.1 disabled the timer before close, but this code was lost in threadpool refactoring in 10.2	6 years ago
Vladislav Vaintroub	a895c68c58	On Windows, treat linker warnings as errors, if MYSQL_MAINTAINER_MODE is ERR	6 years ago
Vladislav Vaintroub	d251b76884	Fix warning when compiling with OpenSSL.	6 years ago
Vladislav Vaintroub	7e7b6ec4d6	Fix connect RESTSDK support. Remove debug output, remove overriding of the Windows C runtime flags(linker warning) do not add code that depends on restsdk if library is not going to be linked. freaking Connect	6 years ago
Vladislav Vaintroub	803bb5cdf8	Windows, cmake : Fix occasional link error when switching between debug to optimized compilation For Visual Studio generator, use a per-config .def/.lib files with symbols exported from mysqld.exe Functions exported from mysqld.exe may differ between debug/optimized compilation, e.g dbug functions are missing in release config.	6 years ago
Jan Lindström	0fd5b11eb0	MDEV-20511: Galera replication of events is not consistent After SST from master node (the one where event is ENABLED) - you will end up with the event enabled on two nodes, hence it's now being executed twice. It can be solved by comparing event's originator with server_id. if not equal, then change its status to 'SLAVESIDE_DISABLED' Changes to be committed: new file: mysql-test/suite/galera/r/galera_events2.result new file: mysql-test/suite/galera/t/galera_events2.test modified: sql/events.cc	6 years ago
Jan Lindström	efbfded563	Move MW-328B to big test to avoid test timeout.	6 years ago
Jan Lindström	caa7bb62f6	MDEV-20485: Galera test failure on galera.galera_var_node_address Test changes only.	6 years ago
Jan Lindström	b8b4b6594e	MDEV-19926: Galera SST tests fail Enable after SST script changes.	6 years ago
Marko Mäkelä	7591a24fa6	MDEV-20531: innodb.temporary_table_optimisation fails Try to use more deterministic floating-point operations. Apparently, 2.2 > 2.2 wrongly holds on many platforms, but not ppc64le on the compiler used on Red Had Enterprise Linux 8. The reason could be an infinite binary presentation: 2.2 = 0b10.001100110011… With t1_f = 2.5 = 0b10.1, t1_f > 2.5 would no longer hold on AMD64. Let us replace the 2.2 with 2.5 and compare t1_f >= 2.5 in order to get more consistent results across all platforms.	6 years ago
Elena Stepanova	604f80e77c	List of unstable tests for 10.3.18 release	6 years ago
Elena Stepanova	f9f968557f	List of unstable tests for 10.2.27 release	6 years ago
Alexander Barkov	8750df43ab	MDEV-20517 Assertion `!is_expensive()' failed in Item::value_depends_on_sql_mode_const_item	6 years ago
Sergei Golubchik	f80e02e043	Merge branch '10.2' into 10.3	6 years ago
Sergei Golubchik	39e5b76ef1	use a shorter name for sources in debuginfo rpms have the same path as in source rpms, don't build them differently	6 years ago
Sergei Golubchik	5a9e2b77d4	Part3: MDEV-18156 Assertion `0' failed or `btr_validate_index(index, 0, false)' in row_upd_sec_index_entry or error code 126: Index is corrupted upon DELETE with PAD_CHAR_TO_FULL_LENGTH Don't break compatibility in GA releases. Warn the user, but don't refuse to create a table until 10.5	6 years ago
Sergei Golubchik	2480f6b7ff	don't run RocksDB suites by default	6 years ago
Marko Mäkelä	292e2649d4	MDEV-12121: Avoid unused variable With cmake -DWITH_INNODB_AHI=OFF -DCMAKE_BUILD_TYPE=RelWithDebInfo the variable 'i' in fseg_free_extent() was declared but not used.	6 years ago
Vlad Lesin	16e9943d89	MDEV-20421: big_innodb_log reliably fails on buildbot Windows The test fails because it reuses mysqltest perl code to copy directory tree, and this code contains Windows-specific piece which outputs some diagnostic information. The patch introduces new parameter for that Windows-specific perl code to have the ability to suppress diagnostic output on the corresponding mysqltest perl module initialization.	6 years ago
Sergei Petrunia	41e351f608	MDEV-20490: rocksdb.ttl_primary_read_filtering fails in BB Make the test stable: after DROP TABLE, make sure the compaction is run and finishes. If we don't do this, the post-drop compaction may run during the next testcase. It will cause a record from the next testcase to be compacted away when the test logic doesn't expect it and the test will fail	6 years ago
Marko Mäkelä	2842c36985	MDEV-20425: Enable a test for debug builds	6 years ago
Marko Mäkelä	67e2252ba1	Simplify trx_state_eq()	6 years ago
Marko Mäkelä	2c9e75ccfe	MDEV-15326 after-merge fixes trx_t::is_recovered: Revert most of the changes that were made by the merge of MDEV-15326 from 10.2. The trx_sys.rw_trx_hash and the recovery of transactions at startup is quite different in 10.3. trx_free_at_shutdown(): Avoid excessive mutex protection. Reading fields that can only be modified by the current thread (owning the transaction) can be done outside mutex. trx_t::commit_state(): Restore a tighter assertion. trx_rollback_recovered(): Clarify why there is no potential race condition with other transactions. lock_trx_release_locks(): Merge with trx_t::release_locks(), and avoid holding lock_sys.mutex unnecessarily long. rw_trx_hash_t::find(): Remove redundant code, and avoid starving the committer by checking trx_t::state before trx_t::reference().	6 years ago
Marko Mäkelä	537f8594a6	Merge 10.2 into 10.3	6 years ago
Sergei Golubchik	f605ce08b5	more tests for DEFAULT and DEFAULT(column) in INSERT this is not ideal and needs to be fixed eventually, but it's consistent over all forms of INSERT.	6 years ago
Sergei Golubchik	8dca4cf53f	MDEV-20403 Assertion `0' or Assertion `btr_validate_index(index, 0)' failed in row_upd_sec_index_entry or error code 126: Index is corrupted upon UPDATE with TIMESTAMP..ON UPDATE remove a special treatment of a bare DEFAULT keyword that made it behave inconsistently and differently from DEFAULT(column). Now all forms of the explicit assignment of a default column value behave identically, and all count as an explicitly assigned value (for the purpose of ON UPDATE NOW). followup for `c7c481f4d9`	6 years ago
Sachin	53ec9047c9	MDEV-20137 rpl.mdev_17588 fails in buildbot with "Table doesn't exist" Fix the test case.	6 years ago
Sergei Golubchik	647d5b2430	MDEV-20079 When setting back the system time while mysqld is running, NOW() and UNIX_TIMESTAMP() results get stuck typo. system_time.start wasn't updated when system_time.sec and system_time.sec_part were.	6 years ago
Sergei Golubchik	08b01ace8a	MDEV-16871 in_predicate_conversion_threshold cannot be set in my.cnf	6 years ago
Monty	01e455dbb8	Fix of query cache bug in Aria MDEV-5817 query cache bug (returning inconsistent/old result set) with aria table parallel inserts, row format = page The problem is that for transactional aria tables (row_type=PAGE and transactional=1), maria_lock_database() didn't flush the state or the query cache. Not flushing the state is correct for transactional tables as this is done by checkpoint, but not flushing the query cache was wrong and could cause concurrent SELECT queries to not be deleted from the cache. Fixed by introducing a flush of the query cache as part of commit, if the table has changed. t for transactional aria tables (row_type=PAGE and transactional=1), maria_lock_table() didn't flush their state or the query cache.	6 years ago
Marko Mäkelä	dae1b3b04c	MDEV-15326: Backport trx_t::is_referenced() Backport the applicable part of Sergey Vojtovich's commit `0ca2ea1a65` from MariaDB Server 10.3. trx reference counter was updated under mutex and read without any protection. This is both slow and unsafe. Use atomic operations for reference counter accesses.	6 years ago
Marko Mäkelä	b07beff894	MDEV-15326: InnoDB: Failing assertion: !other_lock MySQL 5.7.9 (and MariaDB 10.2.2) introduced a race condition between InnoDB transaction commit and the conversion of implicit locks into explicit ones. The assertion failure can be triggered with a test that runs 3 concurrent single-statement transactions in a loop on a simple table: CREATE TABLE t (a INT PRIMARY KEY) ENGINE=InnoDB; thread1: INSERT INTO t SET a=1; thread2: DELETE FROM t; thread3: SELECT * FROM t FOR UPDATE; -- or DELETE FROM t; The failure scenarios are like the following: (1) The INSERT statement is being committed, waiting for lock_sys->mutex. (2) At the time of the failure, both the DELETE and SELECT transactions are active but have not logged any changes yet. (3) The transaction where the !other_lock assertion fails started lock_rec_convert_impl_to_expl(). (4) After this point, the commit of the INSERT removed the transaction from trx_sys->rw_trx_set, in trx_erase_lists(). (5) The other transaction consulted trx_sys->rw_trx_set and determined that there is no implicit lock. Hence, it grabbed the lock. (6) The !other_lock assertion fails in lock_rec_add_to_queue() for the lock_rec_convert_impl_to_expl(), because the lock was 'stolen'. This assertion failure looks genuine, because the INSERT transaction is still active (trx->state=TRX_STATE_ACTIVE). The problematic step (4) was introduced in mysql/mysql-server@e27e0e0bb75b4d35e87059816f1cc370c09890ad which fixed something related to MVCC (covered by the test innodb.innodb-read-view). Basically, it reintroduced an error that had been mentioned in an earlier commit mysql/mysql-server@a17be6963fc0d9210fa0642d3985b7219cdaf0c5: "The active transaction was removed from trx_sys->rw_trx_set prematurely." Our fix goes along the following lines: (a) Implicit locks will released by assigning trx->state=TRX_STATE_COMMITTED_IN_MEMORY as the first step. This transition will no longer be protected by lock_sys_t::mutex, only by trx->mutex. This idea is by Sergey Vojtovich. (b) We detach the transaction from trx_sys before starting to release explicit locks. (c) All callers of trx_rw_is_active() and trx_rw_is_active_low() must recheck trx->state after acquiring trx->mutex. (d) Before releasing any explicit locks, we will ensure that any activity by other threads to convert implicit locks into explicit will have ceased, by checking !trx_is_referenced(trx). There was a glitch in this check when it was part of lock_trx_release_locks(); at the end we would release trx->mutex and acquire lock_sys->mutex and trx->mutex, and fail to recheck (trx_is_referenced() is protected by trx_t::mutex). (e) Explicit locks can be released in batches (LOCK_RELEASE_INTERVAL=1000) just like we did before. trx_t::state: Document that the transition to COMMITTED is only protected by trx_t::mutex, no longer by lock_sys_t::mutex. trx_rw_is_active_low(), trx_rw_is_active(): Document that the transaction state should be rechecked after acquiring trx_t::mutex. trx_t::commit_state(): New function to change a transaction to committed state, to release implicit locks. trx_t::release_locks(): New function to release the explicit locks after commit_state(). lock_trx_release_locks(): Move much of the logic to the caller (which must invoke trx_t::commit_state() and trx_t::release_locks() as needed), and assert that the transaction will have locks. trx_get_trx_by_xid(): Make the parameter a pointer to const. lock_rec_other_trx_holds_expl(): Recheck trx->state after acquiring trx->mutex, and avoid a redundant lookup of the transaction. lock_rec_queue_validate(): Recheck impl_trx->state while holding impl_trx->mutex. row_vers_impl_x_locked(), row_vers_impl_x_locked_low(): Document that the transaction state must be rechecked after trx_mutex_enter(). trx_free_prepared(): Adjust for the changes to lock_trx_release_locks().	6 years ago
Marko Mäkelä	7c79c12784	MDEV-15326 preparation: Remove trx_sys_t::n_prepared_trx This is a backport of `900b07908b` from MariaDB Server 10.3.	6 years ago
Marko Mäkelä	154bd0950f	MDEV-15326 preparation: Test slow shutdown after XA PREPARE We were missing a test that would exercise trx_free_prepared() with innodb_fast_shutdown=0. Add a test. Note: if shutdown hangs due to the XA PREPARE transactions, in MariaDB 10.2 the test would unfortunately pass, but take 2*60 seconds longer, because of two shutdown_server statements timing out after 60 seconds. Starting with MariaDB 10.3, the hung server would be killed with SIGABRT, and the test could fail thanks to a backtrace message.	6 years ago
Marko Mäkelä	b2775ae855	MVCC::view_close(): Correct comments	6 years ago
Alexander Barkov	7e08ac0b41	Merge 10.2 (up to commit `ef00ac4c86`) into 10.3	6 years ago
Jan Lindström	cbb85f0d21	Disable galera.galera_var_node_address test case.	6 years ago
Sergei Golubchik	6ee7a9a438	C/C	6 years ago
Sergei Golubchik	c7c481f4d9	MDEV-20403 Assertion `0' or Assertion `btr_validate_index(index, 0)' failed in row_upd_sec_index_entry or error code 126: Index is corrupted upon UPDATE with TIMESTAMP..ON UPDATE Three issues here: * ON UPDATE DEFAULT NOW columns were updated after generated columns were computed - this broke indexed virtual columns * ON UPDATE DEFAULT NOW columns were updated after BEFORE triggers, so triggers didn't see the correct NEW value * in case of a multi-update generated columns were also updated after BEFORE triggers	6 years ago
Sergei Golubchik	3789692d17	don't compare unassigned columns on UPDATE, compare_record() was comparing all columns that are marked for writing. But generated columns that are written to the table are always deterministic and cannot change unless normal non-generated columns were changed. So it's enough to compare only non-generated columns that were explicitly assigned values in the SET clause.	6 years ago
Sergei Golubchik	17ab02f4b0	cleanup: on update default now * remove one level of virtual functions * remove redundant checks * remove an if() as the value is always known at compilation time don't pretend that "DEFAULT expr" and "ON UPDATE DEFAULT NOW" are "basically the same thing"	6 years ago
Monty	a071e0e029	Merge branch '10.2' into 10.3	6 years ago
Alexander Barkov	ef00ac4c86	Part2: MDEV-18156 Assertion `0' failed or `btr_validate_index(index, 0, false)' in row_upd_sec_index_entry or error code 126: Index is corrupted upon DELETE with PAD_CHAR_TO_FULL_LENGTH This patch allows the server to open old tables that have "bad" generated columns (i.e. indexed virtual generated columns, persistent generated columns) that depend on sql_mode, for general things like SELECT, INSERT, DROP, etc. Warning are issued in such cases. Only these commands are now disallowed and return an error: - CREATE TABLE introducing a "bad" generated column - ALTER TABLE introducing a "bad" generated column - CREATE INDEX introdicing a "bad" generated column (i.e. adding an index on a virtual generated column that depends on sql_mode). Note, these commands are allowed: - ALTER TABLE removing a "bad" generate column - ALTER TABLE removing an index from a "bad" virtual generated column - DROP INDEX removing an index from a "bad" virtual generated column but only if the table does not have any "bad" columns as a result.	6 years ago
Alexander Barkov	dc719597ee	MDEV-18156 Assertion `0' failed or `btr_validate_index(index, 0, false)' in row_upd_sec_index_entry or error code 126: Index is corrupted upon DELETE with PAD_CHAR_TO_FULL_LENGTH This change takes into account a column's GENERATED ALWAYS AS expression dependcy on sql_mode's PAD_CHAR_TO_FULL_LENGTH and NO_UNSIGNED_SUBTRACTION flags. Indexed virtual columns as well as persistent generated columns are now not allowed to have such dependencies to avoid inconsistent data or index files on sql_mode changes. So an error is now returned in cases like this: CREATE OR REPLACE TABLE t1 ( a CHAR(5), v VARCHAR(5) AS (a) PERSISTENT -- CHAR->VARCHAR or CHAR->TEXT = ERROR ); Functions RPAD() and RTRIM() can now remove dependency on PAD_CHAR_TO_FULL_LENGTH. So this can be used instead: CREATE OR REPLACE TABLE t1 ( a CHAR(5), v VARCHAR(5) AS (RTRIM(a)) PERSISTENT ); Note, unlike CHAR->VARCHAR and CHAR->TEXT this still works, not RPAD(a) is needed: CREATE OR REPLACE TABLE t1 ( a CHAR(5), v CHAR(5) AS (a) PERSISTENT -- CHAR->CHAR is OK ); More sql_mode flags may affect values of generated columns. They will be addressed separately. See comments in sql_mode.h for implementation details.	6 years ago
Monty	0d66358220	Disabled test in 32bit that uses too much memory or cpu	6 years ago

1 2 3 4 5 ...

185824 Commits (da9201dd5bfbd5df68612c33e2b087705d44bec7) All Branches Search

185824 Commits (da9201dd5bfbd5df68612c33e2b087705d44bec7)

All Branches