mariadb

Tree: d2f84ab978

Author	SHA1	Message	Date
Sergei Golubchik	d2f84ab978	MDEV-10352 Server crashes in Field::set_default on CREATE TABLE fix Item_default_value not to pretend being const_item if the field's default_value expression isn't parsed yet	9 years ago
Sergei Golubchik	cf00393378	Race condition in DEFAULT() with expressions Item_default_value::calculate was updating table->s->default_values, but it is supposed to be read-only	9 years ago
Sergei Golubchik	cd4dd2b62d	MDEV-10201 Bad results for CREATE TABLE t1 (a INT DEFAULT b, b INT DEFAULT 4) Optionally do table->update_default_fields() even for INSERT that supposedly provides values for all column. Because these "values" might be DEFAULT, which would need table->update_default_fields() at the end. Also set Item_default_value::used_tables() from the default expression. Non-zero used_field() means that mysql_insert() will initialize all fields to their default values (with restore_record()) even if all columns are later provided with values. Because default expressions may refer to other columns and they must be initialized.	9 years ago
Alexander Barkov	ae91690d89	MDEV-11780 Crash with PREPARE + SP out parameter + literal Before "MDEV-10709 Expressions as parameters to Dynamic SQL" only user variables were syntactically allowed as EXECUTE parameters. User variables were OK as both IN and OUT parameters. When Item_param was bound to an actual parameter (a user variable), it automatically meant that the bound Item was settable. The DBUG_ASSERT() in Protocol_text::send_out_parameters() guarded that the actual parameter is really settable. After MDEV-10709, any kind of expressions are allowed as EXECUTE IN parameters. But the patch for MDEV-10709 forgot to check that only descendants of Settable_routine_parameter should be allowed as OUT parameters. So an attempt to pass a non-settable parameter as an OUT parameter made server crash on the above mentioned DBUG_ASSERT. This patch changes Item_param::get_settable_routine_parameter(), which previously always returned "this". Now, when Item_param is bound to some Item, it caches if the bound Item is settable. Item_param::get_settable_routine_parameter() now returns "this" only if the bound actual parameter is settable, and returns NULL otherwise.	9 years ago
Alexander Barkov	45e40892c5	MDEV-11134 Assertion `fixed' failed in Item::const_charset_converter(THD, CHARSET_INFO, bool, const char*) Problem: Item_param::basic_const_item() returned true when fixed==false. This unexpected combination made Item::const_charset_converter() crash on asserts. Fix: - Changing all Item_param::set_xxx() to set "fixed" to true. This fixes the problem. - Additionally, changing all Item_param::set_xxx() to set Item_param::item_type, to avoid duplicate code, and for consistency, to make the code symmetric between different constant types. Before this patch only set_null() set item_type. - Moving Item_param::state and Item_param::item_type from public to private, to make sure easier that these members are in sync with "fixed" and to each other. - Adding a new argument "unsigned_arg" to Item::set_decimal(), and reusing it in two places instead of duplicate code. - Adding a new method Item_param::fix_temporal() and reusing it in two places. - Adding methods has_no_value(), has_long_data_value(), has_int_value(), instead of direct access to Item_param::state.	9 years ago
Vicențiu Ciorbaru	1e192e901c	Post merge review fixes * Remove duplicate lines from tests * Use thd instead of current_thd * Remove extra wsrep_binlog_format_names * Correctly merge union patch from 5.5 wrt duplicate rows. * Correctly merge SELinux changes into 10.1	9 years ago
Alexander Barkov	ebb8c9fb26	MDEV-11030 Assertion `precision > 0' failed in decimal_bin_size Fixing Item::decimal_precision() to return at least one digit. This fixes the problem reported in MDEV. Also, fixing Item_func_signed::fix_length_and_dec() to reserve space for at least one digit (plus one character for an optional sign). This is needed to have CONVERT(expr,SIGNED) and CONVERT(expr,UNSIGNED) create correct string fields when they appear in string context, e.g.: CREATE TABLE t1 AS SELECT CONCAT(CONVERT('',SIGNED));	9 years ago
Alexander Barkov	5e051bfa15	MDEV-10386 Assertion `fixed == 1' failed in virtual String* Item_func_conv_charset::val_str(String*) The patch `b96c196f1c` added a new call for safe_charset_converter() without a corresponding fix_fields(). In case of a sub-query the created Item remained in non-fixed state. The problem did not show up with literal derived expressions, only subselects were affected. This patch adds a corresponding fix_fields() to the previously added safe_charset_converter().	9 years ago
Igor Babaev	9b27d3e86e	Fixed bug mdev-11608. The fix for bug mdev-11488 introduced the virtual method convert_to_basic_const_item for the class Item_cache. The implementation of this method for the class Item_cache_str was not quite correct: the server could crash if the cached item was null. A similar problem could appear for the implementation of this method for the class Item_cache_decimal. Although I could not reproduce the problem I decided to change the code appropriately.	9 years ago
Sergei Petrunia	268bb69bea	MDEV-7691: Assertion `outer_context \|\| !from_field \|\| from_field == not_found_field' ... The bug occurred when a subquery - has a reference to outside, to grand-parent query or further up - is converted to a semi-join (i.e. merged into its parent). Then the reference to outside had form Item_ref(Item_field(...)). - Conversion to semi-join would call item->fix_after_pullout() for the outside reference. - Item_ref::fix_after_pullout would call Item_field->fix_after_pullout - The Item_field would construct a new Name_resolution_context object This process ignored the fact that the Item_field does not belong to any of the subselects being flattened. The result was crash in the next call to Item_field::fix_fields(), where we would try to use an invalid Name_resolution_context object. Fixed by not creating Name_resolution_context object if the Item_field's context does not belong to the subselect(s) that were flattened.	9 years ago
Igor Babaev	441fa0056d	Fixed bug mdev-11488. The patch for bug mdev-10882 tried to fix it by providing an implementation of the virtual method build_clone for the class Item_cache. It's turned out that it is not easy provide a valid implementation for Item_cache::build_clone(). At the same time if the condition that can be pushed into a materialized view contains a cached item this item can be substituted for a basic constant of the same value. In such a way we can avoid building proper clones for Item_cache objects when constructing pushdown conditions.	9 years ago
Sergei Golubchik	180065ebb0	Item::print(): remove redundant parentheses by introducing new Item::precedence() method and using it to decide whether parentheses are required	9 years ago
Sergei Golubchik	2a0f7a34d6	bugfix: non-deterministic vcols in partitioning	9 years ago
Sergei Golubchik	a72f1deb2d	rename Virtual_column_info::expr_item now, when expr_str is gone, expr_item can be unambiguously renamed to expr.	9 years ago
Sergei Golubchik	a411d7f4f6	store/show vcols as item->print() otherwise we'd need to store sql_mode per vcol (consider CREATE INDEX...) and how SHOW CREATE TABLE would support that? Additionally, get rid of vcol::expr_str, just to make sure the string is always generated and never leaked in the original form.	9 years ago
Sergei Golubchik	a418c99200	gcol mysql-test suite from 5.7 update tests and results, fix bugs	9 years ago
Sergei Golubchik	c2b2cb8acd	TABLE::update_virtual_field to compute just one vcol will be used later by storage engines (e.g. in MyISAM repair or in InnoDB purge)	9 years ago
Sergei Golubchik	a632df9de0	improve Item_field::register_field_in_read_map() make it to work when read_set == vcol_set, that is, when the caller wants to get a one complete bitmap of all fields a particular vcol depends on.	9 years ago
Oleksandr Byelkin	d67ef7a2fb	MDEV-10663: Use of Inline table columns in HAVING clause throws 1463 Error check for VIEW/DERIVED fields	9 years ago
Alexander Barkov	46dee0d184	MDEV-10717 Assertion `!null_value' failed in virtual bool Item::send(Protocol, String) The problem was that null_value was not set to "false" on a well-formed row. If an ill-formed row was followed by a well-forned row, null_value remained "true" in the call of Item::send() for the well-formed row.	9 years ago
Oleksandr Byelkin	098dff10ba	MDEV-11359 Implement IGNORE for bulk operation	9 years ago
Alexander Barkov	9bfde897c3	MDEV-11360 Dynamic SQL: DEFAULT as a bind parameter This patch adds DEFAULT as a possible dynamic SQL parameter, e.g.: EXECUTE IMMEDIATE 'INSERT INTO t1 (column) VALUES(?)' USING DEFAULT; EXECUTE IMMEDIATE 'UPDATE t1 SET column=?' USING DEFAULT; and for similar PREPARE..EXECUTE queries. This is done for symmetry with the STMT_INDICATOR_DEFAULT indicator in the client-server PS protocol. The changes include: - Allowing DEFAULT as a possible option in execute USING clause (sql_yacc.yy) - Adding "virtual bool Item::save_in_param(THD thd, Item_param param)", because "normal" items (that have real values) and Item_default_value have now different actions when assigning itself as an Item_param value. - Fixing switch() statements in a few Item_param methods not to have "default", because it was easy to forget to add a new "case" when adding a new XXX_VALUE value into the enum Item_param::enum_item_param_state. This is important, as we'll be adding new values soon, e.g. for MDEV-11359. Removing "default" helped to find and report bugs MDEV-11361 and MDEV-11362, because DECIMAL_VALUE is obviously not properly handled in some cases.	9 years ago
Oleksandr Byelkin	e2d6912609	MDEV-9114: Bulk operations (Array binding) (+ default values)	10 years ago
Alexey Botchkov	201c1e0f29	MDEV-9143 JSON_xxx functions. Item_bool fixed to behave smarter with NOT operation.	9 years ago
Alexander Barkov	4c45b820aa	MDEV-10709 Expressions as parameters to Dynamic SQL	9 years ago
Alexander Barkov	8ea2e143f0	MDEV-10772 Introduce Item_param::CONVERSION_INFO	9 years ago
Monty	7b96416f3c	Use sql_mode_t for sql_mode. This fixed several cases where we where using just ulong for sql_mode	9 years ago
Monty	8be53a389c	MDEV-6112 multiple triggers per table This is similar to MysQL Worklog 3253, but with a different implementation. The disk format and SQL syntax is identical with MySQL 5.7. Fetures supported: - "Any" ammount of any trigger - Supports FOLLOWS and PRECEDES to be able to put triggers in a certain execution order. Implementation details: - Class Trigger added to hold information about a trigger. Before this trigger information was stored in a set of lists in Table_triggers_list and in Table_triggers_list::bodies - Each Trigger has a next field that poinst to the next Trigger with the same action and time. - When accessing a trigger, we now always access all linked triggers - The list are now only used to load and save trigger files. - MySQL trigger test case (trigger_wl3253) added and we execute these identically. - Even more gracefully handling of wrong trigger files than before. This is useful if a trigger file uses functions or syntax not provided by the server. - Each trigger now has a "Created" field that shows when the trigger was created, with 2 decimals. Other comments: - Many of the changes in test files was done because of the new "Created" field in the trigger file. This shows up in SHOW ... TRIGGER and when using information_schema.trigger. - Don't check if all memory is released if on uses --gdb; This is needed to be able to get a list from safemalloc of not freed memory while debugging. - Added option to trim_whitespace() to know how many prefix characters was skipped. - Changed a few ulonglong sql_mode to sql_mode_t, to find some wrong usage of sql_mode.	9 years ago
Vicențiu Ciorbaru	5cb568786a	MDEV-10669: Crash in SELECT with window function used Make sure to call split_sum_func on all items that contain window functions, so that all the column references are set up correctly.	9 years ago
Vicențiu Ciorbaru	2857ff3c98	MDEV-10815: Window Function Expressions Wrong Results Fix window function expressions such as win_func() <operator> expr. The problem was found in 2 places. First, when we have complex expressions containing window functions, we can only compute their final value _after_ we have computed the window function's values. These values must be stored within the temporary table that we are using, before sending them off. This is done by performing an extra copy_funcs call before the final end_send() call. Second, such expressions need to have their inner arguments, changed such that the references within those arguments point to fields within the temporary table. Ex: sum(t.a) over (order by t.b) + sum(t.a) over (order by t.b) Before this fix, t.a pointed to the original table's a field. In order to compute the sum function's value correctly, it needs to point to the copy of this field inside the temp table. This is done by calling split_sum_func for each argument in the expression in turn. The win.test results have also been updated as they contained wrong values for such a use case.	9 years ago
Igor Babaev	3630a00e25	Fixed bug mdev-10782. This bug in the code of Item_ref::build_clone could cause corruption of items in where conditions. Also made sure that equality predicates extracted from multiple equality items to be pushed into materialized views were cloned.	9 years ago
Oleksandr Byelkin	9810d5ea13	Helper function for debugging.	9 years ago
Igor Babaev	dc9b0924d1	More cleanup.	9 years ago
Alexander Barkov	e4f6fd5e12	MDEV-10743 LDML: a new syntax to reuse sort order from another 8bit simple collation	9 years ago
Igor Babaev	de02bfd373	The code that pushed conditions into derived did not take into account that the list of equal items in an Item_equal object may contain items with type() == REF_ITEM.	9 years ago
Igor Babaev	3b40f78ede	Fixed a flaw in the implementation of condition push-down for materialized views and derived tables: there were no push-down if the view was defined as union of selects without aggregation. Added test cases with such unions. Adjusted result files after the merge of the code for mdev-9197.	9 years ago
Oleksandr Byelkin	b9631e310b	MDEV-8833 Crash of server on prepared statement with conversion to semi-join Correct context chain made to allow outer fields pullout.	10 years ago
Igor Babaev	4de75afb45	Fixed the previous merge to be able to build mysqld. Adjusted one result file.	9 years ago
Oleksandr Byelkin	a322651b8a	MDEV-10017: Get unexpected `Empty Set` for correlated subquery with aggregate functions take into account all arguments of aggregate function	9 years ago
Sergei Golubchik	7450cb7f69	re-fix vcols on demand, not always for every SELECT	9 years ago
Sergei Golubchik	cd51c7fb60	move away from TIMESTAMP_DNUN_FIELD/TIMESTAMP_DN_FIELD code use the new approach with Field->default_value expressions. But keep the old TIMESTAMP_UN_FIELD for ON UPDATE NOW().	9 years ago
Sergei Golubchik	12d2c4fcd0	optimize constant default expressions to be calculated at the CREATE TABLE time and stored in the default row image.	9 years ago
Galina Shalygina	eb2c147475	The consolidated patch for mdev-9197.	10 years ago
Sreeharsha Ramanavarapu	ac460e584d	Bug #23280699 : MYSQLD GOT SIGNAL 11 IN IS_NULL ON SELECT FROM I_S Issue: ------ There is a difference in the field type created when the following DDLs are used: 1) CREATE TABLE t0 AS SELECT NULL; 2) CREATE TABLE t0 AS SELECT GREATEST(NULL,NULL); The first statement creates field of type Field_string and the second one creates a field of type Field_null. This creates a problem when the query mentioned in this bug is used. Since the null_ptr is calculated differently for Field_null. Solution: --------- When there is a function returning null in the select list as mentioned above, the field should be of type Field_string. This was fixed in 5.6+ as part of Bug#14021323. This is a backport to mysql-5.5. An incorrect comment in innodb_bug54044.test has been corrected in all versions.	9 years ago
Alexander Barkov	59ec3973aa	Removing duplicate code in double-to-longlong conversion. Adding Converter_double_to_longlong and reusing it in: 1. Field_longlong::store(double nr) 2. Field_double::val_int() 3. Item::val_int_from_real() 4. Item_dyncol_get::val_int() As a good side efferct, now overflow in conversion in the mentioned val_xxx() methods return exactly the same warning.	9 years ago
Sergei Golubchik	3687edeec9	clarify the order of evaluation for INSERT	10 years ago
Sergei Golubchik	f93a2a3b3b	various cleanups * remove a confusing method name - Field::set_default_expression() * remove handler::register_columns_for_write() * rename stuff * add asserts * remove unlikely unlikely * remove redundant if() conditions * fix mark_unsupported_function() to report the most important violation * don't scan vfield list for default values (vfields don't have defaults) * move handling for DROP CONSTRAINT IF EXIST where it belongs * don't protect engines from Alter_inplace_info::ALTER_ADD_CONSTRAINT * comments	10 years ago
Sergei Golubchik	0a056c9b53	better ER_VIRTUAL_COLUMN_FUNCTION_IS_NOT_ALLOWED	10 years ago
Sergei Golubchik	ed77ee1aab	cleanup: change Item::walk() to take void* not uchar* and remove all related casts to uchar* also remove a couple of unused methods	10 years ago
Sergei Golubchik	e8bdb73ade	function DEFAULT(x) now works for expression defaults	10 years ago

1 2 3 4 5 ...

3513 Commits (d2f84ab978c596fcaa96e0d53282b57f6225e50f)