mariadb

Tree: cb9fa1a08b

Author	SHA1	Message	Date
Varun Gupta	cb9fa1a08b	MDEV-9959: A serious MariaDB server performance bug If a derived table has SELECT DISTINCT, provide index statistics for it so that the join optimizer in the upper select knows that ref access to the table will produce one row.	7 years ago
Alexander Barkov	8c8bee0a56	MDEV-10307 CAST(11068046444225730969 AS SIGNED) does not return a warning	7 years ago
Marko Mäkelä	447b8ba164	Merge 10.2 into 10.3	7 years ago
Marko Mäkelä	810f014ca7	MDEV-18429: Simpler implementation This reverts commit `61f370a3c9` and implements a simpler fix that is straightforward to merge to 10.3. lock_print_info: Renamed from PrintNotStarted. Dump the entire contents of trx_sys->mysql_trx_list. lock_print_info_rw_recovered: Like lock_print_info, but dump only recovered transactions in trx_sys->rw_trx_list. lock_print_info_all_transactions(): Dump both trx_sys->mysql_trx_list and trx_sys->rw_trx_list. TrxLockIterator, TrxListIterator, lock_rec_fetch_page(): Remove. This is a partial backport of the 10.3 commit `a447980ff3` which removed the race-condition-prone ability of the InnoDB monitor to read relevant pages into the buffer pool for some record locks.	7 years ago
Marko Mäkelä	092602ac9b	MDEV-14130 InnoDB messages should not refer to the MySQL 5.7 manual In InnoDB error messages, replace the hyperlink URLs to point to the MariaDB knowledge base.	7 years ago
Marko Mäkelä	5fb4c0a8a8	Clean up ut_list ut_list_validate(), ut_list_map(): Add variants with const Functor& so that these functions can be called with an rvalue. Remove wrapper macros, and add #ifdef UNIV_DEBUG around debug-only code.	7 years ago
Marko Mäkelä	bdd6e33f00	MDEV-13626: Add a test case	7 years ago
Eugene Kosov	61f370a3c9	MDEV-18429 Consistent non-locking reads do not appear in TRANSACTIONS section of SHOW ENGINE INNODB STATUS lock_print_info_all_transactions(): print transactions which are started but not in RW or RO lists. print_not_started(): Replaces PrintNotStarted. Collect the skipped transactions.	7 years ago
Vladislav Vaintroub	d6e431dfa8	MDEV-18131 : Update C/C to fix IP address SAN verification in 10.2+	7 years ago
Vladislav Vaintroub	e03ad4f71a	Fix a typo	7 years ago
Marko Mäkelä	1b577e4d8b	MDEV-19356 Assertion 'space->free_limit == 0 \|\| space->free_limit == free_limit' fil_node_t::read_page0(): Do not replace up-to-date metadata with a possibly old version of page 0 that is being reread from the file. A more up-to-date page 0 could still exists in the buffer pool, waiting to be written back to the file.	7 years ago
Marko Mäkelä	e10b3fa97a	MDEV-19231: Correct an assertion BtrBulk::finish(): On error, the B-tree can be corrupted. Only upon successful completion, it makes sense to validate the index.	7 years ago
Marko Mäkelä	cc359eae3b	Remove a type cast, and use correct format instead	7 years ago
Alexey Botchkov	bb4f4b3a1b	Make Win compiler happy.	7 years ago
Alexey Botchkov	a529188e05	MDEV-17456 Malicious SUPER user can possibly change audit log configuration without leaving traces. The 'SET server_audit_logging ' statements should be logged no matter what.	7 years ago
Alexey Botchkov	cd26cdcd97	MDEV-19141 server_audit_excl_users accepts only values with less than 1024 chars. Since this limit is imposed by the SHOW_VAR_FUNC_BUFF_SIZE, we just launch the error message.	7 years ago
Marko Mäkelä	4d59f45260	Merge 10.2 into 10.3	7 years ago
Alexander Barkov	00377147e3	Tests for MDEV-15881 Assertion `is_valid_value_slow()' failed in Datetime::Datetime or corrupt data after ALTER with indexed persistent column The patch for "MDEV-18486 Database crash on a table with indexed virtual column" fixed MDEV-15881 as well. So adding tests only.	7 years ago
Marko Mäkelä	1a5ba2a4be	MDEV-19342 Merge new release of InnoDB 5.7.26 to 10.2	7 years ago
Marko Mäkelä	4e9f8c9cc4	Remove roll_node_t::partial The field roll_node_t::partial holds if and only if savept has been set. Make savept a pointer. trx_rollback_start(): Use the semantic type undo_no_t for roll_limit.	7 years ago
Aditya A	f3a9f12bc3	Bug #29021730 CRASHING INNOBASE_COL_CHECK_FK WITH FOREIGN KEYS PROBLEM ------- Function innodb_base_col_setup_for_stored() was skipping to store the base column information for a generated column if the base column was a "STORED" generated column. This later causes a crash in function innoabse_col_check_fk() where it says that a generated columns depends upon two base columns ,but there is information on only one of them. There was a explicit check barring the stored columns being stored, which is wrong because the documentation says that a generated stored column can be a part of a generated column. FIX ---- Store the information of base column if it is a stored generated column. #RB21247 Reviewed by: Debarun Banerjee <debarun.banerjee@oracle.com>	7 years ago
Marko Mäkelä	793bd3ee13	lock_rec_convert_impl_to_expl_for_trx(): Remove unused parameter	7 years ago
Marko Mäkelä	c795a9f3fe	MDEV-12004: Add the Bug#28825718 test case Adapt the test case from mysql/mysql-server@2bbbcddd903626c84c610dd2ed82cc22ee4d6cde (MySQL 5.7.26).	7 years ago
Sachin Agarwal	06ec56f579	Bug #27850600 INNODB ASYNC IO ERROR HANDLING IN IO_EVENT Problem: io_getevents() - read asynchronous I/O events from the completion queue. For each IO event, the res field in io_event tells whether IO event is succeeded or not. To see if the IO actually succeeded we always need to check event.res (negative=error, positive=bytesread/written). LinuxAIOHandler::collect() doesn't check event.res value for each event. which leads to incorrect value in n_bytes for IO context (or IO Slot). Fix: Added a check for event.res negative value. RB: 20871 Reviewed by : annamalai.gurusami@oracle.com	7 years ago
Marko Mäkelä	1c4d1f3d05	innobase_col_check_fk(): Remove copying	7 years ago
Alexander Barkov	5cfc7799a3	MDEV-16518 MYSQL57_GENERATED_FIELD: The code in TABLE_SHARE::init_from_binary_frm_image() is not safe	7 years ago
Sujatha Sivakumar	9a5a86f293	MDEV-17260: Memory leaks in mysqlbinlog Problem: ======== The mysqlbinlog tool is leaking memory, causing failures in various tests when compiling and testing with AddressSanitizer or LeakSanitizer like this: cmake -DCMAKE_BUILD_TYPE=Debug -DWITH_ASAN:BOOL=ON /path/to/source make -j$(nproc) cd mysql-test ASAN_OPTIONS=abort_on_error=1 ./mtr --parallel=auto Analysis: ========= Two types of leaks were observed during above execution. 1) Leak in Log_event::read_log_event(char const, unsigned int, char const, Format_description_log_event const, char) File: sql/log_event.cc:2150 For all row based replication events the memory which is allocated during read_log_event is not freed after the event is processed. The event specific memory has to be retained only when flashback option is enabled with mysqlbinlog tool. In this case all the events are retained till the end statement is received and they are processed in reverse order and they are destroyed. But in the existing code all events are retained irrespective of flashback mode. Hence the memory leaks are observed. 2) read_remote_annotate_event(unsigned char, unsigned long, char const) File: client/mysqlbinlog.cc:194 In general the Annotate event is not printed immediately because all subsequent rbr-events can be filtered away. Instead it will be printed together with the first not filtered away Table map or the last rbr will be processed. While reading remote annotate events memory is allocated for event buffer and event's temp_buf is made to point to the allocated buffer as shown below. The TRUE flag is used for doing proper cleanup using free_temp_buf(). i.e at the time of deletion of annotate event its destructor takes care of clearing the temp_buf. / Ensure the event->temp_buf is pointing to the allocated buffer. (TRUE = free temp_buf on the event deletion) / event->register_temp_buf((char)event_buf, TRUE); But existing code does the following when it receives a remote annotate_event. if (remote_opt) ev->temp_buf= 0; That is code immediately sets temp_buf=0, because of which free_temp_buf() call will return empty handed as it has lost the reference to the allocated temporary buffer. This results in memory leak Fix: ==== 1) If not in flashback mode, destroy the memory for events once they are processed. 2) Remove the ev->temp_buf=0 code for remote option. Let the proper cleanup to be done as part of free_temp_buf().	7 years ago
Oleksandr Byelkin	4e01bc8c96	MDEV-16240: Assertion `0' failed in row_sel_convert_mysql_key_to_innobase Set table in row ID position mode before using this function.	7 years ago
Oleksandr Byelkin	3dffdee667	MDEV-17036: BULK with replace doesn't take the first parameter in account INSERT and REPLACE served by the same function, so flags (and processing) should be the same.	7 years ago
Marko Mäkelä	b2dbc781c7	Implement --debug=d,ib_log_checkpoint_avoid Normally, the InnoDB master thread executes InnoDB log checkpoints so frequently that bugs in crash recovery or redo logging can be hard to reproduce. This is because crash recovery would start replaying the log only from the latest checkpoint. Because the InnoDB redo log format only allows saving information for at most 2 latest checkpoints, and because the log files are written in a circular fashion, it would be challenging to implement a debug option that would start the redo log apply from the very start of the redo log file.	7 years ago
Eugene Kosov	6c5c1f0b2f	MDEV-19231 make DB_SUCCESS equal to 0 It's a micro optimization. On most platforms CPUs has instructions to compare with 0 fast. DB_SUCCESS is the most popular outcome of functions and this patch optimized code like (err == DB_SUCCESS) BtrBulk::finish(): bogus assertion fixed fil_node_t::read_page0(): corrected usage of os_file_read() que_eval_sql(): bugus assertion removed. Apparently it checked that the field was assigned after having been zero-initialized at object creation. It turns out that the return type of os_file_read_func() was changed in mysql/mysql-server@98909cefbc37e54efc6452c7e95bccbf64ac9213 (MySQL 5.7) from ibool to dberr_t. The reviewer (if there was any) failed to point out that because of future merges, it could be a bad idea to change the return type of a function without changing the function name. This change was applied to MariaDB 10.2.2 in commit `2e814d4702` but the MariaDB-specific code was not fully adjusted accordingly, e.g. in fil_node_open_file(). Essentially, code like !os_file_read(...) became dead code in MariaDB and later in Mariabackup 10.2, and we could be dealing with an uninitialized buffer after a failed page read.	7 years ago
Marko Mäkelä	acf6f92aa9	Merge 10.2 into 10.3	7 years ago
Marko Mäkelä	bc145193c1	Merge 10.1 into 10.2	7 years ago
Marko Mäkelä	bfb0726fc2	Merge 5.5 into 10.1	7 years ago
Thirunarayanan Balathandayuthapani	d5da8ae04d	MDEV-15772 Potential list overrun during XA recovery InnoDB could return the same list again and again if the buffer passed to trx_recover_for_mysql() is smaller than the number of transactions that InnoDB recovered in XA PREPARE state. We introduce the transaction state TRX_PREPARED_RECOVERED, which is like TRX_PREPARED, but will be set during trx_recover_for_mysql() so that each transaction will only be returned once. Because init_server_components() is invoking ha_recover() twice, we must reset the state of the transactions back to TRX_PREPARED after returning the complete list, so that repeated traversals will see the complete list again, instead of seeing an empty list. Without this tweak, the test main.tc_heuristic_recover would hang in MariaDB 10.1.	7 years ago
Varun Gupta	1f1a61cfc4	MDEV-15837: Assertion `item1->type() == Item::FIELD_ITEM && item2->type() == Item::FIELD_ITEM' failed in compare_order_elements function The issue here is the function compare_order_lists() is called for the order by list of the window functions so that those window function that can be computed together are adjacent. So in the function compare_order_list we iterate over all the elements in the order list of the two functions and compare the items in their order by clause. The function compare_order_elements() is called for each item in the order by clause. This function assumes that all the items that are in the order by list would be of the type Item::FIELD_ITEM. The case we have is that we have constants in the order by clause. We should ignore the constant and only compare items of the type Item::FIELD_ITEM in compare_order_elements()	7 years ago
Sujatha Sivakumar	cb8d888c42	MDEV-17260: Memory leaks in mysqlbinlog Problem: ======== The mysqlbinlog tool is leaking memory, causing failures in various tests when compiling and testing with AddressSanitizer or LeakSanitizer like this: cmake -DCMAKE_BUILD_TYPE=Debug -DWITH_ASAN:BOOL=ON /path/to/source make -j$(nproc) cd mysql-test ASAN_OPTIONS=abort_on_error=1 ./mtr --parallel=auto rpl.rpl_row_mysqlbinlog CURRENT_TEST: rpl.rpl_row_mysqlbinlog Direct leak of 112 byte(s) in 1 object(s) allocated from: #0 0x4eff87 in __interceptor_malloc (/dev/shm/5.5/client/mysqlbinlog+0x4eff87) #1 0x60eaab in my_malloc /mariadb/5.5/mysys/my_malloc.c:41:10 #2 0x5300dd in Log_event::read_log_event(char const, unsigned int, char const, Format_description_log_event const, char) /mariadb/5.5/sql/log_event.cc:1568: #3 0x564a9c in dump_remote_log_entries(st_print_event_info, char const) /mariadb/5.5/client/mysqlbinlog.cc:1978:17 Analysis: ======== 'mysqlbinlog' tool is being used to read binary log events from a remote server. While reading binary log, if a fake rotate event is found following actions are taken. If 'to-last-log' option is specified, then fake rotate event is processed. In the absence of 'to-last-log' skip the fake rotate event. In this skipped case the fake rotate event object is not getting cleaned up resulting in memory leak. Fix: === Cleanup the fake rotate event. This issues is already fixed in MariaDB 10.0.23 and higher versions as part of commit `c3018b0ff4`	7 years ago
Igor Babaev	5fc8dd8b82	MDEV-17796 WHERE filter is ignored by DISTINCT IFNULL(GROUP_CONCAT(X), Y) with GROUP BY + ORDER BY The method JOIN::create_postjoin_aggr_table() should not call call JOIN::add_sorting_to_table() unless the first non-constant join table is passed as the first parameter to the method.	7 years ago
Marko Mäkelä	e5aa8ea525	MDEV-18139 ALTER IGNORE ... ADD FOREIGN KEY causes bogus error dict_create_foreign_constraints_low(): Tolerate the keywords IGNORE and ONLINE between the keywords ALTER and TABLE. We should really remove the hacky FOREIGN KEY constraint parser from InnoDB.	7 years ago
Marko Mäkelä	38b6dc5a3d	Fix the linking of async_example	7 years ago
Vladislav Vaintroub	6b5d3c51b3	Do fast exit with error code and FATAL ERROR message, if innodb cannot start during prepare. Otherwise, it is possible for "prepare" to exit with error code 0, even if it did not work at all.	7 years ago
Alexander Barkov	9dcfd6be94	MDEV-9465 The constructor StringBuffer(const char str, size_t length, const CHARSET_INFO cs) looks suspicious Removing the suspicious constructor, it's not used in the code anyway.	7 years ago
Igor Babaev	279a907fd0	MDEV-17605 Statistics for InnoDB table is wrong if persistent statistics is used The command SHOW INDEXES ignored setting of the system variable use_stat_tables to the value of 'preferably' and and showed statistical data received from the engine. Similarly queries over the table STATISTICS from INFORMATION_SCHEMA ignored this setting. It happened because the function fill_schema_table_by_open() did not read any data from statistical tables.	7 years ago
Alexey Botchkov	a4f7d85932	MDEV-18920 Prepared statements with st_convexhull hang and eat 100% cpu. In the case of error when object shapes are half-collected we need to set the NULL at the vertice's list.	7 years ago
Alexander Barkov	6c5e4c9bc0	Fixing -Werror=format-overflow errors (found by gcc-8.3.1)	7 years ago
Alexander Barkov	279b50b4eb	MDEV-14041 Server crashes in String::length on queries with functions and ROLLUP	7 years ago
Alexander Barkov	765ae6e821	MDEV-19239 ERROR 1300 (HY000): Invalid utf8 character string in 10.3.13-MariaDB A sequence of <digits>e<mbhead><mbtail>, e.g.: SELECT 123eXYzzz FROM t1; was not scanned correctly (where XY is a multi-byte character). The multi-byte head byte X was appended to 123e separately from the multi-byte tail byte Y, so a pointer to "Yzzz" was passed into scan_ident_start(), which failed on a bad multi-byte sequence. After this change, scan_ident_start() gets a pointer to "XYzzz", so it correctly sees the whole multi-byte character.	7 years ago
Alexander Barkov	f4019f5b35	Backporting from 10.4 to 10.3: MDEV-17325 NULL-ability problems with LEAST() in combination with NO_ZERO_DATE and NO_ZERO_IN_DATE This also fixes: MDEV-17299 Assertion `maybe_null' failed in make_sortkey Note, during merge of the 10.1 version of MDEV-17299, please use the 10.3 version of the code (i.e. null merge the 10.1 version).	7 years ago
Alexander Barkov	f4b2740018	MDEV-17299 Assertion `maybe_null' failed in make_sortkey	7 years ago
Andrei Elkin	42c58b87da	MDEV-18096 The server would crash when has configs rpl_semi_sync_master_enabled = OFF rpl_semi_sync_master_wait_no_slave = OFF The patch fixes a fired assert in the semisync master module. The assert caught attempt to switch semisync off (per rpl_semi_sync_master_wait_no_slave = OFF) when it was not even initialized (per rpl_semi_sync_master_enabled = OFF). The switching-off execution branch is relocated under one that executes enable_master() first. A minor cleaup is done to remove the int return from two functions that did not return anything but an error which could not happen in the functions.	7 years ago

1 2 3 4 5 ...

184815 Commits (cb9fa1a08bd1f4f609324971e58b9b300a5cb55f) All Branches Search

184815 Commits (cb9fa1a08bd1f4f609324971e58b9b300a5cb55f)

All Branches