mariadb

Tree: b896f60a73

Author	SHA1	Message	Date
Marko Mäkelä	b896f60a73	Fix -Wformat and -Wnonnull-compare for WSREP	7 years ago
Marko Mäkelä	d0116e10a5	Revert MDEV-18464 and MDEV-12009 This reverts commit `21b2fada7a` and commit `81d71ee6b2`. The MDEV-18464 change introduces a few data race issues. Contrary to the documentation, the field trx_t::victim is not always being protected by lock_sys_t::mutex and trx_t::mutex. Most importantly, it seems that KILL QUERY could wrongly avoid acquiring both mutexes when invoking lock_trx_handle_wait_low(), in case another thread had already set trx->victim=true. We also revert MDEV-12009, because it should depend on the MDEV-18464 fix being present.	7 years ago
Jan Lindström	81d71ee6b2	MDEV-12009: Allow to force kill user threads/query which are flagged as high priority by Galera As noted on kill_one_thread SUPER should be able to kill even system threads i.e. threads/query flagged as high priority or wsrep applier thread. Normal user, should not able to kill threads/query flagged as high priority (BF) or wsrep applier thread.	7 years ago
Marko Mäkelä	f2c1c9590c	Fix cmake -DENABLED_PROFILING=OFF	7 years ago
Eugene Kosov	67b601c503	remove unused argument	8 years ago
Eugene Kosov	a523444eda	remove dead code	8 years ago
Alexander Barkov	f704361cd6	Backporting slow log simulation logic details from 10.2 to 10.1 Simulate slow statements only for COM_QUERY and COM_STMT_EXECUTE commands, to exclude mysqld_stmt_prepare() and mysqld_stmt_close() entries from the log, as they are not relevant for log_slow_debug.test. This simplifies the test.	7 years ago
Chris Calender	9d2d80aace	Update sql_parse.cc Corrected one more "refering" typo.	7 years ago
Sergei Golubchik	1f020299f8	post-merge: --ps-protocol fixes Includes: MDEV-17302 Add support for ALTER USER command in prepared statement and MDEV-17673 main.cte_recursive fails in bb-10.4-ps branch in --ps Set correct SELECT_LEX linkage for recursive CTEs. Do not delegate this job to TABLE_LIST::set_as_with_table, because it is only run on prepare, while With_element::move_anchors_ahead is run both on prepare and execute (fix by Igor)	7 years ago
Sergei Golubchik	3d2d060b62	fix gcc 8 compiler warnings There were two newly enabled warnings: 1. cast for a function pointers. Affected sql_analyse.h, mi_write.c and ma_write.cc, mf_iocache-t.cc, mysqlbinlog.cc, encryption.cc, etc 2. memcpy/memset of nontrivial structures. Fixed as: * the warning disabled for InnoDB * TABLE, TABLE_SHARE, and TABLE_LIST got a new method reset() which does the bzero(), which is safe for these classes, but any other bzero() will still cause a warning * Table_scope_and_contents_source_st uses `TABLE_LIST ` (trivial) instead of `SQL_I_List<TABLE_LIST>` (not trivial) so it's safe to bzero now. added casts in debug_sync.cc and sql_select.cc (for JOIN) * move assignment method for MDL_request instead of memcpy() * PARTIAL_INDEX_INTERSECT_INFO::init() instead of bzero() * remove constructor from READ_RECORD() to make it trivial * replace some memcpy() with c++ copy assignments	7 years ago
Alexander Barkov	d7a38eaf1a	MDEV-18907 Slow log: RENAME TABLE is not "admin", while ALTER TABLE..RENAME is	7 years ago
Sergey Vojtovich	3568427d11	MDEV-18450 Slaves wait shutdown The patches features an optional shutdown behavior to hold on until after all connected slaves have been sent the last binlogged event. The connected slave is one whose START SLAVE has been acknowledged and that was not stopped since that though it could be technically reconnecting in background. The solution therefore disallows killing the dump thread until is has found EOF of the latest binlog file. It is up to the shutdown requester (DBA) to set up a sufficiently large shutdown timeout value for shudown to wait patiently until lagging behind slaves have been synchronized. On the other hand if a specific slave needs exclusion from synchronization the DBA would have to stop it manually which would terminate its dump thread. `mysqladmin shutdown' is extended with a `--wait_for_all_slaves' option which translates to `SHUTDOW WAIT FOR ALL SLAVES' sql query to enable the feature on the client side. The patch also performs a small refactoring of the server shutdown around close_connections() to introduce kill thread phases which are two as of current.	7 years ago
Alexander Barkov	90ce95de4b	Tests for MDEV-18892 Regression in slow log and admin statements The patch for MDEV-15945 fixed MDEV-18892. Adding tests only.	7 years ago
Sergei Golubchik	a62e9a83c0	MDEV-15945 --ps-protocol does not test some queries Make mysqltest to use --ps-protocol more use prepared statements for everything that server supports with the exception of CALL (for now). Fix discovered test failures and bugs. tests: * PROCESSLIST shows Execute state, not Query * SHOW STATUS increments status variables more than in text protocol * multi-statements should be avoided (see tests with a wrong delimiter) * performance_schema events have different names in --ps-protocol * --enable_prepare_warnings mysqltest.cc: * make sure run_query_stmt() doesn't crash if there's no active connection (in wait_until_connected_again.inc) * prepare all statements that server supports protocol.h * Protocol_discard::send_result_set_metadata() should not send anything to the client. sql_acl.cc: * extract the functionality of getting the user for SHOW GRANTS from check_show_access(), so that mysql_test_show_grants() could generate the correct column names in the prepare step sql_class.cc: * result->prepare() can fail, don't ignore its return value * use correct number of decimals for EXPLAIN columns sql_parse.cc: * discard profiling for SHOW PROFILE. In text protocol it's done in prepare_schema_table(), but in --ps it is called on prepare only, so nothing was discarding profiling during execute. * move the permission checking code for SHOW CREATE VIEW to mysqld_show_create_get_fields(), so that it would be called during prepare step too. * only set sel_result when it was created here and needs to be destroyed in the same block. Avoid destroying lex->result. * use the correct number of tables in check_show_access(). Saying "as many as possible" doesn't work when first_not_own_table isn't set yet. sql_prepare.cc: * use correct user name for SHOW GRANTS columns * don't ignore verbose flag for SHOW SLAVE STATUS * support preparing REVOKE ALL and ROLLBACK TO SAVEPOINT * don't ignore errors from thd->prepare_explain_fields() * use select_send result for sending ANALYZE and EXPLAIN, but don't overwrite lex->result, because it might be needed to issue execute-time errors (select_dumpvar - too many rows) sql_show.cc: * check grants for SHOW CREATE VIEW here, not in mysql_execute_command sql_view.cc: * use the correct function to check privileges. Old code was doing check_access() for thd->security_ctx, which is invoker's sctx, not definer's sctx. Hide various view related errors from the invoker. sql_yacc.yy: * initialize lex->select_lex for LOAD, otherwise it'll contain garbage data that happen to fail tests with views in --ps (but not otherwise).	7 years ago
Sergei Golubchik	22f1cf9292	cleanup: misc	7 years ago
Sergei Golubchik	dda2e940fb	pass the slow logging information in thd->query_plan_flags This solves the following issues: * unlike lex->m_sql_cmd and lex->sql_command, thd->query_plan_flags is not reset in Prepared_statement::execute, it survives till the log_slow_statement(), so slow logging behaves correctly in --ps * using thd->query_plan_flags for both slow_log_filter and log_slow_admin_statements means the definition of "admin" statements for the slow log is the same no matter how it is filtered out.	7 years ago
Monty	ec66320b0c	Replace setting QPLAN_ADMIN directly with prepare_logs_for_admin_command()	7 years ago
Alexander Barkov	f0cd707503	After-merge fix for MDEV-18333 Slow_queries count doesn't increase when slow_query_log is turned off	7 years ago
Alexander Barkov	26f0d72a3f	A cleanup for MDEV-18333 Slow_queries count doesn't increase when slow_query_log is turned off thd->lex->m_sql_cmd was not cleared between queries. log_slow_query() could crash (when running mtr --ps) because of this.	7 years ago
Sergey Vojtovich	2b711d231a	Adieu slave_list slave_list was used to provide data for SHOW SLAVE HOSTS and Slaves_connected status variable. Introduced binlog_dump_thread_count which is exposed via Slaves_connected (replaces slave_list.records). Store Slave_info on THD and access it by iterating server_threads (replaces slave_list). Added: THD::slave_info binlog_dump_thread_count show_slave_hosts_callback() Removed: slave_list SLAVE_LIST_CHUNK SLAVE_ERRMSG_SIZE slave_list_key() slave_info_free() init_slave_list() end_slave_list() all_slave_list_mutexes init_all_slave_list_mutexes() key_LOCK_slave_list LOCK_slave_list Moved: SLAVE_INFO -> Slave_info register_slave() -> THD::register_slave() unregister_slave() -> THD::unregister_slave() Also removed redundant end_slave() from close_connections(): it is called again soon afterwards by clean_up(). Pre-requisite for clean MDEV-18450 solution.	7 years ago
Alexander Barkov	19df45a705	MDEV-18333 Slow_queries count doesn't increase when slow_query_log is turned off	7 years ago
Robert Bindar	90ad4dbd17	MDEV-7597 Expiration of user passwords This patch adds support for expiring user passwords. The following statements are extended: CREATE USER user@localhost PASSWORD EXPIRE [option] ALTER USER user@localhost PASSWORD EXPIRE [option] If no option is specified, the password is expired with immediate effect. If option is DEFAULT, global policy applies according to the default_password_lifetime system var (if 0, password never expires, if N, password expires every N days). If option is NEVER, the password never expires and if option is INTERVAL N DAY, the password expires every N days. The feature also supports the disconnect_on_expired_password system var and the --connect-expired-password client option. Closes #1166	7 years ago
Nikita Malyavin	073c93b194	MDEV-17082 Application-time periods: CREATE * add syntax `CREATE TABLE ... PERIOD FOR <apptime>` * add table period entity	7 years ago
Teemu Ollakka	3be9982f6a	MDEV-18571 Fix wsrep PS protocol crash Calls to wsrep_after_statement() were missing on PS protocol codepath. Added calls after mysqld_stmt_execute() and mysqld_stmt_bulk_execute().	7 years ago
Varun Gupta	be8709eb7b	MDEV-6111 Optimizer Trace This task involves the implementation for the optimizer trace. This feature produces a trace for any SELECT/UPDATE/DELETE/, which contains information about decisions taken by the optimizer during the optimization phase (choice of table access method, various costs, transformations, etc). This feature would help to tell why some decisions were taken by the optimizer and why some were rejected. Trace is session-local, controlled by the @@optimizer_trace variable. To enable optimizer trace we need to write: set @@optimizer_trace variable= 'enabled=on'; To display the trace one can run: SELECT trace FROM INFORMATION_SCHEMA.OPTIMIZER_TRACE; This task also involves: MDEV-18489: Limit the memory used by the optimizer trace introduces a switch optimizer_trace_max_mem_size which limits the memory used by the optimizer trace. This was implemented by Sergei Petrunia.	7 years ago
Sergey Vojtovich	4d5f85a3ec	Bootstrap cleanups Remove unused key_thread_bootstrap. No more global bootstrap_error: it is return value of bootstrap() instead.	7 years ago
Sergei Golubchik	5b15cc613e	MDEV-11340 Allow multiple alternative authentication methods for the same user introduce the syntax ... IDENTIFIED { WITH \| VIA } plugin [ { USING \| AS } auth ] [ OR plugin [ { USING \| AS } auth ] [ OR ... ]] Server will try auth plugins in the specified order until the first success. No protocol changes, server uses the existing "switch plugin" packet. The auth chain is stored in json as "auth_or":[{"plugin":"xxx","authentication_string":"yyy"}, {}, {"plugin":"foo","authentication_string":"bar"}, ...], "plugin":"aaa", "authentication_string":"bbb" Note: * "auth_or" implies that there might be "auth_and" someday; * one entry in the array is an empty object, meaning to take plugin/auth from the main json object. This preserves compatibility with the existing mysql.global_priv table and with the mysql.user view. This entry is preferrably a mysql_native_password plugin for a non-empty mysql.user.password column. SET PASSWORD is supported and changes the password for the first plugin in the chain that has a notion of a "password"	7 years ago
Vladislav Vaintroub	261ce5286f	MDEV-18281 COM_RESET_CONNECTION changes the connection encoding Store original charset during client authentication, and restore it for COM_RESET_CONNECTION	7 years ago
Vladislav Vaintroub	e214aa1cd3	MDEV-18281 COM_RESET_CONNECTION changes the connection encoding Store original charset during client authentication, and restore it for COM_RESET_CONNECTION	7 years ago
Sergey Vojtovich	4b3656a44d	Avoid taking LOCK_thread_count for thread_count protection Replaced wait on COND_thread_count with busy waiting with 1 millisecond sleep. Aim is to reduce usage of LOCK_thread_count and COND_thread_count.	7 years ago
Sergey Vojtovich	3503fbbebf	Move THD list handling to THD_list Implemented and integrated THD_list as a replacement for the global thread list. It uses own mutex instead of LOCK_thread_count for THD list protection. Removed unused first_global_thread() and next_global_thread(). delayed_insert_threads is now protected by LOCK_delayed_insert. Although this patch doesn't fix very wrong synchronization of this variable. After this patch there are only 2 legitimate uses of LOCK_thread_count left, both in mysqld.cc: thread_count and ready_to_exit. Aim is to reduce usage of LOCK_thread_count and COND_thread_count. Part of MDEV-15135.	7 years ago
Sergey Vojtovich	c88fd54d17	Execute bootstrap in main thread Bootstrap in a separate thread was introduced in `746f0b3b7` to workaround OS/2 small stack size. OS/2 support was discontinued in 2006 and modern operating systems have default stack size a few times larger than default thread_stack and it is tunable. Aim is to reduce usage of LOCK_thread_count and COND_thread_count. Part of MDEV-15135.	7 years ago
Brave Galera Crew	36a2a185fe	Galera4	7 years ago
Michael Widenius	aad0165cea	Added support for BACKUP LOCK / BACKUP UNLOCK	7 years ago
Sachin	f16d4d4c6e	MDEV-17720 slave_ddl_exec_mode=IDEMPOTENT does not handle DROP DATABASE Relevant if exists flag are added for create database and drop database.	7 years ago
Oleksandr Byelkin	c1caada886	MDEV-16278: Missing DELETE operation in COM_STMT_BULK_STMT Allow array binding for DELETE, test it.	7 years ago
Sergey Vojtovich	15eaeace39	MDEV-16987 - ALTER DATABASE possible in read-only mode Forbid ALTER DATABASE under read_only.	7 years ago
Monty	c53aab974b	Added syntax and implementation for BACKUP STAGE's Part of MDEV-5336 Implement LOCK FOR BACKUP - Changed check of Global_only_lock to also include BACKUP lock. - We store latest MDL_BACKUP_DDL lock in thd->mdl_backup_ticket to be able to downgrade lock during copy_data_between_tables()	7 years ago
Monty	e54643a063	Simplify test for updateable TABLE_CATEGORY's - Re-numbered enum_table_category to make some tests easier - Moved TABLE_CATEGORY_INFORMATION to be first CATEGORY of virtual tables - Don't take MDL locks for not updateable table category's	7 years ago
Monty	163b34fe25	Optimize flush tables with read lock (FTWRL) to not wait for select's Part of MDEV-5336 Implement LOCK FOR BACKUP The idea is that instead of waiting in close_cached_tables() for all tables to be closed, we instead call flush_tables() that does: - Flush not used objects in table cache to free memory - Collect all tables that are open - Call HA_EXTRA_FLUSH on the objects, to get them into "closed state" - Added HA_EXTRA_FLUSH support to archive and CSV - Added multi-user protection to HA_EXTRA_FLUSH in MyISAM and Aria The benefit compared to old code is: - FTWRL doesn't have to wait for long running read operations or open HANDLER's	7 years ago
Monty	ecdf97924c	Fixed that CREATE TABLE code used the right create_info - The old code used the original create_info from lex, not the new one that includes more information (like OPT_OR_REPLACE). The bug was not discovered as the code in lock_table_named() only checked for OPT_OR_REPLACE in case of timeout errors. As lock_table_names will be fixed as part of BACKUP STAGE's, there is no changes in lock_table_names() in this commit. - Removed also the 'temporary' copy of statement flags to thd for lock_table_names()	7 years ago
Jan Lindström	1037edcb11	MDEV-17804: Galera tests cause mysql_socket.h:738: inline_mysql_socket_send: Assertion `mysql_socket.fd != -1' failed. Do not do end of statement logic if thd is already killed as socket is already closed.	7 years ago
Jan Lindström	3728b11f87	MDEV-17804: Galera tests cause mysql_socket.h:738: inline_mysql_socket_send: Assertion `mysql_socket.fd != -1' failed. Do not do end of statement logic if thd is already killed as socket is already closed.	7 years ago
Sergei Golubchik	6087e21d91	compilation failure on Windows sql\sql_acl.cc(3114): error C2220: warning treated as error - no 'object' file generated sql\sql_acl.cc(3114): warning C4390: ';': empty controlled statement found; is this the intent?	7 years ago
Sergei Golubchik	329058be29	wsrep: create a macro for the error: label that is used by WSREP_TO_ISOLATION_BEGIN and other galera macros, to avoid the need for wrapping this label in #ifdef WITH_WSREP/#endif	7 years ago
Monty	8cc53aded9	MDEV-17068 mysql system table is marked as crashed and should be repaired after the server crashes or is killed - Changed ERROR to WARNING for MyISAM/Aria message that are warnings in the check utilities. This affects for example "client is using or hasn't closed the table properly". - Print "Table is fixed" if check succeded in fixing the table.	7 years ago
Anel Husakovic	d526679efd	MDEV-14474 information_schema.check_constraints Implement according to standard SQL specification 2008. The check_constraints table is used for fetching metadata about the constraints defined for tables in all databases.	8 years ago
Jan Lindström	c863159c32	MDEV-16799: Test wsrep.variables crash at sql_class.cc:639 thd_get_ha_data Problem was that binlog_hton was not initialized fully when needed i.e. when wsrep_on = true.	7 years ago
Sachin	9827c5e103	MDEV-16192 Table 't' is specified twice, both as a target for 'CREATE' and... as a separate source for data Actually MDEV-15867 and MDEV-16192 are same, Slave adds "or replace" to create table stmt. So create table t1 is create or replace on slave. So this bug is not because of replication, We can get this bug on general server if we manually add or replace to create query. Problem:- So if we try to create table t1 (same name as of temp table t1 ) via CREATE or replace TABLE t AS SELECT * FROM t; Since in this query we are creating table from select * from t1 , we call unique_table function to see whether if source and destination table are same. But there is one issue unique_table does not account if source table is tmp table in this case source and destination table can be same. Solution:- We will change find_dup_table to not to look for temp table if CHECK_DUP_SKIP_TEMP_TABLE flag is on.	7 years ago
sachin	ada54101a7	MDEV-9266 Creating index on temporaray table breaks replication Problem:- Create/drop index was logged into binlog. Goal:- Operation on temporary table should not be binlog when binlog format is row. Solution:- We should add CF_FORCE_ORIGINAL_BINLOG_FORMAT when there is ddl on temp table. For optimize, analyze, repair we wont change anything ,Then will be logged in binlog , But they also dont throw any error if operation fails Since slave wont be having any temp table , but these operation on tmp table will be processed without breaking replication. For rename we need a different logic MDEV-16728 will solve it.	8 years ago

1 2 3 4 5 ...

7347 Commits (b896f60a73aea32843a0a86a35def669d82503af)