mariadb

Tree: b81b194393

Author	SHA1	Message	Date
Vladislav Vaintroub	2a4bd038f7	MDEV-30055 - fix race condition in shutdown_debug.test Remove DBUG_ASSERT, that depends on timing/scheduling to succeed.	3 years ago
Marko Mäkelä	7933367a27	Merge 10.10 into 10.11	3 years ago
Marko Mäkelä	bebe193979	Merge 10.9 into 10.10	3 years ago
Marko Mäkelä	b35a048ece	Merge 10.8 into 10.9	3 years ago
Marko Mäkelä	5b1eb87b6f	Merge 10.7 into 10.8	3 years ago
Marko Mäkelä	7f6ddce7eb	Merge 10.6 into 10.7	3 years ago
Marko Mäkelä	7889aae886	Cleanup: Define less of bulk insert inline trx_mod_table_time_t::write_bulk(): Define non-inline. There are 2 callers, so this will avoid some code duplication. trx_t::bulk_insert_apply(): In the inline function, only check for the condition, and invoke the actual operation in the non-inline function trx_t::bulk_insert_apply_low().	3 years ago
Marko Mäkelä	549e84b4d5	MDEV-30047 innodb.insert_into_empty fails to delete bulk_store InnoDB fails to remove bulk store when InnoDB bulk insert does partial rollback on multiple tables. This memory leak was revealed by a test case that was added in commit `505da21e33` (MDEV-27214). trx_t::bulk_rollback(): Delete the bulk_store. After this function finishes execution, trx_t::is_bulk_insert() will not hold and therefore trx_t::commit_cleanup() will not free the memory. Alternatively, we could define trx_mod_table_time_t::~trx_mod_table_time_t() { delete bulk_store; } but that would likely introduce a performance regression for the common transaction commit. Bulk insert is rarely used. This fix was developed by Thirunarayanan Balathandayuthapani.	3 years ago
Marko Mäkelä	6b083ce851	Merge 10.5 into 10.6	3 years ago
Marko Mäkelä	c9ccd978eb	Fix clang -Winconsistent-missing-override	3 years ago
Marko Mäkelä	5995ca3166	Merge 10.4 into 10.5	3 years ago
Marko Mäkelä	0d586d62e5	MDEV-29613 fixup: Fix Spider	3 years ago
Marko Mäkelä	f46efb4476	Merge 10.7 into 10.8	3 years ago
Marko Mäkelä	d5332086d7	Merge 10.6 into 10.7	3 years ago
Marko Mäkelä	9aea7d83c8	Merge 10.5 into 10.6	3 years ago
Marko Mäkelä	41028d70f6	MDEV-29982 fixup: Relax the test The log overwrite warnings are not being reliably emitted in all debug-instrumented environments. It may be related to the scheduling of some InnoDB internal activity, such as the purging of committed transaction history.	3 years ago
Marko Mäkelä	24fe53477c	MDEV-29603 btr_cur_open_at_index_side() is missing some consistency checks btr_cur_t: Zero-initialize all fields in the default constructor. btr_cur_t::index: Remove; it duplicated page_cur.index. Many functions: Remove arguments that were duplicating page_cur_t::index and page_cur_t::block. page_cur_open_level(), btr_pcur_open_level(): Replaces btr_cur_open_at_index_side() for dict_stats_analyze_index(). At the end, release all latches except the dict_index_t::lock and the buf_page_t::lock on the requested page. dict_stats_analyze_index(): Rely on mtr_t::rollback_to_savepoint() to release all uninteresting page latches. btr_search_guess_on_hash(): Simplify the logic, and invoke mtr_t::rollback_to_savepoint(). We will use plain C++ std::vector<mtr_memo_slot_t> for mtr_t::m_memo. In this way, we can avoid setting mtr_memo_slot_t::object to nullptr and instead just remove garbage from m_memo. mtr_t::rollback_to_savepoint(): Shrink the vector. We will be needing this in dict_stats_analyze_index(), where we will release page latches and only retain the index->lock in mtr_t::m_memo. mtr_t::release_last_page(): Release the last acquired page latch. Replaces btr_leaf_page_release(). mtr_t::release(const buf_block_t&): Release a single page latch. Used in btr_pcur_move_backward_from_page(). mtr_t::memo_release(): Replaced with mtr_t::release(). mtr_t::upgrade_buffer_fix(): Acquire a latch for a buffer-fixed page. This replaces the double bookkeeping in btr_cur_t::open_leaf(). Reviewed by: Vladislav Lesin	3 years ago
Daniel Bartholomew	8283948846	bump the VERSION	3 years ago
Sergei Golubchik	4b3b1eb810	MDEV-25625 Test sys_vars.wsrep_on_without_provider fails: mysqltest: At line 8: query 'SET GLOBAL wsrep_on=ON' failed with wrong errno 1193: 'Unknown system variable 'wsrep_on'', instead of 1210...	3 years ago
Oleksandr Byelkin	bb894f2376	Merge branch '10.10' into bb-10.10-release	3 years ago
Marko Mäkelä	89ec4b53ac	MDEV-29603: Implement btr_cur_t::open_leaf() btr_cur_t::open_leaf(): Replaces btr_cur_open_at_index_side() for most calls, except dict_stats_analyze_index(), which is the only place where we need to open a page at the non-leaf level. Use btr_block_get() for better error handling. Also, use the enumeration type btr_latch_mode wherever possible. Reviewed by: Vladislav Lesin	3 years ago
Marko Mäkelä	6b2d6a81d4	Cleanup: Remove btr_pcur_t::old_stored The Boolean field btr_pcur_t::old_stored mostly duplicates old_rec. Let us remove it.	3 years ago
Marko Mäkelä	8442bc6e13	Cleanup: Remove an unnecessary page lookup btr_cur_search_to_nth_level(): Simply acquire a latch on the already buffer-fixed page. There is no need to release the buffer-fix and re-lookup the page.	3 years ago
Marko Mäkelä	a5ed56cd4f	Cleanup: Remove BTR_MODIFY_EXTERNAL btr_blob_log_check_t::check(): Acquire an index U-latch upfront and pass the flag BTR_MODIFY_LEAF_ALREADY_LATCHED to the search.	3 years ago
Marko Mäkelä	af7bd64edb	Cleanup: Use BTR_INSERT_TREE for pessimistic insert	3 years ago
Marko Mäkelä	b363d9758a	Cleanup: Use the alias BTR_PURGE_TREE for pessimistic delete	3 years ago
Marko Mäkelä	0b25551a61	MDEV-29999 innodb_undo_log_truncate=ON is not crash safe If a log checkpoint occurs at the end LSN of mtr.commit_shrink(space) in trx_purge_truncate_history(), then recovery may fail because it could try to apply too old log records to too old copies of undo log pages. This was repeated with the following test: ./mtr innodb.undo_log_truncate,4k,strict_full_crc32 recv_sys_t::trim(): Move some code to the caller. recv_sys_t::apply(): For undo tablespace truncation, discard all old redo log for the undo tablespace, and then truncate the file to the desired size. Tested by: Matthias Leich	3 years ago
Alexander Barkov	72c728feba	MDEV-29370 Functions in packages are slow and seems to ignore deterministic	3 years ago
Oleksandr Byelkin	2437674291	Merge branch '10.10' into 10.11	3 years ago
Oleksandr Byelkin	695f20f1b5	MDEV-30007 SIGSEGV in st_select_lex_unit::is_derived_eliminated, runtime error: member access within null pointer of type 'struct TABLE' in st_select_lex_unit::is_derived_eliminated() Take into account case of a degenerate subquery (like SELECT 1).	3 years ago
Marko Mäkelä	ae6ebafd81	Merge 10.5 into 10.6	3 years ago
Marko Mäkelä	dc2741be52	MDEV-29984 innodb_fast_shutdown=0 fails to report change buffer merge progress ibuf.size, ibuf.max_size: Changed the type to Atomic_relaxed<ulint> in order to fix some (not all) race conditions. ibuf_contract(): Renamed from ibuf_merge_pages(ulint*). ibuf_merge(), ibuf_merge_all(): Removed. srv_shutdown(): Invoke log_free_check() and ibuf_contract(). Even though ibuf_contract() is not writing anything, it will trigger calls of ibuf_merge_or_delete_for_page(), which will write something. Because we cannot invoke log_free_check() at that low level, we must invoke it at the high level. srv_shutdown_print(): Replaces srv_shutdown_print_master_pending(). Report progress and remaining work every 15 seconds. For the change buffer merge, the remaining work is indicated by ibuf.size.	3 years ago
Marko Mäkelä	744b33c287	Cleanup: Remove a useless header file	3 years ago
Marko Mäkelä	ee7fba1749	MDEV-16264 fixup: Remove unused variables	3 years ago
Marko Mäkelä	c82f3f1b04	MDEV-29978 Corruption errors upon CHECK on temporary InnoDB table row_check_index(): Treat secondary indexes of temporary tables as if SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED is in effect. That is, only consider the delete-mark and nothing else.	3 years ago
Thirunarayanan Balathandayuthapani	704c74cd99	MDEV-29987 Bogus errors about file size in the test mariabackup.defer_space - Changed the page0 perl corruption code in test case to avoid the bogus error in windows	3 years ago
Marko Mäkelä	e0e096faaa	MDEV-29982 Improve the InnoDB log overwrite error message The InnoDB write-ahead log ib_logfile0 is of fixed size, specified by innodb_log_file_size. If the tail of the log manages to overwrite the head (latest checkpoint) of the log, crash recovery will be broken. Let us clarify the messages about this, including adding a message on the completion of a log checkpoint that notes that the dangerous situation is over. To reproduce the dangerous scenario, we will introduce the debug injection label ib_log_checkpoint_avoid_hard, which will avoid log checkpoints even harder than the previous ib_log_checkpoint_avoid. log_t::overwrite_warned: The first known dangerous log sequence number. Set in log_close() and cleared in log_write_checkpoint_info(), which will output a "Crash recovery was broken" message.	3 years ago
Sergei Golubchik	dc37828042	MDEV-29947 Spider doesn't return all rows when doing a join of two tables with no usable keys followup for `57d233e2a6`	3 years ago
Marko Mäkelä	2283f82de5	MDEV-29905 fixup: Remove some unnecessary code srv_shutdown(): Do not call log_free_check(), because it will now be repeatedly called by ibuf_merge_all(). Do not call srv_sync_log_buffer_in_background(), because we do not actually care about durability during shutdown. Log writes will already be triggered by buf_flush_page_cleaner() for writing back modified pages, possibly by log_free_check(). logs_empty_and_mark_files_at_shutdown(): Clean up a condition. This function is the caller of srv_shutdown(), and it will ensure that the log and the buffer pool will be in clean state before shutdown.	3 years ago
Dominik Hassler	5bf5e6eeca	OS detection logic in my_gethwaddr.c is backwards	3 years ago
Aleksey Midenkov	0e6f2757d1	MDEV-29841 More descriptive text for ER_PARTITION_WRONG_TYPE For commands (1) alter table t1 add partition (partition p2); (2) alter table t1 add partition (partition px history); It printed the same error message: Wrong partitioning type, expected type: `SYSTEM_TIME` For (1) it is not clear from the syntax that we are trying to add HASH partition. For (2) it is not clear that the table partitioning is different than SYSTEM_TIME. Now it prints what type we are trying to add to what type of partitioning. Fixed warning unused function rename_field_in_list() for compilation without partitioning.	3 years ago
Alexander Barkov	505da21e33	MDEV-27214 Import with disabled keys corrupts meta-data like rows, indexes, ... This bug was previously fixed in 10.6.11 by: MDEV-28327 InnoDB persistent statistics fail to update after bulk insert Adding MTR tests only. Also, fixing the old test for MDEV-28327 to make "mtr" reliably pass with/without --mysqld=--innodb-stats-persistent=0, and with different page sizes, as suggested by Marko.	3 years ago
Otto Kekäläinen	f4adf35474	Misc Debian/Salsa-CI fixes (#2299 ) * Deb: Handle codename 'n/a' from Debian Sid properly and autobake-deb cleanup This fixes autobake-deb.sh builds on Sid which was visible as 4 failing build steps on Salsa-CI. - In Sid the LSBNAME might evaluate to 'n/a', so accept it as 'Sid' to fix builds that failed with error: Error - unknown release codename n/a - Refactor list to have Ubuntu versions first, then Debian, and as last the special case of Debian Sid - Fix minor syntax issues detected by Shellcheck Also remove useless DEB_HOST_ARCH_CPU check from debian/rules: * It was never in effect as the 'sed' in autobake-deb.sh cleared it anyway * The variable name was wrong and always empty * If variable would have been correct, logic was still reversed - Define 3h timeout as the default 1h timeout on Gitlab.com (and others) is usually not enough for initial (uncached) MariaDB builds. - Replace Buster to Bookworm/Sid upgrade testing with upgrade inside Buster testing as direct upgrades from Stretch to Bullseye and Buster to Bookworm are no longer possible due to: Bug#993755: libcrypt.so.1: cannot open shared object file when upgrading from Stretch to Sid (https://bugs.debian.org/993755) - Stop ignoring MariaDB.org 10.6 to this version upgrade testing failures to reveal bug MDEV-28640. Originally this step was failing as the uring dependencies in upstream builders lagged behind and there was nothing that needed work, only time time to resolve. Now there is an actual bug in packaging that should be visible as a CI failure. - Stop testing for 'service mysql status' on systems that upgraded from MySQL 8.0 to MariaDB.org vended 10.6. Due to some unidentified debian/control changes in 10.6 on upstream the upgrade is no longer compatible in a way that would maintain the init.d script with name 'mysql'. - Fix typos where mergers had changed occurrences of 10.5 to 10.6 while they intentionally need to be exactly 10.5, otherwise the meaning changes. - Align autopkgtest code with downstream official Debian packaging one. This is change is safe on a stable branch because is only affects builds and testing, not any actual usage of MariaDB 10.6. - Standardize on using capitalized 'YES' in CMake build options (instead of 'yes' or mixed case) - Add some comments to better document debian/rules - Fix typo in Lintian overrides Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/mariadb-10.6/+bug/1970634 MariaDB ticket: https://jira.mariadb.org/browse/MDEV-25633 When built with LTO on Ubuntu, MariaDB does not catch an exception when the uring initialization fails due to a low RLIMIT_MEMLOCK value. This commit amends the commit `0609b34555` to be identical to the one done downstream in Debian: `8d20ca979c` This way both the inline comments and 'git blame' for this section will show properly why this is needed, and the fix is one that is fully tested on Debian and Ubuntu. Also having this section fully identical in upstream MariaDB and downstream Debian will make the packaging maintenance easier as 'diff` runs on this file will not flag this as a difference anymore. In MDEV-28640 the init script failed to stop/start the MariaDB server due to missing mysqladmin on the system. This was however very hard to spot from the console output. Add an explicit check for the binary the script depends on, and fail verbosely if the dependency is missing.	3 years ago
Marko Mäkelä	67f4ba240e	MDEV-29996 Duplicated call to buf_page_t::set_ibuf_exist() on recovery mlog_init_t::mark_ibuf_exist(): After applying the changes, invoke clear(). It turns out that multiple calls to recv_sys.apply(true) are possible during recovery. Therefore, we might redundantly invoke mlog_init_t::mark_ibuf_exist() multiple times. Starting with commit `aaef2e1d8c` the call buf_page_t::set_ibuf_exist() is not idempotent, because the flag is actually represented by 2 values of a 3-bit state field.	3 years ago
Marko Mäkelä	da21f3f428	Merge 10.5 into 10.6	3 years ago
Marko Mäkelä	7ee612c912	MDEV-21174 fixup: Remove mtr_t::release_page() mtr_t::release_page(): Remove. The function became unused in commit `56f6dab1d0` when the call was replaced with a call to mtr_t::memo_release().	3 years ago
Marko Mäkelä	91a7e9eb1e	Merge 10.8 into 10.9	3 years ago
Marko Mäkelä	038cd51956	Merge 10.7 into 10.8	3 years ago
Marko Mäkelä	08e2c98ec8	Merge 10.6 into 10.7	3 years ago
Marko Mäkelä	fef9d6ef1d	Add STATS_PERSISTENT=0 to a test This fixes up commit `314ed9f5ec` and commit `9608773f75`	3 years ago

1 2 3 4 5 ...

197261 Commits (b81b1943932a383a92bcd22d053e112198507ae2) All Branches Search

197261 Commits (b81b1943932a383a92bcd22d053e112198507ae2)

All Branches