mariadb

Tree: b7d22a843e

Author	SHA1	Message	Date
Vicențiu Ciorbaru	eb4f2e063c	MDEV-11533: Roles with trailing white spaces are not cleared correctly Role names with trailing whitespaces are truncated in length as of `956e92d908` to fix MDEV-8609. The problem is that the code that creates role mappings expects the string to be null terminated. Add the null terminator to account for that as well. In the future the rest of the code can be cleaned up to never assume c style strings but only LEX_STRINGS.	9 years ago
Alexander Barkov	466728c452	Moving LEX::set_last_field_type() to Column_definition::set_attributes() This is an extraction from the patch for MDEV-10577, which is not directly related to %TYPE implementation. This patch does the following: - Moves LEX::set_last_field_type() to Column_definition::set_attributes() - Adds initialization of Column_definition members length, decimals, charset, on_update into the constructor. - Column_definition::set_attributes() now does not set length and decimal to 0 any more, as they are not initialized in the constructor. - Move Column_definition::prepare_interval_field() from field.h to field.cc, as it's too huge.	9 years ago
Alexander Barkov	7ae95bd0e5	MDEV-11347 Move add_create_index_prepare(), add_key_to_list(), set_trigger_new_row(), set_local_variable(), set_system_variable(), create_item_for_sp_var() as methods to LEX Moving another banch of functions implemented in sql_yacc.yy as methods to LEX, to be able to reuse them between sql_yacc.yy and sql_yacc_ora.yy easier. The list of functions: - add_create_index_prepare() - add_key_to_list() - set_trigger_new_row() - set_local_variable() - set_system_variable() - create_item_for_sp_var()	9 years ago
Alexander Barkov	8a1c0d46eb	MDEV-11346 Move functions case_stmt_xxx and add_select_to_union_list as methods to LEX The full list of functions moved: int case_stmt_action_expr(LEX , Item expr); int case_stmt_action_when(LEX , Item when, bool simple); int case_stmt_action_then(LEX ); bool add_select_to_union_list(LEX ,bool is_union_distinct, bool is_top_level); This is a preparatory change for "MDEV-10142 PL/SQL parser", to reuse the code easier between sql_yacc.yy and coming soon sql_yacc_ora.yy.	9 years ago
Alexander Barkov	b9768dd17c	MDEV-11245 Move prepare_create_field and sp_prepare_create_field() as methods to Column_definition Some upcoming tasks, e.g.: - MDEV-10577 sql_mode=ORACLE: %TYPE in variable declarations - MDEV-10914 ROW data type for stored routine variables will need to reuse the code implemented in prepare_create_field(), sp_prepare_create_field(), prepare_blob_field(). Before reusing this code, it's a good idea to move these global functions as methods to Column_definition. This patch: - actually moves prepare_create_field(), sp_prepare_create_field(), prepare_blob_field() as methods to Column_definition - makes sp_prepare_create_field() call prepare_create_field() at the end, to avoid duplicate code in MDEV-10577 and MDEV-10914. - changes the return data type for prepare_create_field() from int to bool, to make it consistent with all other functions returning "ok" or "error". - moves the implementation sp_head::fill_field_definition() from sp_head.cc to sp_head.h, as it now uses globally visible Column_definition methods, and is very simple, so inlining is now possible. - removes the unused "LEX*" argument from sp_head::fill_field_definition()	9 years ago
Alexey Botchkov	486079d159	MDEV-11440 JSON has become a reserved word in MariaDB. 'JSON' made possible identifier.	9 years ago
Oleksandr Byelkin	098dff10ba	MDEV-11359 Implement IGNORE for bulk operation	9 years ago
Alexander Barkov	9bfde897c3	MDEV-11360 Dynamic SQL: DEFAULT as a bind parameter This patch adds DEFAULT as a possible dynamic SQL parameter, e.g.: EXECUTE IMMEDIATE 'INSERT INTO t1 (column) VALUES(?)' USING DEFAULT; EXECUTE IMMEDIATE 'UPDATE t1 SET column=?' USING DEFAULT; and for similar PREPARE..EXECUTE queries. This is done for symmetry with the STMT_INDICATOR_DEFAULT indicator in the client-server PS protocol. The changes include: - Allowing DEFAULT as a possible option in execute USING clause (sql_yacc.yy) - Adding "virtual bool Item::save_in_param(THD thd, Item_param param)", because "normal" items (that have real values) and Item_default_value have now different actions when assigning itself as an Item_param value. - Fixing switch() statements in a few Item_param methods not to have "default", because it was easy to forget to add a new "case" when adding a new XXX_VALUE value into the enum Item_param::enum_item_param_state. This is important, as we'll be adding new values soon, e.g. for MDEV-11359. Removing "default" helped to find and report bugs MDEV-11361 and MDEV-11362, because DECIMAL_VALUE is obviously not properly handled in some cases.	9 years ago
Alexey Botchkov	ebe5ebba16	MDEV-9143 JSON_xxx functions. The rest of mysql/json functions implemented. CAST AS JSON implemented.	9 years ago
Alexey Botchkov	27025221fe	MDEV-9143 JSON_xxx functions. strings/json_lib.c added as a JSON library. SQL frunction added with sql/item_jsonfunc.h/cc	9 years ago
Kristian Nielsen	19abe79fd1	MDEV-7145: Delayed replication, intermediate commit. Initial merge of delayed replication from MySQL git. The code from the initial push into MySQL is merged, and the associated test case passes. A number of tasks are still pending: 1. Check full test suite run for any regressions or .result file updates. 2. Extend the feature to also work for parallel replication. 3. There are some todo-comments about future refactoring left from MySQL, these should be located and merged on top. 4. There are some later related MySQL commits, these should be checked and merged. These include: `e134b9362b` `b38f0f7857` `fd2b210383` `afc397376e` 5. The testcase from MySQL relies heavily on sleep and timing for testing, and seems likely to sporadically fail on heavily loaded test servers in buildbot or distro build farms. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	9 years ago
Alexander Barkov	5058ced5df	MDEV-7769 MY_CHARSET_INFO refactoring# On branch 10.2 Part 3 (final): removing MY_CHARSET_HANDLER::well_formed_len().	9 years ago
Hartmut Holzgraefe	3234fafebf	MDEV-726 - CREATE and ALTER SERVER need to lowercase host name	9 years ago
Alexander Barkov	46dc7bdf1d	MDEV-10866 Extend PREPARE and EXECUTE IMMEDIATE to understand expressions MDEV-10867 PREPARE..EXECUTE is not consistent about non-ASCII characters	9 years ago
Alexander Barkov	e1a212ebbc	MDEV-10585 EXECUTE IMMEDIATE statement	9 years ago
Alexander Barkov	4c45b820aa	MDEV-10709 Expressions as parameters to Dynamic SQL	9 years ago
Monty	8be53a389c	MDEV-6112 multiple triggers per table This is similar to MysQL Worklog 3253, but with a different implementation. The disk format and SQL syntax is identical with MySQL 5.7. Fetures supported: - "Any" ammount of any trigger - Supports FOLLOWS and PRECEDES to be able to put triggers in a certain execution order. Implementation details: - Class Trigger added to hold information about a trigger. Before this trigger information was stored in a set of lists in Table_triggers_list and in Table_triggers_list::bodies - Each Trigger has a next field that poinst to the next Trigger with the same action and time. - When accessing a trigger, we now always access all linked triggers - The list are now only used to load and save trigger files. - MySQL trigger test case (trigger_wl3253) added and we execute these identically. - Even more gracefully handling of wrong trigger files than before. This is useful if a trigger file uses functions or syntax not provided by the server. - Each trigger now has a "Created" field that shows when the trigger was created, with 2 decimals. Other comments: - Many of the changes in test files was done because of the new "Created" field in the trigger file. This shows up in SHOW ... TRIGGER and when using information_schema.trigger. - Don't check if all memory is released if on uses --gdb; This is needed to be able to get a list from safemalloc of not freed memory while debugging. - Added option to trim_whitespace() to know how many prefix characters was skipped. - Changed a few ulonglong sql_mode to sql_mode_t, to find some wrong usage of sql_mode.	9 years ago
Igor Babaev	3b314ec633	Fixed bug mdev-10933. The bug was caused by a misplaced construct opt_with_clause for one of the variants of CREATE ... SELECT.	9 years ago
Vicențiu Ciorbaru	53cf265b3b	Implement LEAD and LAG and NTH_VALUE functions Refactour out (into a copy for now) the logic of Item_sum_hybrid, to allow for multiple arguments. It does not contain the comparator members. The result is the class Item_sum_hybrid_simple. LEAD and LAG make use of this Item to store previous rows in a chache. It also helps in specifying the field type. Currently LEAD/LAG do not support default values. NTH_VALUE behaves identical to LEAD and LAG, except that the starting position cursor is placed on the top of the frame instead of the current row.	9 years ago
Vicențiu Ciorbaru	9a5930bcdf	Implement first_value and last_value as window functions Currently the implementation doesn't support removal, thus the computation is performed by running over the window frame again.	9 years ago
Igor Babaev	48b4e33596	Allowed to use WITH clauses before SELECT in CREATE ... SELECT and INSERT ... SELECT. Added test cases.	9 years ago
Oleksandr Byelkin	4ec088f2e7	MDEV-8348: Add catchall to all table partitioning for list partitions DEFAULT partition support added to LIST and LIST COLUMN partitioning. Partitions Prunning added for DEFAULT partititon.	9 years ago
Alexander Barkov	dd283db6bc	MDEV-8909 union parser cleanup This is the final patch removing some old remainders that are not needed anymore. (Other clean-ups were done in earlier commits)	9 years ago
Alexey Botchkov	225440047d	MDEV-10421 duplicate CHECK CONSTRAINTs. mysql_prepare_create_table fixed so it doesn't let duplicating constraint names. Syntax for CONSTRAINT IF NOT EXISTS added and handled in mysql_alter_table.	9 years ago
Oleksandr Byelkin	1da21cd4a5	MDEV-10035: DBUG_ASSERT on CREATE VIEW v1 AS SELECT * FROM t1 FOR UPDATE Ability to print lock type added. Restoring correct lock type for CREATE VIEW added.	10 years ago
Jon Olav Hauglid	55a2babcef	Bug#24400628: DEBUG ASSETION KICKS IN WHEN LONG SUBPARTITION NAME IS USED IN CREATE TABLE The problem was that using a very long subpartition name could lead to the server exiting abnormally. This patch fixes the problem by reporting ER_TOO_LONG_IDENT if a name with more than 64 characters are used as partition and subpartition name.	9 years ago
Arun Kuruvila	fd31eea949	Bug #23295288 : HANDLE_FATAL_SIGNAL (SIG=11) IN GET_SERVER_FROM_TABLE_TO_CACHE Description:- Server received SIG11 in the function, "get_server_from_table_to_cache()". Analysis:- Defining a server with a blank name is not handled properly. Fix:- Modified "get_server_from_table_to_cache()" to take care of blank server name.	10 years ago
Sergei Golubchik	8f9530a9ab	revert second lookahead in the lexer it's not enough to look for NOT NULL IS, this also fails queries like SELECT NOT NULL <=> NULL; and adds no value anymore, as the grammar now requires parentheses	10 years ago
Sergei Golubchik	f93a2a3b3b	various cleanups * remove a confusing method name - Field::set_default_expression() * remove handler::register_columns_for_write() * rename stuff * add asserts * remove unlikely unlikely * remove redundant if() conditions * fix mark_unsupported_function() to report the most important violation * don't scan vfield list for default values (vfields don't have defaults) * move handling for DROP CONSTRAINT IF EXIST where it belongs * don't protect engines from Alter_inplace_info::ALTER_ADD_CONSTRAINT * comments	10 years ago
Sergei Golubchik	1b4f0962c1	fix grammar for "DEFAULT (SELECT 1)" not be a syntax error the error should be "subselect is not allowed here", same as for DEFAULT ((SELECT 1))	10 years ago
Alexander Barkov	b3e11d33db	Adding a comment why we need column_default_non_parenthesized_expr (a new rule in sql_yacc.yy)	10 years ago
Michael Widenius	fb67cde237	Use default character set for expressions - Force usage of () around complex DEFAULT expressions - Give error if DEFAULT expression contains invalid characters - Don't use const_charset_conversion for stored Item_func_sysconf expressions as the result is not constaint over different executions - Fixed Item_func_user() to not store calculated value in str_value	10 years ago
Michael Widenius	db7edfed17	MDEV-7563 Support CHECK constraint as in (or close to) SQL Standard MDEV-10134 Add full support for DEFAULT - Added support for using tables with MySQL 5.7 virtual fields, including MySQL 5.7 syntax - Better error messages also for old cases - CREATE ... SELECT now also updates timestamp columns - Blob can now have default values - Added new system variable "check_constraint_checks", to turn of CHECK constraint checking if needed. - Removed some engine independent tests in suite vcol to only test myisam - Moved some tests from 'include' to 't'. Should some day be done for all tests. - FRM version increased to 11 if one uses virtual fields or constraints - Changed to use a bitmap to check if a field has got a value, instead of setting HAS_EXPLICIT_VALUE bit in field flags - Expressions can now be up to 65K in total - Ensure we are not refering to uninitialized fields when handling virtual fields or defaults - Changed check_vcol_func_processor() to return a bitmap of used types - Had to change some functions that calculated cached value in fix_fields to do this in val() or getdate() instead. - store_now_in_TIME() now takes a THD argument - fill_record() now updates default values - Add a lookahead for NOT NULL, to be able to handle DEFAULT 1+1 NOT NULL - Automatically generate a name for constraints that doesn't have a name - Added support for ALTER TABLE DROP CONSTRAINT - Ensure that partition functions register virtual fields used. This fixes some bugs when using virtual fields in a partitioning function	10 years ago
Sergei Golubchik	23d03a1b1e	parse negative numbers into one item use Item->neg to convert generate negative Item_num's instead of Item_func_neg(Item_num). Based on the following commit: Author: Monty <monty@mariadb.org> Date: Mon May 30 22:44:00 2016 +0300 Make negative number their own token The negation (-) operator will call Item->neg() one underlying numeric constants and remove itself (like the NOT() function does today for other NOT functions. This simplifies things - -1 is not anymore an expression but a basic_const_item - improves optimizer - DEFAULT -1 doesn't need special handling anymore - When we add DEFAULT expressions, -1 will be treated exactly like 1 - printing of items doesn't anymore put braces around all negative numbers Other things fixed: - Fixed that longlong converted to decimal's has a more appropriate size - Fixed that "-0.0" read into a decimal is interpreted as 0.0	10 years ago
Sergei Golubchik	c73b987e73	MDEV-8328 Evaluation of two "!" operators depends on space in beetween fix the lexer to backtrack when parsing "<=", "<>", "!=", ">=", "<<", ">>", "<=>".	10 years ago
Otto Kekäläinen	effbe7dd7b	General spell fixing in comments and strings	10 years ago
Alexander Barkov	286416404a	MDEV-10101 Wrong error message of SELECT 1 UNION (SELECT 1 FROM t1 GROUP BY 1 WITH ROLLUP)	10 years ago
Alexander Barkov	caee832df1	MDEV-10124 Incorrect usage of CUBE/ROLLUP and ORDER BY with GROUP_CONCAT(a ORDER BY a) Allowing GROUP_CONCAT(... ORDER BY ..) in queries with ROLLUP. The story of the related code: 1. The original patch from Wax commit: `0b505fb437` date: Tue Mar 18 03:07:40 2003 opt_gorder_clause reused the regular order_clause, which already had some protection against ROLLUP queries: order_clause: ORDER_SYM BY { LEX *lex=Lex; if (lex->current_select->linkage != GLOBAL_OPTIONS_TYPE && lex->current_select->select_lex()->olap != UNSPECIFIED_OLAP_TYPE) { net_printf(lex->thd, ER_WRONG_USAGE, "CUBE/ROLLUP", "ORDER BY"); YYABORT; } } order_list; The assumption that ORDER BY in group_concat() had to have the same ROLLUP restriction (with order_clause) was wrong. Moreover, GROUP_CONCAT() in select_item_list was not affected by this restriction, because WITH ROLLUP goes after select_item_list and therefore sel->olap is always equal to UNSPECIFIED_OLAP_TYPE during select_item_list. GROUP BY was not affected for two reasons: - it goes before WITH ROLLUP and sel->olap is still UNSPECIFIED_OLAP_TYPE - Aggregate functions like AVG(), GROUP_CONCAT() in GROUP BY are not allowed So only GROUP_CONCAT() in HAVING and ORDER BY clauses were erroneously affected by this restriction. 2. Bug#27848 rollup in union part causes error with order of union commit: `3f6073ae63` Author: unknown <igor@olga.mysql.com> 2007-12-15 01:42:46 The condition in the ROLLUP protection code became more complex. Note, opt_gconcat_order still reused the regular order_clause. 3. Bug#16347426 ASSERTION FAILED: (SELECT_INSERT && !TABLES->NEXT_NAME_RESOLUTION_TABLE) \|\| !TAB commit: `2d83663380` author: Chaithra Gopalareddy <chaithra.gopalareddy@oracle.com> date: 2013-04-14 06:00:49 opt_gorder_clause was refactored not to use order_clause and to collect information directly to select->gorder_list. The ROLLUP protection code was duplicated from order_clause to the new version of opt_gorder_clause.	10 years ago
Oleksandr Byelkin	7166069537	MDEV-3944: Allow derived tables in VIEWS	10 years ago
Alexander Barkov	1f89ea8ea0	sql_yacc.yy: Removing union_opt. Using /empty/, union_list, union_order_or_limit instead. This is to get rid of lex->current_select->braces easier (separately in union_list and in union_order_or_limit)	10 years ago
Alexander Barkov	804b00e878	An sql_yacc.yy clean-up - Moving opt_union_order_or_limit inside union_opt, as it's not used in other places any more. - Changing union_opt to have no type. Earlier (before all MDEV-8909 dependency tasks) it had the <num> type, and it's return value was used to generate errors. Now union_opt does not need a return value because the grammar disallows ORDER and LIMIT clauses in wrong context.	10 years ago
Alexander Barkov	c80c3f6759	MDEV-10109 Disallow syntactically INSERT .. SELECT .. {ORDER BY ..\| LIMIT ..} .. UNION ..	10 years ago
Alexander Barkov	ea9a393a86	MDEV-10103 Disallow syntactically UNION SELECT .. PROCEDURE ANALYSE()	10 years ago
Alexander Barkov	9a25c01f78	MDEV-10102 Disallow CREATE VIEW .. PROCEDURE ANALYSE() syntactically	10 years ago
Alexander Barkov	4c0e2960d4	MDEV-10051 Fix subselect to return a syntax error instead of "Incorrect usage of UNION and LIMIT"	10 years ago
Alexander Barkov	a999acf26e	MDEV-10095 Fix derived tables to return a syntax error instead of "Illegal usage of UNION and LIMIT"	10 years ago
Alexander Barkov	349da1d643	sql_yacc.yy: Removing unnecessary init_nested_join() and end_nested_join() from select_derived_init.	10 years ago
Alexander Barkov	c44b2e66a9	A derived_query_specification clean-up (to simplify further MDEV-8909 changes) 1. Better semantic readability: - Moving get_select_lex_derived inside select_derived_init and decomposing it into get_select_lex and $1->init_nested_join(lex->thd) - Moving DBUG_ASSERT($1 == Lex->current_select) inside select_derived_init Now init_nested_join() and end_nested_join() reside inside the same rule select_derived_init. (It's very likely that they can be further removed, as there are no any joins in this rule). 3. Better grammar readability: Moving SELECT_SYM from select_derived_init to derived_query_specification. It's easier to read a rule when it starts from a terminal symbol.	10 years ago
Alexander Barkov	f6a7c1c75a	MDEV-10080 Derived tables allow double LIMIT clause 1. Moving the "\| get_select_lex_derived select_derived_init" part of select_derived into a separate new rule derived_query_specification. 2. Using derived_query_specification directly in select_derived_union rather than in select_derived. 3. Moving the sequence "opt_order_clause opt_limit_clause opt_select_lock_type" from select_derived2 to select_derived_union, after derived_query_specification. Effectively, the parser now does not go through the sequence "opt_order_clause opt_limit_clause ... opt_union_order_or_limit" any more. This fixes the problem with double LIMIT clause and removes 2 shift/reduce conflicts.	10 years ago
Alexander Barkov	c9629daa1e	This patch is a cleanup simplifying upcoming "MDEV-8909 union parser cleanup" changes. When the server parses a query like SELECT * FROM (SELECT 1); a sequence of calls st_select_lex::init_nested_join() .. st_select_lex::end_nested_join() was performed two times (tested in gdb). Both pairs of calls seem to be redundant for a query like this, because there are actually no any joins here. This patch moved "table_ref_select" inside "select_derived", which revealed that one the pairs was definitely redundant: After this transformation we got an init_nested_join() immediately followed by end_nested_join() for the same st_select_lex, which has no any sense. So this pair of calls was removed.	10 years ago

... 5 6 7 8 9 ...

5690 Commits (b7d22a843e36cd5b8695f8ac2b92789d1cf50e4f)