mariadb

Tree: b7d22a843e

Author	SHA1	Message	Date
Alexander Barkov	b7d22a843e	MDEV-16872 Add CAST(expr AS FLOAT)	7 years ago
Vicențiu Ciorbaru	5543b75550	Update FSF Address * Update wrong zip-code	7 years ago
Igor Babaev	09aa5d3f69	MDEV-17894 Assertion `(thd->lex)->current_select' failed in MYSQLparse(), query with VALUES() A table value constructor can be used in all contexts where a select can be used. In particular an ORDER BY clause or a LIMIT clause or both of them can be attached to a table value constructor to produce a new query. Unfortunately execution of such queries was not supported. This patch fixes the problem.	7 years ago
Sergei Golubchik	5d510fdbf0	MDEV-18507 can't update temporary table when joined with table with triggers on read-only triggers are opened and tables used in triggers are prelocked in open_tables(). But multi-update can detect what tables will actually be updated only later, after all main tables are opened. Meaning, if a table is used in multi-update, but is not actually updated, its on-update treggers will be opened and tables will be prelocked, even if it's unnecessary. This can cause more tables to be write-locked than needed, causing read_only errors, privilege errors and lock waits. Fix: don't open/prelock triggers unless table->updating is true. In multi-update after setting table->updating=true, do a second open_tables() for newly added tables, if any.	7 years ago
Sergei Golubchik	5057d46375	bugfix: multi-update checked privileges on views incorrectly it always required UPDATE privilege on views, not being able to detect when a views was not actually updated in multi-update. fix: instead of marking all tables as "updating" by default, only set "updating" on tables that will actually be updated by multi-update. And mark the view "updating" if any of the view's tables is.	7 years ago
Sergei Golubchik	66099b8f2d	cleanup	7 years ago
Sergei Golubchik	3d2d060b62	fix gcc 8 compiler warnings There were two newly enabled warnings: 1. cast for a function pointers. Affected sql_analyse.h, mi_write.c and ma_write.cc, mf_iocache-t.cc, mysqlbinlog.cc, encryption.cc, etc 2. memcpy/memset of nontrivial structures. Fixed as: * the warning disabled for InnoDB * TABLE, TABLE_SHARE, and TABLE_LIST got a new method reset() which does the bzero(), which is safe for these classes, but any other bzero() will still cause a warning * Table_scope_and_contents_source_st uses `TABLE_LIST ` (trivial) instead of `SQL_I_List<TABLE_LIST>` (not trivial) so it's safe to bzero now. added casts in debug_sync.cc and sql_select.cc (for JOIN) * move assignment method for MDL_request instead of memcpy() * PARTIAL_INDEX_INTERSECT_INFO::init() instead of bzero() * remove constructor from READ_RECORD() to make it trivial * replace some memcpy() with c++ copy assignments	7 years ago
Sergei Golubchik	a62e9a83c0	MDEV-15945 --ps-protocol does not test some queries Make mysqltest to use --ps-protocol more use prepared statements for everything that server supports with the exception of CALL (for now). Fix discovered test failures and bugs. tests: * PROCESSLIST shows Execute state, not Query * SHOW STATUS increments status variables more than in text protocol * multi-statements should be avoided (see tests with a wrong delimiter) * performance_schema events have different names in --ps-protocol * --enable_prepare_warnings mysqltest.cc: * make sure run_query_stmt() doesn't crash if there's no active connection (in wait_until_connected_again.inc) * prepare all statements that server supports protocol.h * Protocol_discard::send_result_set_metadata() should not send anything to the client. sql_acl.cc: * extract the functionality of getting the user for SHOW GRANTS from check_show_access(), so that mysql_test_show_grants() could generate the correct column names in the prepare step sql_class.cc: * result->prepare() can fail, don't ignore its return value * use correct number of decimals for EXPLAIN columns sql_parse.cc: * discard profiling for SHOW PROFILE. In text protocol it's done in prepare_schema_table(), but in --ps it is called on prepare only, so nothing was discarding profiling during execute. * move the permission checking code for SHOW CREATE VIEW to mysqld_show_create_get_fields(), so that it would be called during prepare step too. * only set sel_result when it was created here and needs to be destroyed in the same block. Avoid destroying lex->result. * use the correct number of tables in check_show_access(). Saying "as many as possible" doesn't work when first_not_own_table isn't set yet. sql_prepare.cc: * use correct user name for SHOW GRANTS columns * don't ignore verbose flag for SHOW SLAVE STATUS * support preparing REVOKE ALL and ROLLBACK TO SAVEPOINT * don't ignore errors from thd->prepare_explain_fields() * use select_send result for sending ANALYZE and EXPLAIN, but don't overwrite lex->result, because it might be needed to issue execute-time errors (select_dumpvar - too many rows) sql_show.cc: * check grants for SHOW CREATE VIEW here, not in mysql_execute_command sql_view.cc: * use the correct function to check privileges. Old code was doing check_access() for thd->security_ctx, which is invoker's sctx, not definer's sctx. Hide various view related errors from the invoker. sql_yacc.yy: * initialize lex->select_lex for LOAD, otherwise it'll contain garbage data that happen to fail tests with views in --ps (but not otherwise).	7 years ago
Alexey Botchkov	a4c687c494	the opt_constraint_no_id should not have the lex_str type.	7 years ago
Alexey Botchkov	f53e795250	MDEV-17599 ALTER TABLE DROP CONSTRAINT does not work for foreign keys. The list of table constraints doesn't include foreign keys and uniques. So we replace DROP CONSTRAINT with DROP [FOREIGN] KEY in this case.	7 years ago
Andrei Elkin	5d48ea7d07	MDEV-10963 Fragmented BINLOG query The problem was originally stated in http://bugs.mysql.com/bug.php?id=82212 The size of an base64-encoded Rows_log_event exceeds its vanilla byte representation in 4/3 times. When a binlogged event size is about 1GB mysqlbinlog generates a BINLOG query that can't be send out due to its size. It is fixed with fragmenting the BINLOG argument C-string into (approximate) halves when the base64 encoded event is over 1GB size. The mysqlbinlog in such case puts out SET @binlog_fragment_0='base64-encoded-fragment_0'; SET @binlog_fragment_1='base64-encoded-fragment_1'; BINLOG @binlog_fragment_0, @binlog_fragment_1; to represent a big BINLOG. For prompt memory release BINLOG handler is made to reset the BINLOG argument user variables in the middle of processing, as if @binlog_fragment_{0,1} = NULL is assigned. Notice the 2 fragments are enough, though the client and server still may need to tweak their @@max_allowed_packet to satisfy to the fragment size (which they would have to do anyway with greater number of fragments, should that be desired). On the lower level the following changes are made: Log_event::print_base64() remains to call encoder and store the encoded data into a cache but now without doing any formatting. The latter is left for time when the cache is copied to an output file (e.g mysqlbinlog output). No formatting behavior is also reflected by the change in the meaning of the last argument which specifies whether to cache the encoded data. Rows_log_event::print_helper() is made to invoke a specialized fragmented cache-to-file copying function which is copy_cache_to_file_wrapped() that takes care of fragmenting also optionally wraps encoded strings (fragments) into SQL stanzas. my_b_copy_to_file() is refactored to into my_b_copy_all_to_file(). The former function is generalized to accepts more a limit argument to constraint the copying and does not reinitialize anymore the cache into reading mode. The limit does not do any effect on the fully read cache.	7 years ago
Sreeharsha Ramanavarapu	b20d94da35	Bug #28499924 : INCORRECT BEHAVIOR WITH UNION IN SUBQUERY Issue: ------ When a subquery contains UNION the count of the number of subquery columns is calculated incorrectly. Only the first query block in the subquery's UNION is considered and an array indexing goes out-of-bounds, and this is caught by an assert. Solution: --------- Sum up the columns from all query blocks of the query expression. Change specific to 5.6/5.5: --------------------------- The "child" points to the last query block of the UNION (as opposed to 5.7+ where it points to the first member of UNION). So "child->master_unit()->first_select()" is used to reach the first query block of UNION.	7 years ago
Alexander Barkov	2a0b6de41b	MDEV-17253 Oracle compatibility: The REVERSE key word for FOR loop behaves incorrectly	7 years ago
Alexander Barkov	c29c39a7dc	MDEV-17693 Shift/reduce conflicts for NAMES,ROLE,PASSWORD in the option_value_no_option_type grammar	7 years ago
Alexander Barkov	e1dc05a696	MDEV-17687 Add sql_mode specific tokens for keywords BLOB, CLOB, NUMBER, RAW, VARCHAR2	7 years ago
Alexander Barkov	cefef6a704	MDEV-17669 Add sql_mode specific tokens for the keyword DECLARE	7 years ago
Alexander Barkov	7f4aee2233	MDEV-17666 sql_mode=ORACLE: Keyword ELSEIF should not be reserved	7 years ago
Alexander Barkov	f5855ba03d	MDEV-17664 Add sql_mode specific tokens for ':' and '%'	7 years ago
Alexander Barkov	8e6f10335d	A join patch for MDEV-17660 and MDEV-17661 MDEV-17660 sql_mode=ORACLE: Some keywords do not work as label names: history, system, versioning, without MDEV-17661 Add sql_mode specific tokens for the keyword DECODE	7 years ago
Alexander Barkov	def2ac209a	MDEV-17652 Add sql_mode specific tokens for some keywords	7 years ago
Anel Husakovic	d5e1f6a632	Fix typo sql_yacc	7 years ago
Sergei Golubchik	c32f7ed235	MDEV-17377 invalid gap in auto-increment values after LOAD DATA reset lex->many_values for LOAD DATA, as it's used for auto-inc range size estimation.	7 years ago
halfspawn	67f06cadc3	MDEV-17359 Concatenation operator \|\| in like expression	7 years ago
Andrei Elkin	d8974ebd67	MDEV-14431 binlog.binlog_flush_binlogs_delete_domain failed in buildbot The test and also rpl_gtid_delete_domain failed on PPC64 platform due to an incorrectly specified actual key for searching in a gtid domain system hash. While the correct size is 32 bits the supplied value was 8 bytes of long int size on the platform. The problem became evident thanks to the big endiness which cut off the least significant part of the value field. Fixed with correcting a dynamic array initialization to hold now uint32 values as well as the values extraction for searching in the gtid domain system hash. A new added test ensures no overflowed values are accepted for deletion which prevents inadvertent action. Notice though MariaDB [test]> set @@session.gtid_domain_id=(1 << 32) + 1; MariaDB [test]> show warnings; +---------+------+--------------------------------------------------------+ \| Level \| Code \| Message \| +---------+------+--------------------------------------------------------+ \| Warning \| 1292 \| Truncated incorrect gtid_domain_id value: '4294967297' \| +---------+------+--------------------------------------------------------+ MariaDB [test]> select @@session.gtid_domain_id; +--------------------------+ \| @@session.gtid_domain_id \| +--------------------------+ \| 4294967295 \| +--------------------------+	7 years ago
Alexander Barkov	d7b293be87	MDEV-17374 Shift/reduce conflicts because of SOUNDS_SYM, ESCAPE_SYM, USER_SYM not given precedence	7 years ago
Igor Babaev	7419f72b71	Fixed a compiler warning.	7 years ago
Igor Babaev	3473e0452e	MDEV-17154 Multiple selects from parametrized CTE fails with syntax error This patch fills a serious flaw in the implementation of common table expressions. Before this patch an attempt to prepare a statement from a query with a parameter marker in a CTE that was used more than once in the query ended up with a bogus error message. Similarly if a statement in a stored procedure contained a CTE whose specification used a local variables and this CTE was referred to more than once in the statement then the server failed to execute the stored procedure returning a bogus error message on a non-existing field. The problems appeared due to incorrect handling of parameter markers / local variables in CTEs that were referred more than once. This patch fixes the problems by differentiating between the original occurrences of a parameter marker / local variable used in the specification of a CTE and the corresponding occurrences used in copies of this specification. These copies are substituted instead of non-first references to the CTE. The idea of the fix and even some code were taken from the MySQL implementation of the common table expressions.	7 years ago
Sergei Golubchik	710093ccb0	compilation failure	7 years ago
Sergei Golubchik	22bcfa011a	cleanup: FOREIGN_KEY_INFO instead of returning strings for CASCADE/RESTRICT from every storage engine, use enum values Backport of `a3614d33e8`	7 years ago
Igor Babaev	6c6ca907ee	Correction for MDEV-16930.	7 years ago
Igor Babaev	c43d11b96e	MDEV-16930 Crash when VALUES in derived table contains expressions This patch always provides columns of the temporary table used for materialization of a table value constructor with some names. Before this patch these names were always borrowed from the items of the first row of the table value constructor. When this row contained expressions and expressions were not named then it could cause different kinds of problems. In particular if the TVC is used as the specification of a derived table this could cause a crash. The names given to the expressions used in a TVC are the same as those given to the columns of the result set from the corresponding SELECT.	7 years ago
Sreeharsha Ramanavarapu	a653fca99b	Bug #26791931 : INCORRECT BEHAVIOR IN ALTER TABLE REORGANIZE PARTITION Issue: ------ ALTER TABLE REORGANIZE PARTITION .... can result in incorrect behavior if any partition other than the last one misses the "VALUES LESS THAN..." part of the syntax. Root cause: ----------- Currently ALTER TABLE with changes to partitions is handled incorrectly by the parser. Fix: ---- The if condition which handles partition management differently for ALTER TABLE in the parser should be removed. Change the code to handle the case in the parser.	7 years ago
Alexander Barkov	9c53cbdd88	MDEV-15941 Explicit cursor FOR loop does not close the cursor	7 years ago
Alexander Barkov	4787913db0	MDEV-16464 Oracle Comp.: Sql-Error on "SELECT name, comment FROM mysql.proc"	8 years ago
Aleksey Midenkov	b1efff46cd	Vers cleanups * Always-false vers_select_conds_t::from_query * Debug helpers Closes #684	8 years ago
Alexander Barkov	611488e3d9	MDEV-16244 sql_mode=ORACLE: Some keywords do not work in variable declarations 1. Adding LEX::make_item_sysvar() and reusing it in sql_yacc.yy and sql_yacc_ora.yy. Removing the "opt_component" rule. 2. Renaming rules to better reflect their purpose: - keyword to keyword_ident - keyword_sp to keyword_label - keyword_sp_not_data_type to keyword_sp_var_and_label Also renaming: - sp_decl_ident_keyword to keyword_sp_decl for naming consistency - keyword_alias to keyword_table_alias, for consistency with ident_table_alias - keyword_sp_data_type to keyword_data_type, as it has nothing SP-specific. 3. Moving GLOBAL_SYM, LOCAL_SYM, SESSION_SYM from keyword_sp_var_and_label to a separate rule keyword_sysvar_type. We don't have system variables with these names anyway. Adding ident_sysvar_name and using it in the grammar that needs a system variable name instead of ident_or_text. This removed a number of shift/reduce conflicts between GLOBAL_SYM/LOCAL_SYM/SESSION_SYM as a variable scope and as a variable name. 4. Moving keywords BEGIN_SYM, END (in both *.yy fiels) and EXCEPTION_SYM (in sql_yacc_ora.yy) into a separate rule keyword_sp_block_section, because in Oracle verb keywords (COMMIT, DO, HANDLER, OPEN, REPAIR, ROLLBACK, SAVEPOINT, SHUTDOWN, TRUNCATE) are good variables names and can appear in e.g. DECLARE, while block keywords (BEGIN, END, EXCEPTION) are not good variable names and cannot appear in DECLARE. 5. Further splitting keyword_directly_not_assignable in sql_yacc_ora.yy: moving keyword_sp_verb_clause out. Renaming the rest of keyword_directly_not_assignable to keyword_sp_head, which represents keywords that can appear in optional clauses in CREATE PROCEDURE/FUNCTION/TRIGGER. 6. Renaming keyword_sp_verb_clause to keyword_verb_clause, as now it does not contains anything SP-specific. As a result or #4,#5,#6, the rule keyword_directly_not_assignable was replaced to three separate rules: - keyword_sp_block - keyword_sp_head - keyword_verb_clause Adding the same rules in sql_yacc.yy, for unification. 6. Adding keyword_sp_head and keyword_verb_clause into keyword_sp_decl. This fixes MDEV-16244. 7. Reorganizing the rest of keyword related rules into two groups: a. Rules defining a list of keywords and consisting of only terminal symbols: - keyword_sp_var_not_label - keyword_sp_head - keyword_sp_verb_clause - keyword_sp_block_section - keyword_sysvar_type b. Rules that combine the above lists into keyword places: - keyword_table_alias - keyword_ident - keyword_label - keyword_sysvar_name - keyword_sp_decl Rules from the group "b" use on the right side only rules from the group "a" (with optional terminal symbols added). Rules from the group "b" DO NOT mutually use each other any more. This makes them easier to read (and see the difference between them). Sorting the right sides of the group "b" keyword rules alphabetically, for yet better readability.	8 years ago
Alexander Barkov	fe3bf136b6	A cleanup for MDEV-15818 Fix shift-reduce conflicts in the new 10.3 syntax Fixing PERIOD to PERIOD_SYM in the %left command.	8 years ago
Alexander Barkov	7d91d98ac1	A cleanup for `2a33d248e0` - Removing the unused "THD*" paramer from Lex_ident_sys_st::to_size_number() - Removing redundant #include for "sql_tvc.h" and "vers_utils.h"	8 years ago
Alexander Barkov	b73083c57a	Cleanup: fixing shift-reduce conflicts in expr/bool_pri/predicate	8 years ago
Alexander Barkov	cc231c9f1e	A cleanup for `2a33d248e0` - Removing the unused "THD*" paramer from Lex_ident_sys_st::to_size_number() - Removing redundant #include for "sql_tvc.h" and "vers_utils.h"	8 years ago
Alexander Barkov	d69cc7301b	Cleanup: fixing shift-reduce conflicts in expr/bool_pri/predicate	8 years ago
Alexander Barkov	2a33d248e0	MDEV-15975 PL/SQL parser does not understand historical queries Merging the following features from sql_yacc.yy to sql_yacc_ora.yy: - system versioning - column compression - table value constructor - spatial predicate WITHIN - DELETE_DOMAIN_ID	8 years ago
Igor Babaev	de86997160	MDEV-15581 Incorrect result (missing row) with UNION DISTINCT in anchor parts The current code does not support recursive CTEs whose specifications contain a mix of ALL UNION and DISTINCT UNION operations. This patch catches such specifications and reports errors for them.	8 years ago
Alexander Barkov	fdcc95143d	sql_yacc_ora.yy: mering MDEV-13384 "window" seems like a reserved column name but it's not listed as one Merging MDEV-13384 changes from sql_yacc.yy to sql_yacc_ora.yy	8 years ago
Alexander Barkov	023c789a55	MDEV-15818 Fix shift-reduce conflicts in the new 10.3 syntax Fixing shift/reduce conflicts introduced by the new system versioning syntax. Additionally, fixing old shift/reduce conflicts: In PREVIOUS/NEXT being identifiers or sequence operations: SELECT PREVIOUS FROM t1; SELECT PREVIOUS VALUE FOR t1; In TIME/DATE/TIMESTAMP being literals, functions or identifiers: SELECT TIMESTAMP'2001-01-01 10:20:30' FROM t1; SELECT TIMESTAMP('2001-01-01 10:20:30') FROM t1; SELECT TIMESTAMP FROM t1;	8 years ago
Alexander Barkov	50d71c8b37	Cleanup: moving keyword comments such as SQL-2003-R from rules to %token commands Reasoning: - Avoid duplicate comments, both in %token and in the "keyword*" rules. - The space in the rules will be needed for %prec commands.	8 years ago
Alexander Barkov	10d44db5d4	MDEV-16202 Latest changes made erroneously some keywords reserved in sql_mode=ORACLE	8 years ago
Alexander Barkov	48d7038861	Token precedence cleanup in *.yy We'll be fixing soon shift-reduce conflicts introduced in the new 10.3 syntax (see MDEV-15818 for details) by defining precedence for a number of tokens (e.g. TIMESTAMP, TRANSACTION_SYM, TEXT_STRING) and adding "%prec" directives. Before doing this, it's better to have the existing precedences set properly, for easier readability and maintainability. Details: - Changing precedence of NOT to its proper position (between AND and IS). It was wrong. It worked fine only because the relevant grammar reside in different separate rules (expr and predicate). - Moving NOT2_SYM and BINARY to the same line with NEG and ~ It worked fine because operators !, BINARY, ~ do not conflict to each other. - Fixing associativity of NOT_SYM, NOT2_SYM, BINARY, COLLATE_SYM from "right" to "left". They are not dyadic (operate on a single expression only). So "%left" or "%right" is needed only to set precedence, while associativity does not matter. Note, it would be better to use "%precedence" for these tokens instead of "%left" though, but we use an old version of Bison on windows, which may not support %precedence yet. This patch does not change behavior. The generated sql_yacc.cc and sql_yacc_ora.cc are exactly the same before and after this change.	8 years ago
Alexander Barkov	c2df4e9d62	MDEV-16186 Concatenation operator \|\| returns wrong results in sql_mode=ORACLE	8 years ago
Alexander Barkov	2e0c23d82b	Removing redundant "%left INTERVAL_SYM" and "%prec INTERVAL_SYM" These directives did not have any affect. All these affected lines: 1. \| INTERVAL_SYM expr interval '+' expr 2. \| INTERVAL_SYM '(' expr ',' expr ')' 3. \| INTERVAL_SYM '(' expr ',' expr ',' expr_list ')' 4. \| DATE_ADD_INTERVAL '(' expr ',' INTERVAL_SYM expr interval ')' 5. \| DATE_SUB_INTERVAL '(' expr ',' INTERVAL_SYM expr interval ')' define the grammar unambiguously. "bison -v sql_yacc.yy" produces exactly the same sql_yacc.output before and after the change.	8 years ago

1 2 3 4 5 ...

5690 Commits (b7d22a843e36cd5b8695f8ac2b92789d1cf50e4f)