mariadb

Tree: a88c86f67f

Author	SHA1	Message	Date
Anurag Shekhar	90032c1007	Bug #44723 Larger read_buffer_size values can cause performance decrease for INSERTs Bulk inserts (multiple row, CREATE ... SELECT, INSERT ... SELECT) into MyISAM tables were performed inefficiently. This was mainly affecting use cases where read_buffer_size was considerably large (>256K) and low number of rows was inserted (e.g. 30-100). The problem was that during I/O cache initialization (this happens before each bulk insert) allocated I/O buffer was unnecessarily initialized to '\0'. This was happening because of mess in flag values. MyISAM informs I/O cache to wait for free space (if out of disk space) by passing MY_WAIT_IF_FULL flag. Since MY_WAIT_IF_FULL and MY_ZEROFILL have the same values, memory allocator was initializing memory to '\0'. The performance gain provided with this patch may only be visible with non-debug binaries, since safemalloc always initializes allocated memory to 0xA5A5...	16 years ago
monty@mysql.com/narttu.mysql.fi	7887babe69	Moved a lot of old bug fixes and safe cleanups from Maria 5.1 tree to 5.1 - Reserver namespace and place in frm for TABLE_CHECKSUM and PAGE_CHECKSUM create options - Added syncing of directory when creating .frm files - Portability fixes - Added missing cast that could cause bugs - Code cleanups - Made some bit functions inline - Moved things out of myisam.h to my_handler.h to make them more accessable - Renamed some myisam variables and defines to make them more globaly usable (as they are used outside of MyISAM) - Fixed bugs in error conditions - Use compiler time asserts instead of run time - Fixed indentation HA_EXTRA_PREPARE_FOR_DELETE -> HA_EXTRA_PREPARE_FOR_DROP as the old name was wrong (Added a define for old value to ensure we don't break any old code) Added HA_EXTRA_PREPARE_FOR_RENAME as a signal for rename (before we used a DROP signal which is wrong) - Initialize error messages early to get better errors when mysqld or an engine fails to start - Fix windows bug that query_performance_frequency was not initialized if registry code failed - thread_stack -> my_thread_stack_size	18 years ago
monty@mysql.com/narttu.mysql.fi	088e2395f1	WL#3817: Simplify string / memory area types and make things more consistent (first part) The following type conversions was done: - Changed byte to uchar - Changed gptr to uchar* - Change my_string to char * - Change my_size_t to size_t - Change size_s to size_t Removed declaration of byte, gptr, my_string, my_size_t and size_s. Following function parameter changes was done: - All string functions in mysys/strings was changed to use size_t instead of uint for string lengths. - All read()/write() functions changed to use size_t (including vio). - All protocoll functions changed to use size_t instead of uint - Functions that used a pointer to a string length was changed to use size_t* - Changed malloc(), free() and related functions from using gptr to use void * as this requires fewer casts in the code and is more in line with how the standard functions work. - Added extra length argument to dirname_part() to return the length of the created string. - Changed (at least) following functions to take uchar* as argument: - db_dump() - my_net_write() - net_write_command() - net_store_data() - DBUG_DUMP() - decimal2bin() & bin2decimal() - Changed my_compress() and my_uncompress() to use size_t. Changed one argument to my_uncompress() from a pointer to a value as we only return one value (makes function easier to use). - Changed type of 'pack_data' argument to packfrm() to avoid casts. - Changed in readfrm() and writefrom(), ha_discover and handler::discover() the type for argument 'frmdata' to uchar** to avoid casts. - Changed most Field functions to use uchar* instead of char* (reduced a lot of casts). - Changed field->val_xxx(xxx, new_ptr) to take const pointers. Other changes: - Removed a lot of not needed casts - Added a few new cast required by other changes - Added some cast to my_multi_malloc() arguments for safety (as string lengths needs to be uint, not size_t). - Fixed all calls to hash-get-key functions to use size_t. (Needed to be done explicitely as this conflict was often hided by casting the function to hash_get_key). - Changed some buffers to memory regions to uchar to avoid casts. - Changed some string lengths from uint to size_t. - Changed field->ptr to be uchar* instead of char*. This allowed us to get rid of a lot of casts. - Some changes from true -> TRUE, false -> FALSE, unsigned char -> uchar - Include zlib.h in some files as we needed declaration of crc32() - Changed MY_FILE_ERROR to be (size_t) -1. - Changed many variables to hold the result of my_read() / my_write() to be size_t. This was needed to properly detect errors (which are returned as (size_t) -1). - Removed some very old VMS code - Changed packfrm()/unpackfrm() to not be depending on uint size (portability fix) - Removed windows specific code to restore cursor position as this causes slowdown on windows and we should not mix read() and pread() calls anyway as this is not thread safe. Updated function comment to reflect this. Changed function that depended on original behavior of my_pwrite() to itself restore the cursor position (one such case). - Added some missing checking of return value of malloc(). - Changed definition of MOD_PAD_CHAR_TO_FULL_LENGTH to avoid 'long' overflow. - Changed type of table_def::m_size from my_size_t to ulong to reflect that m_size is the number of elements in the array, not a string/memory length. - Moved THD::max_row_length() to table.cc (as it's not depending on THD). Inlined max_row_length_blob() into this function. - More function comments - Fixed some compiler warnings when compiled without partitions. - Removed setting of LEX_STRING() arguments in declaration (portability fix). - Some trivial indentation/variable name changes. - Some trivial code simplifications: - Replaced some calls to alloc_root + memcpy to use strmake_root()/strdup_root(). - Changed some calls from memdup() to strmake() (Safety fix) - Simpler loops in client-simple.c	19 years ago
jani@ua141d10.elisa.omakaista.fi	5c542a4656	Fixed compiler warnings.	19 years ago
msvensson@pilot.blaudden	0b5c41acc7	Bug#25807 LOAD DATA INFILE does not work with Pipes - Additional fix for io_cache_init being called on a closed file	19 years ago
cmiller@zippy.cornsilk.net	9e9dd4327c	Bug#25807: LOAD DATA INFILE does not work with Pipes Showstopper and regression against 5.0.24. Previously, we ignored seek() errors (see Bug#22828) and let seek()s against pipes fail. Now, since we check that a seek didn't fail, and return without reading, this bug popped up. This restores the behavior for file-ish objects that could never be seek()ed.	19 years ago
Kristofer.Pettersson@naruto.	270752654e	Bug#24751 - Possible infinit loop in init_io_cache() when insufficient memory - When cache memory can't be allocated size is recaclulated using 3/4 of the requested memory. This number is rounded up to the nearest min_cache step. However with the previous implementation the new cache size might become bigger than requested because of this rounding and thus we get an infinit loop. - This patch fixes this problem by ensuring that the new cache size always will be smaller on the second and subsequent iterations until we reach min_cache.	19 years ago
thek@kpdesk.mysql.com	0906993457	Cset exclude: thek@kpdesk.mysql.com\|ChangeSet\|20061106104152\|07628	19 years ago
kent@mysql.com/kent-amd64.(none)	226a5c833f	Many files: Changed header to GPL version 2 only	19 years ago
monty@mysql.com/nosik.monty.fi	e825879800	Remove compiler warnings (Mostly in DBUG_PRINT() and unused arguments) Fixed bug in query cache when used with traceing (--with-debug) Fixed memory leak in mysqldump Removed warnings from mysqltest scripts (replaced -- with #)	19 years ago
thek@kpdesk.mysql.com	689a32385a	Bug#23010 _my_b_read() passing illegal file handles to my_seek() - The io cache flag seek_not_done was not set properly in the reinit_io_cache function call and this led my_seek to be called desipite an invalid file handle. - Added a test in reinit_io_cache to ensure we have a valid file handle before setting seek_not_done flag.	19 years ago
cmiller@zippy.cornsilk.net	e235c8c421	Fix merge collision.	19 years ago
thek@kpdesk.mysql.com	12d8f2bf31	Bug#22828 _my_b_read() ignores return values for my_seek() calls - Because my_seek actually is capable of returning an error code we should exploit that in the best possible way. - There might be kernel errors or other errors we can't predict and capturing the return value of all system calls gives us better understanding of possible errors.	19 years ago
Kristofer.Pettersson@naruto.	3b316569a7	Bug#23010 _my_b_read() passing illegal file handles to my_seek() - The io cache flag seek_not_done was not set properly in the reinit_ io_chache function call and this led my_seek to be called despite an invalid file handle. - Added a test in reinit_io_cache to ensure we have a valid file handle before setting seek_not_done flag.	19 years ago
istruewing@chilla.local	5f08a83186	Bug#8283 - OPTIMIZE TABLE causes data loss OPTIMIZE TABLE with myisam_repair_threads > 1 performs a non-quick parallel repair. This means that it does not only rebuild all indexes, but also the data file. Non-quick parallel repair works so that there is one thread per index. The first of the threads rebuilds also the new data file. The problem was that all threads shared the read io cache on the old data file. If there were holes (deleted records) in the table, the first thread skipped them, writing only contiguous, non-deleted records to the new data file. Then it built the new index so that its entries pointed to the correct record positions. But the other threads didn't know the new record positions, but put the positions from the old data file into the index. The new design is so that there is a shared io cache which is filled by the first thread (the data file writer) with the new contiguous records and read by the other threads. Now they know the new record positions. Another problem was that for the parallel repair of compressed tables a common bit_buff and rec_buff was used. I changed it so that thread specific buffers are used for parallel repair. A similar problem existed for checksum calculation. I made this multi-thread safe too.	19 years ago
ingo@mysql.com	718ae78972	Bug#11527 - Setting myisam_repair_threads to >1 leads to corruption A wrong cast led to numeric overflow for data files greater than 4GB. The parallel repair assumed end of file after reading the amount of data that the file was bigger than 4GB. It truncated the data file and noted the number of records it found so far in the index file header as the number of rows in the table. Removing the cast fixed the problem. I added some cosmetic changes too. The normal repair worked because it uses a different function to read from the data file.	20 years ago
jani@a193-229-222-105.elisa-laajakaista.fi	acf218b708	Several fixes revelaled by Intel compiler.	20 years ago
georg@lmy002.wdf.sap.corp	b64e6db5a4	fixes for windows 64-bit compiler warnings	21 years ago
jimw@mysql.com	a33a283a49	Fix change to allow FIFO as log. (Bug #8271 )	21 years ago
jimw@mysql.com	165f2abba5	Avoid doing a seek when first setting up the IO cache for a file, which allows a FIFO to be used for the non-binary logs. (Bug #8271)	21 years ago
jani@ua141d10.elisa.omakaista.fi	8db4423b8c	Fixed Bug#8922. Reverted Jim's patch.	21 years ago
jimw@mysql.com	2ca5cec8c2	Avoid calls to my_seek() and my_tell() on log files so that non-seekable files like FIFOs can be used for logs other than the binlog. (Bug #8271)	21 years ago
monty@mysql.com	a37e91e435	Changed interface for my_strntod() to make it more general and more portable	21 years ago
monty@mysql.com	6d280ac161	Fixed possible access to unintialized memory in filesort when using many buffers	21 years ago
monty@mysql.com	309d691e65	Changed %lx -> 0x%lx (for easier comparison of debug files) Cosmetic cleanups Don't call 'delete_elements' on copy_funcs as this causes elements to be freed twice	22 years ago
konstantin@mysql.com	f08bbd1f12	assert.h needed for my_dbug.h now is included in my_dbug.h, where it for some reason wasn't included before. A lot of files cleaned up from #include <assert.h>	22 years ago
paul@kite-hub.kitebird.com	2f0ca1ce42	Fix skipp -> skip once and for all. (Note: This affects only comments, not variable names.)	22 years ago
dlenev@jabberwock.localdomain	a80f46bfdf	WL#775 "Add status variable identifying binlog_cache_size shortage" Added two status variables: binlog_cache_use - counts number of transactions that used somehow transaction temporary binary log. binlog_cache_disk_use - counts number of transactions that required disk I/O for storing info in this this binary log.	22 years ago
serg@serg.mylan	d8a9a8267b	shared IO_CACHE: protection against remove_io_share in a wrong time bug#3134	22 years ago
monty@mysql.com	4ee44751d9	Fixed memory leak in DROP DATABASE when using RAID tables (Bug #2882 )	22 years ago
ram@gw.mysql.r18.ru	f231d9826b	just tried to find all 'skipp' and replace it with 'skip'.	22 years ago
jani@rhols221.adsl.netsonic.fi	1cc08ed699	Fixed Bug#2123, mysqld segmentation faulted when it tried to open a file that already existed. The problem was that end_io_cache() was called even if init_io_cache() was not. This affected both OUTFILE and DUMPFILE (both fixed). Sometimes wrongly aligned pointer was freed, sometimes mysqld core dumped. Other problem was that select_dump::send_error removed the dumpfile, even if it was created by an earlier run, or by some other program, if the file permissions just permitted it. Fixed it so that the file will only be deleted, if an error occurred, but the file was created by mysqld just a moment ago, in that thread. On the other hand, select_export did not handle the corresponding garbage file at all. Both fixed. After these fixes, a big part of the select_export::prepare and select_dump::prepare code became identical. Merged the code into a new function called create_file(), which is now called by the two latter functions. Regards, Jani	22 years ago
monty@mysql.com	d08945498e	Fixed memory leak with RAID tables Fixed tests for RAID tables Detect uninitialized mutexes on lock and destroy	22 years ago
guilhem@mysql.com	6e32e19047	Use my_b_append instead of my_b_write on a SEQ_READ_APPEND cache, when we write the first 4 bytes of the relay log. Indeed comments in mysys/mf_iocache.c say we must always use my_b_append for such a cache. This could avoid a very rare assertion failure which is: 030524 19:32:38 Slave SQL thread initialized, starting replication in log 'FIRST' at position 0, relay log '/ users/gbichot/4.1.1/mysql-test/var/log/slave-relay-bin.000001' position: 4 030524 19:32:38 next log '/users/gbichot/4.1.1/mysql-test/var/log/slave-relay-bin.000002' is currently active mysqld: mf_iocache.c:701: _my_b_seq_read: Assertion `pos_in_file == info->end_of_file' failed. and which seemed to happen always when the SQL thread and/or the I/O thread were at position 4 in a relay log.	23 years ago
serg@serg.mysql.com	585185d7b8	do not "trust number of broadcasts" in shared IO_CACHE	23 years ago
serg@serg.mysql.com	f29224c6fe	fixed bug in parallel repair	23 years ago
monty@mashka.mysql.fi	6603d75213	New multi-table-update code New (simpler) internal timestamp handling. More debuging to heap tables. Small cleanups to multi-table-delete false -> 0 and true -> 1 (We should use TRUE and FALSE)	23 years ago
monty@hundin.mysql.fi	03b0179af9	Use our version of RWLOCKS on UNIXWARE 7 More DBUG info for replication Better error messages from replication Fixed bug in replication code when connecting to 'localhost' (time was not released properly) Block ALARM signal on Linux for signal handler thread (Fixes problem with running mysqld with --debug) Removed warning when setting an AUTO_INCREMENT field to NULL	24 years ago
monty@hundin.mysql.fi	c99c1fd384	Changed IF(expr, column, NULL) to take type from column Fixed some windows portability problems and removed some compiler warnings Cleaned up QUOTE() function and fixed bug in \0 and \Z handling.	24 years ago
monty@mashka.mysql.fi	2c4fa340cc	Lots of code fixes to the replication code (especially the binary logging and index log file handling) Fixed bugs in my last changeset that made MySQL hard to compile. Added mutex around some data that could cause table cache corruptions when using OPTIMIZE TABLE / REPAIR TABLE or automatic repair of MyISAM tables. Added mutex around some data in the slave start/stop code that could cause THD linked list corruptions Extended my_chsize() to allow one to specify a filler character. Extend vio_blocking to return the old state (This made some usage of this function much simpler) Added testing for some functions that they caller have got the required mutexes before calling the function. Use setrlimit() to ensure that we can write core file if one specifies --core-file. Added --slave-compressed-protocol Made 2 the minimum length for ft_min_word_len Added variables foreign_key_checks & unique_checks. Less logging from replication code (if not started with --log-warnings) Changed that SHOW INNODB STATUS requre the SUPER privilege More DBUG statements and a lot of new code comments	24 years ago
monty@mashka.mysql.fi	dddc20d9d1	New SET syntax & system variables. Made a some new buffers thread specific and changeable. Resize of key_buffer. AUTO_COMMIT -> AUTOCOMMIT Fixed mutex bug in DROP DATABASE Fixed bug when using auto_increment as second part of a key where first part could include NULL. Split handler->extra() to extra() and extra_opt() to be able to support thread specific buffers. Don't write message to error log when slave reconnects becasue of timeout. Fixed possible update problem when using DELETE/UPDATE on small tables (In some cases we used index even if table scanning would be better) A lot of minior code cleanups	24 years ago
serg@sergbook.mysql.com	2fe3fec4e4	parallel repair needs rec_buff local for thread !!!	24 years ago
monty@hundin.mysql.fi	6cb77c6b3e	Portability fixes. Don't free memory from InnoDB at exit (as this may be done before other threads are finnished)	24 years ago
serg@serg.mysql.com	f3e1fb4d4c	post-merge fix	24 years ago
serg@serg.mysql.com	53ac59b913	"myisamchk -p" for parallel recover works (no extensive testing though)	24 years ago
monty@hundin.mysql.fi	6b36860c9c	Made lock_io_cache() and unlock_io_cache() as functions.	24 years ago
serg@serg.mysql.com	5c83ae3fca	multithreaded repair-by-sort code parallel read access to IO_CACHE	24 years ago
monty@mashka.mysql.fi	2aecdd1a91	Big code cleanup/review before 4.0.2 release. (All commit emails since 4.0.1 checked) This had to be done now, before the 4.1 tree changes to much, to make it easy to propagate bug fixes to the 4.1 tree.	24 years ago
monty@hundin.mysql.fi	e4130b11c9	removed init_count from IO_CACHE. Added missing mutex_unlock to slave replication code.	24 years ago
sasha@mysql.sashanet.com	14603a3620	relay_log_space_limit DBUG_ macro cleanup buffer boundary cleanup This changeset, although not fully tested, works for me better than anything I've had so far, including what is in the repository. I will push it unless something crashes while I am writing this :-)	24 years ago

1 2

87 Commits (a88c86f67f57fe19d4018717822bece5f4e50cfc)