mariadb

Tree: 9fe681c9e4

Author	SHA1	Message	Date
Thirunarayanan Balathandayuthapani	9fe681c9e4	MDEV-25509 Atomic DDL: Assertion `err != DB_DUPLICATE_KEY' fails after previous error upon multi-RENAME - InnoDB fails to rename the foreign key constraint while rollbacking the rename operation. In that case, InnoDB should rename the FK constraint too.	5 years ago
Marko Mäkelä	fd8c68c7fe	MDEV-25491 fixup: Race between DROP TABLE and purge of DROP INDEX xdes_get_descriptor_with_space_hdr(): Use the correct mode BUF_GET_POSSIBLY_FREED also when the tablespace is larger than innodb_page_size pages. This function could be called by fseg_free_step(). fsp_alloc_seg_inode(): For completeness (and for improved robustness in case of a corrupted tablespace), use BUF_GET_POSSIBLY_FREED. With this, the entire compilation unit fsp0fsp.cc will use that mode.	5 years ago
Vladislav Vaintroub	f21e159bb5	MDEV-25506 fixup for Windows make os_file_rename_func work on Windows the same as on Unix.	5 years ago
Marko Mäkelä	db0782243c	MDEV-25524 fixup for Windows In commit `54e2e70194` we relaxed a debug assertion in the POSIX version of os_file_rename_func() only. Let us relax it also on Windows, so that the test innodb.truncate_crash will pass.	5 years ago
Marko Mäkelä	54e2e70194	MDEV-25524 heap-use-after-free in fil_space_t::rename() In commit `91599701d0` (MDEV-25312) some recovery code for TRUNCATE TABLE was broken causing a regression in a case where undo log for a RENAME TABLE operation had been durably written but the tablespace had not been renamed yet. row_rename_table_for_mysql(): Add a DEBUG_SYNC point for the test case, and simplify the logic and trim the error messages. fil_space_t::rename(): Simplify the operation. Merge the necessary part of fil_rename_tablespace_check(). If there is no change to the file name, do nothing. dict_table_t::rename_tablespace(): Refactored from dict_table_rename_in_cache(). row_undo_ins_parse_undo_rec(): On rolling back TRX_UNDO_RENAME_TABLE, invoke dict_table_t::rename_tablespace() even if the table name matches. os_file_rename_func(): Temporarily relax an assertion that would fail during the recovery in the test innodb.truncate_crash.	5 years ago
Marko Mäkelä	55e0ce1401	Merge 10.5 into 10.6	5 years ago
Sergei Golubchik	e8b9d8d38c	MDEV-25530 Error 1451 on slave: Cannot delete or update a parent row: a foreign key constraint fails after `dfb41fddf6` tables that failed to drop are excluded from the binlogged DROP TABLE statement. It means that the slave should not expect any errors when executing DROP TABLE, and the binlog should report that no error has happened, even if it was. Do not write error code into the binlogged DROP TABLE, and remove all code that was needed to compute it.	5 years ago
Jan Lindström	aed8605dd1	Update wsrep-lib	5 years ago
mkaruza	c409dd42ef	MDEV-22131 allow transition from unencrypted to TLS cluster communication without cluster downtime Cluster communication should be possible even when: 1. Node 2 is TCP 2. Node 1/3 is dynamic with SSL enabled During test we shutdown Node 2 and enable SSL on it. It should connect back to cluster successfully.	5 years ago
Vladislav Vaintroub	65e73b56d2	MDEV-24382 Assertion in tdc_remove_table The assert is no more reproducible in the lastest 10.5-10.6 The patch only adds testcase from MDEV-24382.	5 years ago
Marko Mäkelä	98e3034eea	MDEV-25534 Assertion lock_table_has...LOCK_IX ha_innobase::start_stmt(): Always set m_prebuilt->sql_stat_start. row_search_mvcc(): Cleanup: Simplify debug assertions.	5 years ago
Marko Mäkelä	a29618f3bd	MDEV-25522: Purge of aborted ADD INDEX leaves orphan locks behind lock_discard_for_index(): New function, to discard locks for an index whose index tree has been purged. By definition, such indexes must be ones for which the MDL upgrade failed in inplace ALTER TABLE and the ADD INDEX operation was never committed. Note: Because we do not support online ADD SPATIAL INDEX, we only have to traverse the lock_sys.rec_hash for B-trees and not the hash tables for R-trees. row_purge_remove_clust_if_poss_low(): Invoke lock_discard_for_index() if necessary before dropping a B-tree for a SYS_INDEXES record.	5 years ago
Marko Mäkelä	5abb505af9	dict_drop_index_tree(): More robust corruption handling	5 years ago
Marko Mäkelä	f619d79bda	MDEV-25491: Race condition between DROP TABLE and purge of SYS_INDEXES record btr_free_if_exists(): Always use the BUF_GET_POSSIBLY_FREED mode when accessing pages, because due to MDEV-24589 the function fil_space_t::set_stopping(true) can be called at any time during the execution of this function. mtr_t::m_freeing_tree: New data member for debugging purposes. buf_page_get_low(): Assert that the BUF_GET mode is not being used anywhere during the execution of btr_free_if_exists(). In all code related to freeing or allocating pages, we will add some robustness, by making more use of BUF_GET_POSSIBLY_FREED and by reporting an error instead of crashing in some cases of corruption.	5 years ago
Marko Mäkelä	a81aec1505	MDEV-25491 preparation: Clean up tablespace destruction fil_check_pending_ops(), fil_check_pending_io(): Remove. These functions were actually duplicating each other ever since commit `118e258aaa` (MDEV-23855). fil_space_t::check_pending_operations(): Replaces fil_check_pending_operations() and incorporates the logic of fil_check_pending_ops(). Avoid unnecessary lookups for the tablespace. Just wait for the reference count to drop to zero. fil_space_t::io(): Remove an unnecessary condition. We can (and probably better should) refuse asynchronous reads of undo tablespaces that are being truncated. fil_truncate_prepare(): Remove. trx_purge_truncate_history(): Implement the necessary steps that used to be in fil_truncate_prepare().	5 years ago
Krunal Bauskar	3f4b7ed95a	MDEV-25093: Adaptive flushing fails to kick in even if innodb_adaptive_flushing_lwm is hit. (possible regression) adaptive flushing should kick in if a. dirty_pct (dirty pages in buffer pool) > innodb_max_dirty_pages_pct_lwm OR b. innodb_adaptive_flushing_lwm limit is reached (default to 10%) both conditions are mutually exclusive and whichever is first to evaluate true should kick-start the adaptive flushing. After recent changes to simplify the flushing algorithm logic, (b) got ignored that introduced the said regression.	5 years ago
Kentoku SHIBA	b3d963fee4	MDEV-22265 Connect string character limit too small for full 64 character InnoDB table-name limit when using ad-hoc Spider server definitions. Fix length for getting default table name.	5 years ago
Marko Mäkelä	559efad44e	Merge 10.4 into 10.5	5 years ago
Marko Mäkelä	90a306a7ab	Merge 10.3 into 10.4	5 years ago
Marko Mäkelä	29b2f3dbb5	MDEV-24545 Sequence created by one connection remains invisible to another row_merge_is_index_usable(): Allow access to any SEQUENCE, even if it was created after the read view. SQL sequences are no-rollback tables with no history at all.	5 years ago
Marko Mäkelä	0785771e57	Merge 10.2 into 10.3	5 years ago
Daniel Black	a35cde8cd8	MDEV-25513: raise systemd LimitNOFILE limits to match server defaults Quoting MDEV reporter Daniel Lewart: Starting MariaDB with default configuration causes the following problems: "[Warning] Could not increase number of max_open_files to more than 16384 (request: 32186)" silently reduces table_open_cache_instances from 8 (default) to 4 Default Server System Variables: extra_max_connections = 1 max_connections = 151 table_open_cache = 2000 table_open_cache_instances = 8 thread_pool_size = 4 LimitNOFILE=16834 is in the following files: support-files/mariadb.service.in support-files/mariadb@.service.in Looking at sql/mysqld.cc lines 3837-3917: wanted_files= (extra_files + max_connections + extra_max_connections + tc_size * 2 * tc_instances); wanted_files+= threadpool_size; Plugging in the default values: wanted_files = (30 + 151 + 1 + 2000 * 2 * 8 + 4) = 32186 However, systemd configuration has LimitNOFILE = 16384, which is far smaller. I suggest increasing LimitNOFILE to 32768.	5 years ago
Marko Mäkelä	4d412e9854	MDEV-24758 heap-use-after-poison in innobase_add_instant_try/rec_copy This is a backport of commit `fd9ca2a742` (MDEV-23295) and commit `9a156e1a23` (MDEV-23345) to 10.3. An instant ADD/DROP/reorder column could create a dummy table object with the wrong ROW_FORMAT when innodb_default_row_format was changed between CREATE TABLE and ALTER TABLE. prepare_inplace_alter_table_dict(): If we had promised that ALGORITHM=INPLACE is supported, we must preserve the ROW_FORMAT. The rest of the changes are related to adding Alter_inplace_info::inplace_supported to cache the return value of handler::check_if_supported_inplace_alter().	5 years ago
Daniel Bartholomew	9db14e93ac	bump the VERSION	5 years ago
Marko Mäkelä	dd07cfcecd	MDEV-15756: Remove some garbage output os_aio_print(): Remove output that should have been removed in commit `5e62b6a5e0` (MDEV-16264).	5 years ago
Daniele Sciascia	9e6310e323	Fix MTR test wsrep.variables_debug The test was changing variable wsrep_provider dynamically, but wsrep_provider was recently made read-only. followup for `ce3a2a688d`	5 years ago
Marko Mäkelä	ed4b2b3f95	Merge 10.5 into 10.6	5 years ago
Sujatha	391f1aa6ee	MDEV-24773: slave_compressed_protocol doesn't work properly with semi-sync replication Back port upstream fix commit `1800b015a1` Author: Venkatesh Duggirala <venkatesh.duggirala@oracle.com> Date: Fri Sep 8 20:29:22 2017 +0530 Bug#26027024 SLAVE_COMPRESSED_PROTOCOL DOESN'T WORK WITH SEMI-SYNC REPLICATION IN MYSQL-5.7 Analysis: In mysql-5.6, dump thread (the thread that is created on Master after Slave requested for a binlog dump) is also used to receive acknowledgements from the Slave and act on them accordingly. For performance reasons, a special thread called Ack Receiver thread is added in mysql-5.7 Semi synchronous replication plugin. This thread does not have special handling to receive acknowledgements if Slave has enabled compression in the protocol. Hence Master is unable to handle any slave if Slave_compressed_protocol is enabled on it. Fix: Enable compress flag on the communication channels if the Slave has Slave_compressed_protocol ON.	5 years ago
Sergei Petrunia	2f6912dabc	MDEV-24898: Server crashes in st_select_lex::next_select (trivial backport to 10.2) Add a testcase	5 years ago
Sergei Petrunia	c72c77ca3b	MDEV-24925: Server crashes in Item_subselect::init_expr_cache_tracker (trivial backport to 10.2) The optimizer removes redundant GROUP BY operations. If GROUP BY element is a subselect, it is "eliminated". However one must not eliminate the item if it is used both in the select list and in the GROUP BY, like so: select (select ... ) as SUBQ from ... group by SUBQ Do not eliminate such items.	5 years ago
Marko Mäkelä	b81382887c	MDEV-25512 Deadlock between sux_lock::u_x_upgrade() and sux_lock::u_lock() In the SUX_LOCK_GENERIC implementation, we can remember at most one pending exclusive lock request. If multiple exclusive lock requests are pending, the WRITER_WAITING flag will be cleared when the first waiting writer acquires the exclusive lock. ssux_lock_low::update_lock(): If WRITER_WAITING is set, wake up the writer even if the UPDATER flag is set, because the waiting writer may be in the process of upgrading its U lock to X. rw_lock::read_unlock(): Also indicate that an X lock waiter must be woken up if an U lock exists. This fix may cause unnecessary wake-ups and system calls, but this is the best that we can do. Ideally we would use the MDEV-25404 idea of a separate 'writer' mutex, but there is no portable way to request that a non-recursive mutex be created, and InnoDB requires the ability to transfer buf_block_t::lock ownership to an I/O thread. To allow problems like this to be caught more reliably in the future, we add a unit test for srw_mutex, srw_lock, ssux_lock, sux_lock.	5 years ago
Marko Mäkelä	4725792bf3	Merge 10.4 into 10.5	5 years ago
Sergei Petrunia	42aad65b89	MDEV-24898: Server crashes in st_select_lex::next_select Add a testcase	5 years ago
Sergei Petrunia	393cf51c04	MDEV-24925: Server crashes in Item_subselect::init_expr_cache_tracker The optimizer removes redundant GROUP BY operations. If GROUP BY element is a subselect, it is "eliminated". However one must not eliminate the item if it is used both in the select list and in the GROUP BY, like so: select (select ... ) as SUBQ from ... group by SUBQ Do not eliminate such items.	5 years ago
Marko Mäkelä	e4394cc547	Merge 10.3 into 10.4	5 years ago
Igor Babaev	2c9bf0ae87	This commit adds the same call of st_select_lex::set_unique_exclude() that complemented the fix for MDEV-24823 in 10.2. As it is the only call of this function in 10.3 the commit also has added the code of the function.	5 years ago
Marko Mäkelä	c425d93b92	Merge 10.2 into 10.3 except commit `1288dfffe7`	5 years ago
Marko Mäkelä	14a18d7d7f	MDEV-23026/MDEV-25474 fixup: Assertion ib_table->stat_initialized It is possible that an object that was originally created by open_purge_table() will remain cached and reused for SQL execution. Our previous fix wrongly assumed that ha_innobase::open() would always be called before SQL execution starts. Therefore, we must invoke dict_stats_init() in ha_innobase::info_low() instead of only doing it in ha_innobase::open(). Note: Concurrent execution of dict_stats_init() on the same table is possible, but it also was possible between two calls to ha_innobase::open(), with no ill effects observed. This should fix the assertion failure on stat_initialized. A possibly easy way to reproduce it would have been to run the server with innodb_force_recovery=2 (disable the purge of history), update a table so that an indexed virtual column will be affected, and finally restart the server normally (purge enabled), to observe a crash when the table is accessed from SQL. The problem was first observed and this fix verified by Elena Stepanova. Also Thirunarayanan Balathandayuthapani repeated the problem.	5 years ago
Marko Mäkelä	25ed665a20	MDEV-25459 MVCC read from index on CHAR or VARCHAR wrongly omits rows row_sel_sec_rec_is_for_clust_rec(): If the field in the clustered index record stored off page, always fetch it, also when the secondary index field has been built on the entire column. This was broken ever since the InnoDB Plugin for MySQL Server 5.1 introduced ROW_FORMAT=DYNAMIC and ROW_FORMAT=COMPRESSED for InnoDB tables. That code was first introduced in this tree in commit `3945d5e554`. For the original ROW_FORMAT=REDUNDANT and the MySQL 5.0.3 ROW_FORMAT=COMPRESSED, there was no problem, because for those tables we always stored at least a 768-byte prefix of each column in the clustered index record. row_sel_sec_rec_is_for_blob(): Allow prefix_len==0 for matching the full column.	5 years ago
Igor Babaev	1288dfffe7	This patch complements the patch for MDEV-24823.	5 years ago
Aleksey Midenkov	42f8548ff6	MDEV-25091 CREATE TABLE: field references qualified by a wrong table name succeed Before FRM is written walk vcol expressions through check_table_name_processor() and check if field items match (db, table_name) qualifier. We cannot do this in check_vcol_func_processor() as there is already no table name qualifiers in expressions of written and loaded FRM.	5 years ago
Aleksey Midenkov	4649ba7493	MDEV-23455 Hangs + Sig11 in unknown location(s) due to single complex FK query Buffer overflow in ib_push_warning() fixed by using vsnprintf(). InnoDB parser was obsoleted by MDEV-16417. Thanks to Nikita Malyavin for review and suggestion.	5 years ago
Sergei Golubchik	018d7440fd	remove EXCEPTIONS-CLIENT It's Oracle libmysqlclient license exception, we no longer include, build or ship libmysqlclient	5 years ago
Marko Mäkelä	1a647b700f	MDEV-25487 Assertion failed in lock_rec_move row_ins_clust_index_entry_low(): Do not enable bulk insert if any record locks exist on the table. Bulk insert is assumed to be covered only by an exclusive table lock, with no row-level locking or undo logging.	5 years ago
Sujatha	ee20e26dbb	MDEV-20220 post push fix Remove garbage files.	5 years ago
Igor Babaev	e3a25793be	MDEV-24823 Crash with invalid multi-table update of view in 2nd execution of SP Before this patch mergeable derived tables / view used in a multi-table update / delete were merged before the preparation stage. When the merge of a derived table / view is performed the on expression attached to it is fixed and ANDed with the where condition of the select S containing this derived table / view. It happens after the specification of the derived table / view has been merged into S. If the ON expression refers to a non existing field an error is reported and some other mergeable derived tables / views remain unmerged. It's not a problem if the multi-table update / delete statement is standalone. Yet if it is used in a stored procedure the select with incompletely merged derived tables / views may cause a problem for the second call of the procedure. This does not happen for select queries using derived tables / views, because in this case their specifications are merged after the preparation stage at which all ON expressions are fixed. This patch makes sure that merging of the derived tables / views used in a multi-table update / delete statement is performed after the preparation stage. Approved by Oleksandr Byelkin <sanja@mariadb.com>	5 years ago
Igor Babaev	b3b5d57e78	MDEV-24823 Crash with invalid multi-table update of view in 2nd execution of SP Before this patch mergeable derived tables / view used in a multi-table update / delete were merged before the preparation stage. When the merge of a derived table / view is performed the on expression attached to it is fixed and ANDed with the where condition of the select S containing this derived table / view. It happens after the specification of the derived table / view has been merged into S. If the ON expression refers to a non existing field an error is reported and some other mergeable derived tables / views remain unmerged. It's not a problem if the multi-table update / delete statement is standalone. Yet if it is used in a stored procedure the select with incompletely merged derived tables / views may cause a problem for the second call of the procedure. This does not happen for select queries using derived tables / views, because in this case their specifications are merged after the preparation stage at which all ON expressions are fixed. This patch makes sure that merging of the derived tables / views used in a multi-table update / delete statement is performed after the preparation stage. Approved by Oleksandr Byelkin <sanja@mariadb.com>	5 years ago
Sergei Golubchik	b8fad8c6bf	MDEV-25030 Upgrade to 10.5.9 breaks root's ability to grant	5 years ago
Sergei Golubchik	a40f29ab19	MYSQL_MAINTAINER_MODE fixes * MSVC check was lost in a bad merge * add a comment * move AIX check where it belongs and where it would still allow -Werror, if desired	5 years ago
Marko Mäkelä	bfc0110b9b	Null-merge the revert of MDEV-24589 While MDEV-24589 causes the regression MDEV-25491 Race condition between DROP TABLE and purge of SYS_INDEXES record we must not revert it from 10.6, because MDEV-24589 is a prerequisite for MDEV-25180 Atomic ALTER TABLE that is targeting 10.6. The regression will be dealt with later.	5 years ago

1 2 3 4 5 ...

192639 Commits (9fe681c9e4db6f2ffde058773bbf83c471862318) All Branches Search

192639 Commits (9fe681c9e4db6f2ffde058773bbf83c471862318)

All Branches