mariadb

Tree: 9c85ced30d

Author	SHA1	Message	Date
Jan Lindström	9c85ced30d	Merge fix.	12 years ago
unknown	2f6a2494a5	MDEV-4708: GTID strict mode doesn't work on a database with purged binlogs When a new master is provisioned that does not have any old binlogs, the @@gtid_slave_pos is used to know where in the GTID history the provisioning happened. A slave is allowed to connect at the point of this value of @@gtid_slave_pos, even if that GTID is not in the binlogs on the new master. The code to handle this case when the binlog on the newly provisioned master is completely empty was just wrong (couple of typos). Clearly it had never been tested ... :-/	13 years ago
unknown	1e43277838	MDEV-4708: GTID strict mode doesn't work on a database with purged binlogs When a new master is provisioned that does not have any old binlogs, the @@gtid_slave_pos is used to know where in the GTID history the provisioning happened. A slave is allowed to connect at the point of this value of @@gtid_slave_pos, even if that GTID is not in the binlogs on the new master. But --gtid-strict-mode did not correctly handle this case. When strict mode was enabled, an attempt to connect at the position would cause an error about holes in the binlog, which is not correct. This patch adds a hash of GTIDs that need to be treated specially by GTID strict mode to deal correctly with this case.	13 years ago
Michael Widenius	5f1f2fc0e4	Applied all changes from Igor and Sanja	13 years ago
unknown	b5fcf33d24	MDEV-4490: Old-style master position points at the last GTID event after slave restart Now whenever we reach the GTID point requested from the slave (when using GTID position to connect), we send a fake Gtid_list event. This event is used by the slave to know the current old-style position for MASTER_POS_WAIT(), and later the similar binlog position for MASTER_GTID_WAIT(). Without this fake event, if the slave is already fully up-to-date with the master, there may be no events sent at the given position for an indeterminate time.	13 years ago
unknown	7b6ab5638a	MDEV-4483: CHANGE MASTER TO master_use_gtid=xxx looses old-style coordinates. There was some old code that cleared the position in CHANGE MASTER, it was forgotten to be removed. In addition, add code that saves/restores the old-style position when we nuke the old relay logs as part of GTID slave start. Normally we will not use these, but it could be useful in case the GTID connect fails and user wants to go back to the old-style coordinates.	13 years ago
unknown	5cb486d159	MDEV-26: Global transaction ID. Fix problems related to reconnect. When we need to reconnect (ie. explict stop/start of just the IO thread by user, or automatic reconnect due to loosing network connection with the master), it is a bit complex to correctly resume at the right point without causing duplicate or missing events in the relay log. The previous code had multiple problems in this regard. With this patch, the problem is solved as follows. The IO thread keeps track (in memory) of which GTID was last queued to the relay log. If it needs to reconnect, it resumes at that GTID position. It also counts number of events received within the last, possibly partial, event group, and skips the same number of events after a reconnect, so that events already enqueued before the reconnect are not duplicated. (There is no need to keep any persistent state; whenever we restart slave threads after both of them being stopped (such as after server restart), we erase the relay logs and start over from the last GTID applied by SQL thread. But while the SQL thread is running, this patch is needed to get correct relay log).	13 years ago
unknown	385780f571	MDEV-4485: Master did not allow slave to connect from the very start (empty GTID pos) if GTIDs from other multi_source master was present The idea in the code was to protect the user that tries to connect a slave to a master with completely different domains than what was intended. If none of the domains in the start position are present at all in the master binlog, we gave an error. However, this is a stupid idea. Because when a slave connects to a master to start replication from the very start of binlogs - such as when setting up new master->slave servers from scratch - there will be just this situation, the requested slave position is empty for all the domains in the master's binlog. So the code that gives this error is wrong, and the solution is simply to remove it.	13 years ago
unknown	ee2b7db3f8	MDEV-4478: Implement GTID "strict mode" When @@GLOBAL.gtid_strict_mode=1, then certain operations result in error that would otherwise result in out-of-order binlog files between servers. GTID sequence numbers are now allocated independently per domain; this results in less/no holes in GTID sequences, increasing the likelyhood that diverging binlogs will be caught by the slave when GTID strict mode is enabled.	13 years ago
unknown	1cd6eb5f94	MDEV-26: Global transaction ID. Change of user interface to be more logical and more in line with expectations to work similar to old-style replication. User can now explicitly choose in CHANGE MASTER whether binlog position is taken into account (master_gtid_pos=current_pos) or not (master_gtid_pos= slave_pos) when slave connects to master. @@gtid_pos is replaced by three separate variables @@gtid_slave_pos (can be set by user, replicated GTIDs only), @@gtid_binlog_pos (read only), and @@gtid_current_pos (a combination of the two, most recent GTID within each domain). mysql.rpl_slave_state is renamed to mysql.gtid_slave_pos to match. This fixes MDEV-4474.	13 years ago
unknown	d795bc9ff8	Fix race condition in binlog dump thread during server shutdown. There was missing a check for THD::killed after THD::enter_cond(). This could cause the binlog dump thread to miss the kill signal during server shutdown and hang until it was force-closed. Also fix a race in a test case that occasionally fails in Buildbot.	13 years ago
unknown	9fae993024	MDEV-26: Global transaction ID. Implement START SLAVE UNTIL master_gtid_pos = "<GTID position>". Add test cases, including a test showing how to use this to promote a new master among a set of slaves.	13 years ago
unknown	5aa0d185ca	MDEV-4473: mysql_binlog_send() starts sending events from wrong GTID position in some master failover scenarios Suppose binlog file X has in its Gtid_list_event: 0-1-3,0-2-5, and suppose the slave requests to start replicating after 0-1-3. In this case the bug was that master would start sending events from the start of X. This is wrong, because 0-2-4 and 0-2-5 are contained in X-1, and are needed by the slave. So these events were lost. On the other hand, if the slave requested 0-2-5, then it _is_ correct to start sending from the beginning of binlog file X, because 0-2-5 is the last GTID logged in earlier binlogs. The difference is that 0-2-5 is the last of the GTIDs in the Gtid_list_event. The problem was that the code did not check that the matched GTID was the last one in the list. Fixed by checking if the gtid requested by slave that matches a gtid in the Gtid_list_event is the last event for that domain in the list. If not, go back to a prior binlog to ensure all needed events are sent to slave. mysql-test/include/show_events.inc: Backport --let $binlog_file=LAST, used by MDEV-4473 test case.	13 years ago
Michael Widenius	8cdb118a0a	Fixed: MDEV-4352; LOAD DATA was not multi-source safe - Calls to cleanup_load_tmpdir() could delete temporary files for another master connection - Concurrent LOAD DATA commands from two master connections could use the same file name Other bug fixes: - Enlarge buffer for connection names with 'special characters' one can't store in filenames Optimization: - Don't do 'lower case' of connection names. We can use cmp_connection_name, where we already have the connection name in lower case. mysql-test/suite/multi_source/load_data.result: Test case for MDEV-4352 mysql-test/suite/multi_source/load_data.test: Test case for MDEV-4352 sql/log_event.cc: Fixed: MDEV-4352 - Calls to cleanup_load_tmpdir() could delete temporary files for another master connection - Concurrent LOAD DATA commands from two master connections could use the same file name The fix was to add the connection name (if one exists) to all slave temporary files used by LOAD DATA sql/rpl_mi.cc: Enlarge buffer for connection names with 'special characters' one can't store in filenames Use mi->cmp_connection_name for connection file names. sql/rpl_rli.cc: Use mi->cmp_connection_name for connection file names. sql/slave.cc: Removed not needed empty line sql/sql_const.h: Added MAX_FILENAME_MBWIDTH to be able to calculate buffer length for connection_names stored in file names sql/sql_repl.cc: Use mi->cmp_connection_name for connection file names.	13 years ago
unknown	59830e1ab8	MDEV-4446: Incorrect handling of binlog checksum when searching for GTID start position in binlog When the slave connects, the master skips binlog event groups until it reaches the position requested by the slave. To identify event groups, it needs to detect COMMIT events. But this detection did not correctly handle binlog checksums, so could incorrectly skip extra groups due to not detecting the end of an event group.	13 years ago
unknown	203264ddc9	Fix unsigned/signed conversion bug in event type during mysql_binlog_send(). Since event types can be >=128 and are read from a (possibly signed) char pointer, we need to cast to unsigned char before extending to int, or we will get an incorrect negative number. This was done in the main code path already, but there is a rare case where we check for new events first without a lock and then again with the lock. If the second check succeeds because a new event turns up at just the right time, then we took a code path that was missing the correct unsigned char cast, leading to incorrect handling of events for old slave servers and possibly other grief. (This was found from a sporadic failure in Buildbot of test case rpl_mariadb_slave_capability).	13 years ago
unknown	6b97512b21	Add missing check for thd->killed in mysql_binlog_send(). The slave dump thread running on the master only checked thd->killed whenever it reached the end of a binlog file, not between events. This could unnecessarily delay server shutdown. This was found by code inspection while tracking down some occasional "forcing close of thread..." errors in Buildbot. Hopefully this will fix the failures, but the fix is correct in any case. Also increase the wait during server shutdown, 2 seconds is a bit tight in case of heavy I/O stall, and it seems better to delay shutdown a bit than force-kill threads unnecessarily. Also fix some races in test cases that restart the mysqld server. The .expect file should be changed with --append_file, --remove_file + --write_file creates a short window where mysqld can error out due to .expect file missing.	13 years ago
Sergei Golubchik	84ce6832e6	MDEV-4332 Increase username length from 16 characters	13 years ago
Sergei Golubchik	07315d3603	strmake_buf(X,Y) helper, equivalent to strmake(X,Y,sizeof(X)-1) with a bit of lame protection against abuse.	13 years ago
Sergei Golubchik	4ec6fe10e5	remove ULL() and LL(), because they're totally unnecessary and sometimes harmful (used with expressions)	13 years ago
unknown	b7363eb4ac	MDEV-26: Global transaction ID. Replace CHANGE MASTER TO ... master_gtid_pos='xxx' with a new system variable @@global.gtid_pos. This is more logical; @@gtid_pos is global, not per-master, and it is not affected by RESET SLAVE. Also rename master_gtid_pos=AUTO to master_use_gtid=1, which again is more logical.	13 years ago
unknown	c2cbc9cee6	MDEV-26: Global transaction ID. Move combining slave and gtid binlog state into a separate function. Make SHOW ALL SLAVES STATUS use the same function, so it shows the same value used by slave connect. Add a test case.	13 years ago
Sujatha Sivakumar	d054027c4b	Bug#14324766:PARTIALLY WRITTEN INSERT STATEMENT IN BINLOG NO ERRORS REPORTED Problem: ======= Errors from my_b_fill are ignored. MYSQL_BIN_LOG::write_cache code assumes that 0 returned from my_b_fill always means end-of-cache, but that is incorrect. It can result in error and the error is ignored. Other callers of my_b_fill don't check for error: my_b_copy_to_file, maybe my_b_gets. Fix: === An error handler is already present to check the "cache" error that is reported during "MYSQL_BIN_LOG::write_cache" call. Hence error handlers are added for "my_b_copy_to_file" and "my_b_gets". During my_b_fill() function call, when the cache read fails info->error= -1 is set. Hence a check for "info->error" is added for the above to callers upon their return. mysys/mf_iocache2.c: Added a check for "cache->error" and simulation of cache read failure mysys/my_read.c: Simulation of read failure sql/log_event.cc: Added debug simulation sql/sql_repl.cc: Added a check for cache error	13 years ago
unknown	0fdbdde474	MDEV-26: Global transaction ID. Implement test case rpl_gtid_stop_start.test to test normal stop and restart of master and slave mysqld servers. Fix a couple bugs found with the test: - When InnoDB is disabled (no XA), the binlog state was not read when master mysqld starts. - Remove old code that puts a bogus D-S-0 into the initial binlog state, it is not correct in current design. - Fix memory leak in gtid_find_binlog_file().	13 years ago
unknown	cb65cee82a	MDEV-26: Global transaction ID. When slave requested to start at some GTID, and that GTID was the very last event (within its replication domain) in some binlog file, we did not allow the binlog dump thread on the master to start from the beginning of a following binlog file. This is a problem, since the binlog file containing the GTID is likely to be purged if the replication domain is unused for long. With this fix, if the Gtid list event at the start of a binlog file contains exactly the GTID requested by the slave, we allow to start the binlog dump thread from this file, taking care not to skip any events from that domain in the file.	13 years ago
unknown	20e021115f	MDEV-26: Global transaction ID. Fix MDEV-4329. When user does CHANGE MASTER TO MASTER_GTID_POS='<explicit GTID state>', we check that this state does not conflict with the binlog. But the code forgot to give an error in the case where a domain was completely missing from the requested position (eg. MASTER_GTID_POS='').	13 years ago
unknown	f66e3474a8	MDEV-26: Global transaction ID. Fix missing error check for applying Gtid_log_event. Fix a couple compiler warnings.	13 years ago
Michael Widenius	068c61978e	Temporary commit of 10.0-merge	13 years ago
unknown	a3f651d0f6	MDEV-26: Global transaction ID. Fix checksums for the new GTID events (reported by Pavel Ivanov). Fix printing of GTID_LIST_EVENT.	13 years ago
unknown	e590f89114	MDEV-26: Global transaction ID. Fix MDEV-4278: Slave does not check that master understands GTID. Now the slave will abort with a suitable error if an attempt is made to connect with GTID to a master that does not support GTID.	13 years ago
unknown	9bb989a9d1	MDEV-26: Global transaction ID. Fix MDEV-4275 - I/O thread restart duplicates events in the relay log. The first time we connect to master after CHANGE MASTER or restart, we connect from the GTID position. But then subsequent reconnects or IO thread restarts reconnect with the old-style file/offset binlog pos from where it left off at last disconnect. This is necessary to avoid duplicate events in the relay logs, as there is nothing that synchronises the SQL thread update of GTID state (multiple threads in case of multi-source) with IO thread reconnects. Test cases. Some small cleanups and fixes.	13 years ago
unknown	9d9ddad759	MDEV-26: Global transaction ID. Fix things so that a master can switch with MASTER_GTID_POS=AUTO to a slave that was previously running with log_slave_updates=0, by looking into the slave replication state on the master when the slave requests something not present in the binlog. Be a bit more strict about what position the slave can ask for, to avoid some easy-to-hit misconfiguration errors. Start over with seq_no counter when RESET MASTER.	13 years ago
unknown	379819d8c0	MDEV-26: Global transaction ID. After-rebase fixes. Rebase was done to be able to build on top of the binlog background thread of MDEV-532.	13 years ago
unknown	008363e87c	MDEV-26: Global transaction ID. Add a missing check for correct table definition.	13 years ago
unknown	492c3b09d2	Fix compile error when building with DBUG, but without DEBUG_SYNC.	13 years ago
unknown	06ffea8c5b	MDEV-26: Global Transaction ID Fix that CHANGE MASTER ... MASTER_GTID_POS="" works to start from the very beginning of the binary log (with test case). Fix that not finding the requested GTID position in master binlog results in fatal error, not endless connect retry.	13 years ago
unknown	861830f9c2	MDEV-26: Global transaction ID. Remove the two-component form of GTID with implicit domain_id=0, as it is likely to cause more confusion than help. Give a better error for CHANGE MASTER ... MASTER_GTID_POS='gtid,gitd,...' when two specified GTIDs have conflicting domain_id.	13 years ago
unknown	2cf3d61fc2	MDEV-26: Global Transaction ID - Fix skipping initial MyISAM DML when connecting using GTID. - Fix RESET MASTER not clearing in-memory binlog state. - Fix not reading standalone flag in Gtid_log_event::peek(). - Fix skipping DDL that the slave has already seen when using GTID position.	13 years ago
unknown	fff47f40f6	MDEV-26: Global Transaction ID - Fix that binlog_gtid_pos() (and hence slave connect) does not work correctly in the very first binlog file (due to not logging empty Gtid_list_log_event). - Remove one instance of the stupid domain_id-0-is-implicit. - Rename the confusing Gtid_Pos_Auto in SHOW SLAVE STATUS to Using_Gtid. - Fix memory leak.	13 years ago
unknown	cb46c33386	MDEV-26: Global transaction ID. Fix crash in binlog_gtid_pos('', 4) (and thus slave connect) when master does not have binlog enabled.	13 years ago
unknown	7426a466dc	MDEV-26: Global transaction ID, intermediate commit. Fix memory leak.	13 years ago
unknown	bfec9c64b8	MDEV-26: Global transaction ID, intermediate commit. - Fix that slave GTID state was updated from the wrong place in the code, causing random crashing and other misery. - Fix updates to mysql.rpl_slave_state to not go to binlog (this would cause duplicate key errors on the slave and is generally the wrong thing to do).	13 years ago
unknown	ff8676e0e1	MDEV-26: Global transaction ID. Fix initial loading of mysql.rpl_slave_state, the code had several issues. Some very basic MTR stuff, more to come.	13 years ago
Pedro Gomes	7e8c887786	BUG#13545447: RPL_ROTATE_LOGS FAILS DUE TO CONCURRENCY ISSUES IN REP. CODE In method mysql_binlog_send, right after detecting a EOF in the read event loop, and before deciding if we should change to a new binlog file there is a execution window where new events can be written to the binlog and a rotation can happen. When reaching the test, the function will then change to a new binlog file ignoring all the events written in this window. This will result in events not being replicated. Only when the binlog is detected as deactivated in the event loop of the dump thread, can we really know that no more events remain. For this reason, this test is now made under the log lock in the beginning of the event loop when reading the events.	13 years ago
unknown	1c6271b36a	MDEV-26: Global Transaction ID. Implement CHANGE MASTER TO ... MASTER_GTID_POS = "x-y-z,a-b-c".	13 years ago
unknown	d98e2ea9fe	MDEV-26. Intermediary commit. Fix binlog_gtid_pos() to handle empty file name, and to not allow user to open arbitrary file on the system.	13 years ago
unknown	041f26d349	MDEV-26. Intermediate commit. Implement binlog_gtid_pos() function. This will be used so that the slave can obtain the gtid position automatically from first connect with old-style position - then MASTER_GTID_POS=AUTO will work the next time. Can also be used by mysqldump --master-data to give the current gtid position directly.	13 years ago
unknown	ea5632e9d7	MDEV-3984: Double free of Master_info * when CHANGE MASTER fails. When CHANGE MASTER fails, it may or may not have already added the Master_info * to the index. Implement logic that properly handles removal and freeing in both cases.	13 years ago
Venkatesh Duggirala	f31611c4c5	BUG#14798572: REMOVE UNUSED VARIABLE BINLOG_CAN_BE_CORRUPTED FROM MYSQL_BINLOG_SEND As part Bug #11747416 A DISK FULL MAKES BINARY LOG CORRUPT, reading the variable "binlog_can_be_corrupted" was removed In the existing code the value of this variable is only set, never read. And also this issue causing compiler warnings. So the variable is completely redundant and should be removed. sql/sql_repl.cc: Removing dead code	13 years ago
unknown	0b36233acd	MDEV-26. Intermediate commit. Implement CHANGE MASTER TO MASTER_GTID_POS=xxx.	13 years ago

1 2 3 4 5 ...

587 Commits (9c85ced30dc4f6d28b4fe7ad1b73ca76f3c43a44)