mariadb

Tree: 89ae01fd00

Author	SHA1	Message	Date
Marko Mäkelä	ea61b79694	MDEV-20805 ibuf_add_free_page() is not initializing FIL_PAGE_TYPE first In the function recv_parse_or_apply_log_rec_body() there are debug checks for validating the state of the page when redo log records are being applied. Most notably, FIL_PAGE_TYPE should be set before anything else is being written to the page. ibuf_add_free_page(): Set FIL_PAGE_TYPE before performing any other changes.	6 years ago
Marko Mäkelä	4ebaf81360	MDEV-19455: Avoid SET DEBUG_DBUG='-d,...' construct Apply the correct pattern for debug instrumentation: SET @save_dbug=@@debug_dbug; SET debug_dbug='+d,...'; ... SET debug_dbug=@save_dbug; Numerous tests use statements of the form SET debug_dbug='-d,...'; which will inadvertently enable all DBUG tracing output, causing unnecessary waste of resources.	6 years ago
Marko Mäkelä	5ef1224434	MDEV-20804 Speed up main.index_merge_innodb The test main.index_merge_innodb is taking very much time, especially on later versions (10.2 and 10.3). Some of this could be attributed to the use of INSERT...SELECT, which is time-consumingly creating explicit record locks in InnoDB for the locking read in the SELECT part. In 10.3 and later, some slowness can be attributed to MDEV-12288, which makes the InnoDB purge thread spend time to reset transaction identifiers in the inserted records. If we prevent purge from running before all tables are dropped, the test seems to be 10% faster on an unoptimized debug build on 10.5. (A proper fix would be to implement MDEV-515 and stop writing row-level undo log records for inserts into an empty table or partition.) At the same time, it should not hurt to make main.index_merge_myisam to use the sequence engine. Not only could it be a little faster, but the test would be slightly more readable.	6 years ago
Nikita Malyavin	350e46a8b5	MDEV-18546 ASAN heap-use-after-free in innobase_get_computed_value / row_purge the bug was already fixed in MDEV-17005, so now only test is added	6 years ago
Nikita Malyavin	b393e2cb0c	add innodb_debug_sync var to support DEBUG_SYNC from purge threads	6 years ago
Marko Mäkelä	b05be3ef8c	Add encryption.innodb-redo-badkey,strict_full_crc32 In commit `0f7732d1d1` we introduced a innodb_checksum_algorithm=full_crc32 combination to a number of encryption tests, and also fixed the code accordingly. The default in MariaDB 10.5 is innodb_checksum_algorithm=full_crc32. In a test merge to 10.5, the test encryption.innodb-redo-badkey failed once due to a message that had been added in that commit. Let us introduce a full_crc32 option to that test. And let us use strict_crc32 and strict_full_crc32 instead of the non-strict variants, for the previously augmented tests, to be in line with the earlier tests encryption.corrupted_during_recovery and encryption.innodb_encrypt_temporary_tables.	6 years ago
Marko Mäkelä	09afd3da1a	Merge 10.3 into 10.4	6 years ago
Marko Mäkelä	4cdb72f237	MDEV-19783: Relax an assertion btr_page_get_split_rec_to_left(): Assert that in the leftmost leaf page, if the metadata record exists, index->is_instant() must hold. The assertion of commit `01f45becd1` could fail during innobase_instant_try().	6 years ago
Marko Mäkelä	01f45becd1	MDEV-19783: Add more assertions btr_page_get_split_rec_to_left(): Assert that in the leftmost leaf page, the metadata record exists if and only if index->is_instant(). page_validate(): Correct the wording of a message. rec_init_offsets(): Assert that whenever a record is in "instant ALTER" format, index->is_instant() must hold.	6 years ago
Marko Mäkelä	7f84e3ad75	Merge 10.2 into 10.3	6 years ago
Marko Mäkelä	6d7a826953	MDEV-20788: Bogus assertion failure for PAGE_FREE list In MDEV-11369 (instant ADD COLUMN) in MariaDB Server 10.3, we introduced the hidden metadata record that must be the first record in the clustered index if and only if index->is_instant() holds. To catch MDEV-19783, in commit `ed0793e096` and commit `99dc40d6ac` we added some assertions to find cases where the metadata record is missing while it should not be, or a record exists when it should not. Those assertions were invalid when traversing the PAGE_FREE list. That list can contain anything; we must only be able to determine the successor and the size of each garbage record in it. page_validate(), page_simple_validate_old(), page_simple_validate_new(): Do not invoke page_rec_get_next_const() for traversing the PAGE_FREE list, but instead use a lower-level accessor that does not attempt to validate the REC_INFO_MIN_REC_FLAG. page_copy_rec_list_end_no_locks(), page_copy_rec_list_start(), page_delete_rec_list_start(): Add assertions. btr_page_get_split_rec_to_left(): Remove a redundant return value, and make the output parameter the return value. btr_page_get_split_rec_to_right(), btr_page_split_and_insert(): Clean up.	6 years ago
Marko Mäkelä	0f7732d1d1	MDEV-19335 adjustment for innodb_checksum_algorithm=full_crc32 When MDEV-12026 introduced innodb_checksum_algorithm=full_crc32 in MariaDB 10.4, it accidentally added a dependency on buf_page_t::encrypted. Now that the flag has been removed, we must adjust the page-read routine. buf_page_io_complete(): When the full_crc32 page checksum matches but the tablespace ID in the page does not match after decrypting, we should declare it a decryption failure and suppress the page dump output and any attempts to re-read the page.	6 years ago
Aleksey Midenkov	545c545206	Fix compilation 2 (GCC 9) Fixed warning: -Woverloaded-virtual for GCC 9 (Clang treats it differently) Caused by `c9cba59749`	6 years ago
Marko Mäkelä	c11e5cdd12	Merge 10.3 into 10.4	6 years ago
Aleksey Midenkov	3c78d1b640	Fix Mroonga compilation Fixed warnings: -Woverloaded-virtual, -Winconsistent-missing-override Caused by `c9cba59749`	6 years ago
Jan Lindström	cb3f856ecd	Fix compiler error when using -Wconversion. /mariadb/10.3/wsrep/wsrep_gtid.c:45:26: error: conversion from 'long int' to 'unsigned int' may change value [-Werror=conversion] 45 \| offset = endptr - str;	6 years ago
Michael Widenius	726b1998fc	Fixed feedback_plugin_load to work with staticly loaded plugin	6 years ago
Aleksey Midenkov	c9cba59749	MDEV-17333 Assertion in update_auto_increment() upon exotic LOAD While `handler::next_insert_id` is restored on duplicate key errors `part_share->next_auto_inc_val` is not restored which causes discrepancy.	7 years ago
Aleksey Midenkov	a92f3146d2	MDEV-19406 Assertion on updating view of join with versioned table TABLE::mark_columns_needed_for_update(): use_all_columns() assigns pointer of all_set into read_set and write_set, but this is not good since all_set is changed later by TABLE::mark_columns_used_by_index_no_reset(). Do column_bitmaps_signal() whenever we change read_set/write_set.	7 years ago
Aleksey Midenkov	647a38818a	MDEV-16130 wrong error message adding AS ROW START to versioned table	8 years ago
Aleksey Midenkov	75ba5c815d	MDEV-16210 FK constraints on versioned tables use historical rows, which may cause constraint violation Constraint check is done on secondary index update. F.ex. DELETE does row_upd_sec_index_entry() and checks constraints in row_upd_check_references_constraints(). UPDATE is optimized for the case when order is not changed (node->cmpl_info & UPD_NODE_NO_ORD_CHANGE) and doesn't do row_upd_sec_index_entry(), so it doesn't check constraints. Since for versioned DELETE we do UPDATE actually, but expect behaviour of DELETE in terms of constraints, we should deny this optimization to get constraints checked. Fix wrong referenced table check when versioned DELETE inserts history in parent table. Set check_ref to false in this case. Removed unused dup_chk_only argument for row_ins_sec_index_entry() and added check_ref argument. MDEV-18057 fix was superseded by this fix and reverted. foreign.test: All key_type combinations: pk, unique, sec(ondary).	8 years ago
Aleksey Midenkov	6684989801	versioning test suite fixes Preparation for MDEV-16210: replace.test: key_type combinations: PK and UNIQUE. foreign.test: Preparation for key_type combinations. Other fixes: * Merged versioning.update2 into versioning.update; * Removed test2 database and done individual drop instead.	8 years ago
Sergey Vojtovich	cf71cc838e	After merge fix, this line was removed in `adefaef`	6 years ago
Marko Mäkelä	6fde0073bf	Rename log_make_checkpoint_at() to log_make_checkpoint() The function was always called with lsn=LSN_MAX. Remove that redundant parameter. Spotted by Thirunarayanan Balathandayuthapani.	6 years ago
Marko Mäkelä	892378fb9d	Merge 10.2 into 10.3	6 years ago
Thirunarayanan Balathandayuthapani	c65cb244b3	MDEV-19335 Remove buf_page_t::encrypted The field buf_page_t::encrypted was added in MDEV-8588. It was made mostly redundant in MDEV-12699. Remove the field.	6 years ago
Marko Mäkelä	f11d425a15	MDEV-20591: Follow-up fix calc_field_event_length(): For type=MYSQL_TYPE_BLOB and meta==0, return 0 instead of *ptr+1. This was noted by -Wimplicit-fallthrough.	6 years ago
Jan Lindström	62dce14d15	MDEV-20782 : Galera test failure on galera_sr.galera_sr_mysqldump_sst Add auto increment offset save and restore as node(s) are restarted.	6 years ago
Jan Lindström	44a11a7c08	MDEV-20780 : Galera test failure on galera_sr.galera_sr_ddl_master Fix wait_condition and use repeatable read with wsrep_sync at the end.	6 years ago
Oleksandr Byelkin	896b869685	MDEV-19238 Mariadb spider - crashes on where null (fix and explanation came with MDEV-20753 (duplicate of this bug))	6 years ago
Oleksandr Byelkin	b7408be0c3	MDEV-20753: Sequence with limit 0 crashes server Do not try to push down conditions to engine if query was resolved without tables (and so the engine).	6 years ago
Marko Mäkelä	24232ec12c	Merge 10.1 into 10.2	6 years ago
Eugene Kosov	ed0793e096	MDEV-19783: Add more REC_INFO_MIN_REC_FLAG checks btr_cur_pessimistic_delete(): code changed in a way that allows to put more REC_INFO_MIN_REC_FLAG assertions inside btr_set_min_rec_mark(). Without that change tests innodb.innodb-table-online, innodb.temp_table_savepoint and innodb_zip.prefix_index_liftedlimit fail. Removed basically duplicated page_zip_validate() calls which fails because of temporary(!) invariant violation. That fixed innodb_zip.wl5522_debug_zip and innodb_zip.prefix_index_liftedlimit	6 years ago
Eugene Kosov	99dc40d6ac	MDEV-19783 Random crashes and corrupt data in INSTANT-added columns The bug affects MariaDB Server 10.3 or later, but it makes sense to improve CHECK TABLE in earlier versions already. page_validate(): Check REC_INFO_MIN_REC_FLAG in the records. This allows CHECK TABLE to catch more bugs.	6 years ago
Marko Mäkelä	d480d28f4f	Add page_has_prev(), page_has_next(), page_has_siblings() Until now, InnoDB inefficiently compared the aligned fields FIL_PAGE_PREV, FIL_PAGE_NEXT to the byte-order-agnostic value FIL_NULL. This is a backport of `32170f8c6d` from MariaDB Server 10.3.	6 years ago
Seth Shelnutt	b1ac174279	Cast string literal to char* MDEV-20767	6 years ago
Jan Lindström	57b666b2e5	Fix test case wsrep.mdev_6832 we need to wait until wsrep_ready is ON before test can end.	6 years ago
Marko Mäkelä	6bc75a4253	MDEV-15528 preparation: Remove a constant parameter fsp_free_seg_inode(): Remove the constant parameter log=true. Only fsp_free_page() could also be called with log=false. The dead code was introduced in commit `304ae942f7` by me, and spotted by Thirunarayanan Balathandayuthapani.	6 years ago
Marko Mäkelä	d95f96ad1b	Merge 5.5 into 10.1	6 years ago
Sachin Setiya	27664ef29d	MDEV-20574 Position of events reported by mysqlbinlog is wrong with encrypted binlogs, SHOW BINLOG EVENTS reports the correct one. Analysis Mysqlbinlog output for encrypted binary log #Q> insert into tab1 values (3,'row 003') #190912 17:36:35 server id 10221 end_log_pos 980 CRC32 0x53bcb3d3 Table_map: `test`.`tab1` mapped to number 19 # at 940 #190912 17:36:35 server id 10221 end_log_pos 1026 CRC32 0xf2ae5136 Write_rows: table id 19 flags: STMT_END_F Here we can see Table_map_log_event ends at 980 but Next event starts at 940. And the reason for that is we do not send START_ENCRYPTION_EVENT to the slave Solution:- Send Start_encryption_log_event as Ignorable_log_event to slave(mysqlbinlog), So that mysqlbinlog can update its log_pos. Since Slave can request multiple FORMAT_DESCRIPTION_EVENT while master does not have so We only update slave master pos when master actually have the FORMAT_DESCRIPTION_EVENT. Similar logic should be applied for START_ENCRYPTION_EVENT. Also added the test case when new server reads the data from old server which does not send START_ENCRYPTION_EVENT to slave. Master Slave Upgrade Scenario. When Slave is updated first, Slave will have extra logic of handling START_ENCRYPTION_EVENT But master willnot be sending START_ENCRYPTION_EVENT. So there will be no issue. When Master is updated first, It will send START_ENCRYPTION_EVENT to slave , But slave will ignore this event in queue_event.	6 years ago
sachin	1e0f09cacb	MDEV-16239 Many test in rpl suite fails Fix rpl_skip_error test. We cant reset Slave_skipped_errors(even with FLUSH STATUS), So instead of absolute slave_skipped_errors we look for delta of slave_skipped_errors Fix rpl.rpl_binlog_errors and binlog_encryption.rpl_binlog_errors We create the $load_file and $load_file2 but we never remove them. Fix rpl_000011.test Instead of real value use delta value , Since flush status wont flush LONGLONG variable. Fix rpl_row_find_row_debug Instead of searching whole log_error_ file we will use search_pattern_in_file which runs pattern search only on latest test run , instead of full file. Fix rpl_ip_mix rpl_ip_mix2 We should call reset slave all because we also want to reset master_host otherwise show slave status wont be empty and making repeat N a failure. Fix rpl_rotate_logs First we have to remove master.info file (cleanup) and second we have to call reset slave all because if we do not call reset slave all then we wont read master.info file beacuse we already have master config in memory. And this makes start slave to pass , which shoud fail becuase its permision is 000 Fix circular_serverid0 test The reason is that ++dbug_rows_event_count == 2 in queue_event does not take --repeat into account. So I have reseted the dbug_rows_event_count in if body.	8 years ago
Sachin	01bf9f8c3d	MDEV-20591 Wrong Number of rows in mysqlbinlog output calc_field_event_length should accurately calculate the size of BLOB type fields, Instead of returning just the bytes taken by length it should return length bytes + actual length.	6 years ago
Marko Mäkelä	db9a4d928d	Remove orphan declaration buf_flush_wait_batch_end_wait_only() The function was declared but not defined in commit `9d6d1902e0`	6 years ago
Sergey Vojtovich	adefaeffcc	MDEV-19536 - Server crash or ASAN heap-use-after-free in is_temporary_table / read_statistics_for_tables_if_needed Regression after `279a907`, read_statistics_for_tables_if_needed() was called after open_normal_and_derived_tables() failure. Fixed by moving read_statistics_for_tables() call to a branch of get_schema_stat_record() where result of open_normal_and_derived_tables() is checked. Removed THD::force_read_stats, added read_statistics_for_tables() instead. Simplified away statistics_for_command_is_needed().	6 years ago
Jan Lindström	c339487030	Try to fix galera_parallel_simple test case.	6 years ago
Sergei Petrunia	37570e845b	MDEV-20740: Odd computations in calculate_cond_selectivity_for_table Make SEL_ARG graph traversal code in sel_arg_range_seq_next() set max_key_parts first. (Pushing to 10.4 first)	6 years ago
Sergei Golubchik	a5c34bc200	if the test uses example plugin, it has to check whether plugin exists	6 years ago
Sergei Golubchik	b710d01dc7	mark PAMv2 plugin stable	6 years ago
Jan Lindström	fe4f766e81	Add wait_condition to wait that node returns to ready state before accessing it.	6 years ago
Oleksandr Byelkin	13535b2713	Fix problem with warnings of new compilers.	6 years ago

... 3 4 5 6 7 ...

187430 Commits (89ae01fd0085cf0d1af272eca545e49fdadf4538) All Branches Search

187430 Commits (89ae01fd0085cf0d1af272eca545e49fdadf4538)

All Branches