mariadb

Tree: 841a74a4d6

Author	SHA1	Message	Date
Igor Babaev	841a74a4d6	Fixed LP bug #939009 . The result of materialization of the right part of an IN subquery predicate is placed into a temporary table. Each row of the materialized table is distinct. A unique key over all fields of the temporary table is defined and created. It allows to perform key look-ups into the table. The table created for a materialized subquery can be accessed by key as any other table. The function best_access-path search for the best access to join a table to a given partial join. With some where conditions this function considers a possibility of a ref_or_null access. If such access employs the unique key on the temporary table then when estimating the cost this access the function tries to use the array rec_per_key. Yet, such array is not built for this unique key. This causes a crash of the server. Rows returned by the subquery that contain nulls don't have to be placed into temporary table, as they cannot be match any row produced by the left part of the subquery predicate. So all fields of the temporary table can be defined as non-nullable. In this case any ref_or_null access to the temporary table does not make any sense and it does not make sense to estimate such an access. The fix makes sure that the temporary table for a materialized IN subquery is defined with columns that are all non-nullable. The also ensures that any row with nulls returned by the subquery is not placed into the temporary table.	14 years ago
Igor Babaev	4de7978a3f	Back-ported the fix and the test case for bug #50257 from mariadb-5.3 code line. Adjusted results for a few test cases.	14 years ago
Igor Babaev	c9259f166b	Fixed LP bug #904345 . The MIN/MAX optimizer code from the function opt_sum_query erroneously did not take into account conjunctive conditions that did not depend on any table, yet were not identified as constant items. These could be items containing rand() or PS/SP parameters. These items are supposed to be evaluated at the execution phase. That's why if such conditions can be extracted from the WHERE condition the MIN/MAX optimization is not applied as currently it is always done at the optimization phase. (In 5.3 expensive subqueries are also evaluated only at the execution phase. So, if a constant condition with such subquery can be extracted from the WHERE clause the MIN/MAX optimization should not be applied in 5.3.) IF an IN/ALL/SOME predicate with a constant left part is transformed into an EXISTS subquery the resulting subquery should not be considered uncacheable if the right part of the predicate is not uncacheable. Backported the function dbug_print_item() from 5.3. The function is used only for debugging.	14 years ago
Igor Babaev	2b1f0b8757	Back-ported the patch of the mysql-5.6 code line that fixed several defects in the greedy optimization: 1) The greedy optimizer calculated the 'compare-cost' (CPU-cost) for iterating over the partial plan result at each level in the query plan as 'record_count / (double) TIME_FOR_COMPARE' This cost was only used locally for 'best' calculation at each level, and not accumulated into the total cost for the query plan. This fix added the 'CPU-cost' of processing 'current_record_count' records at each level to 'current_read_time' before it is used as 'accumulated cost' argument to recursive best_extension_by_limited_search() calls. This ensured that the cost of a huge join-fanout early in the QEP was correctly reflected in the cost of the final QEP. To get identical cost for a 'best' optimized query and a straight_join with the same join order, the same change was also applied to optimize_straight_join() and get_partial_join_cost() 2) Furthermore to get equal cost for 'best' optimized query and a straight_join the new code substrcated the same '0.001' in optimize_straight_join() as it had been already done in best_extension_by_limited_search() 3) When best_extension_by_limited_search() aggregated the 'best' plan a plan was 'best' by the check : 'if ((search_depth == 1) \|\| (current_read_time < join->best_read))' The term '(search_depth == 1' incorrectly caused a new best plan to be collected whenever the specified 'search_depth' was reached - even if this partial query plan was more expensive than what we had already found.	14 years ago
Sergey Petrunya	fa061af373	Update mysql-test/suite/pbxt/r/subselect.result for the previous push	14 years ago
Igor Babaev	f5dac20f38	Made the optimizer switch flags 'outer_join_with_cache', 'semijoin_with_cache' set to 'on' by default.	14 years ago
Igor Babaev	81d390ac86	Adjusted the results of pbxt.subselect after the latest merge 5.1->5.2->5.3.	14 years ago
Sergey Petrunya	255fd6c929	Make subquery Materialization, as well as semi-join Materialization be shown in EXPLAIN as select_type==MATERIALIZED. Before, we had select_type==SUBQUERY and it was difficult to tell materialized subqueries from uncorrelated scalar-context subqueries.	14 years ago
Igor Babaev	17b4e4a194	Set new default values for the optimizer switch flags 'derived_merge' and 'derived_with_keys'. Now they are set on by default.	14 years ago
Sergey Petrunya	b796833e8d	Update test results	14 years ago
Igor Babaev	b4b7d941fe	Fixed LP bug #889750 . If the optimizer switch 'semijoin_with_cache' is set to 'off' then join cache cannot be used to join inner tables of a semijoin. Also fixed a bug in the function check_join_cache_usage() that led to wrong output of the EXPLAIN commands for some test cases.	14 years ago
unknown	32d230d67b	Fixed PBXT test cases.	14 years ago
Sergey Petrunya	47861a6577	Change the default @@optimizer_switch settings: - semijoin=on - firstmatch=on - loosescan=on	14 years ago
unknown	6498687325	Fix bug lp:833702 Analysis: Equality propagation propagated the constant '7' into args[0] of the Item_in_optimizer that stands for the "< ANY" predicate. At the same the min/max subquery rewrite swapped the order of the left and right operands of the "<" predicate, but used Item_in_subselect::left_expr. As a result, when the <ANY predicate is executed early in the execution phase as a contant condition, instead of a constant right (swapped) argument of the < predicate, there was a field (t3.a). This field had no data, since the whole predicate is considered constant, and it is evaluated before any tables are read. Having junk in the field row buffer produced wrong result Solution: Fix create_swap to pick the correct Item_in_optimizer left argument.	14 years ago
Sergei Golubchik	60e1ef85e5	update pbxt test results	14 years ago
unknown	8b062c1fef	Fix of LP BUG#780386. ALL subquery should return TRUE if subquery rowa set is empty independently of left part. The problem was that Item_func_(eq,ne,gt,ge,lt,le) do not call execution of second argument if first is NULL no in this case subquery will not be executed and when Item_func_not_all calls any_value() of the subquery or aggregation function which report that there was rows. So for NULL < ALL (SELECT...) result was FALSE instead of TRUE. Fix is just swapping of arguments of Item_func_(eq,ne,gt,ge,lt,le) (with changing the operation if it is needed) so that result will be the same (for examole a < b is equal to b > a). This fix exploit the fact that first argument will be executed in any case.	15 years ago
unknown	4338091967	Fix pbxt suite to keep the same opti9misation it was before.	15 years ago
unknown	2df1914791	Fix bug lp:827416 Analysis: Constant table optimization of the outer query finds that the right side of the equality is a constant that can be used for an eq_ref access to fetch one row from t1, and substitute t1 with a constant. Thus constant optimization triggers evaluation of the subquery during the optimize phase of the outer query. The innermost subquery requires a plan with a temporary table because with InnoDB tables the exact count of rows is not known, and the empty tables cannot be optimzied way. JOIN::exec for the innermost subquery substitutes the subquery tables with a temporary table. When EXPLAIN gets to print the tables in the innermost subquery, EXPLAIN needs to print the name of each table through the corresponding TABLE_LIST object. However, the temporary table created during execution doesn't have a corresponding TABLE_LIST, so we get a null pointer exception. Solution: The solution is to forbid using expensive constant expressions for eq_ref access for contant table optimization. Notice that eq_ref with a subquery providing the value is still possible during regular execution.	15 years ago
unknown	a6037394e3	Fix bug lp:817384 This bug is a special case of lp:813447. Analysis: Constant optimization finds that the condition t2.a = 1 can be used to access the primary key of table 't2'. As a result both outer table t1,t2 are considered as constant when we reach the execution phase. At the same time, during constant optimization, the IN predicate is not evaluated because it is expensive. When execution of the outer query reaches do_select(), control flow enter the branch: if (join->table_count == join->const_tables) { ... } This branch checks only the WHERE and HAVING clauses, but doesn't check the ON clauses of the query. Since the IN predicate was not evaluated during optimization, it is not evaluated at all, thus execution doesn't detect that the ON clause is FALSE. Solution: Similar to the patch for bug lp:813447, exclude system tables from constant substitution based on unique key lookups if there is an expensive ON condition on the inner table.	15 years ago
Igor Babaev	d117f51901	Fixed a crash with pbxt.subselect when 'derived_merge' is set off in the optimizer switch.	15 years ago
Igor Babaev	63abf00a62	Made the optimizer switches 'derived_merge' and 'derived_with_keys' off by default.	15 years ago
Igor Babaev	5ab7adfcaf	Adjusted the results of the pbxt.subselect test after the push of the patch for bug 780386.	15 years ago
unknown	af284b55f0	Make subquery cache off by default. mysql-test/r/subselect_scache.result: Test with subquery cache on. mysql-test/t/subselect_scache.test: Test with subquery cache on.	15 years ago
unknown	4fadcc2bb4	Bug lp:802979 Adjust PBXT test results.	15 years ago
Sergey Petrunya	c1de6f8b77	Change the default @@optimizer_switch setting from semijoin=on,firstmatch=on,loosescan=on to semijoin=off,firstmatch=off,loosescan=off Adjust the testcases: - Modify subselect*.test and join_cache.test so that all tests use the same execution paths as before (i.e. optimizations that are being tested are enabled) - Let all other test files run with the new default settings (i.e. with new optimizations disabled) - Copy subquery testcases from these files into t/subselect_extra.test which will run them with new optimizations enabled.	15 years ago
Igor Babaev	db0c340601	Fixed LP bug #793436 . When looking for the execution plan of a derived table to be materialized JOIN::optimize finds out that all joined tables of the derived table contain not more than one row then the derived table should be maretialized at the optimization stage. Added a test case for the bug. Adjusted results in other test cases.	15 years ago
Sergey Petrunya	4efe046352	Update pbxt suite test results	15 years ago
Igor Babaev	8ec03d805d	Fixed crashes in the rpl suite due to a bug in Item_func_set_user_var::fix_fields. Adjusted the result files in the pbxt, innodb and innodb_plugin suites. Commented out a failing test case in innodb.innodb_multi_update.test. It should be returned back when the problem with multi-update of derived tables (bug 784297) is resolved.	15 years ago
unknown	920d467703	LP BUG#778413 Adjusted test results for tests not run by default on Linux. mysql-test/suite/pbxt/r/subselect.result: lp:778413	15 years ago
Oleksandr Byelkin	7b797fe66d	Moving max/min optimization from prepare to optimization phase. MWL#148 mysql-test/r/explain.result: fixed results (new item) mysql-test/r/subselect.result: fixed results (new item) mysql-test/r/subselect_no_mat.result: fixed results (new item) mysql-test/r/subselect_no_opts.result: fixed results (new item) mysql-test/r/subselect_no_semijoin.result: Fixed results (new item) mysql-test/suite/pbxt/r/subselect.result: Fixed results (new item) mysql-test/t/explain.test: Fixed results (correct behaviour) sql/item_cmpfunc.cc: Pass through for max/min sql/item_subselect.cc: moving max/min sql/item_subselect.h: moving max/min sql/mysql_priv.h: new uncacheble flags added sql/opt_subselect.cc: maxmin moved. sql/opt_subselect.h: New function for maxmin. sql/sql_class.h: debug code sql/sql_lex.cc: Fixed flags. Limit setting fixed. sql/sql_lex.h: 2 new flags. sql/sql_select.cc: Prepare divided on 2 function to be able recollect some info after transformation. sql/sql_select.h: Prepare divided on 2 functions.	15 years ago
unknown	9d20163536	Fix LP BUG#715069 Corrected PBXT test results (explains).	15 years ago
Sergey Petrunya	886d84d6d1	BUG#727667: Update test results in pbxt test suite	15 years ago
Sergey Petrunya	b6fd7acb84	Post-merge test result update.	15 years ago
unknown	96efe1cab3	Fix for LP BUG#714808 and LP BUG#719280. The patch also adjusts several instable test results to order the result. Analysis: The function prev_record_reads() may skip (jump over) some query plan nodes where record_count < 1. At the same time, even though get_partial_join_cost() uses all first N plan nodes after the last constant table, it may produce a smaller record_count than prev_record_reads(), because the record count for some plan nodes may be < 1, and these nodes may not participate in prev_record_reads. Solution: The current solution is to treat the result of get_partial_join_cost() as the upper bound for the total number of unique lookup keys.	15 years ago
unknown	1be11803c7	MWL#89 Adjusted test results.	15 years ago
Igor Babaev	e13406b29b	Changed the queries of index_intersect.test to ensure platform independent execution plans. Fixed a bug in Unique::unique_add that caused a crash for a query from index_intersect_innodb on some platforms. Fixed two bugs in opt_range.cc that led to the choice of not the cheapest plans for index intersections.	15 years ago
Michael Widenius	40b7efb354	Fixed failing test cases mysql-test/include/have_not_innodb_plugin.inc: Also detect if xtradb is installed mysql-test/suite/innodb/t/innodb_bug56143.test: Disabled test case that doesn't work for innodb_plugin/xtradb. mysql-test/suite/innodb_plugin/r/innodb_bug56632.result: Updated result (key_block_size is lower case in MariaDB, as all other options) mysql-test/suite/pbxt/r/partition_hash.result: Updated results (after partition row count optimization changes) mysql-test/suite/pbxt/r/partition_pruning.result: Updated results (after partition row count optimization changes) mysql-test/suite/pbxt/r/partition_range.result: Updated results (after partition row count optimization changes) mysql-test/suite/pbxt/r/subselect.result: Updated result after ROW() changes.	15 years ago
Igor Babaev	4bc81968ab	Post merge adjustment	15 years ago
Igor Babaev	25f5debdc7	MWL#128: Added into EXPLAIN output info about types of the used join buffers and about the employed join algorithms. Refactored constructors of the JOIN_CACHE* classes.	15 years ago
Igor Babaev	e49cb8a71b	Adjusted some results from the vcol, pbxt, maria test suites after the fix for bug 52636.	15 years ago
unknown	d6a9b52269	Fixed LP BUG#615760: Check on double cache assignment added into the transformation methods. Cache parameters print added in EXPLAIN EXTENDED output. mysql-test/r/compare.result: Cache parameters print added in EXPLAIN EXTENDED output. mysql-test/r/group_by.result: Cache parameters print added in EXPLAIN EXTENDED output. mysql-test/r/subselect.result: Cache parameters print added in EXPLAIN EXTENDED output. mysql-test/r/subselect3.result: Cache parameters print added in EXPLAIN EXTENDED output. mysql-test/r/subselect3_jcl6.result: Cache parameters print added in EXPLAIN EXTENDED output. mysql-test/r/subselect4.result: Cache parameters print added in EXPLAIN EXTENDED output. mysql-test/r/subselect_cache.result: Added test suite for LP BUG#615760 mysql-test/r/subselect_mat.result: Cache parameters print added in EXPLAIN EXTENDED output. mysql-test/r/subselect_no_mat.result: Cache parameters print added in EXPLAIN EXTENDED output. mysql-test/r/subselect_no_opts.result: Cache parameters print added in EXPLAIN EXTENDED output. mysql-test/r/subselect_no_semijoin.result: Cache parameters print added in EXPLAIN EXTENDED output. mysql-test/r/subselect_sj.result: Cache parameters print added in EXPLAIN EXTENDED output. mysql-test/r/subselect_sj_jcl6.result: Cache parameters print added in EXPLAIN EXTENDED output. mysql-test/suite/pbxt/r/subselect.result: Cache parameters print added in EXPLAIN EXTENDED output. mysql-test/t/subselect_cache.test: Cache parameters print added in EXPLAIN EXTENDED output. sql/item.cc: Item::set_expr_cache result fixed according to its description. Cache parameters print added in EXPLAIN EXTENDED output. sql/item.h: Cache parameters print added in EXPLAIN EXTENDED output. sql/item_cmpfunc.cc: Check on double cache assignment added into the transformation methods. sql/item_cmpfunc.h: Check on double cache assignment added into the transformation methods. sql/item_subselect.cc: Check on double cache assignment added into the transformation methods. sql/item_subselect.h: Check on double cache assignment added into the transformation methods. sql/sql_expression_cache.cc: Cache parameters print added. sql/sql_expression_cache.h: Cache parameters print added. sql/sql_select.cc: Removed unused method (now it is impossible to make double transformation with the cache). sql/sql_select.h: Removed unused method.	16 years ago
unknown	08d1de3732	pbxt test suite fix (expression test added to EXPLAIN EXTENDED).	16 years ago
Sergey Petrunya	559dafdf60	Update pbxt testsuite results with latest subquery changes.	16 years ago
unknown	1a13a2df47	After-merge fixes for MySQL 5.1.46 merge into MariaDB: result file update and compiler warning removals.	16 years ago
Sergey Petrunya	30bac79806	Always refer to materialized table as "SUBSELECT#%d" where %d is select number - for Item-based materialization, it was "materialized subselect" - for SJ-Materialization it was "subquery%d"	16 years ago
Sergey Petrunya	cef9a6bd13	MWL#90: Subqueries: Inside-out execution for non-semijoin materialized subqueries that are AND-parts of the WHERE - Update test results.	16 years ago
unknown	e0642712f5	MWL#68: Subquery optimization: Efficient NOT IN execution with NULLs Fix for the PBXT copy of subselect.test.	16 years ago
Sergey Petrunya	279b8efd09	Subquery backport: update pbxt suite test results (checked).	16 years ago
Sergey Petrunya	3cc3938b19	DS-MRR backport: - Fix PBXT test results (PBXT doesn't support MRR or ICP, but we get result diffs because we've also backported a fix that - prints out "Using where" when the table has part of WHERE that it has got from LEFT JOIN's ON expression - Does a better job at removing equalities that are guaranteed to be true by use of ref acccess.	16 years ago
unknown	0a65668080	After-merge fixes for MySQL 5.1.41 merge: PBXT result file updates. mysql-test/suite/pbxt/r/func_group.result: Result file update. mysql-test/suite/pbxt/r/grant.result: Use --sorted_result mysql-test/suite/pbxt/r/group_min_max.result: Result file update. mysql-test/suite/pbxt/r/join_nested.result: Result file update. mysql-test/suite/pbxt/r/negation_elimination.result: Result file update. mysql-test/suite/pbxt/r/ps_grant.result: Use --sorted_result mysql-test/suite/pbxt/r/skip_grants.result: Result file update. mysql-test/suite/pbxt/r/subselect.result: Adjust test case following error message change due to fix of Bug#48293 mysql-test/suite/pbxt/r/view_grant.result: Result file update. mysql-test/suite/pbxt/t/grant.test: Use --sorted_result mysql-test/suite/pbxt/t/ps_grant.test: Use --sorted_result mysql-test/suite/pbxt/t/subselect.test: Adjust test case following error message change due to fix of Bug#48293	16 years ago

1 2

61 Commits (841a74a4d6ebdaa2760ce615e7fc18f57100ee19)