mariadb

Tree: 841a74a4d6

Author	SHA1	Message	Date
Igor Babaev	841a74a4d6	Fixed LP bug #939009 . The result of materialization of the right part of an IN subquery predicate is placed into a temporary table. Each row of the materialized table is distinct. A unique key over all fields of the temporary table is defined and created. It allows to perform key look-ups into the table. The table created for a materialized subquery can be accessed by key as any other table. The function best_access-path search for the best access to join a table to a given partial join. With some where conditions this function considers a possibility of a ref_or_null access. If such access employs the unique key on the temporary table then when estimating the cost this access the function tries to use the array rec_per_key. Yet, such array is not built for this unique key. This causes a crash of the server. Rows returned by the subquery that contain nulls don't have to be placed into temporary table, as they cannot be match any row produced by the left part of the subquery predicate. So all fields of the temporary table can be defined as non-nullable. In this case any ref_or_null access to the temporary table does not make any sense and it does not make sense to estimate such an access. The fix makes sure that the temporary table for a materialized IN subquery is defined with columns that are all non-nullable. The also ensures that any row with nulls returned by the subquery is not placed into the temporary table.	14 years ago
Sergey Petrunya	12bd3dfe29	BUG#923246: Loosescan reports different result than other semijoin methods - If LooseScan is used with quick select, require that quick select produces data in key order (this disables use of MRR, which can return data in arbitrary order).	14 years ago
Igor Babaev	4e2b6d45e0	Back-ported test cases for bug #59919 of mysql-5.6 code line. The bug could not be reproduced in the latest release of mariadb-5.3 as it was was fixed by Sergey Petrunia when working on the problems concerning outer joins within in subqueries converted to semi-joins.	14 years ago
Sergey Petrunya	424f56b3ba	BUG#920713: Wrong result (missing rows) with firstmatch+BNL, IN subquery, ... - Disable use of join cache when we're using FirstMatch strategy, and the join order is such that subquery's inner tables are interleaved with outer. Join buffering code is incapable of handling such join orders. - The testcase requires use of @@debug_optimizer_prefer_join_prefix to hit the bug, but I'm pushing it anyway (including the mention of the variable in .test file), so that it can be found and enabled when/if we get something comparable in the main tree.	14 years ago
Sergey Petrunya	73cc529b51	BUG#920255: Wrong result (extra rows) with loosescan and IN subquery The problem was that LooseScan execution code assumed that tab->key holds the index used for looseScan. This is only true when range or full index scan are used. In case of ref access, the index is in tab->ref.key (and tab->index==0 which explains how LooseScan passed tests with ref access: they used one index) Fixed by setting/using loosescan_key, which always the correct index#.	14 years ago
Igor Babaev	7bdbdb05ce	Back-ported test cases for bugs #54437 , #55955 , #52329 , #57623 from subquery_sj of mysql-5.6 code line. The bugs could not be reproduced in the latest release of mariadb-5.3 as they were fixed either when the code of subquery optimization was back-ported from mysql-6.0 or later when some other bugs were fixed.	14 years ago
Igor Babaev	80009f5862	Back-ported test cases for bugs #53060 , #53305 , #50358 , #49453 from subquery_sj of mysql-5.6 code line. The bugs could not be reproduced in the latest release of mariadb-5.3 as they were fixed either when the code of subquery optimization was back-ported from mysql-6.0 or later when some other bugs were fixed.	14 years ago
Sergey Petrunya	0b590282fc	BUG#912510: Crash in do_copy_not_null with semijoin=ON, firstmatch=ON, aggregate ... - Create/use do_copy_nullable_row_to_notnull() function for ref access, which is used when copying from not-NULL field in table that can be NULL-complemented to not-NULL field.	14 years ago
Igor Babaev	2b1f0b8757	Back-ported the patch of the mysql-5.6 code line that fixed several defects in the greedy optimization: 1) The greedy optimizer calculated the 'compare-cost' (CPU-cost) for iterating over the partial plan result at each level in the query plan as 'record_count / (double) TIME_FOR_COMPARE' This cost was only used locally for 'best' calculation at each level, and not accumulated into the total cost for the query plan. This fix added the 'CPU-cost' of processing 'current_record_count' records at each level to 'current_read_time' before it is used as 'accumulated cost' argument to recursive best_extension_by_limited_search() calls. This ensured that the cost of a huge join-fanout early in the QEP was correctly reflected in the cost of the final QEP. To get identical cost for a 'best' optimized query and a straight_join with the same join order, the same change was also applied to optimize_straight_join() and get_partial_join_cost() 2) Furthermore to get equal cost for 'best' optimized query and a straight_join the new code substrcated the same '0.001' in optimize_straight_join() as it had been already done in best_extension_by_limited_search() 3) When best_extension_by_limited_search() aggregated the 'best' plan a plan was 'best' by the check : 'if ((search_depth == 1) \|\| (current_read_time < join->best_read))' The term '(search_depth == 1' incorrectly caused a new best plan to be collected whenever the specified 'search_depth' was reached - even if this partial query plan was more expensive than what we had already found.	14 years ago
Sergey Petrunya	04e9004fa3	BUG#901399: Wrong result (extra row) with semijoin=ON, materialization=OFF, optimizer_prune_level=0 - Correctly handle plan refinement stage for LooseScan plans: run create_ref_for_key() if LooseScan plan includes a ref access, and if we don't have any fixed key components, switch to a full index scan.	14 years ago
Igor Babaev	a910e8ef5b	Made join_cache_level == 2 by default.	14 years ago
Igor Babaev	f5dac20f38	Made the optimizer switch flags 'outer_join_with_cache', 'semijoin_with_cache' set to 'on' by default.	14 years ago
Igor Babaev	63d32c115d	Fixed LP bug #901709 . The cause of the reported assertion failure was a division of a double value by 0.	14 years ago
Igor Babaev	8a09adb3ea	Fixed LP bug #901312 . The function setup_sj_materialization_part1() forgot to set the value of TABLE::map for any materialized IN subquery. This could lead to wrong results for queries with subqueries that were converted to queries with semijoins.	14 years ago
Sergey Petrunya	255fd6c929	Make subquery Materialization, as well as semi-join Materialization be shown in EXPLAIN as select_type==MATERIALIZED. Before, we had select_type==SUBQUERY and it was difficult to tell materialized subqueries from uncorrelated scalar-context subqueries.	14 years ago
Igor Babaev	17b4e4a194	Set new default values for the optimizer switch flags 'derived_merge' and 'derived_with_keys'. Now they are set on by default.	14 years ago
Sergey Petrunya	f84dbf4b20	Semi-join optimizations code cleanup part 2: - Make EXPLAIN display "Start temporary" at the start of the fanout (it used to display at the first table whose rowid gets into temp. table which is not that useful for the user) - Updated test results (all checked)	14 years ago
Igor Babaev	b2e5a3f603	Fixed LP bug #887496 . This bug in the function Loose_scan_opt::check_ref_access_part1 could lead to choosing an invalid execution plan employing a loose scan access to a semi-join table even in the cases when such access could not be used at all. This could result in wrong answers for some queries with IN subqueries.	14 years ago
Igor Babaev	b4b7d941fe	Fixed LP bug #889750 . If the optimizer switch 'semijoin_with_cache' is set to 'off' then join cache cannot be used to join inner tables of a semijoin. Also fixed a bug in the function check_join_cache_usage() that led to wrong output of the EXPLAIN commands for some test cases.	14 years ago
unknown	511459bd14	Enable subquery materialization=ON by default.	14 years ago
Sergey Petrunya	9b761df393	BUG#878753: Assertion '0' failed in replace_where_subcondition with derived_merge - Remove the assert in replace_where_subcondition (the patch has explanation why)	14 years ago
Sergey Petrunya	8e6440df0b	BUG#877288: Wrong result with semijoin + materialization + multipart key - when create_ref_for_key() is constructing a ref access for a table that's inside a SJ-Materialization nest, it may not use references to fields of tables that are unside the nest (because these fields will not yet have values when ref access will be used) The check was performed in the first of create_ref_for_key's loops (the one which counts how many key parts are usable) but not in the second (the one which actually fills the TABLE_REF structure).	14 years ago
unknown	54caeee5d6	Making subquery cache on by default.	14 years ago
Igor Babaev	715dc5f99d	Fixed a cost estimation bug introduced into in the function best_access_path of the 5.3 code line after a merge with 5.2 on 2010-10-28 in order not to allow the cost to access a joined table to be equal to 0 ever. Expanded data sets for many test cases to get the same execution plans as before.	14 years ago
Sergey Petrunya	b45beca368	BUG#861147: Assertion `fixed == 1' failed in Item_func_eq::val_int() with semijoin + materialization - convert_subq_to_jtbm() didn't check that subuqery optimization was successful. If it wasn't (in this example because of @@max_join_size violation), it would proceed further and eventually crash when trying to execute the un-optimized subquery.	14 years ago
Sergey Petrunya	ebbdb14a02	BUG#849776: Wrong result with semijoin + "Impossible where" - Provide fix_after_pullout() function for Item_in_optimizer and other Item_XXX classes (basically, all of them that have eval_not_null_tables, which means they have special rules for calculating not_null_tables_cache value)	14 years ago
Sergey Petrunya	27cd8d7b70	BUG##849717: Crash in Item_func::fix_fields on second execution of a prepared statement with semijoin - If convert_join_subqueries_to_semijoins() decides to wrap Item_in_subselect in Item_in_optimizer, it should do so in prep_on_expr/prep_where, too, as long as they are present. There seems to be two possibilities of how we arrive in this function: - prep_on_expr/prep_where==NULL, and will be set later by simplify_joins() - prep_on_expr/prep_where!=NULL, and it is a copy_and_or_structure()-made copy of on_expr/where. the latter can happen for some (but not all!) nested joins. This bug was that we didn't handle this case.	14 years ago
Sergey Petrunya	5673aa41c3	BUG#830993: Crash in end_read_record with derived table - Let join buffering code correctly take into account rowids needed by DuplicateElimination when it is calculating minimum record sizes. - In JOIN_CACHE::write_record_data, added asserts that prevent us from writing beyond the end of the buffer.	14 years ago
Sergey Petrunya	e1435a5178	BUG#834739: Wrong result with 3-way inner join, LooseScan,multipart keys - Don't use join buffering for tables that are within ranges that are covered by LooseScan strategy.	15 years ago
Sergey Petrunya	6035d0d755	BUG#834758: Wrong result with innner join, LooseScan, two-column IN() predicate - get_bound_sj_equalities() would produce incorrect bitmap when non-first equality was bound, which resulted in invalid LooseScan plans.	15 years ago
Sergey Petrunya	945a595aa3	BUG#834534: Assertion `0' failed in replace_where_subcondition with semijoin subquery in HAVING - The problem was that the code that made the check whether the subquery is an AND-part of the WHERE clause didn't work correctly for nested subqueries. In particular, grand-child subquery in HAVING was treated as if it was in the WHERE, which eventually caused an assert when replace_where_subcondition looked for the subquery predicate in the WHERE and couldn't find it there. - The fix: Removed implementation of "thd_marker approach". thd->thd_marker was used to determine the location of subquery predicate: setup_conds() would set accordingly it when making the {where\|on_expr}->fix_fields(...) call so that AND-parts of the WHERE/ON clauses can determine they are the AND-parts. Item_cond_or::fix_fields(), Item_func::fix_fields(), Item_subselect::fix_fields (this one was missed), and all other items-that-contain-items had to reset thd->thd_marker before calling fix_fields() for their children items, so that the children can see they are not AND-parts of WHERE/ON. - The "thd_marker approach" required that a lot of code in different locations maintains correct value of thd->thd_marker, so it was replaced with: - The new approach with mark_as_condition_AND_part does not keep context in thd->thd_marker. Instead, setup_conds() now calls {where\|on_expr}->mark_as_condition_AND_part() and implementations of that function make sure that: - parts of AND-expressions get the mark_as_condition_AND_part() call - Item_in_subselect objects record that they are AND-parts of WHERE/ON	15 years ago
Sergey Petrunya	c9494dc42d	BUG#818280: crash in do_copy_not_null() in maria-5.3 with semijoin - Make simplify_joins() set maybe_null=FALSE for tables that were on the inner sides of inner joins and then were moved to the inner sides of semi-joins.	15 years ago
Igor Babaev	b7e9713ee3	Fixed LP bug #819716 . Do not optimize derived table for the second time ever.	15 years ago
Sergey Petrunya	c86ffc23ee	BUG#803457: Wrong result with semijoin + view + outer join in maria-5.3-subqueries-mwl90 - Correct handling of outer joins + DuplicateWeedout (docs pending)	15 years ago
Sergey Petrunya	5df875b02b	BUG#803303: Wrong result with semijoin=on, outer join in maria-5.3-subqueries-mwl90 - Add testcase.	15 years ago
Sergey Petrunya	775ac38dcd	Buildbot fixes: add --sorted-result	15 years ago
unknown	af284b55f0	Make subquery cache off by default. mysql-test/r/subselect_scache.result: Test with subquery cache on. mysql-test/t/subselect_scache.test: Test with subquery cache on.	15 years ago
Sergey Petrunya	56a23357ae	BUG#803457: Wrong result with semijoin + view + outer join in maria-5.3-subqueries-mwl90 (This is not a real fix for this bug, even though it makes it to no longer repeat) - Semi-join subquery predicates, i.e. ... WHERE outer_expr IN (SELECT ...) may have null-rejecting properties, may allow to convert outer joins into inner. - When convert_subq_to_sj() injected IN-equality into parent's WHERE/ON clause, it didn't call $new_cond->top_level_item(), which would cause null-rejecting properties to be lost. - Fixed, now the mentioned outer-to-inner conversion will really take place.	15 years ago
Sergey Petrunya	85571ea76c	Disable LooseScan and FirstMatch when outer joins are present.	15 years ago
Igor Babaev	102fb4e0b8	Corrected the code of the recent patch that had changed the base class for Item_func_xor. Added the implementation of the subst_argument_checker virtual method that the objects of this class used to use before the patch. Reverted the previous result changes in sunselect_sj and subselect_sj_jcl6.	15 years ago
Sergey Petrunya	bf28449803	Update test results for previous cset	15 years ago
Sergey Petrunya	1492de8563	Set the default to be mrr=off,mrr_sort_keys=off: - Set the default - Adjust the testcases so that 'new' tests are run with optimizations turned on. - Pull out relevant tests from "irrelevant" tests and run them with optimizations on. - Run range.test and innodb.test with both mrr=on and mrr=off	15 years ago
Sergey Petrunya	a5a8683f70	# BUG#611704: Crash in replace_where_subcondition with nested subquery and semijoin=on - SELECT_LEX::merge_subquery should not set "(*in_subq)->emb_on_expr_nest= derived" for subqueries that are in the ON expressions of semi-joins.	15 years ago
Sergey Petrunya	05d54b121c	BUG#803365: Crash in pull_out_semijoin_tables with outer join + semijoin + derived tables in maria-5.3 with WL#106 - Don't perform table pullout out of semi-join nests that have nested outer joins.	15 years ago
Sergey Petrunya	c1de6f8b77	Change the default @@optimizer_switch setting from semijoin=on,firstmatch=on,loosescan=on to semijoin=off,firstmatch=off,loosescan=off Adjust the testcases: - Modify subselect*.test and join_cache.test so that all tests use the same execution paths as before (i.e. optimizations that are being tested are enabled) - Let all other test files run with the new default settings (i.e. with new optimizations disabled) - Copy subquery testcases from these files into t/subselect_extra.test which will run them with new optimizations enabled.	15 years ago
Sergey Petrunya	e2eafc3bd1	Fix buildbot failures: - JOIN::prepare would have set JOIN::table_count to incorrect value (bad merge of MWL 106) - optimize_keyuse() would use table-bit as table number (the change in optimize_keyuse is also the reason for query plan changes. Not expected to have much effect because only handles cases of no index statistics) - st_select_lex::register_dependency_item() ignored the fact that some of the selects on the dependency paths could have been merged to their parents (because they were mergeable VIEWs) - Undo the incorrect fix in Item_subselect::recalc_used_tables(): do not call fix_after_pullout() for Item_subselect::Ref_to_outside members.	15 years ago
Sergey Petrunya	f30b4a0ded	lp:802965: Crash in do_copy_not_null with semijoin=on in maria-5.3 - The crash was because a NOT NULL table column inside the subquery was considered NULLable because the code thought it was on the inner side of an outer join nest. - Fixed by making correct distinction between tables inside outer join nests and inside semi-join nests.	15 years ago
Sergey Petrunya	4493197125	Followup to previous commit: - Update test results - Fix a problem with PS: = convert_subq_to_sj() should not save where to prep_where or on_expr to prep_on_expr. = After an unmerged subquery predicate has been pulled, it should call fix_after_pullout() for outer_refs.	15 years ago
Sergey Petrunya	95cba1043e	BUG#751484: Valgrind warning / sporadic crash in evaluate_join_record sql_select.cc:14099 with semijoin - Added testcase. The bug is most likely fixed by MWL#90 code.	15 years ago
Sergey Petrunya	c25728cdd9	More semi-join + outer-join testcases.	15 years ago

1 2 3

111 Commits (841a74a4d6ebdaa2760ce615e7fc18f57100ee19)