mariadb

Tree: 841a74a4d6

Author	SHA1	Message	Date
Igor Babaev	841a74a4d6	Fixed LP bug #939009 . The result of materialization of the right part of an IN subquery predicate is placed into a temporary table. Each row of the materialized table is distinct. A unique key over all fields of the temporary table is defined and created. It allows to perform key look-ups into the table. The table created for a materialized subquery can be accessed by key as any other table. The function best_access-path search for the best access to join a table to a given partial join. With some where conditions this function considers a possibility of a ref_or_null access. If such access employs the unique key on the temporary table then when estimating the cost this access the function tries to use the array rec_per_key. Yet, such array is not built for this unique key. This causes a crash of the server. Rows returned by the subquery that contain nulls don't have to be placed into temporary table, as they cannot be match any row produced by the left part of the subquery predicate. So all fields of the temporary table can be defined as non-nullable. In this case any ref_or_null access to the temporary table does not make any sense and it does not make sense to estimate such an access. The fix makes sure that the temporary table for a materialized IN subquery is defined with columns that are all non-nullable. The also ensures that any row with nulls returned by the subquery is not placed into the temporary table.	14 years ago
Sergey Petrunya	567d871ff0	Don't run test for BUG#933412 with embedded server, as it requires concurrent query execution which mtr --embedded does not support	14 years ago
Sergey Petrunya	59b2bb9aca	Added back MRR counters. The new names are: Handler_mrr_init, Handler_mrr_key_refills, Handler_mrr_rowid_refills.	14 years ago
unknown	c299e027ee	Changed names of statistic variables and counting matches instaed of rejected rows.	14 years ago
Sergei Golubchik	c9fc9f7317	lp:923429 Crash in decimal_cmp on using UNIX_TIMESTAMP with a wrongly formatted timestamp UNIX_TIMESTAMP() can be null, and returns null for invalid values	14 years ago
Michael Widenius	6fbeed067b	Fixed that 'make distcheck' works with automake 1.11.11 Fixed compiler warnings found by buildbot Makefile.am: Removed extra empty line cmd-line-utils/libedit/sys.h: Fixed that strndup() doesn't give compiler warnings mysql-test/Makefile.am: Fixes for 'make distcheck' plugin/auth_pam/auth_pam.c: Ensure that prototype for strndup() is included on linux sql/share/Makefile.am: Fixes for 'make distcheck' storage/innodb_plugin/btr/btr0sea.c: Fixed compiler warning support-files/Makefile.am: Fixes for 'make distcheck'	14 years ago
Michael Widenius	70e6f0d854	Fixed suppression expression.	14 years ago
Michael Widenius	3608ec3036	Fixed wrong test case mysql-test/suite/innodb_plugin/t/innodb_gis.test: Don't run test if innodb_plugin isn't used.	14 years ago
Michael Widenius	7ed4806b11	More general handling of memory loss in dlclose (backported from 5.2) Fixed supression in mysql-test-run so it also works on windows. mysql-test/mysql-test-run.pl: Fixed supression so it also works on windows. mysql-test/valgrind.supp: More general handling of memory loss in dlclose (backported from 5.2) sql/signal_handler.cc: Added newlines around link to how to do bug reports	14 years ago
Sergey Petrunya	c381e44050	BUG#933412: Server crashes in _mi_put_key_in_record on KILL QUERY with ICP, STRAIGHT_JOIN - In mi_rkey(), do correct handling of case where mi_yield_and_check_if_killed() detects that the thread was killed (all other similar functions in MyISAM/Aria have slightly different code and do not have this problem). - Also fixed assignment in DBUG_ASSERT - this is 2nd variant of the fix: = make .result file smaller = run KILLable statements in a separate connection, otherwise we could end up trying to KILL the final "DROP TABLE" statement	14 years ago
Michael Widenius	84a3767c19	Fixed issue found by buildbot mysql-test/suite/innodb/t/innodb_bug51920.test: Add another possible connect error	14 years ago
Michael Widenius	3c07d04580	Fixed lp:902654 "MariaDB consistently crashes in collect_tables on Aria checkpoint execution" This happend when you have more than 1024 open Aria tables during checkpoint. mysql-test/mysql-test-run.pl: Fixed that variable names are consistent between external and internal server. mysql-test/suite/maria/suite.pm: Test for aria-block-size instead of 'aria' as 'aria' is not set for embedded server. This should be ok for aria tests, as aria is never disabled for these. storage/maria/ma_checkpoint.c: Fixed bug when there are more than 1024 open Aria tables during checkpoint.	14 years ago
Sergey Petrunya	fecad7c945	BUG#933407: Valgrind warnings in mark_as_null_row with materialization+semijoin, STRAIGHT_JOIN, impossible WHERE - In return_zero_rows(), don't call mark_as_null_row() for semi-join materialized tables, because 1) they may have been already freed, and 2)there is no real need to call mark_as_null_row() for them.	14 years ago
Igor Babaev	3ef46370e9	Fixed bug #934348 . This bug is the result of an incomplete/inconsistent change introduced into 5.3 code when the cond_equal parameter were added to the function optimize_cond. The change was made during a merge from 5.2 in October 2010. The bug could affect only queries with HAVING.	14 years ago
Igor Babaev	cd81f57830	Fixed LP bug #934342 . An outer join query with a semi-join subquery could return a wrong result if the optimizer chose to materialize the subquery. It happened because when substituting for the best field into a ref item used to build access keys not all COND_EQUAL objects that could be employed at substitution were checked. Also refined some code in the function check_join_cache_usage to make it safer.	14 years ago
Igor Babaev	c563ea0717	Fixed LP bug #933117 . The bug was fixed with the code back-ported from the patch for LP bug 800184 pushed into mariadb-5.3.	14 years ago
Sergey Petrunya	541334c5ac	Backport of: timestamp: Thu 2011-12-01 15:12:10 +0100 Fix for Bug#13430436 PERFORMANCE DEGRADATION IN SYSBENCH ON INNODB DUE TO ICP When running sysbench on InnoDB there is a performance degradation due to index condition pushdown (ICP). Several of the queries in sysbench have a WHERE condition that the optimizer uses for executing these queries as range scans. The upper and lower limit of the range scan will ensure that the WHERE condition is fulfilled. Still, the WHERE condition is part of the queries' condition and if ICP is enabled the condition will be pushed down to InnoDB as an index condition. Due to the range scan's upper and lower limits ensure that the WHERE condition is fulfilled, the pushed index condition will not filter out any records. As a result the use of ICP for these queries results in a performance overhead for sysbench. This overhead comes from using resources for determining the part of the condition that can be pushed down to InnoDB and overhead in InnoDB for executing the pushed index condition. With the default configuration for sysbench the range scans will use the primary key. This is a clustered index in InnoDB. Using ICP on a clustered index provides the lowest performance benefit since the entire record is part of the clustered index and in InnoDB it has the highest relative overhead for executing the pushed index condition. The fix for removing the overhead ICP introduces when running sysbench is to disable use of ICP when the index used by the query is a clustered index. When WL#6061 is implemented this change should be re-evaluated.	14 years ago
unknown	607aab9c1d	Counters for Index Condition Pushdown added (MDEV-130).	14 years ago
unknown	764eeeee74	Fix for LP BUG#910123 MariaDB 5.3.3 causes 1093 error on Drupal Problem was that now we can merge derived table (subquery in the FROM clause). Fix: in case of detected conflict and presence of derived table "over" the table which cased the conflict - try materialization strategy.	14 years ago
Alexey Botchkov	7ab53e8062	MDEV-59 Review and push crashsafe GIS keys. tests for RTree keys recovery.	14 years ago
Sergey Petrunya	c9355dc279	BUG#928048: Query containing IN subquery with OR in the where clause returns a wrong result - Make equality propagation work correctly when done inside the OR branches	14 years ago
Igor Babaev	c8bbe06ac7	Fixed LP bug #925985 . If the flag 'optimize_join_buffer_size' is set to 'off' and the value of the system variable 'join_buffer_size' is greater than the value of the system variable 'join_buffer_space_limit' than no join cache can be employed to join tables of the executed query. A bug in the function JOIN_CACHE::alloc_buffer allowed to use join buffer even in this case while another bug in the function revise_cache_usage could cause a crash of the server in this case if the chosen execution plan for the query contained outer join or semi-join operation.	14 years ago
unknown	f6cdddf51f	Test case for bug lp:905353 The bug itself is fixed by the patch for bug lp:908269.	14 years ago
Igor Babaev	3efc8d016f	Made mrr related counters temporarily invisible until we agree upon their names.	14 years ago
unknown	79a04a2c9c	Moving LP BUG#794005 to 5.3 + fixing INSERT of multi-table view.	14 years ago
unknown	52d4103ccc	Fixed DELETE issues of view over view over table.	14 years ago
unknown	b9616d815d	Added 5.2 test result delimiter	14 years ago
unknown	d6e1377ac2	Fix check of view updatability in case of underlying view changes its updatability. For single table update/insert added deep check of single tables (single_table_updatable()). For multi-table view insert added additional check of target table (check_view_single_update). Multi-update was correct. Test suite for all cases added.	14 years ago
unknown	b4643d75fe	fix for LP BUG#921878. Problem was in try to check/use Item_direct_ref of derived view when we have to use real Item_field under it.	14 years ago
Sergei Golubchik	7ed15e6e50	sort status variables alphabetically in mysqld.cc	14 years ago
Sergey Petrunya	12bd3dfe29	BUG#923246: Loosescan reports different result than other semijoin methods - If LooseScan is used with quick select, require that quick select produces data in key order (this disables use of MRR, which can return data in arbitrary order).	14 years ago
Igor Babaev	5ca1dd8f0b	Fixed LP bug #922971 . Applied the fix for bug #12546542 from the mysql-5.6 code line: JOIN_CACHE::join_records forgot to reset JOIN_TAB::first_unmatched in some cases.	14 years ago
Igor Babaev	4e2b6d45e0	Back-ported test cases for bug #59919 of mysql-5.6 code line. The bug could not be reproduced in the latest release of mariadb-5.3 as it was was fixed by Sergey Petrunia when working on the problems concerning outer joins within in subqueries converted to semi-joins.	14 years ago
Sergey Petrunya	4f4047a259	Make testcase stable by adding --sorted_result for SHOW STATUS commands.	14 years ago
Sergey Petrunya	53fde5bb6f	BUG#922254: Assertion `0' failed at item_cmpfunc.cc:5899: Item* Item_equal::get_first(JOIN_TAB, Item) Fixed Item* Item_equal::get_first(JOIN_TAB context, Item field_item) to work correctly in the case where: - context!= NO_PARTICULAR_TAB, it points to a table within SJ-Materialization nest - field_item points to an item_equal that has a constant Item_field but does not have any fields from tables that are within semi-join nests.	14 years ago
Sergey Petrunya	424f56b3ba	BUG#920713: Wrong result (missing rows) with firstmatch+BNL, IN subquery, ... - Disable use of join cache when we're using FirstMatch strategy, and the join order is such that subquery's inner tables are interleaved with outer. Join buffering code is incapable of handling such join orders. - The testcase requires use of @@debug_optimizer_prefer_join_prefix to hit the bug, but I'm pushing it anyway (including the mention of the variable in .test file), so that it can be found and enabled when/if we get something comparable in the main tree.	14 years ago
Sergey Petrunya	73cc529b51	BUG#920255: Wrong result (extra rows) with loosescan and IN subquery The problem was that LooseScan execution code assumed that tab->key holds the index used for looseScan. This is only true when range or full index scan are used. In case of ref access, the index is in tab->ref.key (and tab->index==0 which explains how LooseScan passed tests with ref access: they used one index) Fixed by setting/using loosescan_key, which always the correct index#.	14 years ago
Sergey Petrunya	e10816118a	Update handler status variables after the last commit.	14 years ago
Sergei Golubchik	8fedf8ac75	mtr runs only "big" tests, if --big-test is repeated twice	14 years ago
Sergey Petrunya	2ae3fca465	Add MRR counters: Handler_mrr_init, Handler_mrr_extra_rowid_sorts, Handler_mrr_extra_key_sorts.	14 years ago
Igor Babaev	7bdbdb05ce	Back-ported test cases for bugs #54437 , #55955 , #52329 , #57623 from subquery_sj of mysql-5.6 code line. The bugs could not be reproduced in the latest release of mariadb-5.3 as they were fixed either when the code of subquery optimization was back-ported from mysql-6.0 or later when some other bugs were fixed.	14 years ago
Igor Babaev	80009f5862	Back-ported test cases for bugs #53060 , #53305 , #50358 , #49453 from subquery_sj of mysql-5.6 code line. The bugs could not be reproduced in the latest release of mariadb-5.3 as they were fixed either when the code of subquery optimization was back-ported from mysql-6.0 or later when some other bugs were fixed.	14 years ago
Igor Babaev	bb4053afc3	Fixed LP bug #919427 . The function subselect_uniquesubquery_engine::copy_ref_key has to take into account that when EXPLAIN is processed the array of store_key object created for any TABLE_REF may contain elements for constant items. These items should be ignored by thefunction.	14 years ago
Sergey Petrunya	9f60aa27f7	BUG#912513: Wrong result (missing rows) with join_cache_hashed+materialization+semijoin=on - equality substitution code was geared towards processing WHERE/ON clauses. that is, it assumed that it was doing substitions on the code that = wasn't attached to any particular join_tab yet = was going to be fed to make_join_select() which would take the condition apart and attach various parts of it to tables inside/outside semi-joins. - However, somebody added equality substition for ref access. That is, if we have a ref access on TBL.key=expr, they would do equality substition in 'expr'. This possibility wasn't accounted for. - Fixed equality substition code by adding a mode that does equality substition under assumption that the processed expression will be attached to a certain particular table TBL.	14 years ago
Sergey Petrunya	8bedf1ea1c	BUG#912538: Wrong result (missing rows) with semijoin=on, firstmatch=on, ... - setup_semijoin_dups_elimination() would incorrectly set join_tab->do_firstmatch when the join order had outer tables interleaved with inner.	14 years ago
Igor Babaev	746dbbe583	Fixed LP bug #917990 . If the expression for a derived table of a query contained a LIMIT clause the estimate of the number of rows in this derived table returned by the EXPLAIN command could be badly off since the optimizer ignored the limit number from the LIMIT clause when getting the estimate. The call of the method SELECT_LEX_UNIT->set_limit added in the code of mysql_derived_optimize() will be needed also in maria-5.5 where parameters in the LIMIT clause are supported.	14 years ago
unknown	69327e2987	Adjust test results after Monty's push of the new handler counter Handler_read_rnd_deleted.	14 years ago
Michael Widenius	5438d57315	Added Handler_read_rnd_deleted, number of deleted rows found with ha_read_rnd_first.	14 years ago
unknown	cf31ccc33c	Fix for LP BUG#908269 Wrong result with subquery in select list, EXISTS, constant MyISAM/Aria table. Problem: When building the condition for JOIN::outer_ref_cond the optimizer forgot to take into account that this condition could depend on constant tables as well.	14 years ago
Michael Widenius	a148cf7fb0	Fixed that --sorted-result in mysql-test-run also works for exec mysql-test/r/information_schema_all_engines.result: Update result mysql-test/t/information_schema_all_engines.test: Added --sorted-results as tables in information_schema are not sorted.	14 years ago

1 2 3 4 5 ...

28365 Commits (841a74a4d6ebdaa2760ce615e7fc18f57100ee19)