mariadb

Tree: 7f5849a809

Author	SHA1	Message	Date
Marko Mäkelä	e63f621652	Remove references to MySQL 5.7 native InnoDB partitioning The native InnoDB partitioning was never enabled in MariaDB. Remove some declarations and comments referring to it.	7 years ago
Marko Mäkelä	56304875f7	MDEV-18836 ASAN: heap-use-after-free after TRUNCATE row_drop_tables_for_mysql_in_background(): Copy the table name before closing the table handle, to avoid heap-use-after-free if another thread succeeds in dropping the table before row_drop_table_for_mysql_in_background() completes the table name lookup. dict_mem_create_temporary_tablename(): With innodb_safe_truncate=ON (the default), generate a simple, unique, collision-free table name using only the id, no pseudorandom component. This is safe, because on startup, we will drop any #sql tables that might exist in InnoDB. This is a backport from 10.3. It should have been backported already as part of backporting MDEV-14717,MDEV-14585 which were prerequisites for the MDEV-13564 backup-friendly TRUNCATE TABLE. This seems to reduce the chance of table creation failures in ha_innobase::truncate(). ha_innobase::truncate(): Do not invoke close(), but instead mimic it, so that we can restore to the original table handle in case opening the truncated copy of the table failed.	7 years ago
Marko Mäkelä	ec24dd0be9	Add an end-of-tests marker to ease merges	7 years ago
Jan Lindström	691c306953	MDEV-14033: wsrep_on=off + binlog = mixed on MariaDB 10.2.9 If wsrep provider (i.e. galera library) is defined but wsrep_on=OFF we should not force row binlog row format.	7 years ago
Jan Lindström	d0ebb155fe	MDEV-18577: Indexes problem on import dump SQL Problem was that we skipped background persistent statistics calculation on applier nodes if thread is marked as high priority (a.k.a BF). However, on applier nodes all DDL which is replicate will be executed as high priority i.e BF. Fixed by allowing background persistent statistics calculation on applier nodes even when thread is marked as BF. This could lead BF lock waits but for queries on that node needs that statistics.	7 years ago
Sergey Vojtovich	20928e2e96	MDEV-14984 - regression in connect performance Removed redundant plugin_thdvar_cleanup() from end_connection(): called by THD::free_connection(), which always follows end_connection(). Saves at least one lock(LOCK_plugin) and one rdlock(LOCK_system_variables_hash). Benchmarked on a 2socket/20core/40threads Broadwell system using sysbench connect brencmark @40 threads (with select 1 disabled). 10.2 shows moderate improvement: 136219.93 -> 137766.31 CPS. 10.3 is improvement is somewhat better: 93018.29 -> 101379.77 CPS. Also backported MyRocks memory leak fix from 10.4, which turned out to be unrelated.	7 years ago
Marko Mäkelä	aa6058469e	Revert a part of commit `676f43da3a` We do want to ignore InnoDB's internal #sql-ib*.ibd at shutdown, because those tables will be dropped on the next startup. Failure to filter out these table names occasionally causes some unwanted output for tests that restart InnoDB soon after dropping or truncating tables, for example innodb.recovery_shutdown.	7 years ago
Marko Mäkelä	ee17f7285a	TruncateLogParser::scan(): Simplify string operations This also fixes -Wstringop-truncation that GCC 8 issued for strncpy().	7 years ago
Marko Mäkelä	945edfff2b	Silence GCC 8 -Wno-class-memaccess	7 years ago
Alexander Barkov	90ce95de4b	Tests for MDEV-18892 Regression in slow log and admin statements The patch for MDEV-15945 fixed MDEV-18892. Adding tests only.	7 years ago
Varun Gupta	fe8cf7f131	MDEV-18502: Server crash in find_field_in_tables upon 2nd execution of SP which causes ER_WRONG_GROUP_FIELD Fixed by the commit `cb11b3fb`. Adding the test case for this issue.	7 years ago
Varun Gupta	a4e5888248	MDEV-18431: Select max + row_number giving incorrect result The issue here was when we had a subquery and a window function in an expression in the select list then subquery was getting computed after window function computation. This resulted in incorrect results because the subquery was correlated and the fields in the subquery was pointing to the base table instead of the temporary table. The approach to fix this was to have an additional field in the temporary table for the subquery and to execute the subquery before window function execution. After execution the values for the subquery were stored in the temporary table and then when we needed to calcuate the expression, all we do is read the values from the temporary table for the subquery.	7 years ago
Jan Lindström	3b2a568589	Test cleanups.	7 years ago
Marko Mäkelä	f72760df33	Add an end-of-tests marker to ease merges	7 years ago
Sergei Golubchik	a62e9a83c0	MDEV-15945 --ps-protocol does not test some queries Make mysqltest to use --ps-protocol more use prepared statements for everything that server supports with the exception of CALL (for now). Fix discovered test failures and bugs. tests: * PROCESSLIST shows Execute state, not Query * SHOW STATUS increments status variables more than in text protocol * multi-statements should be avoided (see tests with a wrong delimiter) * performance_schema events have different names in --ps-protocol * --enable_prepare_warnings mysqltest.cc: * make sure run_query_stmt() doesn't crash if there's no active connection (in wait_until_connected_again.inc) * prepare all statements that server supports protocol.h * Protocol_discard::send_result_set_metadata() should not send anything to the client. sql_acl.cc: * extract the functionality of getting the user for SHOW GRANTS from check_show_access(), so that mysql_test_show_grants() could generate the correct column names in the prepare step sql_class.cc: * result->prepare() can fail, don't ignore its return value * use correct number of decimals for EXPLAIN columns sql_parse.cc: * discard profiling for SHOW PROFILE. In text protocol it's done in prepare_schema_table(), but in --ps it is called on prepare only, so nothing was discarding profiling during execute. * move the permission checking code for SHOW CREATE VIEW to mysqld_show_create_get_fields(), so that it would be called during prepare step too. * only set sel_result when it was created here and needs to be destroyed in the same block. Avoid destroying lex->result. * use the correct number of tables in check_show_access(). Saying "as many as possible" doesn't work when first_not_own_table isn't set yet. sql_prepare.cc: * use correct user name for SHOW GRANTS columns * don't ignore verbose flag for SHOW SLAVE STATUS * support preparing REVOKE ALL and ROLLBACK TO SAVEPOINT * don't ignore errors from thd->prepare_explain_fields() * use select_send result for sending ANALYZE and EXPLAIN, but don't overwrite lex->result, because it might be needed to issue execute-time errors (select_dumpvar - too many rows) sql_show.cc: * check grants for SHOW CREATE VIEW here, not in mysql_execute_command sql_view.cc: * use the correct function to check privileges. Old code was doing check_access() for thd->security_ctx, which is invoker's sctx, not definer's sctx. Hide various view related errors from the invoker. sql_yacc.yy: * initialize lex->select_lex for LOAD, otherwise it'll contain garbage data that happen to fail tests with views in --ps (but not otherwise).	7 years ago
Sergei Golubchik	22f1cf9292	cleanup: misc	7 years ago
Sergei Golubchik	dda2e940fb	pass the slow logging information in thd->query_plan_flags This solves the following issues: * unlike lex->m_sql_cmd and lex->sql_command, thd->query_plan_flags is not reset in Prepared_statement::execute, it survives till the log_slow_statement(), so slow logging behaves correctly in --ps * using thd->query_plan_flags for both slow_log_filter and log_slow_admin_statements means the definition of "admin" statements for the slow log is the same no matter how it is filtered out.	7 years ago
Oleksandr Byelkin	bc8ae50e7c	Fix of prepared CREATE VIEW with global ORDER/GROUP	7 years ago
Oleksandr Byelkin	83123412f0	MDEV-11975: SQLCOM_PREPARE of EXPLAIN & ANALYZE statement do not return correct metadata info Added metadate info after prepare EXPLAIN/ANALYZE.	8 years ago
Oleksandr Byelkin	01c49e66b5	MDEV-11966: Impossible to execute prepared ANALYZE SELECT Prepare os ANALYZE now respond as EXPLAIN.	9 years ago
Marko Mäkelä	bef947b4c9	MDEV-18902 Uninitialized variable in recv_parse_log_recs() recv_parse_log_recs(): Do not compare type if ptr==end_ptr (we have reached the end of the redo log parsing buffer), because it will not have been correctly initialized in that case.	7 years ago
Marko Mäkelä	e070cfe398	MDEV-18878: Fix GCC -flifetime-dse GCC 6 and later can optimize away the memset() that is part of mem_heap_zalloc() in a placement new call. So, instead of relying on that kind of initialization, explicitly initialize the necessary fields in the constructors. que_common_t::que_common_t(): Initialize more fields in the default constructor. purge_vcol_info_t::purge_vcol_info_t(): Initialize all fields in the default constructor. purge_node_t::purge_node_t(): Initialize all necessary fields. Reference: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71388 https://gcc.gnu.org/ml/gcc/2016-02/msg00207.html	7 years ago
Marko Mäkelä	e374755bae	Merge 10.1 into 10.2	7 years ago
Marko Mäkelä	32de60bb2e	MDEV-18749: Fix GCC -flifetime-dse row_merge_create_fts_sort_index(): Initialize dict_col_t in an unambiguous way. GCC 6 and later appear to be able to optimize away the memset() that is part of mem_heap_zalloc() in the placement new call. Let us avoid using placement new in order to ensure that the objects will actually be initialized. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71388 https://gcc.gnu.org/ml/gcc/2016-02/msg00207.html While the latter reference hints that the optimization is only applicable to non-POD types (and dict_col_t does not define any member functions before 10.2), it is most consistent to use the same initialization across all versions.	7 years ago
Sergei Golubchik	69abd43703	MDEV-17070 Table corruption or Assertion `table->file->stats.records > 0 \|\| error' or Assertion `!is_set() \|\| (m_status == DA_OK_BULK && is_bulk_op())' failed upon actions on temporary table This was caused by a combination of factors: * MyISAM/Aria temporary tables historically never saved the state to disk (MYI/MAI), because the state never needed to persist * certain ALTER TABLE operations modify the original TABLE structure and if they fail, the original table has to be reopened to revert all changes (m_needs_reopen=1) as a result, when ALTER fails and MyISAM/Aria temp table gets reopened, it reads the stale state from the disk. As a fix, MyISAM/Aria tables now always write the state to disk on close, unless HA_EXTRA_PREPARE_FOR_DROP was done first. And the server now always does HA_EXTRA_PREPARE_FOR_DROP before dropping a temporary table.	7 years ago
Sergei Golubchik	7025a51a7b	fix the typo OPTION_NO_CHECK_CONSTRAINT_CHECKS	7 years ago
Alexey Botchkov	acb4a87204	MDEV-18886 JSON_ARRAY() does not recognise JSON argument. JSON_ARRAY and JSON_OBJECT functions with no arguments now get the connection charset. Item_func_convert_charset returns the correct is_json() flag.	7 years ago
Sergey Vojtovich	ea52ecbc10	Merge remote-tracking branch 'origin/10.0' into 10.1	7 years ago
Sergey Vojtovich	149b754768	MDEV-17595 - ALTER TABLE ADD FOREIGN KEY crash ALTER TABLE ... ADD FOREIGN KEY may trigger assertion failure when it has LOCK=EXCLUSIVE clause or concurrent FLUSH TABLES is being executed. In both cases being altered table is marked as flushed, which forces subsequent attempt to open parent table to re-open. Which in turn is not allowed while transaction is running. Rather than opening parent table, just take appropriate MDL lock. Also removed table_already_fk_prelocked() check: MDL itself has much better methods to handle duplicate locks. E.g. the former won't acquire MDL_SHARED_NO_WRITE if it already has MDL_SHARED_READ.	7 years ago
Marko Mäkelä	28e713dc12	MDEV-18878: Correct a condition Initialize node->trx_id before checking if a table can be skipped.	7 years ago
Marko Mäkelä	219752805c	Try to address MDEV-17745 wait_all_purged.inc: Wait for 60 seconds instead of 30 seconds. Purge can be slow on buildbot, especially in ASAN-instrumented builds.	7 years ago
Marko Mäkelä	6e76704613	MDEV-18878: Slimmer purge in non-debug builds purge_node_t::in_progress: Replaces purge_node_t::done. Only present in debug builds. purge_node_t::start(): Moved from the start of row_purge_step(). purge_node_t::end(): Replaces row_purge_end(). trx_purge_attach_undo_recs(): Omit a check from non-debug builds.	7 years ago
Marko Mäkelä	1ab049e572	MDEV-18878 Purge: Optimize away futile table lookups If a table has been dropped, rebuilt, or its tablespace has been discarded or the table is corrupted, it does not make sense to look up that table again while purging old undo log records. purge_node_t::purge_node_t(): Replaces row_purge_node_create(). que_common_t::que_common_t(): Constructor. row_import_update_index_root(): Remove the constant parameter dict_locked=true, and update the table->def_trx_id in the cache. purge_node_t::unavailable_table_id: The latest unavailable table ID, to avoid future lookups. purge_node_t::def_trx_id: The latest modification of the table identified by unavailable_table_id, or TRX_ID_MAX. purge_node_t::is_skipped(): Determine if a table should be skipped. purge_node_t::skip(): Note that a table should be skipped.	7 years ago
Marko Mäkelä	3ea49d35bd	Merge 10.1 into 10.2	7 years ago
Eugene Kosov	2a2ab121b0	MDEV-17703 Add WITH_UBSAN switch to CMake similar to WITH_ASAN This can be useful: UBSAN_OPTIONS=log_path=/some/path clang users may want to increase stack size in include/my_pthread.h or enable some optimizations	7 years ago
Marko Mäkelä	0415021840	Clean up mysql-test/suite/galera/disabled.def again Clean up after commit `0957d25781` which introduced some disorder (unsorted or duplicated test names).	7 years ago
Jan Lindström	b31d025c97	Decrease the time required to run test by removing unnecessary sleeps. modified: suite/galera/t/galera_autoinc_sst_mariabackup.test	7 years ago
Jan Lindström	9fb84a166a	remove WSREP_SST_OPT_SUFFIX_VALUE, checking [mysqld] is covered in the parse_cnf --mysqld case also in wsrep_sst_xtrabackup-v2	7 years ago
Jan Lindström	a05ca1a99a	Galera 3 versions of the result files recorded.	7 years ago
Daniel Black	e8541c7565	galera: test cases for non [mysqld] section for configuration	7 years ago
Daniel Black	85a18526bc	wsrep_sst: remove WSREP_SST_OPT_SUFFIX_VALUE, checking [mysqld] is covered in the parse_cnf --mysqld case	7 years ago
Jan Lindström	0957d25781	MDEV-18830: Port SST fixes from 10.4 to 10.1 modified: mysql-test/suite/galera/disabled.def modified: mysql-test/suite/galera/r/galera_many_rows.result modified: mysql-test/suite/galera/t/galera_kill_nochanges.test new file: mysql-test/suite/galera/t/galera_many_rows.cnf modified: mysql-test/suite/galera/t/galera_many_rows.test modified: mysql-test/suite/galera/t/galera_var_dirty_reads.test modified: scripts/wsrep_sst_mariabackup.sh	7 years ago
Marko Mäkelä	ab7e2b048d	Merge 10.1 into 10.2	7 years ago
Marko Mäkelä	6567636b09	Disable regularly failing Galera tests galera.partition and galera.galera_binlog_stmt_autoinc regularly display mismatching values for AUTO_INCREMENT columns. galera.MW-336 often times out while waiting for something in PROCESSLIST. Also, sort the test names, remove the redundant "galera." prefix and fix typos in 2 test names.	7 years ago
Thirunarayanan Balathandayuthapani	d038806dfe	MDEV-18855 Mariabackup should fetch innodb_compression_level from running server - Fetch innodb_compression_level from the running server.Add the value of innodb_compression_level in backup-my.cnf file during backup phase. So that prepare can use the innodb_compression_level variable from backup-my.cnf	7 years ago
Marko Mäkelä	bf71d26362	MDEV-13818 after-merge fix: Extend the test case The 10.1 changes to the test case were accidentally omitted in the merge commit `913e33e423`.	7 years ago
Marko Mäkelä	f855ec24d7	MDEV-18272: Add the test case The test case was accidentally omitted from the merge commit `913e33e423`.	7 years ago
Marko Mäkelä	b4cda8bbbc	After-merge fix for GCC GCC does not like MY_ATTRIBUTE((nonnull)) on a reference-to-pointer parameter. clang did not flag an issue wit that.	7 years ago
Marko Mäkelä	913e33e423	Merge 10.1 into 10.2 Rewrite the MDEV-13818 fix to prevent heap-use-after-free. Add a test case for MDEV-18272.	7 years ago
Marko Mäkelä	e3adf96aeb	MDEV-13818 CREATE INDEX leaks memory if running out of undo log space row_merge_create_index_graph(): Relay the internal state from dict_create_index_step(). Our caller should free the index only if it was not copied, added to the cache, and freed. row_merge_create_index(): Free the index template if it was not added to the cache. This is a safer variant of the logic that was introduced in `65070beffd` in 10.2. prepare_inplace_alter_table_dict(): Add additional fault injection to exercise a code path where we have already added an index to the cache.	7 years ago

... 2 3 4 5 6 ...

181817 Commits (7f5849a809670c6466a71dc93133ca0a1504de05) All Branches Search

181817 Commits (7f5849a809670c6466a71dc93133ca0a1504de05)

All Branches