mariadb

Tree: 72429cad7f

Author	SHA1	Message	Date
Nikita Malyavin	72429cad7f	MDEV-30046 wrong row targeted with "insert ... on duplicate" and "replace" When HA_DUPLICATE_POS is not supported, the row to replace was navigated by ha_index_read_idx_map, which uses only hash to navigate. Suchwise, given a hash collision it may choose an incorrect row. handler::position would be correct and very convenient to use here. dup_ref is already set by handler independently of the engine capabilities, when an extra lookup is made (for long unique or something else, for example WITHOUT OVERLAPS) such error will be indicated by file->lookup_errkey != -1.	3 years ago
Alexander Barkov	97fcafb9ec	MDEV-32837 long unique does not work like unique key when using replace write_record() when performing REPLACE has an optimization: - if the unique violation happened in the last unique key, then do UPDATE - otherwise, do DELETE+INSERT This patch changes the way of detecting if this optimization can be applied if the table has long (hash based) unique (i.e. UNIQUE..USING HASH) constraints. Problem: The old condition did not take into account that TABLE_SHARE and TABLE see long uniques differently: - TABLE_SHARE sees as HA_KEY_ALG_LONG_HASH and HA_NOSAME - TABLE sees as usual non-unique indexes So the old condition could erroneously decide that the UPDATE optimization is possible when there are still some unique hash constraints in the table. Fix: - If the current key is a long unique, it now works as follows: UPDATE can be done if the current long unique is the last long unique, and there are no in-engine (normal) uniques. - For in-engine uniques nothing changes, it still works as before: If the current key is an in-engine (normal) unique: UPDATE can be done if it is the last normal unique.	2 years ago
Sergei Golubchik	a7ee3bc58b	MDEV-29954 Unique hash key on column prefix is computed incorrectly use the original, not the truncated, field in the long unique prefix, that is, in the hash(left(field, length)) expression. because MyISAM CHECK/REPAIR in compute_vcols() moves table->field but not prefix fields from keyparts. Also, implement Field_string::cmp_prefix() for prefix comparison of CHAR columns to work.	2 years ago
Sergei Golubchik	e472b682e0	MDEV-32839 LONG UNIQUE gives error when used with REPLACE calculate auto-inc value even if long duplicate check fails - this is what the engine does for normal uniques. auto-inc value is needed if it's a REPLACE	2 years ago
Sergei Golubchik	65b3c89430	MDEV-32015 insert into an empty table fails with hash unique don't enable bulk insert when table->s->long_unique_table	2 years ago
Sergei Golubchik	382c543f53	MDEV-32012 hash unique corrupts index on virtual blobs as always when copying record[0] aside one needs to detach Field_blob::value's from it, and restore them when record[0] is restored from a backup.	2 years ago
Lena Startseva	9854fb6fa7	MDEV-31003: Second execution for ps-protocol This patch adds for "--ps-protocol" second execution of queries "SELECT". Also in this patch it is added ability to disable/enable (--disable_ps2_protocol/--enable_ps2_protocol) second execution for "--ps-prototocol" in testcases.	2 years ago
Sergei Golubchik	bc970573b3	MDEV-22756 SQL Error (1364): Field 'DB_ROW_HASH_1' doesn't have a default value exclude generated columns from the "has default value" check	3 years ago
Sergei Golubchik	fc292f42be	MDEV-29199 Unique hash key is ignored upon INSERT ... SELECT into non-empty MyISAM table disable bulk insert optimization if long uniques are used, because they need to read the table (index_read) after every inserted now. And bulk insert optimization might disable indexes. bulk insert is already disabled in other cases when there are chances that the table will be read duing the bulk insert.	3 years ago
Sachin	10132ad261	MDEV-23264 Unique blobs allow duplicate values upon UPDATE Problem:- We are able to insert duplicate value in table because cmp_binary_offset is not able to differentiate between NULL and empty string. So check_duplicate_long_entry_key is never called and we don't check for duplicate. Solution Added a if condition with is_null() on field which can differentiate between NULL and empty string.	5 years ago
Aleksey Midenkov	231feabd2b	MDEV-21540 Initialization of already inited long unique index on reorganize partition Handler for existing partition was already index-inited at the beginning of copy_partitions(). In the case of REORGANIZE PARTITION we fill new partition by calling its ha_write_row() (handler is storage engine of new partition). From that we go through the below conditions: if (this->inited == RND) table->clone_handler_for_update(); handler *h= table->update_handler ? table->update_handler : table->file; First, the above misses the meaning of this->inited check. Now it is new partition and this handler is not inited. So, we assign table->file which is ha_partition and is really not known to be inited or not. It is supposed (this == table->file), otherwise we are out of the logic for using update_handler. This patch adds DBUG_ASSERT for that. Second, we call check_duplicate_long_entries() for table->file and that calls ha_partition::index_init() which calls index_init() for each partition's handler. But the existing parititions' handlers was already inited in copy_partitions() and we fail on assertion. The fix implies that we don't need check_duplicate_long_entries() per-partition as we've already done check_duplicate_long_entries() for ha_partition. For REORGANIZE PARTITION that means existing row was already checked at previous INSERT/UPDATE commands, so no need to check it again (see NOTE in handler::ha_write_row()). The fix also optimizes ha_update_row() so check_duplicate_long_entries_update() is not called per-partition considering it was already called for ha_partition. Besides, per-partition duplicate check is not really usable.	3 years ago
Sergei Golubchik	af810407f7	MDEV-28098 incorrect key in "dup value" error after long unique reset errkey after using it, so that it wouldn't affect the next error message in the next statement	4 years ago
Nikita Malyavin	1fdac57447	MDEV-26453 Assertion `0' failed in row_upd_sec_index_entry & corruption Long UNIQUE HASH index silently creates virtual column index, which should be impossible for base columns featuring AUTO_INCREMENT. Fix: add a relevant check; add new vcol type for a prettier error message.	4 years ago
Sachin	eb14e073ea	MDEV-22719 Long unique keys are not created when individual key_part->length < max_key_length but SUM(key_parts->length) > max_key_length Make UNIQUE HASH key in case when key_info->key_length > max_key_length	5 years ago
Sachin	e208f91ba8	MDEV-21804 Assertion `marked_for_read()' failed upon INSERT into table with long unique blob under binlog_row_image=NOBLOB Problem:- Calling mark_columns_per_binlog_row_image() earlier may change the result of mark_virtual_columns_for_write() , Since it can set the bitmap on for virtual column, and henceforth mark_virtual_column_deps(field) will never be called in mark_virtual_column_with_deps. This bug is not specific for long unique, It also fails for this case create table t2(id int primary key, a blob, b varchar(20) as (LEFT(a,2)));	5 years ago
Sergei Golubchik	18502f99eb	MDEV-22185 Failing assertion: node->pcur->rel_pos == BTR_PCUR_ON or ER_KEY_NOT_FOUND or Assertion `inited==NONE' failed in handler::ha_index_init long unique checks should be done for a partitioned table as a whole, not for individual partitions. Followup for `f3f31eaa8e` that extends it to UPDATE	6 years ago
Sergei Golubchik	fcd84da5f1	MDEV-22218 InnoDB: Failing assertion: node->pcur->rel_pos == BTR_PCUR_ON upon LOAD DATA with NO_BACKSLASH_ESCAPES in SQL_MODE and unique blob in table `inited == NONE` at the initialization time does not always mean that it'll be `NONE` later, at the execution time. Use a more complex caller-specific logic to decide whether to create a cloned lookup handler. Besides LOAD (as in the original bug report) make sure that all prepare_for_insert() invocations are covered by tests. Add tests for CREATE ... SELECT, multi-UPDATE, and multi-DELETE. Don't enable write cache with long uniques.	6 years ago
Sergei Golubchik	3bb5c6b0c2	MDEV-22113 SIGSEGV, ASAN use-after-poison, Assertion `next_insert_id == 0' in handler::ha_external_lock if the lookup_handler is allocated on the THD's memroot, it may not live long enough to be deleted in handler::ha_external_lock()	6 years ago
Sachin	eed6d215f1	MDEV-20001 Potential dangerous regression: INSERT INTO >=100 rows fail for myisam table with HASH indexes Problem:- So the issue is when we do bulk insert with rows > MI_MIN_ROWS_TO_DISABLE_INDEXES(100) , We try to disable the indexes to speedup insert. But current logic also disables the long unique indexes. Solution:- In ha_myisam::start_bulk_insert if we find long hash index (HA_KEY_ALG_LONG_HASH) we will not disable the index. This commit also refactors the mi_disable_indexes_for_rebuild function, Since this is function is called at only one place, it is inlined into start_bulk_insert mi_clear_key_active is added into myisamdef.h because now it is also used in ha_myisam.cc file. (Same is done for Aria Storage engine)	6 years ago
Sachin Setiya	5a6023cf6f	MDEV-18791 Wrong error upon creating Aria table with long index on BLOB If we have long unique key for aria engine return too long key error, because Aria does not support key on virtual generated column.	6 years ago
Sachin	ba7d33a898	MDEV-18820 Assertion `lock_table_has(trx, index->table, LOCK_IX)' failed in lock_rec_insert_check_and_lock upon INSERT into table with blob key Don't Ignore Any error during index lookup, And throw duplicate key error only if error is HA_ERR_FOUND_DUPP_KEY	7 years ago
Sachin	901e3ddf79	MDEV-18904 Assertion `m_part_spec.start_part >= m_part_spec.end_part' failed in ha_partition::index_read_idx_map Remove the DBUG_ASSERT	7 years ago
Sachin	0c567648a4	Revert (MDEV-18888)2b06de8064660c5c, fix it in different way And add test case for MDEV-18953	7 years ago
Sachin	c23d4700e6	MDEV-18901 Wrong results after ADD UNIQUE INDEX(blob_column) Add test case for MDEV-18901 as MDEV-18967 and MDEV-18922 solves this issue	7 years ago
Sachin	625aa232a6	MDEV-18967 Load data in system version with long unique does not work Update system versioning fields before generated columns for left out fill_record	7 years ago
sachinsetia1001@gmail.com	3943fe5630	MDEV-18888 Server crashes in Item_field::register_field_in_read_map upon... MODIFY COLUMN Do Not create prefix field for long unique key	7 years ago
sachinsetia1001@gmail.com	8995f33c0b	MDEV-18889 Long unique on virtual fields crashes server Use table->record[0] for ha_index_read_map so that vfield gets automatically be updated.	7 years ago
sachinsetia1001@gmail.com	2e34a031f8	MDEV-18809 Server crash in fields_in_hash_keyinfo or Assertion `key_info->key_part->field->flags & (1<< 30)' failed in setup_keyinfo_hash Move calling setup_keyinfo_hash until all continue is exhausted. And also call re_setup_keyinfo_hash for goto err.	7 years ago
sachinsetia1001@gmail.com	050280ce8b	MDEV-18922 Alter on long unique varchar column makes result null Don't add long key into share->keys_for_keyread	7 years ago
sachin	62bfb2fe49	MDEV-18800 Server crash in instant_alter_column_possible or Assertion... `!pk->has_virtual()' failed in instant_alter_column_possible upon adding key Hash key can't be primary key.	7 years ago
sachin	ecf323620b	Add test cases for MDEV-18792 MDEV-18793 MDEV-18795 MDEV-18798 MDEV-18801 As MDEV-18799 fixes these mdevs so adding test cases for these mdevs.	7 years ago
sachin	560598c9b2	MDEV-18799 Long unique does not work after failed alter table Restore table->key_info after calling setup_keyinfo_hash in mysql_prepare_alter_table.	7 years ago
sachin	f9f625fb43	MDEV-18790 Server crash in fields_in_hash_keyinfo after unsuccessful... attempt to drop BLOB with long index Restore long table->key_info, So that in the case of unsuccessful table alter table->key_info should have a correct value. In the case of successful table alter old table is flushed so that is why we don't see this error in the case of successful alter.	7 years ago
Sergei Golubchik	b10340998f	MDEV-18748 REPLACE doesn't work with unique blobs on MyISAM table on long unique conflict, set table->file->dup_ref for engines that support it	7 years ago
Sergei Golubchik	9fd3e810e8	MDEV-18747 InnoDB: Failing assertion: table->get_ref_count() == 0 upon dropping temporary table with unique blob delete update handler clone also for temporary tables	7 years ago
Sergei Golubchik	304f0084ef	MDEV-18720 Assertion `inited==NONE' failed in ha_index_init upon update on versioned table with key on blob * update system versioning fields before generaled columns * don't presume that ha_write_row() means INSERT. It could still be UPDATE * use the correct handler in check_duplicate_long_entry_key()	7 years ago
Sergei Golubchik	f78c0f6f00	MDEV-18722 Assertion `templ->mysql_null_bit_mask' failed in row_sel_store_mysql_rec upon modifying indexed column into blob don't assert that virtual columns are always nullable	7 years ago
Sergei Golubchik	3f53515425	MDEV-18713 Assertion `strcmp(share->unique_file_name,filename) \|\| share->last_version' failed in test_if_reopen upon REPLACE into table with key on blob close table->update_handler in close_thread_tables(). it's not enough to do it in sql_update.cc only, because sql_insert.cc can also do updates (REPLACE) and even sql_delete.cc can (DELETE ... FOR PORTION OF)	7 years ago
Sergei Golubchik	20c89f9f37	MDEV-18712 InnoDB indexes are inconsistent with what defined in .frm for table after rebuilding table with index on blob when auto-adding a virtual LONG_UNIQUE_HASH_FIELD, fill in a Virtual_column_info for it, so that fill_alter_inplace_info() would know we're adding a virtual field (ALTER_ADD_VIRTUAL_COLUMN).	7 years ago
Sergei Golubchik	5adf11250a	MDEV-18707 Server crash in my_hash_sort_bin, ASAN heap-use-after-free in Field::is_null, server hang, corrupted double-linked list adjust share->stored_rec_length for LONG_UNIQUE_HASH_FIELD, just like it's done for normal virtual fields	7 years ago

50 Commits (72429cad7f5448ad680d8df7b55aa055462d5964)