mariadb

Tree: 723a4b1d78

Author	SHA1	Message	Date
Sergey Vojtovich	80a142f146	Lintian complains about script-not-executable Removed #! sequence from non-executable script.	7 years ago
Faustin Lammler	4adf52a048	Add missing script header	7 years ago
Sujatha	78c1be8b6b	MDEV-18913: typo in error log Problem: ======== Following typo in error log: 2019-03-13 15:58:10 0 [Note] Reading of all Master_info entries succeded Should be 'succeeded' Fix: === Fixed the typo with the right word 'succeeded'.	7 years ago
Sujatha	a47464d1c1	MDEV-11094: Blackhole table updates on slave fail when row annotation is enabled Post push fix. Simplified the earlier fixes.	7 years ago
Marko Mäkelä	1d0c27412c	MDEV-19541: Suppress an error also on Windows	7 years ago
Sujatha	b347396181	MDEV-11094: Blackhole table updates on slave fail when row annotation is enabled Problem: ======= rpl_blackhole.test fails when executed with following options mysqld=--binlog_annotate_row_events=1, mysqld=--replicate_annotate_row_events=1 Test output: ------------ worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 16000..16019 rpl.rpl_blackhole_bug 'mix' [ pass ] 791 rpl.rpl_blackhole_bug 'row' [ fail ] Replicate_Wild_Ignore_Table Last_Errno 1032 Last_Error Could not execute Update_rows_v1 event on table test.t1; Can't find record in 't1', Error_code: 1032; handler error HA_ERR_END_OF_FILE; the event's master log master-bin.000001, end_log_pos 1510 Analysis: ========= Enabling "replicate_annotate_row_events" on slave, Tells the slave to write annotate rows events received from the master to its own binary log. The received annotate events are applied after the Gtid event as shown below. thd->query() will be set to the actual query received from the master, through annotate event. Annotate_rows event should not be deleted after the event is applied as the thd->query will be used to generate new Annotate_rows event during applying the subsequent Rows events. After the last Rows event has been applied, the saved Annotate_rows event (if any) will be deleted. In balckhole engine all the DML operations are noops as they donot store any data. They simply return success without doing any operation. But the existing strictly expects thd->query() to be 'NULL' to identify that row based replication is in use. This assumption will fail when row annotations are enabled as the query is not 'NULL'. Hence various row based operations like 'update', 'delete', 'index lookup' will fail when row annotations are enabled. Fix: === Extend the row based replication check to include row annotations as well. i.e Either the thd->query() is NULL or thd->query() points to query and row annotations are in use.	7 years ago
Marko Mäkelä	6eefeb6fea	MDEV-19541: Avoid infinite loop of reading a corrupted page row_search_mvcc(): Duplicate the logic of btr_pcur_move_to_next() so that an infinite loop can be avoided when advancing to the next page fails due to a corrupted page.	7 years ago
Igor Babaev	cbb90f77cd	MDEV-18479 Complement This patch complements the patch that fixes bug MDEV-18479. This patch takes care of possible overflow when calculating the estimated number of rows in a materialized derived table / view.	7 years ago
Marko Mäkelä	eeee1832d7	Speed up buildbot by requiring --big-test for some slow tests	7 years ago
Marko Mäkelä	642ddc3131	MDEV-19541: Add a forgotten test case Also, --skip-innodb-buffer-pool-load-at-startup to avoid a crash in buf_load() due to loading pages that we are corrupting intentionally.	7 years ago
Igor Babaev	eb09580b67	MDEV-19588 Wrong results from query, using left join. This bug could happen when queries with nested outer joins were executed employing join buffers. At such an execution if the method JOIN_CACHE::join_records() is called when a join buffer has become full no 'first_unmatched' field should be cleaned up in the JOIN_TAB structure to which the join cache with this buffer is attached.	7 years ago
Marko Mäkelä	1ca75ae1c8	MDEV-19587 innodb_force_recovery=5 crash on DROP SCHEMA At higher levels of innodb_force_recovery, the InnoDB transaction subsystem will not be set up at all. At slightly lower levels, recovered transactions will not be rolled back, and DDL operations could hang due to locks being held at all. Let us consistently refuse all writes if the predicate high_level_read_only holds. We failed to refuse DROP TABLE and DROP DATABASE. (Refusing DROP TABLE is a partial backport from MDEV-19570 in the 10.5 branch.)	7 years ago
Thirunarayanan Balathandayuthapani	96d9f03328	MDEV-19602 Replace mysql_version check with frm_version for virtual columns inside InnoDB - Replace mysql_version check with omit_virtual_cols() in ha_innobase::check_if_supported_inplace_alter().	7 years ago
Marko Mäkelä	d59e15bdb9	Merge 10.1 into 10.2	7 years ago
Thirunarayanan Balathandayuthapani	88157247fc	MDEV-19509 InnoDB skips the tablespace in rotation list - If one of the encryption threads already started the initialization of the tablespace then don't remove the other uninitialized tablespace from the rotation list. - If there is a change in innodb_encrypt_tables then don't remove the processed tablespace from rotation list.	7 years ago
Marko Mäkelä	8358c6f03e	MDEV-19614: Fix innodb_plugin on Windows LOCK_global_system_variables: Declare with MYSQL_PLUGIN_IMPORT	7 years ago
Thirunarayanan Balathandayuthapani	79b46ab2a6	MDEV-19541 InnoDB crashes when trying to recover a corrupted page - Don't apply redo log for the corrupted page when innodb_force_recovery > 0. - Allow the table to be dropped when index root page is corrupted when innodb_force_recovery > 0.	7 years ago
Marko Mäkelä	bf8fe324d2	Merge 5.5 into 10.1	7 years ago
Marko Mäkelä	626f2a1c17	MDEV-19614 SET GLOBAL innodb_ deadlock due to LOCK_global_system_variables The update callback functions for several settable global InnoDB variables are acquiring InnoDB latches while holding LOCK_global_system_variables. On the other hand, some InnoDB code is invoking THDVAR() while holding InnoDB latches. An example of this is thd_lock_wait_timeout() that is called by lock_rec_enqueue_waiting(). In some cases, the intern_sys_var_ptr() that is invoked by THDVAR() may acquire LOCK_global_system_variables, via sync_dynamic_session_variables(). In lock_rec_enqueue_waiting(), we really must be holding some InnoDB latch while invoking THDVAR(). This implies that LOCK_global_system_variables must conceptually reside below any InnoDB latch in the latching order. That in turns implies that the various update callback functions must release LOCK_global_system_variables before acquiring any InnoDB mutexes or rw-locks, and reacquire LOCK_global_system_variables later. The validate functions are being invoked while not holding LOCK_global_system_variables and thus they do not need any changes. The following statements are affected by this: SET GLOBAL innodb_adaptive_hash_index = …; SET GLOBAL innodb_cmp_per_index_enabled = 1; SET GLOBAL innodb_old_blocks_pct = …; SET GLOBAL innodb_fil_make_page_dirty_debug = …; -- debug builds only SET GLOBAL innodb_buffer_pool_evict = uncompressed; -- debug builds only SET GLOBAL innodb_purge_run_now = 1; -- debug builds only SET GLOBAL innodb_purge_stop_now = 1; -- debug builds only SET GLOBAL innodb_log_checkpoint_now = 1; -- debug builds only SET GLOBAL innodb_buf_flush_list_now = 1; -- debug builds only SET GLOBAL innodb_buffer_pool_dump_now = 1; SET GLOBAL innodb_buffer_pool_load_now = 1; SET GLOBAL innodb_buffer_pool_load_abort = 1; SET GLOBAL innodb_status_output = …; SET GLOBAL innodb_status_output_locks = …; SET GLOBAL innodb_encryption_threads = …; SET GLOBAL innodb_encryption_rotate_key_age = …; SET GLOBAL innodb_encryption_rotation_iops = …; SET GLOBAL innodb_encrypt_tables = …; SET GLOBAL innodb_disallow_writes = …; buf_LRU_old_ratio_update(): Correct the return type.	7 years ago
Marko Mäkelä	242a28c320	MDEV-6812: Remove the wrapper my_log2f()	7 years ago
Marko Mäkelä	661289f462	Mention the sample IPv4 address 10.0.0.1	7 years ago
Igor Babaev	0955462d0a	MDEV-18479 Assertion `join->best_read < double(1.79769313486231570815e+308L)' or server crashes in JOIN::fix_all_splittings_in_plan after EXPLAIN This patch resolves the problem of overflowing when performing calculations to estimate the cost of an evaluated query execution plan. The overflowing in a non-debug build could cause different kind of problems uncluding crashes of the server.	7 years ago
Thirunarayanan Balathandayuthapani	b8b74e141d	MDEV-19027 create_table_def fails when virtual column is present between stored columns - create_table_def() misconstructs the dict_table_t by ignoring the stored columns of the table if virtual column is present between stored columns.	7 years ago
Daniel Black	35522455e0	RocksDB: use crc32c optimised version for POWER	7 years ago
Andrei Elkin	aaf53ea0b6	MDEV-17948 Assertion `thd_killed(thd) \|\| !m_active_tranxs .. Simulation of a big-sized event in rpl.rpl_semi_sync_skip_repl did not clean up after itself so screw the last binlog event offset which could jump backwards. The test is refined to rotate a binlog file with simulation and use the next one for logics of the test incl master-slave synchonization.	7 years ago
Vlad Lesin	bff9b8026b	MDEV-14192: mariabackup.incremental_backup failed in buildbot with Failing assertion: byte_offset % OS_FILE_LOG_BLOCK_SIZE == 0 In some cases it's possible that InnoDB redo log file header is re-written so, that checkpoint lsn and checkpoint lsn offset are updated, but checkpoint number stays the same. The fix is to re-read redo log header if at least one of those three parametes is changed at backup start. Repeat the logic of log_group_checkpoint() on choosing InnoDB checkpoint info field on backup start. This does not influence backup correctness, but simplifies bugs analysis.	7 years ago
Marko Mäkelä	c874040729	Declare INFORMATION_SCHEMA.INNODB_SYS_VIRTUAL stable The INFORMATION_SCHEMA plugin INNODB_SYS_VIRTUAL, which was introduced in MariaDB 10.2.2 along with the dictionary table SYS_VIRTUAL, is similar to other, much older and already stable plugins that provide access to InnoDB dictionary tables.	7 years ago
Igor Babaev	e57bb1f76c	MDEV-19258 RIGHT JOIN hangs in MariaDB This patch corrects the patch for the bug 10006. The latter incorrectly calculates the attribute TABLE_LIST::dep_tables for inner tables of outer joins that are to be converted into inner joins. As a result after the patch some valid join orders were not evaluated and the optimizer could choose an execution plan that was far from being optimal.	7 years ago
Robert Bindar	aad4e5637d	Stale files cause intermittent failure when ordering is unfortunate Running trigger_null-8605 drop_bad_db_type tests in this order was failing due to unremoved temporary files created in trigger_null-8605	7 years ago
Sergei Golubchik	4584c18631	make CPACK_RPM_DEBUGINFO_PACKAGE configurable from the command-line	7 years ago
Varun Gupta	6dbc2ab8b3	MDEV-17752: Plan changes from hash_index_merge to index_merge with new optimizer defaults The code in best_access_path function, when it does not find a key suitable for ref access and join_cache_level is set to a value so that hash_join is possible we build a hash key. Later in the function we compare the cost of ref access with table scan (or index scan or quick selects). No need to do this when we have got the hash key.	7 years ago
Ian Gilfillan	aaa920dad3	MDEV-19537: Document mysqlimport option ignore-foreign-keys	7 years ago
Marko Mäkelä	b90918dae3	Merge 10.1 into 10.2	7 years ago
Monty	3a871c39a9	Fixed monitor.test to handle statistics >= 10	8 years ago
Sergei Golubchik	5034b31b01	MDEV-17799 Add ASAN-poisoned redzones for MEM_ROOT post-merge changes Closes #954	7 years ago
Eugene Kosov	7b59ec6f34	MDEV-17799 Add ASAN-poisoned redzones for MEM_ROOT and mem_heap_t This patch is for MEM_ROOT only. In debug mode add 8 byte of poisoned memory before every allocated chunk. On the right of every chunk there will be either 1-7 trailing poisoned bytes, or next chunk's redzone, or poisoned non allocated memory or redzone of a malloc()ed buffer.	7 years ago
Alexey Botchkov	71ee69c81c	MDEV-17456 Malicious SUPER user can possibly change audit log configuration without leaving traces. thread_pool_server_audit.result fixed.	7 years ago
Marko Mäkelä	74904a667e	Remove UT_NOT_USED btr_pcur_move_to_last_on_page(): Merge with the only caller.	7 years ago
Sujatha	5a2110e7cf	MDEV-19076: rpl_parallel_temptable result mismatch '-33 optimistic' Problem: ======== The test now fails with the following trace: CURRENT_TEST: rpl.rpl_parallel_temptable --- /mariadb/10.4/mysql-test/suite/rpl/r/rpl_parallel_temptable.result +++ /mariadb/10.4/mysql-test/suite/rpl/r/rpl_parallel_temptable.reject @@ -194,7 +194,6 @@ 30 conservative 31 conservative 32 optimistic -33 optimistic Analysis: ========= The part of test which fails with result content mismatch is given below. CREATE TEMPORARY TABLE t4 (a INT PRIMARY KEY) ENGINE=InnoDB; INSERT INTO t4 VALUES (32); INSERT INTO t4 VALUES (33); INSERT INTO t1 SELECT a, "optimistic" FROM t4; slave_parallel_mode=optimistic The expectation of the above test script is, INSERT FROM SELECT should read both 32, 33 and populate table 't1'. But this expectation fails occasionally. All three INSERT statements are handed over to three different slave parallel workers. Temporary tables are not safe for parallel replication. They were designed to be visible to one thread only, so have no table locking. Thus there is no protection against two conflicting transactions committing in parallel and things like that. So anything that uses temporary tables will be serialized with anything before it, when using parallel replication by using a "wait_for_prior_commit" function call. This will ensure that the each transaction is executed sequentially. But there exists a code path in which the above wait doesn't happen. Because of this at times INSERT from SELECT doesn't wait for the INSERT (33) to complete and it completes its executes and enters commit stage. Hence only row 32 is found in those cases resulting in test failure. The wait needs to be added within "open_temporary_table" call. The code looks like this within "open_temporary_table". Each thread tries to open temporary table in 3 different ways: case 1: Find a temporary table which is already in use by using find_temporary_table(tl) && wait_for_prior_commit() case 2: If above failed then try to look for temporary table which is marked for free for reuse. This internally calls "wait_for_prior_commit()" if table is found. find_and_use_tmp_table(tl, &table) case 3: If none of the above open a new table handle from table share. if (!table && (share= find_tmp_table_share(tl))) { table= open_temporary_table(share, tl->get_table_name(), true); } At present the "wait_for_prior_commit" happens only in case 1 & 2. Fix: ==== On slave add a call for "wait_for_prior_commit" for case 3. The above wait on slave will solve the issue. A more detailed fix would be to mark temporary tables as not safe for parallel execution on the master side. In order to do that, on the master side, mark the Gtid_log_event specific flag FL_TRANSACTIONAL to be false all the time. So that they are not scheduled parallely.	7 years ago
Alexey Botchkov	d4e9a50e88	MDEV-17456 Malicious SUPER user can possibly change audit log configuration without leaving traces. Fix for the SET GLOBAL server_audit_loggin=on; added.	7 years ago
Igor Babaev	2c9844a438	MDEV-18896 Crash in convert_join_subqueries_to_semijoins : Correction This patch complements the original patch for MDEV-18896 that prevents conversions to semi-joins in tableless selects used in INSERT statements in post-5.5 versions of the server. The test case was corrected as well to ensure that potential conversion to jtbm semi-joins is also checked (the problem was that one of the preceeding testcases in subselect_sj.test did not restore the state of the optimizer switch leaving the 'materialization' in the state 'off' and so blocking this check). Noticed an inconsistency in the state of select_lex::table_list used in INSERT statements and left a comment about this.	7 years ago
Sergei Petrunia	91efcc6392	Better comment from Monty for code in make_join_select	7 years ago
Jan Lindström	395ce1dcb3	MDEV-16021: galera mtr test galera_evs_suspect_timeout crashed Crash was timeout crash. Add correct waits for connections, wsrep sync waits and auto increment offset save and restore.	7 years ago
Jan Lindström	cd87e4e134	MDEV-13549: Timeout in wait_condition.inc for PROCESSLIST Use wsrep sync wait instead of unnecessary waits and correct slave setting.	7 years ago
Jan Lindström	bc511443b1	MDEV-17061: Test failure on galera.galera_gcs_fc_limit Remove unnecessary sleeps and fix wait_condition to use wsrep_flow_control_paused i.e. we wait until flow control pauses a transaction on master.	7 years ago
Sergei Golubchik	fae6539ef7	restore the correct test result	7 years ago
Alexey Botchkov	cd16d6d518	MDEV-13992 Implement JSON_MERGE_PATCH. JSON_MERGE_PATCH implemented. Added JSON_MERGE_PRESERVE as a synonim for the JSON_MERGE.	7 years ago
Varun Gupta	da6e55f022	MDEV-19472: eq_range_index_dive_limit cannot be configured in server.cnf Fixed, now server can be configured with eq_range_index_dive_limit set in cnf file	7 years ago
Jan Lindström	c84f390df2	MDEV-16021: galera mtr test galera_evs_suspect_timeout crashed Crash was timeout crash. Add correct waits for connections, wsrep sync waits and auto increment offset save and restore.	7 years ago
Jan Lindström	61469b3a3b	MDEV-13549: Timeout in wait_condition.inc for PROCESSLIST Use wsrep sync wait instead of unnecessary waits and correct slave setting.	7 years ago

1 2 3 4 5 ...

182183 Commits (723a4b1d78274b10222b03088ff75884b78c2ced) All Branches Search

182183 Commits (723a4b1d78274b10222b03088ff75884b78c2ced)

All Branches