mariadb

Tree: 716d396bb3

Author	SHA1	Message	Date
Michael Widenius	716d396bb3	Remove \n from DBUG_PRINT statements	6 years ago
Michael Widenius	06d2e1d828	read-only slave using statement replication should replicate tmp tables Relates to MDEV-17863 DROP TEMPORARY TABLE creates a transaction in binary log on read only server Other things: - Fixed that insert into normal_table select from tmp_table is replicated as row events if tmp_table doesn't exists on slave.	6 years ago
Monty	7def2877e3	Write error message if aria_log.??????? files are missing This can happen if one uses a backup where not all aria_log.* files are copied or if the last one is too short. In this case the data files will contain data that is not in the logs and recovery will fail. Other things: - Fixed tprint() to not print extra new line to debug trace	6 years ago
Monty	67687d06bf	Simplify TABLE::decide_logging_format() - Use local variables table and share to simplify code - Use sql_command_flags to detect what kind of command was used - Added CF_DELETES_DATA to simplify detecton of delete commands - Removed duplicate error in create_table_from_items().	6 years ago
Monty	b62101f84b	Fixes for binary logging --read-only mode - Any temporary tables created under read-only mode will never be logged to binary log. Any usage of these tables to update normal tables, even after read-only has been disabled, will use row base logging (as the temporary table will not be on the slave). - Analyze, check and repair table will not be logged in read-only mode. Other things: - Removed not used varaibles in MYSQL_BIN_LOG::flush_and_set_pending_rows_event. - Set table_share->table_creation_was_logged for all normal tables. - THD::binlog_query() now returns -1 if statement was not logged., This is used to update table_share->table_creation_was_logged. - Don't log admin statements in opt_readonly is set. - Table's that doesn't have table_creation_was_logged will set binlog format to row logging. - Removed not needed/wrong setting of table->s->table_creation_was_logged in create_table_from_items()	6 years ago
Alexander Barkov	e0b6294338	MDEV-20855 Crash with PARTITION BY LIST and extended characters The code in convert_charset_partition_constant() did not take into account that the call for item->safe_charset_converter() can return NULL when conversion is not safe. Note, 10.2 was not affected. The test for NULL presents in 10.2, but it disappeared in 10.3 in a mistake. Restoring the test.	6 years ago
Marko Mäkelä	0b9cee2cbf	Merge 10.2 into 10.3	6 years ago
Oleksandr Byelkin	de2186dd2f	MDEV-20074: Lost connection on update trigger Instead of checking lex->sql_command which does not corect in case of triggers mark tables for insert.	6 years ago
Marko Mäkelä	fa929f7cdf	Simplify row_undo_ins_remove_sec_low() Reduce the scope of some variables, remove a goto and a redundant assertion. For B-tree secondary indexes, this function can remove a delete-marked purgeable record, in case a row rollback of the INSERT was initiated due to an error in an earlier secondary index.	6 years ago
Marko Mäkelä	b027830232	MDEV-20850 Merge new release of InnoDB 5.7.28 to 10.2	6 years ago
Marko Mäkelä	fa32d28f2f	MDEV-20852 BtrBulk is unnecessarily holding dict_index_t::lock The BtrBulk class, which was introduced in MySQL 5.7, is by design the exclusive writer to an index. It is therefore unnecessary to acquire the dict_index_t::lock in that code. Holding the dict_index_t::lock would unnecessarily block other threads (SQL connections and the InnoDB purge threads) from buffering concurrent modifications to being-created secondary indexes. This fix is motivated by a change in MySQL 5.7.28: Bug #29008298 MYSQLD CRASHES ITSELF WHEN CREATING INDEX mysql/mysql-server@f9fb96c20f9d190f654e7aa2387255bf80fd6e45 PageBulk::init(), PageBulk::latch(): Never acquire m_index->lock. PageBulk::storeExt(): Remove some pointer indirection, and improve a debug assertion that seems to prove that some code is redundant. BtrBulk::pageCommit(): Assert that m_index->lock is not being held. btr_blob_log_check_t: Do not acquire m_index->lock if m_op == BTR_STORE_INSERT_BULK. Add UNIV_UNLIKELY hints around that condition. btr_store_big_rec_extern_fields(): Allow index->lock not to be held while op == BTR_STORE_INSERT_BULK. Add UNIV_UNLIKELY hints around that condition.	6 years ago
Monty	3ce14a66ef	Fixed bug in lock tables + alter table with Aria tables. MDEV-18451 Server crashes in maria_create_trn_for_mysql upon ALTER TABLE Problem was that when table was locked many times, not all instances where removed from the transaction by _ma_remove_table_from_trnman()	6 years ago
Jan Lindström	6cdde9ebbf	MDEV-20836 : Galera test failure on wsrep.variables Add one more wait to make sure all threads have been started.	6 years ago
Monty	7952f7720f	MDEV-10748 Server crashes in ha_maria::implicit_commit Problem was in a combination of LOCK TABLES on several Aria tables followed by an ALTER TABLE. After the ALTER TABLE there was a force close + reopen of the alter table. The close failed because the table was still part of a transaction. Fixed by calling extra(HA_EXTRA_PREPARE_FOR_FORCED_CLOSE) as part of closing the table, which ensures that the table is not anymore part of the current transaction.	6 years ago
Aleksey Midenkov	7ae0be25a6	MDEV-20812 Unexpected ER_ROW_IS_REFERENCED_2 upon DELETE from versioned table with FK MDEV-16210 original case was wrongly allowed versioned DELETE from referenced table where reference is by non-primary key. InnoDB UPDATE has optimization for new rows not changing its clustered index position. In this case InnoDB doesn't update all secondary indexes and misses the one holding the referenced key. The fix was to disable this optimization for versioned DELETE. In case of versioned DELETE we forcely update all secondary indexes and therefore check them for constraints. But the above fix raised another problem with versioned DELETE on foreign table side. In case when there was no corresponding record in referenced table (illegal foreign reference can be done with "set foreign_key_checks=off") there was spurious constraint check (because versioned DELETE is actually UPDATE) and hence the operation failed with constraint error. MDEV-16210 tried to fix the above problem by checking foreign table instead of referenced table and that at least was illegal. Constraint check is done by row_ins_check_foreign_constraint() no matter what kind of table is checked, referenced or foreign (controlled by check_ref argument). Referenced table is checked by row_upd_check_references_constraints(). Foreign table is checked by row_ins_check_foreign_constraints(). Current fix rolls back the wrong fix for the above problem and disables referenced table check for DELETE on foreign side by introducing `check_foreign` argument which when set to false skips row_ins_check_foreign_constraints() call.	6 years ago
Eugene Kosov	4d14785546	MDEV-20778 UBSAN: call to function free_rpl_filter() through pointer to incorrect function type Proper C-style type erasure is done via void, not via char or something else. free_key_cache() free_rpl_filter(): types were fixed to avoid function pointer type cast which is still undefined behavior. Note, that casting from void* to any other pointer type is safe and correct.	6 years ago
Marko Mäkelä	f989c0ce66	MDEV-20813: Do not rotate keys for unallocated pages fil_crypt_rotate_page(): Skip the key rotation for pages that carry 0 in FIL_PAGE_TYPE. This avoids not only unnecessary writes, but also failures of the recently added debug assertion in buf_flush_init_for_writing() that the FIL_PAGE_TYPE should be nonzero. Note: the debug assertion can fail if the file was originally created before MySQL 5.5. In old InnoDB versions, FIL_PAGE_TYPE was only initialized for B-tree pages, to FIL_PAGE_INDEX. For any other pages, the field could be garbage, including FIL_PAGE_INDEX. In MariaDB 10.2 and later, buf_flush_init_for_writing() would initialize the FIL_PAGE_TYPE on such old pages, but only after passing the debug assertion that insists that pages have a nonzero FIL_PAGE_TYPE. Thus, the debug assertion at the start of buf_flush_init_for_writing() can fail when upgrading from very old debug files. This assertion is only present in debug builds, not release builds.	6 years ago
Marko Mäkelä	4f9f3f19cd	Merge 10.1 into 10.2 Do not merge the InnoDB changes for MDEV-20813.	6 years ago
Marko Mäkelä	ae702d7643	MDEV-20813: Remove the buf_flush_init_for_writing() assertion Old InnoDB/XtraDB versions only initialized FIL_PAGE_TYPE for B-tree pages (to FIL_PAGE_INDEX), and left it uninitialized (possibly containing FIL_PAGE_INDEX) for others. In MySQL or MariaDB 5.5, the field is initialized on almost all pages, but still not all of them. In MariaDB 10.2 and later, buf_flush_init_for_writing() would initialize the FIL_PAGE_TYPE on such old pages, but only after passing the debug assertion that we are now removing from 10.1. There, we will be able to modify fil_crypt_rotate_page() so that it will skip the key rotation for pages that contain 0 in FIL_PAGE_TYPE. In MariaDB 10.1, there is no logic that would initialize FIL_PAGE_TYPE on data pages in old data files after an update. So, encryption key rotation may routinely cause page flushes on pages that contain 0 in FIL_PAGE_TYPE.	6 years ago
Marko Mäkelä	2920377aa0	MDEV-19740: Fix C++11 violations caught by GCC 9.2.1 This is a backport of commit `ec28f9532e` to MariaDB Server 10.1.	6 years ago
Marko Mäkelä	fa6c606257	MDEV-20814 Assertion index->is_instant() failed on trivial upgrade from 10.1 rec_init_offsets(): Relax the assertion that was added in commit `01f45becd1` to catch ROW_FORMAT=REDUNDANT records that have fewer fields than expected. This assertion would fail when accessing the records of the built-in InnoDB table SYS_INDEXES. The column MERGE_THRESHOLD had been effectively instantly added in MariaDB Server 10.2 (and MySQL 5.7), but is_instant() does not hold for that index. Relax the assertion, so that it will not fail in this case.	6 years ago
Marko Mäkelä	bb450b1fed	Merge 10.2 into 10.3	6 years ago
Marko Mäkelä	361e8284f3	MDEV-20813 Assertion failure in buf_flush_init_for_writing() for innodb_immediate_scrub_data_uncompressed=ON The assertion that was added in commit `c0c003beb4` to augment the fix of MDEV-20805 turns out to be invalid when innodb_immediate_scrub_data_uncompressed is enabled. In this mode, fsp_init_file_page() will be invoked on data pages that have been freed, causing writes of almost-all-zero pages. btr_page_free(): Adjust the comment. buf_flush_init_for_writing(): Disable the assertion with a note that it should be re-enabled in MDEV-15528.	6 years ago
Marko Mäkelä	8e3d85e112	Merge 10.2 into 10.3	6 years ago
Marko Mäkelä	2227dec45e	Merge 10.1 into 10.2	6 years ago
Julius Goryavsky	2ae02c295a	MDEV-20728: /usr/sbin/mysqld: unknown variable 'defaults-group-suffix=mysqld1 When the mysqld_multi script passes the --defaults-group-suffix option to mysqld, it must remove the initial substring with the group name ("mysqld") from option value, because otherwise substring "mysqld" will be added to the group name and then the group name will contain the word "mysqld" twice, which is wrong, because mysqld itself adds the suffix received to the group name.	6 years ago
Julius Goryavsky	4ca0abe964	MDEV-20728: /usr/sbin/mysqld: unknown variable 'defaults-group-suffix=mysqld1 When the mysqld_multi script passes the --defaults-group-suffix option to mysqld, it must remove the initial substring with the group name ("mysqld") from option value, because otherwise substring "mysqld" will be added to the group name and then the group name will contain the word "mysqld" twice, which is wrong, because mysqld itself adds the suffix received to the group name.	6 years ago
Julius Goryavsky	0ecc85c5d9	MDEV-20728: /usr/sbin/mysqld: unknown variable 'defaults-group-suffix=mysqld1 When the mysqld_multi script passes the --defaults-group-suffix option to mysqld, it must remove the initial substring with the group name ("mysqld") from option value, because otherwise substring "mysqld" will be added to the group name and then the group name will contain the word "mysqld" twice, which is wrong, because mysqld itself adds the suffix received to the group name.	6 years ago
Marko Mäkelä	38736928e7	Fix -std=c++98 -Wzero-length-array This is another follow-up fix to commit `b393e2cb0c` which turned out to be still broken. Replace the C++11 keyword 'constexpr' with #define. debug_sync_t::str: Remove the zero-length array. Replace sync->str with reinterpret_cast<char*>(&sync[1]).	6 years ago
Marko Mäkelä	1e1b53ccfd	After-merge fix: Correct an assertion During IMPORT TABLESPACE, we do invoke buf_flush_init_for_writing() with block==NULL and newest_lsn!=0.	6 years ago
Marko Mäkelä	966d97b5f9	Merge 10.1 into 10.2	6 years ago
Marko Mäkelä	1fd1ef25c2	Fix CMAKE_BUILD_TYPE=Debug Remove unused variables and type mismatch that was introduced in commit `b393e2cb0c` Also, fix a typo in the documentation of the parameter, and update the test.	6 years ago
Marko Mäkelä	c0c003beb4	MDEV-20805 follow-up: Catch writes of bogus pages buf_flush_init_for_writing(): Assert that FIL_PAGE_TYPE is set except when creating a new data file with a dummy first page. buf_dblwr_create(): Ensure that FIL_PAGE_TYPE on all pages will be initialized. Reset buf_dblwr_being_created at the end.	6 years ago
Marko Mäkelä	cbfd6882f4	Merge 5.5 into 10.1	6 years ago
Marko Mäkelä	ea61b79694	MDEV-20805 ibuf_add_free_page() is not initializing FIL_PAGE_TYPE first In the function recv_parse_or_apply_log_rec_body() there are debug checks for validating the state of the page when redo log records are being applied. Most notably, FIL_PAGE_TYPE should be set before anything else is being written to the page. ibuf_add_free_page(): Set FIL_PAGE_TYPE before performing any other changes.	6 years ago
Marko Mäkelä	4ebaf81360	MDEV-19455: Avoid SET DEBUG_DBUG='-d,...' construct Apply the correct pattern for debug instrumentation: SET @save_dbug=@@debug_dbug; SET debug_dbug='+d,...'; ... SET debug_dbug=@save_dbug; Numerous tests use statements of the form SET debug_dbug='-d,...'; which will inadvertently enable all DBUG tracing output, causing unnecessary waste of resources.	6 years ago
Marko Mäkelä	5ef1224434	MDEV-20804 Speed up main.index_merge_innodb The test main.index_merge_innodb is taking very much time, especially on later versions (10.2 and 10.3). Some of this could be attributed to the use of INSERT...SELECT, which is time-consumingly creating explicit record locks in InnoDB for the locking read in the SELECT part. In 10.3 and later, some slowness can be attributed to MDEV-12288, which makes the InnoDB purge thread spend time to reset transaction identifiers in the inserted records. If we prevent purge from running before all tables are dropped, the test seems to be 10% faster on an unoptimized debug build on 10.5. (A proper fix would be to implement MDEV-515 and stop writing row-level undo log records for inserts into an empty table or partition.) At the same time, it should not hurt to make main.index_merge_myisam to use the sequence engine. Not only could it be a little faster, but the test would be slightly more readable.	6 years ago
Nikita Malyavin	350e46a8b5	MDEV-18546 ASAN heap-use-after-free in innobase_get_computed_value / row_purge the bug was already fixed in MDEV-17005, so now only test is added	6 years ago
Nikita Malyavin	b393e2cb0c	add innodb_debug_sync var to support DEBUG_SYNC from purge threads	6 years ago
Marko Mäkelä	4cdb72f237	MDEV-19783: Relax an assertion btr_page_get_split_rec_to_left(): Assert that in the leftmost leaf page, if the metadata record exists, index->is_instant() must hold. The assertion of commit `01f45becd1` could fail during innobase_instant_try().	6 years ago
Marko Mäkelä	01f45becd1	MDEV-19783: Add more assertions btr_page_get_split_rec_to_left(): Assert that in the leftmost leaf page, the metadata record exists if and only if index->is_instant(). page_validate(): Correct the wording of a message. rec_init_offsets(): Assert that whenever a record is in "instant ALTER" format, index->is_instant() must hold.	6 years ago
Marko Mäkelä	7f84e3ad75	Merge 10.2 into 10.3	6 years ago
Marko Mäkelä	6d7a826953	MDEV-20788: Bogus assertion failure for PAGE_FREE list In MDEV-11369 (instant ADD COLUMN) in MariaDB Server 10.3, we introduced the hidden metadata record that must be the first record in the clustered index if and only if index->is_instant() holds. To catch MDEV-19783, in commit `ed0793e096` and commit `99dc40d6ac` we added some assertions to find cases where the metadata record is missing while it should not be, or a record exists when it should not. Those assertions were invalid when traversing the PAGE_FREE list. That list can contain anything; we must only be able to determine the successor and the size of each garbage record in it. page_validate(), page_simple_validate_old(), page_simple_validate_new(): Do not invoke page_rec_get_next_const() for traversing the PAGE_FREE list, but instead use a lower-level accessor that does not attempt to validate the REC_INFO_MIN_REC_FLAG. page_copy_rec_list_end_no_locks(), page_copy_rec_list_start(), page_delete_rec_list_start(): Add assertions. btr_page_get_split_rec_to_left(): Remove a redundant return value, and make the output parameter the return value. btr_page_get_split_rec_to_right(), btr_page_split_and_insert(): Clean up.	6 years ago
Aleksey Midenkov	545c545206	Fix compilation 2 (GCC 9) Fixed warning: -Woverloaded-virtual for GCC 9 (Clang treats it differently) Caused by `c9cba59749`	6 years ago
Aleksey Midenkov	3c78d1b640	Fix Mroonga compilation Fixed warnings: -Woverloaded-virtual, -Winconsistent-missing-override Caused by `c9cba59749`	6 years ago
Jan Lindström	cb3f856ecd	Fix compiler error when using -Wconversion. /mariadb/10.3/wsrep/wsrep_gtid.c:45:26: error: conversion from 'long int' to 'unsigned int' may change value [-Werror=conversion] 45 \| offset = endptr - str;	6 years ago
Michael Widenius	726b1998fc	Fixed feedback_plugin_load to work with staticly loaded plugin	6 years ago
Aleksey Midenkov	c9cba59749	MDEV-17333 Assertion in update_auto_increment() upon exotic LOAD While `handler::next_insert_id` is restored on duplicate key errors `part_share->next_auto_inc_val` is not restored which causes discrepancy.	7 years ago
Aleksey Midenkov	a92f3146d2	MDEV-19406 Assertion on updating view of join with versioned table TABLE::mark_columns_needed_for_update(): use_all_columns() assigns pointer of all_set into read_set and write_set, but this is not good since all_set is changed later by TABLE::mark_columns_used_by_index_no_reset(). Do column_bitmaps_signal() whenever we change read_set/write_set.	7 years ago
Aleksey Midenkov	647a38818a	MDEV-16130 wrong error message adding AS ROW START to versioned table	8 years ago

1 2 3 4 5 ...

186002 Commits (716d396bb3b4814de3c00c46f98317c45a33551e) All Branches Search

186002 Commits (716d396bb3b4814de3c00c46f98317c45a33551e)

All Branches