mariadb

Tree: 6e140c1ad2

Author	SHA1	Message	Date
marko	79bbbc9810	branches/zip: Fix two more bogus MSVC C4090 warnings on constness differences (Warning C4090 is incorrectly issued when using Visual C++ .NET 2003, bug 101661, http://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=101661) dict_table_find_equivalent_index(): Cast away constness in the mem_free() call. MSVC seems to think that an array of pointers to const data is const itself. UT_SORT_FUNCTION_BODY(): Cast away constness in the memcpy() call. MSVC seems to think that an array of pointers to const data is const itself.	18 years ago
marko	d4f5d8a892	branches/zip: ut_is_2pow(), ut_2pow_round(), ut_2pow_remainder(): Define as type-independent macros instead of functions. Because ut_2pow_round() and ut_2pow_remainder() no longer assert ut_is_2pow(m), add the assertions to callers when needed. Also add parentheses to assist the compiler in common subexpression elimination.	18 years ago
marko	0f599ce0d3	branches/zip: buf_read_ahead_random(), buf_read_ahead_linear(): Compute BUF_READ_AHEAD_RANDOM_AREA and BUF_READ_AHEAD_LINEAR_AREA only once. The definition of BUF_READ_AHEAD_AREA depends on buf_pool->curr_size, which could change while this code is running.	18 years ago
marko	7b47e8ca41	branches/zip: buf_flush_try_neighbors(): Compute buf_flush_area only once and assign it to an auxiliary variable.	18 years ago
marko	c4605a2807	branches/zip: Fix most MSVC (Windows) compilation warnings. lock_get_table(), locks_row_eq_lock(), buf_page_get_mutex(): Add return after ut_error. On Windows, ut_error is not declared as "noreturn". Add explicit type casts when assigning ulint to byte to get rid of "possible loss of precision" warnings. struct i_s_table_cache_struct: Declare rows_used, rows_allocd as ulint instead of ullint. 32 bits should be enough. fill_innodb_trx_from_cache(), i_s_zip_fill_low(): Cast 64-bit unsigned integers to longlong when calling Field::store(longlong, bool is_unsigned). Otherwise, the compiler would implicitly convert them to double and invoke Field::store(double) instead. recv_truncate_group(), recv_copy_group(), recv_calc_lsn_on_data_add(): Cast ib_uint64_t expressions to ulint to get rid of "possible loss of precision" warnings. (There should not be any loss of precision in these cases.) log_close(), log_checkpoint_margin(): Declare some variables as ib_uint64_t instead of ulint, so that there won't be any potential loss of precision. mach_write_ull(): Cast the second argument of mach_write_to_4() to ulint. OS_FILE_FROM_FD(): Cast the return value of _get_osfhandle() to HANDLE. row_merge_dict_table_get_index(): Cast the parameter of mem_free() to (void*) in order to get rid of the bogus MSVC warning C4090, which has been reported as MSVC bug 101661: <http://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=101661> row_mysql_read_blob_ref(): To get rid of a bogus MSVC warning C4090, drop a const qualifier.	18 years ago
marko	7c119c9580	branches/zip: Improve the LRU algorithm with a separate unzip_LRU list of blocks that contains uncompressed and compressed frames. This patch was designed by Heikki and Inaam, implemented by Inaam, and refined and reviewed by Marko and Sunny. buf_buddy_n_frames, buf_buddy_min_n_frames, buf_buddy_max_n_frames: Remove. buf_page_belongs_to_unzip_LRU(): New predicate: bpage->zip.data && buf_page_get_state(bpage) == BUF_BLOCK_FILE_PAGE. buf_pool_t, buf_block_t: Add the linked list unzip_LRU. A block in the regular LRU list is in unzip_LRU iff buf_page_belongs_to_unzip_LRU() holds. buf_LRU_free_block(): Add a third return value to refine the case "cannot free the block". buf_LRU_search_and_free_block(): Update the documentation to reflect the implementation. buf_LRU_stat_t, buf_LRU_stat_cur, buf_LRU_stat_sum, buf_LRU_stat_arr[]: Statistics for the unzip_LRU algorithm. buf_LRU_stat_update(): New function: Update the statistics. Called once per second by srv_error_monitor_thread(). buf_LRU_validate(): Validate the unzip_LRU list as well. buf_LRU_evict_from_unzip_LRU(): New predicate: Use the unzip_LRU before falling back to the regular LRU? buf_LRU_free_from_unzip_LRU_list(), buf_LRU_free_from_common_LRU_list(): Subfunctions of buf_LRU_search_and_free_block(). buf_LRU_search_and_free_block(): Reimplement. Try to evict an uncompressed page from the unzip_LRU list before falling back to evicting an entire block from the common LRU list. buf_unzip_LRU_remove_block_if_needed(): New function. buf_unzip_LRU_add_block(): New function: Add a block to the unzip_LRU list.	18 years ago
calvin	9c8f965212	branches/zip: row_raw_format_str_convert(): Rename to innobase_raw_format(), move the definition from row0row.c to ha_innodb.cc. After this change, row0row.c no longer references system_charset_info (Mantis issue #17). Patch prepared by Vasil, tested by Calvin, and reviewed by Marko.	18 years ago
calvin	66312acc63	branches/zip: Fix the compile errors in btr/btr0cur.c for Windows build. It is part of Mantis issue#18. Reviewed by Marko.	18 years ago
calvin	7ec866a54b	branches/zip: Remove PAGE_WRITECOMBINE from VirtualAlloc() in os_mem_alloc_large(). Otherwise the allocation fails during startup with error code 87 - invalid parameter. Reviewed by Marko.	18 years ago
calvin	3950b2b90d	branches/zip: Exclude mman.h on Windows since it is not supported on Windows. Reviewed by Marko.	18 years ago
marko	60a442d628	branches/zip: Update CMakeLists.txt to correspond to Makefile.am. Add CMake-generated files and directories to svn:ignore. This patch is from Calvin Sun, who couldn't commit it properly on Windows. Do "svn propset svn:eol-style native" on every text file, to fix line format problems on Windows.	18 years ago
marko	64ed375e1e	branches/zip: buf_buddy_alloc(), buf_buddy_alloc_low(): Correct a mistake in the function comment. There is no value BUF_BUDDY_USE_LRU. The mistake was made in r1290.	18 years ago
marko	f1a9f56a14	branches/zip: buf_buddy_alloc_clean(): Remove, as it violates the LRU policy.	18 years ago
marko	3ee5e7576e	branches/zip: buf_relocate(): Document and assert that bpage must be in one of the states BUF_BLOCK_ZIP_DIRTY or BUF_BLOCK_ZIP_PAGE. Note that the caller will have to relocate bpage->list.	18 years ago
marko	b41a1b012c	branches/zip: Replace __attribute with __attribute.	18 years ago
marko	bf1f73aaf0	branches/zip: row_create_table_for_mysql(): Always roll back the transaction when creating the table fails.	18 years ago
marko	1d4ada1abe	branches/zip: ha_innobase::add_index(): Always commit prebuilt->trx, also when row_merge_create_temporary_table() fails. Otherwise, an assertion would fail when the client connection is closed, because prebuilt->trx would still be holding a table lock on innodb_table.	18 years ago
marko	2063531fb1	branches/zip: os_file_set_nocache(): Clean up the function comment. Add the function prototype to os0file.h.	18 years ago
marko	8bf7931e47	branches/zip: dict0dict.c: Add the #include "ha_prototypes.h" that should have been added in r2327.	18 years ago
vasil	41cac32c21	branches/zip: Use innobase_strcasecmp() insteaed of strcasecmp() in i_s.cc and get rid of strings.h (that file is not present on Windows). Move the prototype of innobase_strcasecmp() from ha_innodb.cc and dict0dict.c to ha_prototypes.h. Approved by: Heikki	18 years ago
marko	0b6a7dacf7	branches/zip: Add duration statistics to INFORMATION_SCHEMA.INNODB_ZIP. buf_buddy_relocated_duration[], page_zip_compress_duration[] page_zip_decompress_duration[]: Record the total duration of the operations. buf_buddy_relocate(), page_zip_compress(), page_zip_decompress(): Add ut_time_us() instrumentation. i_s_zip_fields_info[], i_s_zip_fill_low(): Move the columns containing cumulated statistics last. Add relocated_usec, compressed_usec, and decompressed_usec.	18 years ago
marko	58fd174a95	branches/zip: ibuf_update_free_bits_zip(): When after==0, call buf_page_make_young(), like ibuf_update_free_bits_if_full() does. This difference was pointed out by Sunny.	18 years ago
marko	4c7f244cd8	branches/zip: enum db_err: Use the same InnoDB error numbers as the #defines in earlier versions of InnoDB.	18 years ago
marko	f6694b3198	Do not enable page_zip_compress_log by default. This was accidentally set in r2318.	18 years ago
marko	9e43ce09d4	branches/zip: Add the column "free" to INNODB_ZIP and INNODB_ZIP_RESET to display the external fragmentation within the buddy allocator.	18 years ago
marko	949b94c5a9	branches/zip: Enable excessive binary logging of page_zip_compress(), for the purpose of comparing different compression algorithms. PAGE_ZIP_COMPRESS_DBG: New preprocessor condition, to see if deflate() is wrapped. page_zip_compress_log: Log file counter. If set to nonzero, logging is enabled. page_zip_compress_deflate(): Add the parameter logfile. FILE_LOGFILE, LOGFILE: Macros for declaring and passing the parameter logfile. page_zip_compress(): Open and close the logfile if needed. Write the uncompressed page and the size of the compressed data. The data passed to deflate() is written by the wrapper page_zip_compress_deflate().	18 years ago
marko	36a5b2cd37	branches/zip: Merge 2263:2295 from branches/5.1.	18 years ago
marko	c31fb8dad9	branches/zip: Remove the unused function os_thread_join().	18 years ago
marko	b48d0c64e2	branches/zip: trx_undo_prev_version_build(): Remove the unnecessary and incorrect "BLOB bug fix" that was suggested by Heikki. Explain in a comment why no such fix is needed.	18 years ago
marko	bddb5a0cca	branches/zip: Add a UNIV_INTERN qualifier to every global function declaration in .h files, so that the function signatures in the .h and *.c files fully match each other. ut_dulint_sort(): Add a UNIV_INTERN qualifier also to the function definition.	18 years ago
marko	9966023451	branches/zip: Minor fixes. lock_rec_restore_from_page_infimum(): Correct the comment of the parameter rec. lock_sec_rec_read_check_and_lock(): Add the debug assertion ut_ad(mode == LOCK_X \|\| mode == LOCK_S).	18 years ago
marko	da54bec75b	branches/zip: Minor fixes. buf_LRU_old_adjust_len(): Replace a constant ut_ad() with a preprocessor check. buf_LRU_free_block(): Remove the check for the unlikely case buf_pool->LRU_old == prev_b in order to simplify the function. The check was implemented as part of r2306.	18 years ago
marko	6aa400bee4	branches/zip: trx_undo_prev_version_build(): Remove the fix that was suggested by Heikki, because it breaks row_vers_impl_x_locked_off_kernel(); see Mantis issue #10. However, now that Heikki's fix has been removed, the code may break elsewhere when it tries to dereference half-freed or completely freed externally stored columns.	18 years ago
marko	7a41306bc5	branches/zip: Minor improvements. lock_update_delete(): Add the debug assertion ut_ad(page == page_align(rec)). lock_rec_insert_check_and_lock(): Determine next_rec_heap_no before acquiring the kernel mutex. Require the table to be at least S-locked in fast index creation.	18 years ago
marko	060a95bea6	branches/zip: buf_LRU_free_block(): When freeing the uncompressed page corresponding to a compressed page, do not flag the block as recently used, but maintain the position of the control block on the LRU list.	18 years ago
marko	9d02d912a7	branches/zip: lock0lock.c: Minor cleanup. lock_rec_get_first(): Use a simple for loop. lock_rec_copy(): Use mem_heap_dup(). lock_rec_find_similar_on_page(): Add const qualifier to trx. lock_move_rec_list_end(), lock_move_rec_list_start(): Simplify the memcmp() assertion on ROW_FORMAT=REDUNDANT records.	18 years ago
marko	03adfb2fad	branches/zip: lock_rec_other_has_expl_req(): Minor cleanup: add const qualifier to parameter, and fix the formatting of a comment.	18 years ago
marko	17127565dd	branches/zip: buf0lru.c: Minor cleanup. Use ut_d() in assignments to bpage->in_LRU_list instead of #ifdef UNIV_DEBUG. buf_LRU_remove_block(): Move an assertion to a more appropriate place.	18 years ago
marko	b2274cb5e1	branches/zip: lock_rec_add_to_queue(): Improve the debug diagnostics. Make it easier to display the violating lock request in a debugger.	18 years ago
marko	7b538bb8ea	branches/zip: buf_buddy_alloc_from(): Relax a debug assertion that fails on i==j==BUF_BUDDY_SIZES.	18 years ago
marko	388af7a7bb	branches/zip: Minor cleanup of fast index creation diagnostics. innobase_check_index_keys(): Remove unused parameters. Use sql_print_error() for error message output. ha_innobase::add_index(): When row_merge_rename_tables() fails, do not allow row_merge_drop_table() to alter the error code returned to MySQL.	18 years ago
marko	9194c3a9e6	branches/zip: Pass -prefer-non-pic only on IA-32 (x86) when building the dynamic InnoDB plugin, ha_innodb.so. This libtool option cannot be used on every target platform. For instance, the AMD64 (x86_64) ABI mandates position-independent code (PIC) in dynamic shared objects. Makefile.am: Use $(INNODB_CFLAGS) and $(INNODB_DYNAMIC_CFLAGS) in target-specific CFLAGS and CXXFLAGS variable definitions. plug.in: Instead of appending to the MySQL-wide CFLAGS, introduce the variables INNODB_CFLAGS and INNODB_DYNAMIC_CFLAGS. Depending on $target_cpu, append -prefer-non-pic to INNODB_DYNAMIC_CFLAGS.	18 years ago
marko	775fd54ddb	branches/zip: Makefile.am: Disable the generation of position-independent code in the compilation of ha_innodb.so. ha_innodb_la_CXXFLAGS, ha_innodb_la_CFLAGS: Add -prefer-non-pic. This flag is interpreted by the ../../libtool script that acts as a front-end to the compiler and linker.	18 years ago
marko	4d1a1c2347	branches/zip: Add the necessary #include "univ.i" that was removed in the unapproved change r2290.	18 years ago
vasil	00fdbcc019	branches/zip: Do not include univ.i in mysql_addons.h, it was included for the sole purpose of innodb_redefine.h to work and now innodb_redefine.h has been removed. See r2251 and r2288.	18 years ago
marko	345422f65b	branches/zip: scripts/dynconfig: Correct misleading usage message. At present, the script only accepts one command line parameter. Append newline to some die messages, so that the Perl interpreter will not print the file name and line number of the failing statement.	18 years ago
marko	2c521319f2	branches/zip: Remove innodb_redefine.h and all references to it. The file has been redundant since r2278. include/innodb_redefine.h: Remove. include/sync0sync.h: Remove the definition of mutex_free that was added because of innodb_redefine.h. include/univ.i: Remove references to innodb_redefine.h. Explain why the C++ classes need to be renamed. scripts/build-plugin.sh: Build InnoDB only once. The file innodb_redefine.h is no longer needed.	18 years ago
marko	70a539b087	branches/zip: scripts/dynconfig: Minor cleanup (spelling and formatting).	18 years ago
marko	23961f575e	branches/zip: trx_sys_doublewrite_init_or_restore_pages(): Print out the space identifier in the corruption message.	18 years ago
inaam	044e405df0	branches/zip: srv_log_file_size is misspelled as srv_log_filen_size in r2276 reviewed by: non-functional change.	18 years ago

... 3 4 5 6 7 ...

1278 Commits (6e140c1ad20041d8f69b2183b4da3cc27f4a46f1) All Branches Search

1278 Commits (6e140c1ad20041d8f69b2183b4da3cc27f4a46f1)

All Branches