mariadb

Tree: 6cf8f05fd9

Author	SHA1	Message	Date
Aleksey Midenkov	198af54bb9	MDEV-20494 Fix wrongly ignored error status	6 years ago
Aleksey Midenkov	76063c2a13	MDEV-20494 ER_NOT_FORM_FILE or assertion upon adding partition to period table - Fixed mysql_prepare_create_table() constraint duplicate checking; - Refactored period constraint handling in mysql_prepare_alter_table(): * No need to allocate new objects; * Keep old constraint name but exclude it from dup checking by automatic_name; - Some minor memory leaks fixed; - Some conceptual TODOs.	6 years ago
Sergey Vojtovich	d2c366c6fb	Fix CentOS 6 and quantal build failures	6 years ago
Marko Mäkelä	1078a630f7	MDEV-22139 fseg_free_page_low() fails to write FREE_PAGE record, breaking recovery This bug was introduced by MDEV-15528 commit `a35b4ae898`. In the case that I analyzed, we failed to apply an EXTENDED,INSERT_REUSE_REDUNDANT redo log record whose preceding record points to unallocated area after PAGE_HEAP_TOP. Had we properly written the FREE_PAGE record for the page, recovery would have processed it, because during the checkpoint, the log had been completely written past the LSN of the missed write. fseg_free_page_low(): Always invoke mtr_t::free(). The other call is in fsp_free_page().	6 years ago
Daniel Black	abb0a31ec8	output_core_info - freebsd rlimits in different proc entry	6 years ago
Sergey Vojtovich	4197014ba0	Yet less TDC hash lookups Let auto repair table and truncate table routines flush TABLE_SHARE directly. Part of MDEV-17882 - Cleanup refresh version	6 years ago
Sergey Vojtovich	7a947614fb	Split tdc_remove_table() TDC_RT_REMOVE_ALL -> tdc_remove_table(). Some occurrences replaced with TDC_element::flush() (whenver TABLE_SHARE is available). TDC_RT_REMOVE_NOT_OWN[_KEEP_SHARE] -> TDC_element::flush(). These modes assume that current thread owns TABLE_SHARE reference, which means we can avoid hash lookup and flush unused TABLE instances directly. TDC_RT_REMOVE_UNUSED -> TDC_element::flush_unused(). Only [ab]used by mysql_admin_table() currently. Should be removed eventually. Part of MDEV-17882 - Cleanup refresh version	6 years ago
Sergey Vojtovich	06fae75859	tc_remove_all_unused_tables() cleanup As tc_purge() never marks share flushed, let tdc_remove_table() do it directly. Part of MDEV-17882 - Cleanup refresh version	6 years ago
Sergey Vojtovich	14e1385691	Proper locking for mysql.gtid_slave_pos truncation Aim of this patch is to remove tdc_remove_table(TDC_RT_REMOVE_UNUSED), which was mistakenly introduced by `055a3334a`. InnoDB allows only one open TABLE instance while performing table truncation. To fulfill this requirement: 1. MDL_EXCLUSIVE has to be acquired to block concurrent threads from accessing given table 2. cached TABLE instances have to be flushed 3. another InnoDB requirement is such that TABLE_SHARE and remaining TABLE instance have to be invalidated and re-opened after truncation This goes more or less inline with what regular TRUNCATE TABLE does. Alternative solution would be handler::ha_delete_all_rows(), but InnoDB doesn't implement it unfortunately. Part of MDEV-17882 - Cleanup refresh version	6 years ago
Sergey Vojtovich	bfdd30d3e9	Fixed close_cached_connection_tables() flushing Let DROP SERVER and ALTER SERVER perform fair affected tables flushing. That is acquire MDL_EXCLUSIVE and do tdc_remove_table(TDC_RT_REMOVE_ALL). Aim of this patch is elimination of another inconsistent use of TDC_RT_REMOVE_UNUSED. It fixes (to some extent) a problem described in the beginning of sql_server.cc, when close_cached_connection_tables() interferes with concurrent transaction. A better fix should probably introduce proper MDL locks for server objects? Part of MDEV-17882 - Cleanup refresh version	6 years ago
Sergey Vojtovich	54c03cb4f0	Cleanup mysql_inplace_alter_table() Removed redundant tdc_remove_table(TDC_RT_REMOVE_ALL). Share was marked flushed by preceding wait_while_table_is_used() and eventually flushed by close_all_tables_for_name(). Part of MDEV-17882 - Cleanup refresh version	6 years ago
Sergey Vojtovich	02619ed73b	Cleanup close_all_tables_for_name() close_all_tables_for_name() is always preceded by wait_while_table_is_used(), which makes tdc_remove_table() redundant. The only (now fixed) exception was close_cached_tables(). Part of MDEV-17882 - Cleanup refresh version	6 years ago
Sergey Vojtovich	e0743bd1a5	Let "FTWRL <table_list>" use extra(HA_EXTRA_FLUSH) Rather than flushing caches with tdc_remove_table(TDC_RT_REMOVE_UNUSED) flush them with extra(HA_EXTRA_FLUSH) instead. This goes inline with regular FTWRL. Part of MDEV-17882 - Cleanup refresh version	6 years ago
Marko Mäkelä	0870b75af7	MDEV-22126 Rename confusing constant mtr_t::OPT The template parameter mtr_t::OPT refers to optional, not optimized. Also the default parameter mtr_t::NORMAL refers to optimized writes. The name MAYBE_NOP would be more descriptive, conveying the idea that a write to a durable page might not actually have any effect.	6 years ago
Marko Mäkelä	406ca20b49	MDEV-22108 Recovery fails with InnoDB: Malformed log record mtr_t::log_write(): Fix an off-by-one error.	6 years ago
Daniel Black	e8351934b6	Merge pull request #1221 from grooverdan/10.4-MDEV-18851-multiple-sized-large-page-support MDEV-18851: multiple sized large page support (linux)	6 years ago
Sergei Golubchik	3bb5c6b0c2	MDEV-22113 SIGSEGV, ASAN use-after-poison, Assertion `next_insert_id == 0' in handler::ha_external_lock if the lookup_handler is allocated on the THD's memroot, it may not live long enough to be deleted in handler::ha_external_lock()	6 years ago
Daniel Black	a5686e14d9	MDEV-21303 Use mariadbd as the library plugins link to on non-Linux Prevent errors like on FreeBSD [ 56%] Linking CXX shared module ha_test_sql_discovery.so cd /usr/home/dan/build-mariadb-server-10.5/storage/test_sql_discovery && /usr/local/bin/cmake -E cmake_link_script CMakeFiles/test_sql_discovery.dir/link.txt --verbose=1 /usr/bin/c++ -fPIC -Wl,-z,relro,-z,now -fstack-protector --param=ssp-buffer-size=4 -O2 -g -DNDEBUG -D_FORTIFY_SOURCE=2 -DDBUG_OFF -shared -o ha_test_sql_discovery.so CMakeFiles/test_sql_discovery.dir/test_sql_discovery.cc.o -lpthread ../../libservices/libmysqlservices.a -lmysqld -lpthread /usr/bin/ld: error: unable to find library -lmysqld Also tested on OpenIndiana successfully. Closes #1480	6 years ago
Rasmus Johansson	5f3501a6e5	MDEV-22120 Add author to SHOW AUTHORS	6 years ago
Sergei Petrunia	a219006636	MDEV-22014: Rowid Filtering is not displayed well in the optimizer trace - Print the rowid filters that are available for use with each table. - Make print_best_access_for_table() print which filter it has picked. - Make best_access_path() print the filter for considered ref accesses.	6 years ago
Otto Kekäläinen	a135f0ab88	Travis-CI: Update default distro from Ubuntu Xenial to Bionic Ubuntu Bionic 18.04 LTS will be around until 2023 while Xenial is only to 2021. Thus Bionic is much more suitable as the Travis-CI default build environment for the 10.5 branch. For now, still keep one Xenial build to ensure backwards compatibility. Disable main.udf test until MDEV-21976 is addressed.	6 years ago
Otto Kekäläinen	dda61ade11	Travis-CI: Slim down number of parallel jobs to speed up total run time Number of jobs dropped from 23 -> 17 and build time from 8-10 hours to 3-4 hours. Drop GCC 6 and Clang 6 from build dependencies and version 6 is dropped from the jobs matrix. Also ignore arm64 and ppc64le on Bionic builds since they sporadically fail.	6 years ago
Marko Mäkelä	33ffcecc89	MDEV-22114 Assertion failure on SET GLOBAL innodb_buffer_pool_evict='uncompressed' innodb_buffer_pool_evict_uncompressed(): Remove the mutex acquisition that was inadvertently added in `1a6f708ec5`.	6 years ago
Marko Mäkelä	b212f1dac2	MDEV-22107 Restore accidentally orphaned MTR_MEMO_MODIFY In MDEV-12353, the calls to mtr_t::memo_modify_page() were accidentally removed along with mlog_open_and_write_index() and its callers. Let us resurrect the function to enable better debug checks. mtr_t::flag_modified(): Renamed from mtr_t::set_modified() and made private. mtr_t::set_modified(): Take const buf_block_t& as a parameter. In several mtr_t member functions, replace const buf_page_t& parameters with const buf_block_t&, so that we can pass the parameter to set_modified(). mtr_t::modify(): Add a MTR_MEMO_MODIFY entry for a block that is guaranteed to be modified in the mini-transaction.	6 years ago
Marko Mäkelä	587f3e0d9f	MDEV-12353: Fix a warning in RelWithDebInfo build page_zip_clear_rec(): Explicitly initialize len in non-debug builds to avoid a warning about possibly invalid memset() length.	6 years ago
Marko Mäkelä	51a9dd6793	Fix GCC 9.3.0 -Wstrict-aliasing copy_keys_from_share(): Use reinterpret_cast instead of manipulating a reference to a type-punned pointer. This cleans up after the cleanup commit `0515577d12`.	6 years ago
Marko Mäkelä	abaeeffbf9	MDEV-22103 INNODB_ENCRYPTION_NUM_KEY_REQUESTS is missing from INFORMATION_SCHEMA.GLOBAL_STATUS In commit `a5584b13d1` some scrubbing-related status variables were removed along with the background scrubbing code. The status variable INNODB_ENCRYPTION_NUM_KEY_REQUESTS was inadvertently removed as part of that. innodb_status_variables[]: Restore "encryption_num_key_requests". We introduce the test innodb.innodb_status_variables in order to catch similar regressions in the future.	6 years ago
Marko Mäkelä	a1077ab287	MDEV-22102 Assertion w==OPT failed in trx_undo_header_create() Because InnoDB is not freeing undo pages to the normal free-page management, old undo log pages can be reused. Due to that, it is possible (but unlikely) that the fields TRX_UNDO_NEEDS_PURGE and TRX_UNDO_LOG_START relative to the free offset that is stored at TRX_UNDO_PAGE_HDR + TRX_UNDO_PAGE_START already have the correct value. Hence, we must pass the mtr_t::OPT template parameter to silence the debug assertion. Other writes in trx_undo_header_create() that are using the default template parameter seem to be correct (the data fields should be guaranteed to change even in the event of reusing pages).	6 years ago
Nikita Malyavin	244ff3e5a0	forbid REPLACE/ODKU on tables containing WITHOUT OVERLAPS	6 years ago
Sergei Golubchik	62e7ad2bbc	cleanup: move initializations from query exec to prepare time that is don't call alloc_lookup_buffer() and create_lookup_handler() for every row also, don't call ha_check_overlaps() for every partition, after it was already done on the ha_partition level	6 years ago
Nikita Malyavin	259fb1cbed	MDEV-16978 Application-time periods: WITHOUT OVERLAPS * The overlaps check is implemented on a handler level per row command. It creates a separate cursor (actually, another handler instance) and caches it inside the original handler, when ha_update_row or ha_insert_row is issued. Cursor closes on unlocking the handler. * Containing the same key in index means unique constraint violation even in usual terms. So we fetch left and right neighbours and check that they have same key prefix, excluding from the key only the period part. If it doesnt match, then there's no such neighbour, and the check passes. Otherwise, we check if this neighbour intersects with the considered key. * The check does not introduce new error and fails with ER_DUPP_KEY error. This might break REPLACE workflow and should be fixed separately	6 years ago
Sergei Golubchik	0515577d12	cleanup: prepare "update_handler" for WITHOUT OVERLAPS * rename to a generic name * move remaning initializations from query exec to prepare time * simplify/unify key handling in open_table_from_share and delayed * remove dead code * move tests where they belong	6 years ago
Nikita Malyavin	045510cb92	fix mroonga: change field's table as well as ptr for ad-hoc // fixes ptr_in_record usage	6 years ago
Nikita Malyavin	db6f02bb98	fix key_copy to use from_record argument data key_copy is supposed to take field values from the from_record argument, but it was mostly ignoring it and instead relying on the caller to set field->ptr pointers accordingly. Inconsistently, it was checking the null bitmap in the from_record, not at the field->null_ptr. Now key_copy correctly takes all field values from the from_record.	6 years ago
Nikita Malyavin	7f9b3ea951	pass ptr into more Field methods	6 years ago
Nikita Malyavin	6334b57621	cleanup: const	6 years ago
Nikita Malyavin	b9df4d2a35	Fix real keyread count for partitions Sergei's commit `ac6b3c4430` implemented handler status counters compensation for underlying handlers like ha_partition. `index_read_idx_map` is missing there, but it should have been fixed as well (proof: ha_partition::index_read_idx_map never calls ha_partition::index_read_map). Note: all this compensation logic could be broken for subpartitions! (We can experience double decrement)	6 years ago
Nikita Malyavin	e6af62189e	unify "partitioning cannot do X" error messages	6 years ago
Nikita Malyavin	3bef848226	cleanup: reduce code duplication in read_extra2()	6 years ago
Sergei Golubchik	8ab693847e	cleanup: remove unused PLUGIN_INIT_SKIP_DYNAMIC_LOADING	6 years ago
Sergei Golubchik	64be8c2bf2	mysqld --help will now load mysqld.plugin table Remove special treatment for Aria. Add a test with --help and mysql.plugin table being InnoDB MyISAM is still treated specially, as we need to be able to initialize global_system_variables.table_plugin reliably	6 years ago
Sergei Golubchik	dc3185c759	cleanup: pk_is_clustering_key() -> is_clustering_key() where PK is neither required nor implied	6 years ago
Sergei Golubchik	27bf97aa00	cleanup: dead code, comments, avoid current_thd	6 years ago
Marko Mäkelä	63f922dae1	MDEV-22090 Change buffer is not freed after dropping or rebuilding table When MDEV-19514 removed the change buffer merges in the background, it introduced a minor regression: After a DDL operation that drops or rebuilds a table or partition, any entries in the change buffer could survive until a slow shutdown (innodb_fast_shutdown=0) is executed. fil_delete_tablespace(). Before returning, invoke ibuf_delete_for_discarded_space(). With this, the only way to have change buffer ‘leaks’ is to kill and restart the server at an appropriate moment and never initiate a slow shutdown.	6 years ago
Marko Mäkelä	14c72bd3e0	MDEV-19514: Correct a few outdated comments There is no background change buffer merge any more. Change buffer merge will only take place during a slow shutdown (a shutdown initiated after SET GLOBAL innodb_fast_shutdown=0).	6 years ago
Daniele Sciascia	bdcecfa22c	MDEV-22021: Galera database could get inconsistent with rollback to savepoint When binlog is disabled, WSREP will not behave correctly when SAVEPOINT ROLLBACK is executed and we will not rollback transaction.	6 years ago
Marko Mäkelä	b2bc837ebe	Cassandra: Define ha_cassandra::records_in_range() The definition of the member function ha_cassandra::records_in_range() was inadvertently removed (renamed to a non-member function) in commit `ff64152bc7`. Let us define the overridden member function inline, and add C++11 override qualifiers.	6 years ago
Marko Mäkelä	37c14690fc	Merge 10.4 into 10.5	6 years ago
Marko Mäkelä	aae3f921ad	Cleanup recv_sys: Move things to members recv_sys.recovery_on: Replaces recv_recovery_on. recv_sys_t::apply(): Replaces recv_apply_hashed_log_recs(). recv_sys_var_init(): Remove. recv_sys_t::recover_low(): Attempt to initialize a page based on buffered redo log records.	6 years ago
Marko Mäkelä	a8b04c3ee0	MDEV-12353: Remove a trace of pre-MDEV-13564 crash-upgrade In commit `f8a9f90667` we removed support for crash-upgrade from older versions, but forgot to remove a check for recovering TRUNCATE TABLE if MariaDB 10.2.18 or 10.3.9 or earlier were killed and we are attempting to upgrade to MariaDB 10.5.2 or later. Already MariaDB 10.4 would refuse to recover such TRUNCATE operations.	6 years ago

1 2 3 4 5 ...

189094 Commits (6cf8f05fd9deb900a78898576b85753e09feddaa) All Branches Search

189094 Commits (6cf8f05fd9deb900a78898576b85753e09feddaa)

All Branches