mariadb

Tree: 6ca065468f

Author	SHA1	Message	Date
Marko Mäkelä	c425d93b92	Merge 10.2 into 10.3 except commit `1288dfffe7`	5 years ago
Marko Mäkelä	14a18d7d7f	MDEV-23026/MDEV-25474 fixup: Assertion ib_table->stat_initialized It is possible that an object that was originally created by open_purge_table() will remain cached and reused for SQL execution. Our previous fix wrongly assumed that ha_innobase::open() would always be called before SQL execution starts. Therefore, we must invoke dict_stats_init() in ha_innobase::info_low() instead of only doing it in ha_innobase::open(). Note: Concurrent execution of dict_stats_init() on the same table is possible, but it also was possible between two calls to ha_innobase::open(), with no ill effects observed. This should fix the assertion failure on stat_initialized. A possibly easy way to reproduce it would have been to run the server with innodb_force_recovery=2 (disable the purge of history), update a table so that an indexed virtual column will be affected, and finally restart the server normally (purge enabled), to observe a crash when the table is accessed from SQL. The problem was first observed and this fix verified by Elena Stepanova. Also Thirunarayanan Balathandayuthapani repeated the problem.	5 years ago
Marko Mäkelä	25ed665a20	MDEV-25459 MVCC read from index on CHAR or VARCHAR wrongly omits rows row_sel_sec_rec_is_for_clust_rec(): If the field in the clustered index record stored off page, always fetch it, also when the secondary index field has been built on the entire column. This was broken ever since the InnoDB Plugin for MySQL Server 5.1 introduced ROW_FORMAT=DYNAMIC and ROW_FORMAT=COMPRESSED for InnoDB tables. That code was first introduced in this tree in commit `3945d5e554`. For the original ROW_FORMAT=REDUNDANT and the MySQL 5.0.3 ROW_FORMAT=COMPRESSED, there was no problem, because for those tables we always stored at least a 768-byte prefix of each column in the clustered index record. row_sel_sec_rec_is_for_blob(): Allow prefix_len==0 for matching the full column.	5 years ago
Igor Babaev	1288dfffe7	This patch complements the patch for MDEV-24823.	5 years ago
Aleksey Midenkov	42f8548ff6	MDEV-25091 CREATE TABLE: field references qualified by a wrong table name succeed Before FRM is written walk vcol expressions through check_table_name_processor() and check if field items match (db, table_name) qualifier. We cannot do this in check_vcol_func_processor() as there is already no table name qualifiers in expressions of written and loaded FRM.	5 years ago
Aleksey Midenkov	4649ba7493	MDEV-23455 Hangs + Sig11 in unknown location(s) due to single complex FK query Buffer overflow in ib_push_warning() fixed by using vsnprintf(). InnoDB parser was obsoleted by MDEV-16417. Thanks to Nikita Malyavin for review and suggestion.	5 years ago
Sergei Golubchik	018d7440fd	remove EXCEPTIONS-CLIENT It's Oracle libmysqlclient license exception, we no longer include, build or ship libmysqlclient	5 years ago
Igor Babaev	e3a25793be	MDEV-24823 Crash with invalid multi-table update of view in 2nd execution of SP Before this patch mergeable derived tables / view used in a multi-table update / delete were merged before the preparation stage. When the merge of a derived table / view is performed the on expression attached to it is fixed and ANDed with the where condition of the select S containing this derived table / view. It happens after the specification of the derived table / view has been merged into S. If the ON expression refers to a non existing field an error is reported and some other mergeable derived tables / views remain unmerged. It's not a problem if the multi-table update / delete statement is standalone. Yet if it is used in a stored procedure the select with incompletely merged derived tables / views may cause a problem for the second call of the procedure. This does not happen for select queries using derived tables / views, because in this case their specifications are merged after the preparation stage at which all ON expressions are fixed. This patch makes sure that merging of the derived tables / views used in a multi-table update / delete statement is performed after the preparation stage. Approved by Oleksandr Byelkin <sanja@mariadb.com>	5 years ago
Igor Babaev	b3b5d57e78	MDEV-24823 Crash with invalid multi-table update of view in 2nd execution of SP Before this patch mergeable derived tables / view used in a multi-table update / delete were merged before the preparation stage. When the merge of a derived table / view is performed the on expression attached to it is fixed and ANDed with the where condition of the select S containing this derived table / view. It happens after the specification of the derived table / view has been merged into S. If the ON expression refers to a non existing field an error is reported and some other mergeable derived tables / views remain unmerged. It's not a problem if the multi-table update / delete statement is standalone. Yet if it is used in a stored procedure the select with incompletely merged derived tables / views may cause a problem for the second call of the procedure. This does not happen for select queries using derived tables / views, because in this case their specifications are merged after the preparation stage at which all ON expressions are fixed. This patch makes sure that merging of the derived tables / views used in a multi-table update / delete statement is performed after the preparation stage. Approved by Oleksandr Byelkin <sanja@mariadb.com>	5 years ago
Sergei Golubchik	b8fad8c6bf	MDEV-25030 Upgrade to 10.5.9 breaks root's ability to grant	5 years ago
Sergei Golubchik	a40f29ab19	MYSQL_MAINTAINER_MODE fixes * MSVC check was lost in a bad merge * add a comment * move AIX check where it belongs and where it would still allow -Werror, if desired	5 years ago
Vladislav Vaintroub	5c5d24c772	MDEV-25456 - fix predicate in ib::error_or_warn	5 years ago
Vladislav Vaintroub	78bb9533f4	MDEV-25456 MariaBackup logs "[ERROR]" on Invalid log block checksum Fix is to changed message to be [WARNING] for backup	5 years ago
Vladislav Vaintroub	f6542a7af8	Update timezone data on Windows There is new Yukon Standard time Windows timezone. Also fix the powershell script that generates the Windows locale mapping, tell powershell to use TLSv1.2 to access the github (on some reason it is TLS1.1 that powershell is using by default, and it does no work)	5 years ago
Marko Mäkelä	1636db5443	Revert "MDEV-24589 DROP TABLE is not crash-safe" This reverts commit `e731a28394`. A crash occurred during the test stress.ddl_innodb when fil_delete_tablespace() for DROP TABLE was waiting in fil_check_pending_operations() and a purge thread for handling an earlier DROP INDEX was attempting to load the index root page in btr_free_if_exists() and btr_free_root_check(). The function buf_page_get_gen() would write out several times "trying to read...being-dropped tablespace" before giving up and committing suicide. It turns out that during any page access in btr_free_if_exists(), fil_space_t::set_stopping() could have been invoked by fil_check_pending_operations(), as part of dropping the tablespace. Preventing this race condition would require extensive changes to the allocation code or some locking mechanism that would ensure that we only set the flag if btr_free_if_exists() is not in progress. Either way, that could be a too risky change in a GA release. Because MDEV-24589 is not strictly necessary in the 10.5 release series and it only is a requirement for MDEV-25180 in a later major release, we will revert the change from 10.5.	5 years ago
sachin	21973d0d8e	MDEV-22953 main.flush_read_lock failed in buildbot with XAER_NOTA: Unknown XID Issue:- Since there is no waiting for the actual disconnection of the con_tmp (which does XA prepare of test1), We can have a issue when test1 is not prepared and we are calling rollback on test1 , giving XAER_NOTA: Unknown XID error Solution:- Wait for the complete disconnection of con_tmp	5 years ago
Marko Mäkelä	df33b719ca	Merge 10.4 into 10.5	5 years ago
Marko Mäkelä	cbbca7edf6	MDEV-25483: Shutdown crash during innodb.innodb_buffer_pool_resize_temporary buf_resize_callback(): Correct an invalid assertion, and enable the assertion in debug builds only. Between buf_resize_start() and buf_resize_shutdown(), srv_shutdown_state must be less than SRV_SHUTDOWN_CLEANUP. The incorrect assertion had been introduced in commit `5e62b6a5e0` (MDEV-16264). As a result, the server could crash if shutdown was initiated concurrently with initiating a change of innodb_buffer_pool_size.	5 years ago
Marko Mäkelä	ee455e6f2e	Merge 10.3 into 10.4	5 years ago
Marko Mäkelä	0d267f7caa	MDEV-25362 after-merge fix: Remove unnecessary code	5 years ago
Marko Mäkelä	6f271302b6	Merge 10.2 into 10.3	5 years ago
Thirunarayanan Balathandayuthapani	fb96ac0a49	MDEV-25474 Background thread returns uninitialized statistics to mysql interpreter InnoDB returns uninitialized statistics to mysql interpreter when background thread is opening the table. So it leads to assertion failure. In that case, InnoDB avoid sending innodb statistics information to mysql interpreter.	5 years ago
Eugene Kosov	64eeb250eb	MDEV-25457 Server crashes in row_undo_mod_clust_low upon rollback of read-only transaction node->index was NULL. But it's possible to get dict_table_t* from another source.	5 years ago
Andrei Elkin	2a7dd64425	MDEV-24526 binlog rotate via FLUSH LOGS may obsolate binlog file for recovery too eary There was race between a committing transaction and the following in binlog order FLUSH LOGS that could create a 2nd Binlog checkpoint (BCP) event in the new file before the first logged-in-old-binlog transaction gets committed in Innodb. That would cause the transaction loss at recovery, should the server stop right after the BCP. The race is tackled by enforcing the necessary set of mutexes to be acquired by FLUSH-LOGS handler in the correct order (of the group commit leader pattern). Note, there remain two cases where a similar race is still possible: - the above race as it is when the server is run with ("unlikely") non-default `--binlog-optimize-thread-scheduling=0` (MDEV-24530), and - at unlikely event of bin-logging of Incident event (MDEV-24531) that also triggers binlog rotation, in both cases though with lesser chances after the current fixes.	5 years ago
Marko Mäkelä	9abc6fd73f	Cleanup: constexpr PFS_table_context::m_word_size	5 years ago
Marko Mäkelä	b59d07624c	WITH_UBSAN: shift is too large for 32-bit int As suggested by Vladislav Vaintroub, we must shift a constant of unsigned long, not int.	5 years ago
Vicențiu Ciorbaru	ef2749c90d	Fixup: Event_queue_element_for_exec initializer list not supported on gcc-4.1	5 years ago
Marko Mäkelä	d104fe6f73	Merge 10.4 into 10.5	5 years ago
Marko Mäkelä	ceed768eea	MDEV-25362 after-merge fix: GCC -Og -Wmaybe-uninitialized	5 years ago
Marko Mäkelä	80ed136e6d	Merge 10.4 into 10.5	5 years ago
Marko Mäkelä	a0588d54a2	Merge 10.3 into 10.4	5 years ago
Marko Mäkelä	75c01f39b1	Merge 10.2 into 10.3	5 years ago
Lee Keun Won	9e6e0eaee2	fixed some korean error messages Closes #1811	5 years ago
Elena Stepanova	df18fa4cae	Smoke test collection should not be executable Since it ended up being a plain text file rather than a script (post-fix for MDEV-25288) Also removed main-test_sql_discovery.create from the list, as a workaround for MDEV-25384. The bug only affects 10.3+, but it will be simpler if 10.2 part of the tests is the same in all branches	5 years ago
Elena Stepanova	3635280cf7	MDEV-25288 Create a list of tests for distributions ... to run upon building/packaging of MariaDB server	5 years ago
Vicențiu Ciorbaru	6244876488	MDEV-24807:A possibility for double free in dtor of Event_queue_element_for_exec in the case of OOM Eliminate a memory leak when init can fail by forgetting to delete the Event_queue_element_for_exec object.	5 years ago
Marko Mäkelä	922e676b43	MDEV-25466 Merge new release of InnoDB 5.7.34 to 10.2	5 years ago
Aditya A	72432ec7b3	Bug #32032897 DEADLOCKING WAIT GRAPH ON BUSY SERVER PROBLEM ------- 1. The customer had presented a stack which had many threads waiting on multiple mutexes like LOCK_Status, srv_innodb_monitor_mutex, ibuf_mutex etc. 2. The root cause was that the AHI latch was held in S (shared) mode by the a thread which was doing a truncate of a large table . 3. There was another thread which was trying to acquire the AHI latch in X (exclusive) mode 4. With our lock implementation any thread requesting a X lock ,blocks rest of the threads requesting S(shared) locks,this caused many threads to wait for this shared lock. 5. The main reason why we hold the latches in truncate is to avoid disabling of AHI during truncate FIX	5 years ago
Monty	031f11717d	Fix all warnings given by UBSAN The easiest way to compile and test the server with UBSAN is to run: ./BUILD/compile-pentium64-ubsan and then run mysql-test-run. After this commit, one should be able to run this without any UBSAN warnings. There is still a few compiler warnings that should be fixed at some point, but these do not expose any real bugs. The 'special' cases where we disable, suppress or circumvent UBSAN are: - ref10 source (as here we intentionally do some shifts that UBSAN complains about. - x86 version of optimized int#korr() methods. UBSAN do not like unaligned memory access of integers. Fixed by using byte_order_generic.h when compiling with UBSAN - We use smaller thread stack with ASAN and UBSAN, which forced me to disable a few tests that prints the thread stack size. - Verifying class types does not work for shared libraries. I added suppression in mysql-test-run.pl for this case. - Added '#ifdef WITH_UBSAN' when using integer arithmetic where it is safe to have overflows (two cases, in item_func.cc). Things fixed: - Don't left shift signed values (byte_order_generic.h, mysqltest.c, item_sum.cc and many more) - Don't assign not non existing values to enum variables. - Ensure that bool and enum values are properly initialized in constructors. This was needed as UBSAN checks that these types has correct values when one copies an object. (gcalc_tools.h, ha_partition.cc, item_sum.cc, partition_element.h ...) - Ensure we do not called handler functions on unallocated objects or deleted objects. (events.cc, sql_acl.cc). - Fixed bugs in Item_sp::Item_sp() where we did not call constructor on Query_arena object. - Fixed several cast of objects to an incompatible class! (Item.cc, Item_buff.cc, item_timefunc.cc, opt_subselect.cc, sql_acl.cc, sql_select.cc ...) - Ensure we do not do integer arithmetic that causes over or underflows. This includes also ++ and -- of integers. (Item_func.cc, Item_strfunc.cc, item_timefunc.cc, sql_base.cc ...) - Added JSON_VALUE_UNITIALIZED to json_value_types and ensure that value_type is initialized to this instead of to -1, which is not a valid enum value for json_value_types. - Ensure we do not call memcpy() when second argument could be null. - Fixed that Item_func_str::make_empty_result() creates an empty string instead of a null string (safer as it ensures we do not do arithmetic on null strings). Other things: - Changed struct st_position to an OBJECT and added an initialization function to it to ensure that we do not copy or use uninitialized members. The change to a class was also motived that we used "struct st_position" and POSITION randomly trough the code which was confusing. - Notably big rewrite in sql_acl.cc to avoid using deleted objects. - Changed in sql_partition to use '^' instead of '-'. This is safe as the operator is either 0 or 0x8000000000000000ULL. - Added check for select_nr < INT_MAX in JOIN::build_explain() to avoid bug when get_select() could return NULL. - Reordered elements in POSITION for better alignment. - Changed sql_test.cc::print_plan() to use pointers instead of objects. - Fixed bug in find_set() where could could execute '1 << -1'. - Added variable have_sanitizer, used by mtr. (This variable was before only in 10.5 and up). It can now have one of two values: ASAN or UBSAN. - Moved ~Archive_share() from ha_archive.cc to ha_archive.h and marked it virtual. This was an effort to get UBSAN to work with loaded storage engines. I kept the change as the new place is better. - Added in CONNECT engine COLBLK::SetName(), to get around a wrong cast in tabutil.cpp. - Added HAVE_REPLICATION around usage of rgi_slave, to get embedded server to compile with UBSAN. (Patch from Marko). - Added #ifdef for powerpc64 to avoid a bug in old gcc versions related to integer arithmetic. Changes that should not be needed but had to be done to suppress warnings from UBSAN: - Added static_cast<<uint16_t>> around shift to get rid of a LOT of compiler warnings when using UBSAN. - Had to change some '/' of 2 base integers to shift to get rid of some compile time warnings. Reviewed by: - Json changes: Alexey Botchkov - Charset changes in ctype-uca.c: Alexander Barkov - InnoDB changes & Embedded server: Marko Mäkelä - sql_acl.cc changes: Vicențiu Ciorbaru - build_explain() changes: Sergey Petrunia	5 years ago
Daniele Sciascia	eb4123eefc	More fixes to variable wsrep_on * Disallow setting wsrep_on = 1 if wsrep_provider is unset. Also, move wsrep_on_basic from sys_vars to wsrep suite: this test now requires to run with wsrep_provider set * Disallow setting @@session.wsrep_on = 1 when @@global.wsrep_on = 0 * Handle the case where a new connection turns @@global.wsrep_on from off to on. In this case we would miss a call to wsrep_open, causing unexpected states in wsrep::client_state (causing assertions). * Disable wsrep.MDEV-22443 because it is no longer possible to enable wsrep_on, if server is started with wsrep_provider='none' Reviewed-by: Jan Lindström <jan.lindstrom@mariadb.com>	5 years ago
Andrei Elkin	675c22c065	MDEV-22757 Assertion !binlog \|\| exist_hton_without_prepare' failed in MYSQL_BIN_LOG::unlog_xa_prepare The assert fired falsely having not captured two more not apparent possiblities in its condition. They are masked out hton error out of REPLACE execution (so at later xa-prepare that engine is still present as read-write) and a prepare-capable engine which also may not be an actual participant in the xa transation. That engine, such as SEQUENCE, though does create its own event block.	6 years ago
Monty	0620ccf3ea	Fixed failing test spider/bugfix.mdev_22246 This was caused by MDEV-23634, which disabled index optimization for index != constant.	5 years ago
Jan Lindström	57caff245c	MDEV-25423 : Donor node fails to shutdown after mysqldump SST * Table should have primary key * Enable wsrep_sync_wait before final selects * Enable autocommit before final selects. * Fix joiner monitoring in case of mysqldump. * Add wait_conditions to stabilize	5 years ago
Aleksey Midenkov	562bbf5212	MDEV-25327 Unexpected ER_DUP_ENTRY upon dropping PK column from system-versioned table When dropped all user key-parts we also drop key-parts of implicit system fields.	5 years ago
Igor Babaev	635b5ce355	MDEV-25362 Incorrect name resolution for subqueries in ON expressions This patch sets the proper name resolution context for outer references used in a subquery from an ON clause. Usually this context is more narrow than the name resolution context of the parent select that were used before this fix. This fix revealed another problem that concerned ON expressions used in from clauses of specifications of derived tables / views / CTEs. The name resolution outer context for such ON expression must be set to NULL to prevent name resolution beyond the derived table where it is used. The solution to resolve this problem applied in sql_derived.cc was provided by Sergei Petrunia <sergey@mariadb.com>. The change in sql_parse.cc is not good for 10.4+. A corresponding diff for 10.4+ will be provided in JIRA entry for this bug. Approved by Oleksandr Byelkin <sanja@mariadb.com>	5 years ago
Rainer Orth	73bf62469e	MDEV-15064: IO_CACHE mysys read_pos, not libmaria rc_pos It seems some overly tolerant compilers (gcc) allow the structure of IO_CACHE that is defined differently in libmaria to have members equalivance to the iocache in mysys. More strict Solaris compilers recognise that rc_pos really isn't a structure member and won't compile.	5 years ago
Sergei Petrunia	ab5dc62545	MDEV-25407: EXISTS subquery with correlation in ON expression crashes Make Item_subselect::walk() walk the ON expressions, too.	5 years ago
Daniel Black	fce3e4ee8f	Revert "Deb: Use build flag to enforce default charset as utf8mb4" This reverts commit `f26e3259a1`.	5 years ago
Eugene Kosov	a3871cd283	MDEV-22255 SIGABRT: Assertion `id' failed in trx_write_trx_id on INSERT \| Assertion `id > 0' failed in trx_write_trx_id \| Assertion `val > 0' failed in row_upd_index_entry_sys_field \| Assertion `thr_get_trx(thr)->id \|\| index->table->no_rollback()' failed.	5 years ago
Thirunarayanan Balathandayuthapani	7fa12b1e34	MDEV-23026 purge fails with assert !rw_lock_own_flagged(lock, RW_LOCK_FLAG_X \| RW_LOCK_FLAG_S) InnoDB purge thread locks the root page of clustered index while accessing the undo log records and later same thread tries to open the table, initialize statistics and tries to lock the clustered index root page while doing virtual column computation. Solution: ========= InnoDB should prevent statistics initialization when the table is being opened by purge thread	5 years ago

... 3 4 5 6 7 ...

192389 Commits (6ca065468f16fcd9ecc4ab8a874aafc778154b58) All Branches Search

192389 Commits (6ca065468f16fcd9ecc4ab8a874aafc778154b58)

All Branches