mariadb

Tree: 6ae5b07b2a

Author	SHA1	Message	Date
monty@mysql.com/narttu.mysql.fi	088e2395f1	WL#3817: Simplify string / memory area types and make things more consistent (first part) The following type conversions was done: - Changed byte to uchar - Changed gptr to uchar* - Change my_string to char * - Change my_size_t to size_t - Change size_s to size_t Removed declaration of byte, gptr, my_string, my_size_t and size_s. Following function parameter changes was done: - All string functions in mysys/strings was changed to use size_t instead of uint for string lengths. - All read()/write() functions changed to use size_t (including vio). - All protocoll functions changed to use size_t instead of uint - Functions that used a pointer to a string length was changed to use size_t* - Changed malloc(), free() and related functions from using gptr to use void * as this requires fewer casts in the code and is more in line with how the standard functions work. - Added extra length argument to dirname_part() to return the length of the created string. - Changed (at least) following functions to take uchar* as argument: - db_dump() - my_net_write() - net_write_command() - net_store_data() - DBUG_DUMP() - decimal2bin() & bin2decimal() - Changed my_compress() and my_uncompress() to use size_t. Changed one argument to my_uncompress() from a pointer to a value as we only return one value (makes function easier to use). - Changed type of 'pack_data' argument to packfrm() to avoid casts. - Changed in readfrm() and writefrom(), ha_discover and handler::discover() the type for argument 'frmdata' to uchar** to avoid casts. - Changed most Field functions to use uchar* instead of char* (reduced a lot of casts). - Changed field->val_xxx(xxx, new_ptr) to take const pointers. Other changes: - Removed a lot of not needed casts - Added a few new cast required by other changes - Added some cast to my_multi_malloc() arguments for safety (as string lengths needs to be uint, not size_t). - Fixed all calls to hash-get-key functions to use size_t. (Needed to be done explicitely as this conflict was often hided by casting the function to hash_get_key). - Changed some buffers to memory regions to uchar to avoid casts. - Changed some string lengths from uint to size_t. - Changed field->ptr to be uchar* instead of char*. This allowed us to get rid of a lot of casts. - Some changes from true -> TRUE, false -> FALSE, unsigned char -> uchar - Include zlib.h in some files as we needed declaration of crc32() - Changed MY_FILE_ERROR to be (size_t) -1. - Changed many variables to hold the result of my_read() / my_write() to be size_t. This was needed to properly detect errors (which are returned as (size_t) -1). - Removed some very old VMS code - Changed packfrm()/unpackfrm() to not be depending on uint size (portability fix) - Removed windows specific code to restore cursor position as this causes slowdown on windows and we should not mix read() and pread() calls anyway as this is not thread safe. Updated function comment to reflect this. Changed function that depended on original behavior of my_pwrite() to itself restore the cursor position (one such case). - Added some missing checking of return value of malloc(). - Changed definition of MOD_PAD_CHAR_TO_FULL_LENGTH to avoid 'long' overflow. - Changed type of table_def::m_size from my_size_t to ulong to reflect that m_size is the number of elements in the array, not a string/memory length. - Moved THD::max_row_length() to table.cc (as it's not depending on THD). Inlined max_row_length_blob() into this function. - More function comments - Fixed some compiler warnings when compiled without partitions. - Removed setting of LEX_STRING() arguments in declaration (portability fix). - Some trivial indentation/variable name changes. - Some trivial code simplifications: - Replaced some calls to alloc_root + memcpy to use strmake_root()/strdup_root(). - Changed some calls from memdup() to strmake() (Safety fix) - Simpler loops in client-simple.c	19 years ago
mats@romeo.(none)	06faf8f411	BUG#27779 (Slave cannot read old rows log events): Taking code from before BUG#22583 and incorporating as events to be able to read old events. Also incorporating old pack and unpack functions into patch.	19 years ago
serg@janus.mylan	1c678b34aa	Bug#27171 mysqlbinlog produces different output depends from option -R a better fix, that works with 4.1 servers which don't send a fake Format_description_log_event.	19 years ago
serg@sergbook.mysql.com	25b49e99cd	Bug#27171 mysqlbinlog produces different output depends from option -R Server starts any binlog dump from Format_description_log_event, this shifted all offset calculations in mysqlbinlog and made it to stop the dump earlier than --stop-position. Now mysqlbinlog takes Format_description_log_event into account	19 years ago
jani@ua141d10.elisa.omakaista.fi	5c542a4656	Fixed compiler warnings.	19 years ago
guilhem@gbichot3.local	21492b54b4	Fix for BUG#26194 "mysqlbinlog --base64-output produces invalid SQL"; when it was printing a Query event, it produced invalid SQL (missing the BINLOG keyword, so the SQL started with the base64 string, which is incorrect). Note: no testcase; I have a .test which shows that the bugfix works, but it triggers BUG#26361 and so gives Valgrind warnings. I'm sending this test to the fixer of BUG#26361 for her/him to push when she/he fixes BUG#26361.	19 years ago
iggy@recycle.(none)	988ce58052	Bug#23736 Pointer free error in mysqlbinlog - Mis-matched SAFEMALLOC defines caused misleading error message.	19 years ago
jani@ua141d10.elisa.omakaista.fi	71c7035035	Added find_type_or_exit and find_bit_type_or_exit as wrappers around the original functions. These will ensure that error message is always in unique form, reduce code and print the right alternatives automatically in an error case.	19 years ago
gbichot@dl145h.mysql.com	ba2452f092	Fix for BUG#25628: "mysqlbinlog crashes while processing binary logs". mysqlbinlog prints all row-based events of a single statement as a single "BINLOG" statement containing the concatenation of those events. Big (i.e. >64k) concatenations of row-based events (e.g. Write_rows_log_event) caused mysqlbinlog's IO_CACHE to overflow to a temporary file but the IO_CACHE had not been inited with open_cached_file(), so it tried to create a temporary file in an uninitialized directory (thus failing to create, then to write; some OS errors were printed, and it finally segfaulted). After fixing this, it appeared that mysqlbinlog was printing only a piece of big concatenations of row-based events (it printed at most the size of the IO_CACHE's buffer i.e. 64k); that caused data loss at restore. We fix and test that. Last, mysqlbinlog's printouts looked a bit strange with the informative header (#-prefixed) of groupped Rows_log_event all on one line, so we insert \n. After that, a small bug in the --hexdump code appeared (only if the string to hex-print had its length a multiple of 16), we fix it.	19 years ago
monty@mysql.com/narttu.mysql.fi	f0ae3ce9b9	Fixed compiler warnings Fixed compile-pentium64 scripts Fixed wrong estimate of update_with_key_prefix in sql-bench Merge bk-internal.mysql.com:/home/bk/mysql-5.1 into mysql.com:/home/my/mysql-5.1 Fixed unsafe define of uint4korr() Fixed that --extern works with mysql-test-run.pl Small trivial cleanups This also fixes a bug in counting number of rows that are updated when we have many simultanous queries Move all connection handling and command exectuion main loop from sql_parse.cc to sql_connection.cc Split handle_one_connection() into reusable sub functions. Split create_new_thread() into reusable sub functions. Added thread_scheduler; Preliminary interface code for future thread_handling code. Use 'my_thread_id' for internal thread id's Make thr_alarm_kill() to depend on thread_id instead of thread Make thr_abort_locks_for_thread() depend on thread_id instead of thread In store_globals(), set my_thread_var->id to be thd->thread_id. Use my_thread_var->id as basis for my_thread_name() The above changes makes the connection we have between THD and threads more soft. Added a lot of DBUG_PRINT() and DBUG_ASSERT() functions Fixed compiler warnings Fixed core dumps when running with --debug Removed setting of signal masks (was never used) Made event code call pthread_exit() (portability fix) Fixed that event code doesn't call DBUG_xxx functions before my_thread_init() is called. Made handling of thread_id and thd->variables.pseudo_thread_id uniform. Removed one common 'not freed memory' warning from mysqltest Fixed a couple of usage of not initialized warnings (unlikely cases) Suppress compiler warnings from bdb and (for the moment) warnings from ndb	19 years ago
monty@mysql.com/narttu.mysql.fi	410fc81a72	After merge fixes Removed a lot of compiler warnings Removed not used variables, functions and labels Initialize some variables that could be used unitialized (fatal bugs) %ll -> %l	19 years ago
kent@mysql.com/kent-amd64.(none)	226a5c833f	Many files: Changed header to GPL version 2 only	19 years ago
monty@mysql.com/narttu.mysql.fi	88dd873de0	Fixed compiler warnings detected by option -Wshadow and -Wunused: - Removed not used variables and functions - Added #ifdef around code that is not used - Renamed variables and functions to avoid conflicts - Removed some not used arguments Fixed some class/struct warnings in ndb Added define IS_LONGDATA() to simplify code in libmysql.c I did run gcov on the changes and added 'purecov' comments on almost all lines that was not just variable name changes	19 years ago
bar@mysql.com/bar.intranet.mysql.r18.ru	ba6529d7dd	Bug#17642 mysqlbinlog: Restore from row-based binlog fails Problem: mysqlbinlog_base64 failed sporadically. Reason: Missing "flush logs" before running $MYSQL_BINLOG, which could start dumping the log file before server has finished writting into it. Fix: - implementing --force-if-open option to "mysqlbinlog" - adding --disable-force-if-open to make $MYSQL_BINLOG fail on non-closed log files, to garantee that nobody will forget "flush logs" in the future. - adding "flush logs" into all affected tests.	19 years ago
msvensson@neptunus.(none)	4e34f77c85	Bug#23735 mysqlbinlog client fails when reading binlog from stdin - Windows opens stdin in text mode by default. Certain characters such as CTRL-Z are interpeted as events and the read() method will stop. CTRL-Z is the EOF marker in Windows. to get past this you have to open stdin in binary mode. Setmode() is used to set stdin in binary mode. Errors on setting this mode result in halting the function and printing an error message to stderr.	19 years ago
bar@mysql.com/bar.intranet.mysql.r18.ru	a70028a855	Bug#20396 Bin Log does not get DELIMETER cmd - Recover StoredProc fails Problem: when loading mysqlbinlog dumps, CREATE PROCEDURE having semicolons in their bodies failed. Fix: Using safe delimiter "/!/;" to dump log entries.	19 years ago
monty@mysql.com/nosik.monty.fi	f6682e2743	Added --debug-info to most clients to detect memory leaks in mysql-test-run Moved .progress files into the log directory Moved 'cluster' database tables into the MySQL database, to not have 'cluster' beeing a reserved database name Fixed bug where mysqld got a core dump when trying to use a table created by MySQL 3.23 Fixed some compiler warnings Fixed small memory leak in libmysql Note that this doesn't changeset doesn't include the new mysqldump.c code required to run some tests. This will be added when I merge 5.0 to 5.1	19 years ago
monty@mysql.com/nosik.monty.fi	e825879800	Remove compiler warnings (Mostly in DBUG_PRINT() and unused arguments) Fixed bug in query cache when used with traceing (--with-debug) Fixed memory leak in mysqldump Removed warnings from mysqltest scripts (replaced -- with #)	19 years ago
cbell/Chuck@mysql_cab.	801f03381c	BUG#23735 Changes to comments in code for explanation of fix.	19 years ago
cbell/Chuck@mysql_cab.	c062178781	BUG#23735 Test rpl_row_mysqlbinlog fails on Windows. The errors report a file discrepency on reading a binlog from the command line.	19 years ago
mats@romeo.(none)	e762328b54	BUG#19459 (BINLOG RBR command does not lock tables correctly causing crash for, e.g., NDB): Before, mysqlbinlog printed table map events as a separate statement, so when executing the event, the opened table was subsequently closed when the statement ended. Instead, the row-based events that make up a statement are now printed as one BINLOG statement, which means that the table maps and the following *_rows_log_event events are executed fully before the statement ends. Changing implementation of BINLOG statement to be able to read the emitted format, which now consists of several chunks of BASE64-encoded data.	19 years ago
georg@lmy002.wdf.sap.corp	5686da41ac	Fixes for crashes and test failures	20 years ago
kostja@bodhi.local	2ce1a07c89	A fix and a test case for Bug#15752 "Lost connection to MySQL server when calling a SP from C API" The bug was caused by lack of checks for misuse in mysql_real_query. A stored procedure always returns at least one result, which is the status of execution of the procedure itself. This result, or so-called OK packet, is similar to a result returned by INSERT/UPDATE/CREATE operations: it contains the overall status of execution, the number of affected rows and the number of warnings. The client test program attached to the bug did not read this result and ivnoked the next query. In turn, libmysql had no check for such scenario and mysql_real_query was simply trying to send that query without reading the pending response, thus messing up the communication protocol. The fix is to return an error from mysql_real_query when it's called prior to retrieval of all pending results.	20 years ago
knielsen@mysql.com	fc16aff742	Fix two Valgrind memory leak warnings.	20 years ago
ramil@mysql.com	b698a07b1f	Fix for bug #18351 : mysqlbinlog does not set default charset?	20 years ago
knielsen@mysql.com	abcf6ccebb	Changes to make testsuite run in CMake build tree.	20 years ago
paul@snake-hub.snake.net	da8030ff7a	mysqlbinlog.cc: Put options in standard order: help first, then lexically, then variables.	20 years ago
serg@serg.mylan	14f94dc0ca	many warnings (practically safe but annoying) corrected	20 years ago
lars@mysql.com	ad126d90e0	WL#1012: All changes as one single changeset. This includes both code and test cases.	20 years ago
hartmut@mysql.com	45adda8fd1	added --server-id option to mysqlbinlog to filter for a certain server id in the binlog only	20 years ago
jani@a193-229-222-105.elisa-laajakaista.fi	669a12fdb0	A set of Netware related patches.	20 years ago
jamppa@suse9-x86.mysql.com	a50cc250ff	Netware specific changes for 5.0.16a	20 years ago
lars@mysql.com	4ccb1c6e36	mysqlbinlog --hexdump patch 4: Rename last_event_info to print_event_info to better reflect the new semantics	20 years ago
jimw@mysql.com	b6dcc55969	Fix being able to set default TCP port for command-line utilities by using MYSQL_TCP_PORT variable. (Bug #5792)	20 years ago
lars@mysql.com	48457e0852	mysqlbin --hexdump patch 3	20 years ago
lars@mysql.com	0378009b5b	Fix of incompatible types len and packet_error needs to be of same type for (len == packet_error) to check failures	20 years ago
guilhem@mysql.com	fd9a6f9750	Tell the user that this ROLLBACK is added by mysqlbinlog (so that he does not wonder if it's present in binlog). This was brought up by Salle - thanks Salle.	20 years ago
lars@mysql.com	bf19d02b27	mysqlbinlog --hexdump additional patch 2 - Fixes related to Guilhems review - Special printing of event header	20 years ago
lars@mysql.com	d81d57d408	mysqlbinlog --hexdump augments each log entry with byte information	20 years ago
lars@mysql.com	ed7eac5973	Added clarification comment regarding added ROLLBACK to mysqlbinlog output	20 years ago
jani@a193-229-222-105.elisa-laajakaista.fi	fe977b0cd0	Several fixes for Netware.	21 years ago
monty@mishka.local	7f845036c0	After merge fixes Review of new pushed code	21 years ago
serg@serg.mylan	9c332d8d2a	yassl changeset 2: remove FIX_GCC_LINKING_PROBLEM and -DDEFINE_CXA_PURE_VIRTUAL replace echo in configure.in with AC_MSG_WARN/AC_MSG_ERROR don't set -DUSE_MYSYS_NEW for gcc 2.95 set $USE_MYSYS_NEW even if CXX is g++ yassl bugfixes instantiate all yassl templates explicitly	21 years ago
gbichot@production.mysql.com	c766efdc5d	Last part of WL#1062: better replication of timezones: no more use of SET ONE_SHOT; storing tz info directly in event (if this info is needed), it's now allowed to have different global tz on master and slave.	21 years ago
dlenev@brandersnatch.localdomain	f169114042	WL#874 "Extended LOAD DATA". Now one can use user variables as target for data loaded from file (besides table's columns). Also LOAD DATA got new SET-clause in which one can specify values for table columns as expressions. For example the following is possible: LOAD DATA INFILE 'words.dat' INTO TABLE t1 (a, @b) SET c = @b + 1; This patch also implements new way of replicating LOAD DATA. Now we do it similarly to other queries. We store LOAD DATA query in new Execute_load_query event (which is last in the sequence of events representing LOAD DATA). When we are executing this event we simply rewrite part of query which holds name of file (we use name of temporary file) and then execute it as usual query. In the beggining of this sequence we use Begin_load_query event which is almost identical to Append_file event	21 years ago
guilhem@mysql.com	69fb5af28a	mysqlbinlog: safety measures (safe setting for completion_type, auto-end-rollback in case crashed binlog) which cannot hurt.	21 years ago
serg@serg.mylan	2b41b8fa01	post-review fixes. Now ROLLBACK is done in Format_description_log_event	21 years ago
serg@serg.mylan	db13afd89d	auto-ROLLBACK if binlog was not closed properly auto-commit on Xid_log_event	21 years ago
hf@deer.(none)	b94a482ee9	Precision Math implementation	21 years ago
mats@mysql.com	f6caefef2d	Bug#7853 (mysqlbinlog does not accept input from stdin) The utility 'mysqlbinlog' now accepts input from stdin. It can now be used to read the output from, e.g., 'zcat' or other utility.	21 years ago

1 2 3 4 5 ...

285 Commits (6ae5b07b2a930a0d196626811890105e788524f7)