mariadb

Tree: 6a9e24d046

Author	SHA1	Message	Date
Monty	6a9e24d046	Added support for replication for S3 MDEV-19964 S3 replication support Added new configure options: s3_slave_ignore_updates "If the slave has shares same S3 storage as the master" s3_replicate_alter_as_create_select "When converting S3 table to local table, log all rows in binary log" This allows on to configure slaves to have the S3 storage shared or independent from the master. Other thing: Added new session variable '@@sql_if_exists' to force IF_EXIST to DDL's.	6 years ago
Otto Kekäläinen	c8388de2fd	Fix various spelling errors e.g. - dont -> don't - occurence -> occurrence - succesfully -> successfully - easyly -> easily Also remove trailing space in selected files. These changes span: - server core - Connect and Innobase storage engine code - OQgraph, Sphinx and TokuDB storage engines Related to MDEV-21769.	6 years ago
Sergei Golubchik	0fe3d6d563	all status variables above `questions` MUST be ulong see e.g. `add_to_status()`	6 years ago
Marko Mäkelä	d82ac8d374	MDEV-21907: Fix some -Wconversion outside InnoDB Some .c and .cc files are compiled as part of Mariabackup. Enabling -Wconversion for InnoDB would also enable it for Mariabackup. The .h files are being included during InnoDB or Mariabackup compilation. Notably, GCC 5 (but not GCC 4 or 6 or later versions) would report -Wconversion for x\|=y when the type is unsigned char. So, we will either write x=(uchar)(x\|y) or disable the -Wconversion warning for GCC 5. bitmap_set_bit(), bitmap_flip_bit(), bitmap_clear_bit(), bitmap_is_set(): Always implement as inline functions.	6 years ago
Sergei Golubchik	7af733a5a2	perfschema compilation, test and misc fixes	6 years ago
Sergei Golubchik	81cffda2e6	perfschema transaction instrumentation related changes	6 years ago
Sergei Golubchik	6ded554fc2	perfschema thread instrumentation related changes	6 years ago
Sergei Golubchik	0d837e8153	perfschema table io instrumentation related changes	6 years ago
Sergei Golubchik	cea187e349	perfschema sysvar instrumentation related changes incomplete. locking issues	6 years ago
Sergei Golubchik	d4605bc90f	perfschema statement instrumentation related changes	6 years ago
Sergei Golubchik	7c58e97bf6	perfschema memory related instrumentation changes	6 years ago
Varun Gupta	b753ac066b	MDEV-21580: Allow packed sort keys in sort buffer This task deals with packing the sort key inside the sort buffer, which would lead to efficient usage of the memory allocated for the sort buffer. The changes brought by this feature are 1) Sort buffers would have sort keys of variable length 2) The format for sort keys inside the sort buffer would look like \|<sort_length><null_byte><key_part1><null_byte><key_part2>.......\| sort_length is the extra bytes that are required to store the variable length of a sort key. 3) When packing of sort key is done we store the ORIGINAL VALUES inside the sort buffer and not the STRXFRM form (mem-comparable sort keys). 4) Special comparison function packed_keys_comparison() is introduced to compare 2 sort keys. This patch also contains contributions from Sergei Petrunia.	6 years ago
Oleksandr Byelkin	980108ceeb	MDEV-21833 Make slave_run_triggers_for_rbr enforce triggers to run on slave, even when there are triggers on the master A bit changed patch of Anders Karlsson with examples added. New parameters "ENFORCE" to slave-run-triggers-for-rbr added.	6 years ago
Monty	940fcbe73b	Improved speed of optimizer trace - Added unlikely() to optimize for not having optimizer trace enabled - Made THD::trace_started() inline - Added 'if (trace_enabled())' around some potentially expensive code (not many found) - Added ASSERT's to ensure we don't call expensive optimizer trace calls if optimizer trace is not enabled - Added length to Json_writer functions to speed up buffer writes when optimizer trace is enabled. - Changed LEX_CSTRING argument handling to not send full struct to writer function on_add_str() functions now trusts length arguments	6 years ago
Aleksey Midenkov	193725b81e	MDEV-7318 RENAME INDEX This patch adds support of RENAME INDEX operation to the ALTER TABLE statement. Code which determines if ALTER TABLE can be done in-place for "simple" storage engines like MyISAM, Heap and etc. was updated to handle ALTER TABLE ... RENAME INDEX as an in-place operation. Support for in-place ALTER TABLE ... RENAME INDEX for InnoDB was covered by MDEV-13301. Syntax changes ============== A new type of <alter_specification> is added: <rename index clause> ::= RENAME ( INDEX \| KEY ) <oldname> TO <newname> Where <oldname> and <newname> are identifiers for old name and new name of the index. Semantic changes ================ The result of "ALTER TABLE t1 RENAME INDEX a TO b" is a table which contents and structure are identical to the old version of 't1' with the only exception index 'a' being called 'b'. Neither <oldname> nor <newname> can be "primary". The index being renamed should exist and its new name should not be occupied by another index on the same table. Related to: WL#6555, MDEV-13301	6 years ago
Aleksey Midenkov	fa8ad75439	MDEV-16290 ALTER TABLE ... RENAME COLUMN syntax The existing syntax for renaming a column uses "ALTER TABLE ... CHANGE" command. This requires full column specification to rename the column. This patch adds new syntax "ALTER TABLE ... RENAME COLUMN", which do not expect users to provide full column specification. It means that the new syntax would pick in-place or copy algorithm in the same way as that of existing "ALTER TABLE ... CHANGE" command. The existing syntax "ALTER TABLE ... CHANGE" will continue to work. Syntax changes ============== ALTER TABLE tbl_name [alter_specification [, alter_specification] ...] [partition_options] Following is a new <alter_specification> added: \| RENAME COLUMN <oldname> TO <newname> Where <oldname> and <newname> are identifiers for old name and new name of the column. Related to: WL#10761	6 years ago
Vicențiu Ciorbaru	ad17aa110c	MDEV-18650: Options deprecated in previous versions - multi_range_count Remove deprecated system variable multi_range_count. It was ignored from 5.3.	6 years ago
Alexander Barkov	83e75b39b3	MDEV-21702 Add a data type for privileges	6 years ago
mkaruza	41bc736871	Galera GTID support Support for galera GTID consistency thru cluster. All nodes in cluster should have same GTID for replicated events which are originating from cluster. Cluster originating commands need to contain sequential WSREP GTID seqno Ignore manual setting of gtid_seq_no=X. In master-slave scenario where master is non galera node replicated GTID is replicated and is preserved in all nodes. To have this - domain_id, server_id and seqnos should be same on all nodes. Node which bootstraps the cluster, to achieve this, sends domain_id and server_id to other nodes and this combination is used to write GTID for events that are replicated inside cluster. Cluster nodes that are executing non replicated events are going to have different GTID than replicated ones, difference will be visible in domain part of gtid. With wsrep_gtid_domain_id you can set domain_id for WSREP cluster. Functions WSREP_LAST_WRITTEN_GTID, WSREP_LAST_SEEN_GTID and WSREP_SYNC_WAIT_UPTO_GTID now works with "native" GTID format. Fixed galera tests to reflect this chances. Add variable to manually update WSREP GTID seqno in cluster Add variable to manipulate and change WSREP GTID seqno. Next command originating from cluster and on same thread will have set seqno and cluster should change their internal counter to it's value. Behavior is same as using @@gtid_seq_no for non WSREP transaction.	7 years ago
Alexander Barkov	f1e13fdc8d	MDEV-21581 Helper functions and methods for CHARSET_INFO	6 years ago
Vicențiu Ciorbaru	409aba3d99	Improve documentation of Unique class * size represents the size of an element in the Unique class * full_size is used when the Unique class counts the number of duplicates stored per element. This requires additional space per Unique element.	6 years ago
Aleksey Midenkov	5130f5206c	MDEV-20480 Obsolete internal parser for FK in InnoDB Currently InnoDB uses internal parser for adding foreign keys. Remove internal parser and use data parsed by SQL parser (sql_yacc) for adding foreign keys. - create_table_info_t::create_foreign_keys() replacement for dict_create_foreign_constraints_low(); - Pass constraint name via Foreign_key object. Temporary until MDEV-20865: - Pass alter_info as part of create_info.	6 years ago
Sujatha	caa79081c3	MDEV-20707: Missing memory barrier in parallel replication error handler in wait_for_prior_commit() revision-id: `673e253724` Author: Kristian Nielsen Fix missing memory barrier in wait_for_commit. The function wait_for_commit::wait_for_prior_commit() has a fast path where it checks without locks if wakeup_subsequent_commits() has already been called. This check was missing a memory barrier. The waitee thread does two writes to variables `waitee' and `wakeup_error', and if the waiting thread sees the first write it _must_ also see the second or incorrect behavior will occur. This requires memory barriers between both the writes (release semantics) and the reads (acquire semantics) of those two variables. Other accesses to these variables are done under lock or where only one thread will be accessing them, and can be done without barriers (relaxed semantics).	6 years ago
Sergei Petrunia	68ed3a81f2	MDEV-20854: ANALYZE for statements: not clear where the time is spent Count the "gap" time between table accesses and display it as r_other_time_ms in the "table" element. * The advantage of this approach is that it doesn't add any new my_timer_cycles() calls. * The disadvantage is that the definition of what is done during "other time" is not that clear: it includes checking the WHERE (for this table), constructing index lookup tuple (for the next table) writing to GROUP BY temporary table (as we dont account for that time separately [yet], etc)	6 years ago
Sergei Golubchik	5392b4a32c	MDEV-20354 All but last insert ignored in InnoDB tables when table locked mysql_insert() first opens all affected tables (which implicitly starts a transaction in InnoDB), then stat tables. A failure to open a stat table caused open_tables() to abort the current stmt transaction (trans_rollback_stmt()). So, from the server point of view the following ha_write_row()-s happened outside of a transactions, and the server didn't bother to commit them. The server has a mechanism to prevent a transaction being unexpectedly committed or rolled back in the middle of a statement - if an operation takes place _in a sub-statement_ it cannot change the transaction state. Operations on stat tables are exactly that - they are not allowed to change a transaction state. Put them in a sub-statement to make sure they don't.	6 years ago
Sergei Golubchik	42ada91542	cleanup: RAII helper for swapping of thd->security_ctx	6 years ago
Monty	67687d06bf	Simplify TABLE::decide_logging_format() - Use local variables table and share to simplify code - Use sql_command_flags to detect what kind of command was used - Added CF_DELETES_DATA to simplify detecton of delete commands - Removed duplicate error in create_table_from_items().	6 years ago
Rucha Deodhar	837ad9ab97	MDEV-10014 Add RETURNING to INSERT Closes #1384	7 years ago
Sergei Golubchik	721a9df751	cleanup: formatting comments, whitespaces	6 years ago
Oleksandr Byelkin	a6de640804	MDEV-18553: MDEV-16327 pre-requisits part 3: move kill check in one place Kill check moved from send_data() methids in its wrapper: send_data_with_check().	6 years ago
Oleksandr Byelkin	1ae02f0e0d	MDEV-18553: MDEV-16327 pre-requisits part 2: uniform of LIMIT/OFFSET handling Now both offset and limit are stored and do not chenged during execution (offset is decreased during processing in versions before 10.5). (Big part of this changes made by Monty)	6 years ago
Oleksandr Byelkin	eb0804ef5e	MDEV-18553: MDEV-16327 pre-requisits part 1: isolation of LIMIT/OFFSET handling	6 years ago
Alexander Barkov	530f3f7cfc	MDEV-20806 Federated does not work with INET6, returns NULL with warning ER_TRUNCATED_WRONG_VALUE	6 years ago
Sergey Vojtovich	adefaeffcc	MDEV-19536 - Server crash or ASAN heap-use-after-free in is_temporary_table / read_statistics_for_tables_if_needed Regression after `279a907`, read_statistics_for_tables_if_needed() was called after open_normal_and_derived_tables() failure. Fixed by moving read_statistics_for_tables() call to a branch of get_schema_stat_record() where result of open_normal_and_derived_tables() is checked. Removed THD::force_read_stats, added read_statistics_for_tables() instead. Simplified away statistics_for_command_is_needed().	6 years ago
Marko Mäkelä	46facaedbf	Fix GCC 9 -Wmaybe-uninitialized Always initialize ScopedStatementReplication::saved_binlog_format, so that GCC cannot emit a bogus warning about ScopedStatementReplication::~ScopedStatementReplication() using the variable. The code was originally introduced in commit `d998da0306`.	6 years ago
Sergey Vojtovich	f5c3ad1913	MDEV-16470 - Session user variables tracker Based on contribution by Dapeng Huang.	7 years ago
Sergey Vojtovich	ad77e3ac09	Cleanup session tracker - call current_schema::mark_as_changed() directly - call state_change::mark_as_changed() directly - replaced SESSION_TRACKER_CHANGED with dummy tracker - replaced Session_tracker::mark_as_changed() with State_tracker::mark_as_changed() - hide and devirtualize original State_tracker::mark_as_changed(), rename it to set_changed() - all implementations of mark_as_changed() now check is_enabled() for consistency - no argument casts anymore	6 years ago
Sergei Golubchik	647d5b2430	MDEV-20079 When setting back the system time while mysqld is running, NOW() and UNIX_TIMESTAMP() results get stuck typo. system_time.start wasn't updated when system_time.sec and system_time.sec_part were.	6 years ago
Ruihang Xia	2707af2dec	(1)mod: counter type from longlong to ha_rows (2)fix: bug when call create tmp table	6 years ago
Ruihang Xia	95f35bb75d	(1) fix type error (2) remove empty "--error ER_PARSE_ERROR" (3) change three members in class select_unit to protected.	6 years ago
Sergei Petrunia	ef76f81c98	MDEV-20109: Optimizer ignores distinct key created for materialized... (Backported to 10.3, addressed review input) Sj_materialization_picker::check_qep(): fix error in cost/fanout calculations: - for each join prefix, add #prefix_rows / TIME_FOR_COMPARE to the cost, like best_extension_by_limited_search does - Remove the fanout produced by the subquery tables. - Also take into account join condition selectivity optimize_wo_join_buffering() (used by LooseScan and FirstMatch) - also add #prefix_rows / TIME_FOR_COMPARE to the cost of each prefix. - Also take into account join condition selectivity	6 years ago
WayneXia	a896bebfa6	MDEV-18844 Implement EXCEPT ALL and INTERSECT ALL operations	6 years ago
Sachin	284c72eacf	MDEV-17614 INSERT on dup key update is replication unsafe Problem:- When mysql executes INSERT ON DUPLICATE KEY INSERT, the storage engine checks if the inserted row would generate a duplicate key error. If yes, it returns the existing row to mysql, mysql updates it and sends it back to the storage engine.When the table has more than one unique or primary key, this statement is sensitive to the order in which the storage engines checks the keys. Depending on this order, the storage engine may determine different rows to mysql, and hence mysql can update different rows.The order that the storage engine checks keys is not deterministic. For example, InnoDB checks keys in an order that depends on the order in which indexes were added to the table. The first added index is checked first. So if master and slave have added indexes in different orders, then slave may go out of sync. Solution:- Make INSERT...ON DUPLICATE KEY UPDATE unsafe while using stmt or mixed format When there is more then one unique key. Although there is two exception. 1. Auto Increment key is not counted because Innodb will get gap lock for failed Insert and concurrent insert will get a next increment value. But if user supplies auto inc value it can be unsafe. 2. Count only unique keys for which insertion is performed. So this patch also addresses the bug id #72921	7 years ago
Alexey Yurchenko	819c40d694	- wsrep-lib update (SR cleanups and voting support) (#1359 ) - TOI error ignoring fix (wsrep_ignore_apply_errors)	7 years ago
Alexander Barkov	7b5bfa53aa	A cleanup for MDEV-19923 Add type handlers for geometry sub-types Sources did not compile in some builds because of undeclared ER_BLOB_KEY_WITHOUT_LENGTH. Moving the implementations of Key_part_spec::check_key_length_for_blob() from sql_class.h to sql_class.cc	7 years ago
Alexander Barkov	b511202335	MDEV-19923 Add type handlers for geometry sub-types	7 years ago
Alexander Barkov	3e7e87ddcc	MDEV-19897 Rename source code variable names from utf8 to utf8mb3	7 years ago
Alexander Barkov	677133f1b3	MDEV-19863 Add const to TYPELIB pointers	7 years ago
Eugene Kosov	d36c107a6b	imporve clang build cmake -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_BUILD_TYPE=Debug Maintainer mode makes all warnings errors. This patch fix warnings. Mostly about deprecated `register` keyword. Too much warnings came from Mroonga and I gave up on it.	7 years ago
Alexey Botchkov	65e0c9b91b	MDEV-18661 loading the audit plugin causes performance regression. Plugin fixed to not lock the LOCK_operations when not active. Server fixed to lock the LOCK_plugin less - do it once per thread and then only if a plugin was installed/uninstalled.	7 years ago

1 2 3 4 5 ...

4220 Commits (6a9e24d0465fb0e67ba7bbc333263437e7227d8c)