mariadb

Tree: 6660708523

Author	SHA1	Message	Date
Monty	6660708523	Changed "const row not found" to "Const row not found" Also changed Unique row not found to use uppercase first. This was done to make these messages consistent with the rest	8 years ago
halfspawn	1a74d12da6	MDEV-12874 UPDATE statements with the same source and target	8 years ago
Vicențiu Ciorbaru	2160a85184	Update subselect test results to pass on 10.0 One query was removed due to inconsistent behaviour with subquery cache enabled vs disabled. MDEV-13399 has been created to track this change and fix.	8 years ago
Sergei Golubchik	d2e66a6f19	MDEV-7828 Assertion `key_read == 0' failed in TABLE::enable_keyread with SELECT SQ and WHERE SQ already fixed by `a7ed4644a6`. just add a test case,	8 years ago
halfspawn	abf95afa2a	MDEV-12137 DELETE statement with the same source and target single-table deletes only	8 years ago
Sergei Golubchik	6b99859fff	after-merge fix for `a7ed4644a6` (10.0+ changes, as specified in the MDEV) and remove unused variable (compiler warning)	8 years ago
Oleksandr Byelkin	a7ed4644a6	MDEV-10146: Wrong result (or questionable result and behavior) with aggregate function in uncorrelated SELECT subquery When outer reference resolved in a VIEW it still should mark aggregate function resolving border.	8 years ago
Alexander Barkov	705fc43eaa	MDEV-12775 Reuse data type aggregation code for hybrid functions and UNION Introducing a new class Type_holder (used internally in sql_union.cc), to reuse exactly the same data type attribute aggregation Type_handler API for hybrid functions and UNION. This fixes a number of bugs in UNION: - MDEV-9495 Wrong field type for a UNION of a signed and an unsigned INT expression - MDEV-9497 UNION and COALESCE produce different field types for DECIMAL+INT - MDEV-12594 UNION between fixed length double columns does not always preserve scale - MDEV-12595 UNION converts INT to BIGINT - MDEV-12599 UNION is not symmetric when mixing INT and CHAR Details: - sql_union.cc: Reusing attribute aggregation for UNION. Adding new methods: * st_select_lex_unit::join_union_type_handlers() * st_select_lex_unit::join_union_type_attributes() * st_select_lex_unit::join_union_item_types() Removing the old join_types()-based code. - Changing Type_handler::Item_hybrid_func_fix_attributes() to accept "name", Type_handler_hybrid_field_type, Type_all_attributes as three separate parameters instead of a single Item_hybrid_func parameter, to make it possible to pass both Item_hybrid_func and Type_holder. - Moving the former special GEOMETRY and ENUM/SET attribute aggregation code from Item_type_holder::join_types() to * Type_handler_typelib::Item_hybrid_func_fix_attributes(). * Type_handler_geometry::Item_hybrid_func_fix_attrubutes(). This makes GEOMETRY/ENUM/SET symmetric with all other data types (from the UNION point of view). Removing Item_type_holder::join_types() and Item_type_holder::get_full_info(). - Adding new methods into Type_all_attributes: * Type_all_attributes::set_geometry_type() and Item_hybrid_func::set_geometry_type(). * Adding Type_all_attributes::get_typelib(). * Adding Type_all_attributes::set_typelib(). - Adding Type_handler_typelib as a common parent for Type_handler_enum and Type_handler_set, to avoid code duplication: they have already had two common methods, and we're adding one more shared method. - Adding Type_all_attributes::set_maybe_null(), as some type handlers may want to set maybe_null (e.g. Type_handler_geometry) during data type attribute aggregation. - Changing Type_geometry_attributes() to accept Type_handler and Type_all_attributes as two separate parameters, instead of a single Item parameter, to make it possible to pass Type_holder. - Adding Item_args::add_argument(). - Moving Item_args::alloc_arguments() from "protected" to "public". - Moving Item_type_holder::Item_type_holder() from item.cc to item.h, as now it's very simple. Btw, this constructor should probably be eventually removed. It's now used only in sql_show.cc, which could be modified to use Item_return_decimal (for symmetry with Item_return_xxx created for all other data types). Or, another option: remove all Item_return_xxx and use Item_type_holder for all data types instead. - storage/tokudb/mysql-test/tokudb/r/type_float.result Recording new results (MDEV-12594). - mysql-test/r/cte_recursive.result Recording new results (MDEV-9497) - mysql-test/r/subselect*.result Recording new results (MDEV-12595) - mysql-test/r/metadata.result Recording new results (MDEV-9495) - mysql-test/r/temp_table.result Recording new results (MDEV-12594) - mysql-test/r/type_float.result Recording new results (MDEV-12594)	9 years ago
Igor Babaev	0906dc49e8	Fixed the bug mdev-12564. Here's what started happening after the patch that fixed the bug mdev-10454 with query reported for the bug SELECT * FROM t t1 right JOIN t t2 ON (t2.pk = t1.pk) WHERE (t2.i, t2.pk) NOT IN ( SELECT t3.i, t3.i FROM t t3, t t4 ) AND t1.c = 'foo'; The patch added an implementation of propagate_equal_fields() for the class Item_row and thus opened the possibility of equal fields substitutions. At the prepare stage after setup_conds() called for WHERE condition had completed the flag of maybe_null of the Item_row object created for (t2.i, t2.pk) was set to false, because the maybe_null flags of both elements were set to false. However the flag of maybe_null for t1.pk from the ON condition were set to true, because t1 was an inner table of an outer join. At the optimization stage the outer join was converted to inner join, but the maybe_null flags were not corrected and remained the same. So after the substitution t2.pk/t1.pk. the maybe_null flag for the row remained false while the maybe_flag for the second element of the row was true. As a result, when the in-to_exists transformation was performed for the NOT IN predicate the guards variables were not created for the elements of the row, but a guard object for the second element was created. The object were not valid because it referred to NULL as a guard variable. This ultimately caused a crash when the expression with the guard was evaluated at the execution stage. The patch made sure that the guard objects are not created without guard variables. Yet it does not resolve the problem of inconsistent maybe_null flags. and it might be that the problem will pop op in other pieces of code. The resolution of this problem is not easy, but the problem should be resolved in future versions.	9 years ago
Oleksandr Byelkin	05d3c3d3f7	MDEV-10141: Add support for INTERSECT (and common parts for EXCEPT) MDEV-10140: Add support for EXCEPT	9 years ago
Oleksandr Byelkin	7aa09a5ed2	MDEV-10141: Add support for INTERSECT (and common parts for EXCEPT) MDEV-10140: Add support for EXCEPT	9 years ago
Sergei Golubchik	01dd355635	cleanup: make a couple of tests more robust with --sorted_result	9 years ago
Nirbhay Choubey	8b2e642aa2	MDEV-7635: Update tests to adapt to the new default sql_mode	9 years ago
Nirbhay Choubey	3435e8a515	MDEV-7635: Part 1 innodb_autoinc_lock_mode = 2 innodb_buffer_pool_dump_at_shutdown = ON innodb_buffer_pool_dump_pct = 25 innodb_buffer_pool_load_at_startup = ON innodb_checksum_algorithm = CRC32 innodb_file_format = Barracuda innodb_large_prefix = ON innodb_log_compressed_pages = ON innodb_purge_threads = 4 innodb_strict_mode = ON binlog_annotate_row_events = ON binlog_format = MIXED binlog-row-event-max-size = 8192 group_concat_max_len = 1M lock_wait_timeout = 86400 log_slow_admin_statements = ON log_slow_slave_statements = ON log_warnings = 2 max_allowed_packet = 16M replicate_annotate_row_events = ON slave_net_timeout = 60 sync_binlog = 1 aria_recover = BACKUP,QUICK myisam_recover_options = BACKUP,QUICK	9 years ago
Alexander Barkov	5e051bfa15	MDEV-10386 Assertion `fixed == 1' failed in virtual String* Item_func_conv_charset::val_str(String*) The patch `b96c196f1c` added a new call for safe_charset_converter() without a corresponding fix_fields(). In case of a sub-query the created Item remained in non-fixed state. The problem did not show up with literal derived expressions, only subselects were affected. This patch adds a corresponding fix_fields() to the previously added safe_charset_converter().	9 years ago
Sergei Golubchik	180065ebb0	Item::print(): remove redundant parentheses by introducing new Item::precedence() method and using it to decide whether parentheses are required	9 years ago
Oleksandr Byelkin	f988bcecfd	MDEV-10776: Server crash on query Exclude untouched in prepare phese subqueries from the select/unit tree because they became unreachable by execution.	9 years ago
Sergei Golubchik	6820bf9ca9	do not quote numbers in the DEFAULT clause in SHOW CREATE	9 years ago
Monty	6f31dd093a	Added new status variables to make it easier to debug certain problems: - Handler_read_retry - Update_scan - Delete_scan	9 years ago
Oleksandr Byelkin	a52d3aa831	MDEV-10045: Server crashes in Time_and_counter_tracker::incr_loops Do not set 'optimized' flag until whole optimization procedure is finished.	9 years ago
Sergei Golubchik	8f9530a9ab	revert second lookahead in the lexer it's not enough to look for NOT NULL IS, this also fails queries like SELECT NOT NULL <=> NULL; and adds no value anymore, as the grammar now requires parentheses	9 years ago
Sergei Golubchik	99e48cb1d9	restore ER_VIEW_CHECK_FAILED to be different from ER_CONSTRAINT_FAILED collaterals: * use %`s, not '%s' * use correct SQLSTATE codes for these two errors	9 years ago
Michael Widenius	db7edfed17	MDEV-7563 Support CHECK constraint as in (or close to) SQL Standard MDEV-10134 Add full support for DEFAULT - Added support for using tables with MySQL 5.7 virtual fields, including MySQL 5.7 syntax - Better error messages also for old cases - CREATE ... SELECT now also updates timestamp columns - Blob can now have default values - Added new system variable "check_constraint_checks", to turn of CHECK constraint checking if needed. - Removed some engine independent tests in suite vcol to only test myisam - Moved some tests from 'include' to 't'. Should some day be done for all tests. - FRM version increased to 11 if one uses virtual fields or constraints - Changed to use a bitmap to check if a field has got a value, instead of setting HAS_EXPLICIT_VALUE bit in field flags - Expressions can now be up to 65K in total - Ensure we are not refering to uninitialized fields when handling virtual fields or defaults - Changed check_vcol_func_processor() to return a bitmap of used types - Had to change some functions that calculated cached value in fix_fields to do this in val() or getdate() instead. - store_now_in_TIME() now takes a THD argument - fill_record() now updates default values - Add a lookahead for NOT NULL, to be able to handle DEFAULT 1+1 NOT NULL - Automatically generate a name for constraints that doesn't have a name - Added support for ALTER TABLE DROP CONSTRAINT - Ensure that partition functions register virtual fields used. This fixes some bugs when using virtual fields in a partitioning function	9 years ago
Alexander Barkov	4c0e2960d4	MDEV-10051 Fix subselect to return a syntax error instead of "Incorrect usage of UNION and LIMIT"	10 years ago
Alexander Barkov	a999acf26e	MDEV-10095 Fix derived tables to return a syntax error instead of "Illegal usage of UNION and LIMIT"	10 years ago
Galina Shalygina	be1d06c8a5	Merge branch '10.2' into 10.2-mdev9864	10 years ago
Alexander Barkov	c0a59b46be	MDEV-10030 sql_yacc.yy: Split table_expression and remove PROCEDURE from create_select, select_paren_derived, select_derived2, query_specification This change refactors the "table_expression" rule in sql_yacc.yy. Queries with subselects and derived tables, as well as "CREATE TABLE ... SELECT" now return syntax error instead of "Incorrect usage of PROCEDURE and ...".	10 years ago
Oleksandr Byelkin	fba385e3b1	MDEV-9487: Server crashes in Time_and_counter_tracker::incr_loops with UNION in ALL subquery Do not mark subquery as inexpensive when it is not optimized.	10 years ago
Sergey Vojtovich	282497dd6d	MDEV-6720 - enable connection log in mysqltest by default	10 years ago
Vicențiu Ciorbaru	775cccca9f	MDEV-7122: Assertion `0' failed in subselect_hash_sj_engine::init The select mentioned in the bug attempted to create a temporary table using the maria storage engine. The table needs to have primary keys such that duplicates can be removed. Unfortunately this use case has a longer than allowed key and the tmp table got created without a temporary key. We must not allow materialization for the subquery if the total key length and key parts is greater than what the storage engine supports.	10 years ago
Oleksandr Byelkin	ce1b450ab1	MDEV-7930 Assertion `table_share->tmp_table != NO_TMP_TABLE \|\| m_lock_type != 2' failed in handler::ha_index_read_map In optimizing aggregate function do not try to touch tables from outer query.	10 years ago
Oleksandr Byelkin	bed4e84795	MDEV-8380: Subquery parse error backport mysql parser fixes `0034963fbf` `5948561812`	10 years ago
Oleksandr Byelkin	54b998173b	MDEV-7846: Server crashes in Item_subselect::fix_fields or fails with Thread stack overrun Substitute into transformed subselects original left expression and than register its change in case it was substituted.	11 years ago
Oleksandr Byelkin	0ab93fd6f3	MDEV-7445:Server crash with Signal 6 MDEV-7565: Server crash with Signal 6 (part 2) followup test suite and its fix.	11 years ago
Oleksandr Byelkin	2e3e818048	MDEV-7445: Server crash with Signal 6 Problem was in rewriting left expression which had 2 references on it. Solved with making subselect reference main. Item_in_optimized can have not Item_in_subselect reference in left part so type casting with no check is dangerous. Item::cols() should be checked after Item::fix_fields().	11 years ago
Oleksandr Byelkin	7ccde2cbd5	MDEV-7565: Server crash with Signal 6 (part 2) Preparation of subselect moved earlier (before checks which needs it prepared).	11 years ago
Alexander Barkov	3cc6e5b7f2	MDEV-8852 Implicit or explicit CAST from MAX(string) to INT,DOUBLE,DECIMAL does not produce warnings	10 years ago
Alexander Barkov	d9b25ae3db	MDEV-8466 CAST works differently for DECIMAL/INT vs DOUBLE for empty strings MDEV-8468 CAST and INSERT work differently for DECIMAL/INT vs DOUBLE for a string with trailing spaces	10 years ago
Alexander Barkov	39b46ae934	MDEV-8706 Wrong result for SELECT..WHERE time_column=TIMESTAMP'2015-08-30 00:00:00' AND time_column='00:00:00'	10 years ago
Monty	6b20342651	Ensure that fields declared with NOT NULL doesn't have DEFAULT values if not specified and if not timestamp or auto_increment In original code, sometimes one got an automatic DEFAULT value in some cases, in other cases not. For example: create table t1 (a int primary key) - No default create table t2 (a int, primary key(a)) - DEFAULT 0 create table t1 SELECT .... - Default for all fields, even if they where defined as NOT NULL ALTER TABLE ... MODIFY could sometimes add an unexpected DEFAULT value. The patch is quite big because we had some many test cases that used CREATE ... SELECT or CREATE ... (...PRIMARY KEY(xxx)) which doesn't have an automatic DEFAULT anymore. Other things: - Removed warnings from InnoDB when waiting from semaphore (got this when testing things with --big)	10 years ago
Alexander Barkov	43f185e171	MDEV-5528 Command line variable to choose MariaDB-5.3 vs MySQL-5.6 temporal data formats	11 years ago
Igor Babaev	3c4bb0e872	MDEV-334: Backport of UNION ALL optimization from mysql-5.7. Although the original code of mysql-5.7 was adjusted to the current MariaDB code the main ideas of the optimization were preserved.	11 years ago
Sergei Petrunia	c945233a19	MDEV-6657: Poor plan choice for ORDER BY key DESC optimization... The problem was caused by the following scenario: - range optimizer picks an index IDX1 which doesn't match the ORDER BY ... LIMIT clause. - test_if_skip_sort_order() decides to switch to index IDX2 which matches the ORDER BY ... LIMIT. - it runs SQL_SELECT::test_quick_select() for the second time to produce an quick select for IDX2. - However, test_quick_select() would figure that full index scan on IDX1 is still cheaper (its calculations ignore the LIMIT n). Fixed this by - passing force_quick_range=true to test_quick_select() - in test_quick_select, don't consider full index scans if the mentioned parameter is true. Numerous changes in .result files are caused by test_quick_select() being run after "early/late NULLs filtering" feature has injected NOT NULL condition.	11 years ago
unknown	4cd676cbd9	MDEV-6047: Make exists_to_in optimization ON by default	12 years ago
unknown	05722f06b2	MDEV-5991: crash in Item_field::used_tables Units of subqueroes from excluded expressions should be excluded from select_lex/select_unit tree.	12 years ago
Sergey Petrunya	2bbca99018	MDEV-6041: ORDER BY+subqueries: subquery_table.key=outer_table.col is not recongized as binding - Make JOIN::const_key_parts include keyparts for which the WHERE clause has an equality in form "t.key_part=reference_outside_this_select" - This allows to avoid filesort'ing in some cases (and also avoid a difficult choice between using filesort or using an index)	12 years ago
Igor Babaev	3e03c9eae9	After constant row substitution the optimizer should call the method update_used_tables for the the where condition to update cached indicators of constant subexpressions. It should be done before further possible simplification of the where condition. This change caused simplification of the executed where conditions in many test cases.	12 years ago
Michael Widenius	43f6e118fe	Fixes for CREATE_OR_REPLACE - MDEV-5587 Server crashes in Locked_tables_list::restore_lock on CREATE OR REPLACE .. SELECT under LOCK - MDEV-5586 Assertion `share->tdc.all_tables.is_empty() \|\| remove_type != TDC_RT_REMOVE_ALL' fails in tdc_remove_table - MDEV-5588 Strange error on CREATE OR REPLACE table over an existing view mysql-test/r/create_or_replace.result: Added test cases mysql-test/r/lowercase_view.result: New error message mysql-test/r/merge.result: New error message mysql-test/r/multi_update.result: New error message mysql-test/r/subselect.result: New error message mysql-test/r/subselect_exists_to_in.result: New error message mysql-test/r/subselect_no_mat.result: New error message mysql-test/r/subselect_no_opts.result: New error message mysql-test/r/subselect_no_scache.result: New error message mysql-test/r/subselect_no_semijoin.result: New error message mysql-test/r/view.result: New error message mysql-test/suite/funcs_1/r/myisam_views-big.result: New error message mysql-test/t/create_or_replace.test: New tests mysql-test/t/view.test: New error message sql/share/errmsg-utf8.txt: Added new error message sql/sql_base.cc: Updated error message Do an automatic UNLOCK TABLES if we don't have any locked tables (safety fix) sql/sql_db.cc: Updated arguments sql/sql_load.cc: New error message sql/sql_parse.cc: Check that we are not using a table we are dropping and re-creating sql/sql_table.cc: Added parameter to mysql_rm_table_no_locks() to not automaticly do UNLOCK TABLES Added better error message if trying to drop a view with DROP TABLE Don't try to create something we select from sql/sql_table.h: Updated prototypes	12 years ago
timour@askmonty.org	883af99e7d	MDEV-5104 crash in Item_field::used_tables with broken order by Analysis: st_select_lex_unit::prepare() computes can_skip_order_by as TRUE. As a result join->prepare() gets called with order == NULL, and doesn't do name resolution for the inner ORDER clause. Due to this the prepare phase doesn't detect that the query references non-exiting function and field. Later join->optimize() calls update_used_tables() for a non-resolved Item_field, which understandably has no Field object. This call results in a crash. Solution: Resolve unnecessary ORDER BY clauses to detect if they reference non-exising objects. Then remove such clauses from the JOIN object.	12 years ago
Igor Babaev	901737c978	Fixed bug mdev-4944. The patch to fix mdev-4418 turned out to be incorrect. At the substitution of single row tables in make_join_statistics() the used multiple equalities may change and references to the new multiple equalities must be updated. The function remove_eq_conds() takes care of it and it should be called right after the substitution of single row tables. Calling it after the call of make_join_statistics was a mistake.	12 years ago

1 2 3 4 5 ...

257 Commits (666070852384c2f5c40685a1ae0702e7d8cee85e)