mariadb

Tree: 648b957f42

Author	SHA1	Message	Date
Sergei Petrunia	68bf3c5052	Code cleanup	11 years ago
Sergei Petrunia	4a7cacda58	MDEV-406: ANALYZE $stmt: fix "explain UPDATE view problem".	11 years ago
Sergei Petrunia	7711999d8b	MDEV-406: ANALYZE $stmt: add support for BNL join buffering	11 years ago
Sergei Petrunia	1dd5d31c73	MDEV-406: ANALYZE $stmt: fix order_by.test In JOIN_TAB::update_explain_data(), take into account that - the table that may have pre-sorted is the first non-const table - Tables that are eliminated by table elimination are marked as const tables, but are not present in the Explain data structures	11 years ago
Sergei Petrunia	c08de06246	MDEV-406: ANALYZE $stmt: get ANALYZE work for subqueries - "ANALYZE $stmt" should discard select's output, but it should still evaluate the output columns (otherwise, subqueries in select list are not executed) - SHOW EXPLAIN's code practice of calling JOIN::save_explain_data() after JOIN::exec() is disastrous for ANALYZE, because it resets all counters after the first execution. It is stopped = "Late" test_if_skip_sort_order() calls explicitly update their part of the query plan. = Also, I had to rewrite I_S optimization to actually have optimization and execution stages.	11 years ago
Sergei Golubchik	2510f9c606	cleanup: remove special case from store_key::store_key(), add Field_blob::new_key_field (prep for MDEV-6065)	12 years ago
Igor Babaev	d42e6d3a99	Fixed bug mdev-6071. The method JOIN_CACHE::init may fail (return 1) if some conditions on the used join buffer is not satisfied. For example it fails if join_buffer_size is greater than join_buffer_space_limit. The conditions should be checked when running the EXPLAIN command for the query. That's why the method JOIN_CACHE::init has to be called for EXPLAIN commands as well.	12 years ago
Sergey Petrunya	aeb62282a2	MDEV-5985: EITS: selectivity estimates look illogical for join and non-key equalities Part#1. table_cond_selectivity() should discount selectivity of table' conditions only when ity counts that selectivity to begin with. For non-ref-based access methods (ALL/range/index_merge/etc), we start with sel=1.0 and hence do not need to discount any selectivities.	12 years ago
Sergey Petrunya	71df035551	MDEV-6308: Server crashes in table_multi_eq_cond_selectivity with ... - In table_cond_selectivity(), reset keyuse variable between the loops.	12 years ago
Sergei Golubchik	2d2697ea8d	MDEV-6221 SQL_CALC_FOUND_ROWS yields wrong result again replace another old "was there a filesort?" test with a correct "did filesort calculate found_rows?" test.	12 years ago
Sergei Golubchik	fde6ee61bb	revert the fix for MDEV-5898, restore the fix for MDEV-5549. simplify test case for MDEV-5898	12 years ago
Sergei Petrunia	5621aa3230	MDEV-406: ANALYZE $stmt - Support tracking for UNIONs, temporary-table based ORDER BYs, and both.	12 years ago
Sergey Petrunya	b6b5b748e7	MDEV-5884: EXPLAIN UPDATE ... ORDER BY LIMIT shows wrong #rows - Make get_index_for_order() return correct #rows. changed EXPLAIN outputs are checked - only #rows is different.	12 years ago
Sergey Petrunya	d533a64bf3	MDEV-6239: Partition pruning is not working as expected in an inner query - Make partition pruning work for tables inside semi-join nests (the new condition is the same that range optimizer uses so it should be ok)	12 years ago
Sergey Petrunya	dedc76b7d9	MDEV-6263: Wrong result when using IN subquery with order by - When the optimizer chose LooseScan, make_join_readinfo() should use the index that was chosen for LooseScan, and should not try to find a better (shortest) index.	12 years ago
Sergei Petrunia	eaba1ba4a5	Re-commit in git: MDEV-406: ANALYZE $stmt - Ported the old patch to new explain code - New SQL syntax (ANALYZE $stmt) - ANALYZE UPDATE/DELETE is now supported (because EXPLAIN UPDATE/DELETE is supported) - Basic counters are calculated for basic kinds of queries (still need to see what happens with join buffer, ORDER BY...LIMIT queries, etc)	12 years ago
Sergei Golubchik	edf1fbd25b	MDEV-6153 Trivial Lintian errors in MariaDB sources: spelling errors and wrong executable bits	12 years ago
unknown	285160dee2	MDEV-5981: name resolution issues with views and multi-update in ps-protocol It is triple bug with one test suite: 1. Incorrect outer table detection 2. Incorrect leaf table processing for multi-update (should be full like for usual updates and inserts) 3. ON condition fix_fields() fould be called for all tables of the query.	12 years ago
mithun	3d6d85b40d	Bug #18167356 : EXPLAIN W/ EXISTS(SELECT* UNION SELECT) WHERE ONE OF SELECT IS DISTINCT FAILS. ISSUE: ------ There are 2 issues related to explain union. 1. If we have subquery with union of selects. And, one of the select need temp table to materialize its results then it will replace its query structure with a simple select from temporary table. Trying to display new internal temporary table scan resulted in crash. But to display the query plan, we should save the original query structure. 2. Multiple execution of prepared explain statement which have union of subqueries resulted in crash. If we have constant subqueries, fake select used in union operation will be evaluated once before using it for explain. During first execution we have set fake select options to SELECT_DESCRIBE, but did not reset after the explain. Hence during next execution of prepared statement during first time evaluation of fake select we had our select options as SELECT_DESCRIBE this resulted in improperly initialized data structures and crash. SOLUTION: --------- 1. If called by explain now we save the original query structure. And this will be used for displaying. 2. Reset the fake select options after it is called for explain of union. sql/sql_select.cc: Reset the fake select options after it is called for explain of union sql/sql_union.cc: If called by explain but not from select_describe and we need a temp table, then we create a temp join to preserve original query structure.	12 years ago
Sergey Petrunya	504068b093	MDEV-6209: Assertion `join->best_read < double(1.79769313486231570815e+308L ... - Use floating-point division in selectivity calculations.	12 years ago
Sergey Petrunya	32392c05b7	MDEV-6185: Buildbot valgrind failure: Conditional jump or move in table_cond_selectivity	12 years ago
Sergey Petrunya	2acd81af73	MDEV-6003: EITS: ref access, keypart2=const vs keypart2=expr - inconsistent filtered% value - Fix table_cond_selectivity() to work correctly for ref access and "keypart2=const" case.	12 years ago
Sergey Petrunya	182f7d76ee	Revert these two changes (wrong push) : MDEV-5980: EITS: if condition is used for REF access, its selectivity is still in filtered% MDEV-5985: EITS: selectivity estimates look illogical for join and non-key equalities MDEV-6003: EITS: ref access, keypart2=const vs keypart2=expr - inconsistent filtered% value - Made a number of fixes in table_cond_selectivity() so that it returns correct selectivity estimates. - Added comments in related code. Better comments	12 years ago
Sergey Petrunya	46d1b84597	Better comments	12 years ago
Sergey Petrunya	deb26989e9	MDEV-5980: EITS: if condition is used for REF access, its selectivity is still in filtered% MDEV-5985: EITS: selectivity estimates look illogical for join and non-key equalities MDEV-6003: EITS: ref access, keypart2=const vs keypart2=expr - inconsistent filtered% value - Made a number of fixes in table_cond_selectivity() so that it returns correct selectivity estimates. - Added comments in related code.	12 years ago
Igor Babaev	13dc299a4f	Fixed bugs mdev-5927 and mdev-6116. Both bugs are caused by the same problem: the function optimize_cond() should update the value of *cond_equal rather than the value of join->cond_equal, because it is called not only for the WHERE condition, but for the HAVING condition as well.	12 years ago
Sergey Petrunya	244d4b532a	MDEV-6081: ORDER BY+ref(const): selectivity is very incorrect (MySQL Bug#14338686) Add a testcase and backport this fix: Bug#14338686: MYSQL IS GENERATING DIFFERENT AND SLOWER (IN NEWER VERSIONS) EXECUTION PLAN PROBLEM: While checking for an index to sort for the order by clause in this query "SELECT datestamp FROM contractStatusHistory WHERE contract_id = contracts.id ORDER BY datestamp asc limit 1;" we do not calculate the number of rows to be examined correctly. As a result we choose index 'idx_contractStatusHistory_datestamp' defined on the 'datestamp' field, rather than choosing index 'contract_id'. And hence the lower performance. ANALYSIS: While checking if an index is present to give the records in sorted order(datestamp), we consider the selectivity of the 'ref_key'(contract_id here) using 'table->quick_condition_rows'. 'ref_key' here can be an index from 'REF_ACCESS' or from 'RANGE'. As this is a 'REF_ACCESS', 'table->quick_condition_rows' is not set to the actual value which is 2. Instead is set to the number of tuples present in the table indicating that every row that is selected would be satisfying the condition present in the query. Hence, the selectivity becomes 1 even when we choose the index on the order by column instead of the join_condition. But, in reality as only 2 rows satisy the condition, we need to examine half of the entire data set to get one tuple when we choose index on the order by column. Had we chosen the 'REF_ACCESS' we would have examined only 2 tuples. Hence the delay in executing the query specified. FIX: While calculating the selectivity of the ref_key: For REF_ACCESS consider quick_rows[ref_key] if range optimizer has an estimate for this key. Else consider 'rec_per_key' statistic. For RANGE ACCESS consider 'table->quick_condition_rows'.	12 years ago
Sergey Petrunya	2bbca99018	MDEV-6041: ORDER BY+subqueries: subquery_table.key=outer_table.col is not recongized as binding - Make JOIN::const_key_parts include keyparts for which the WHERE clause has an equality in form "t.key_part=reference_outside_this_select" - This allows to avoid filesort'ing in some cases (and also avoid a difficult choice between using filesort or using an index)	12 years ago
Sergey Petrunya	26a3d567c9	MDEV-5992: EITS: Selectivity of non-indexed condition is counted twice in table's fanout MDEV-5984: EITS: Incorrect filtered% value for single-table select with range access - Fix calculate_cond_selectivity_for_table() to work correctly with range accesses over multi-component keys: = First, take selectivity of all possible range scans into account. Remember which fields were used bt the range scans. = Then, calculate selectivity produced by sargable predicates on fields. If a field was used in a possible range access, assume its selectivity is already taken into account. - Fix table_cond_selectivity(): when quick select is used, selectivity of COND(table) is taken into account in matching_candidates_in_table(). In table_cond_selectivity() we should not apply it for the second time.	12 years ago
Sergei Golubchik	3bb249612f	MDEV-5846 MySQL Bug #18144 - Cost with FORCE/USE index seems incorrect in some cases.	12 years ago
Sergei Golubchik	9418bd9c21	MDEV-5898 FOUND_ROWS() return incorrect value when using DISTINCT revert the fix for MDEV-5549, use a different approach.	12 years ago
Igor Babaev	06ef0bdad2	Fixed bug mdev-5191. Corrected cost estimates when a join buffer is used and the optimizer is requested to use condition selectivities.	12 years ago
Sergey Petrunya	8c04dd33dd	MDEV-5811: Server crashes in best_access_path with materialization+semijoin and big_tables=ON - With big_tables=ON, materialized table will use Aria (or MyISAM) SE, which allows prefix key reads. However, the temp.table has rec_per_key=NULL which causes the optimizer to crash when attempting to read index statistics for a prefix index read. - Fixed by providing a rec_per_key array with zeros (i.e. "no statistics data")	12 years ago
Igor Babaev	1f2ef57403	Fixed bug mdev-5686. The calls of the function remove_eq_conds() may change the and/or structure of the where conditions. So JOIN::equal_cond should be updated for non-recursive calls of remove_eq_conds().	12 years ago
Sergey Petrunya	24d9bf8227	MDEV-5778: Valgrind failure in innodb_ext_keys.test - Fix valgrind failure: make test_if_order_by_key() account for extended keys feature.	12 years ago
unknown	05722f06b2	MDEV-5991: crash in Item_field::used_tables Units of subqueroes from excluded expressions should be excluded from select_lex/select_unit tree.	12 years ago
unknown	982607508d	MDEV-4309: DBT-3 Q1 benchmark: Benchmark + profile a patch Removed repetative calls of virtual functions. Removed check of posibility just copy field for every record.	12 years ago
Igor Babaev	3e03c9eae9	After constant row substitution the optimizer should call the method update_used_tables for the the where condition to update cached indicators of constant subexpressions. It should be done before further possible simplification of the where condition. This change caused simplification of the executed where conditions in many test cases.	12 years ago
Sergey Vojtovich	d12c7adf71	MDEV-5314 - Compiling fails on OSX using clang This is port of fix for MySQL BUG#17647863. revno: 5572 revision-id: jon.hauglid@oracle.com-20131030232243-b0pw98oy72uka2sj committer: Jon Olav Hauglid <jon.hauglid@oracle.com> timestamp: Thu 2013-10-31 00:22:43 +0100 message: Bug#17647863: MYSQL DOES NOT COMPILE ON OSX 10.9 GM Rename test() macro to MY_TEST() to avoid conflict with libc++.	12 years ago
Sergey Petrunya	8c9b2f3429	MDEV-5581: Server crashes in in JOIN::prepare on 2nd execution of PS with materialization+semijoin - The problem was that JOIN::prepare() tried to set TABLE::maybe_null for a table in join. Non-merged semi-join tables 1) are present as join's base tables on second EXECUTE, but 2) do not yet have a TABLE object. Worked around the problem by putting mixed_implicit_grouping into JOIN object, and then passing it to JTBM tables in setup_jtbm_semi_joins().	12 years ago
Sergei Golubchik	4b57720caa	use a different error for MySQL bug#11747970 - kill the query, as it was supposed to be in bug#11747970, don't fake an error. (this kill can be useful for other bugs too)	12 years ago
unknown	528df1df45	MDEV-5505: Assertion `! is_set()' fails on PREPARE SELECT with out of range in GROUP BY Fixed error processing in find_order_in_list(): if an error reported to user there is no sens to continue.	12 years ago
Sergey Petrunya	34b6f51dab	MDEV-5582: Plugin 'MEMORY' has ref_count=1 after shutdown with materialization+semijoin - Let cleanup_empty_jtbm_semi_joins() walk into semi-join nests.	12 years ago
Michael Widenius	313f18be5a	Fixed errors and warnings found by buildbot mysql-test/r/lowercase_table2.result: Updated result (The change happend because we don't try to open the table anymore as part of create table) mysql-test/suite/rpl/r/create_or_replace_mix.result: Fixed result file mysql-test/suite/rpl/r/create_or_replace_row.result: Fixed result file mysql-test/suite/rpl/r/create_or_replace_statement.result: Fixed result file mysql-test/suite/rpl/t/create_or_replace.inc: Drop open temporary table mysys/my_delete.c: Added missing newline plugin/metadata_lock_info/mysql-test/metadata_lock_info/r/user_lock.result: Fixed result (Lock names was before off by one. Was corrected by my previous patch) sql/sql_select.cc: Fixed compiler warnings by adding missing casts storage/connect/ha_connect.cc: Fixed compiler warnings storage/innobase/os/os0file.cc: Fixed compiler warnings storage/xtradb/btr/btr0btr.cc: Fixed compiler warnings storage/xtradb/handler/ha_innodb.cc: removed not used function strings/ctype-uca.c: Fixed compiler warnings support-files/compiler_warnings.supp: Added suppression for warnings that are wrong or are not serious andthat we don't plan to fix.	12 years ago
Igor Babaev	5b441013e1	Fixed bug mdev-5468. The field JOIN::select_lex->where should be updated after the call of remove_eq_conds() in the function make_join_statistics(). This matters for subselects.	12 years ago
Sergei Golubchik	ba26b71d31	MDEV-5549 Wrong row counter in found_rows() result only let filesort() count rows for SQL_CALC_ROWS if it's using priority queue	12 years ago
Sergei Golubchik	90e2240869	MDEV-5461 Assertion `length <= column->length' fails in write_block_record with functions in select list, GROUP BY, ORDER BY Old code in create_tmp_table(), that created an extra one-byte field (recinfo) before every NULL-able grouping field (Field) in the tmp table, did not actually work. Because the matching code in end_update(), that was supposed to update this byte, was using a wrong offset, updating the first byte of the Field, not a byte before it. Normally this wasn't an issue, because the Field value (written later in end_update) was overwriting this byte anyway. But in this bug the Field was Field_null, with zero length, so end_update() was overwriting the first byte of the following field. And the following field was not-nullable constant, which was stored only once in create_tmp_table and never updated later. Fixed by removing the code that didn't do any useful work anyway.	12 years ago
Sergey Petrunya	669c6620af	[Backport to 5.3] MDEV-5337: Wrong result in mariadb 5.5.32 with ORDER BY + LIMIT when index_condition_pushdown=on - in test_if_skip_sort_order(), correct the condition under which we have the code that restores the previously pushed index condition.	12 years ago
Sergey Petrunya	e1f94a6985	MDEV-5337: Wrong result in mariadb 5.5.32 with ORDER BY + LIMIT when index_condition_pushdown=on - in test_if_skip_sort_order(), correct the condition under which we have the code that restores the previously pushed index condition.	12 years ago
Michael Widenius	d15b3386db	Fix for MDEV-5531: double call procedure in one session - hard shutdown the server Main fix was to not cache derivied tables as they may be temporary tables that are deleted before the next query. This was a bit tricky as Item_field::fix_fields depended on cached_tables to be set to resolve some columns. mysql-test/r/sp-bugs.result: Added test case mysql-test/t/sp-bugs.test: Added test case sql/item.cc: Fixed fix_outer_field to handle case where found field did not have in cached_table Idea is that if cached_table is not avaliable, use from_field->table->pos_in_table_list instead sql/records.cc: Also accept INTERNAL_TMP_TABLE for memmap sql/sql_base.cc: More DBUG_PRINT Fixed that setup_natural_join_row_types() is not run twice. Original code modified context->first_name_resolution_table also for second executions. This was wrong as this could give wrong results if some joins had been optimized away between calls. sql/sql_derived.cc: Mark derived tables as internal temporary tables (INTERNAL_TMP_TABLE), not as NON_TRANSACTIONAL_TMP_TABLE. This is more correct as the tables are not visible by the end user. sql/sql_insert.cc: Reset pos_in_table_list before calling fix_fields. One of the consequences of the change of not caching all generated tables in Item_ident is that pos_in_table_list needs to be correct in calls to fix_fields. sql/sql_lex.cc: More DBUG_PRINT sql/sql_parse.cc: Don't cache derivied tables as they may be temporary tables that are deleted before the next query sql/sql_select.cc: Reset table_vector. This was required as some code checked the vector to see if temporary tables had already been created. sql/table.cc: Mark tables with field translations as cacheable (as these will not disapper between stmt executions.	12 years ago

1 2 3 4 5 ...

3880 Commits (648b957f42e0b6600da5456407a563b1218c000b)