mariadb

Tree: 6340c23933

Author	SHA1	Message	Date
Alexander Barkov	251c6e1726	MDEV-21073 Collect different grammar rules into a single chunk On order to unify the two .yy files easier, this patch collects all different rules to the end of .yy files, so the rule section looks like this: %% common rules different rules	6 years ago
Alexander Barkov	6d373e8b81	MDEV-21064 Add a new class sp_expr_lex and a new grammar rule expr_lex Adding: - new class sp_expr_lex - new grammar rule expr_lex, which includes both reset_lex() and its corresponding restore_lex() Also: - Moving a few methods from LEX to sp_expr_lex. - Moving the code from *.yy to new method sp_expr_lex methods sp_repeat_loop_finalize() and sp_if_expr(). This change makes it easier to edit the related grammar (and makes it easier to unify sql_yacc.yy and sql_yacc_ora.yy later).	6 years ago
Alexander Barkov	46f2f24ec4	MDEV-20985 Add LEX methods stmt_drop_{function\|procedure}() and stmt_alter_{function\|procedure}_start() Adding a few helper LEX methods, to unify sql_yacc.yy and sql_yacc_ora.yy easier	6 years ago
Alexander Barkov	f2cff12556	MDEV-20924 Unify grammar rules: field_type_string and sp_param_field_type_string In order to: - unify sql_yacc.yy and sql_yacc_ora.yy easier - move more functionality from the parser to Type_handler (so plugins can override the behavior) this patch: - removes rules sp_param_field_type_string and sp_param_field_type from sql_yacc_ora.yy - adds a new virtial method Type_handler::Column_definition_set_attributes()	6 years ago
Michael Widenius	716d396bb3	Remove \n from DBUG_PRINT statements	6 years ago
Monty	b62101f84b	Fixes for binary logging --read-only mode - Any temporary tables created under read-only mode will never be logged to binary log. Any usage of these tables to update normal tables, even after read-only has been disabled, will use row base logging (as the temporary table will not be on the slave). - Analyze, check and repair table will not be logged in read-only mode. Other things: - Removed not used varaibles in MYSQL_BIN_LOG::flush_and_set_pending_rows_event. - Set table_share->table_creation_was_logged for all normal tables. - THD::binlog_query() now returns -1 if statement was not logged., This is used to update table_share->table_creation_was_logged. - Don't log admin statements in opt_readonly is set. - Table's that doesn't have table_creation_was_logged will set binlog format to row logging. - Removed not needed/wrong setting of table->s->table_creation_was_logged in create_table_from_items()	6 years ago
Oleksandr Byelkin	de2186dd2f	MDEV-20074: Lost connection on update trigger Instead of checking lex->sql_command which does not corect in case of triggers mark tables for insert.	6 years ago
Rucha Deodhar	837ad9ab97	MDEV-10014 Add RETURNING to INSERT Closes #1384	6 years ago
Sergei Golubchik	57a09a72a3	cleanup st_select_lex_unit::explainable	6 years ago
Sergei Golubchik	721a9df751	cleanup: formatting comments, whitespaces	6 years ago
Oleksandr Byelkin	1ae02f0e0d	MDEV-18553: MDEV-16327 pre-requisits part 2: uniform of LIMIT/OFFSET handling Now both offset and limit are stored and do not chenged during execution (offset is decreased during processing in versions before 10.5). (Big part of this changes made by Monty)	6 years ago
Oleksandr Byelkin	eb0804ef5e	MDEV-18553: MDEV-16327 pre-requisits part 1: isolation of LIMIT/OFFSET handling	6 years ago
Alexander Barkov	d168601e83	MDEV-20734 Allow reserved keywords as user defined type names	6 years ago
Igor Babaev	b44171428a	MDEV-19956 Queries with subqueries containing UNION are not parsed Shift-Reduce conflicts prevented parsing some queries with subqueries that used set operations when the subqueries occurred in expressions or in IN predicands. The grammar rules for query expression were transformed in order to avoid these conflicts. New grammar rules employ an idea taken from MySQL 8.0.	6 years ago
Alexander Barkov	2f88bd2da2	MDEV-20634 Report disallowed subquery errors as such (instead of parse error)	6 years ago
WayneXia	a896bebfa6	MDEV-18844 Implement EXCEPT ALL and INTERSECT ALL operations	6 years ago
Gleb Shchepa	7473a71a28	Bug #29419820 : MEMORY LEAK IN MY_YYOVERFLOW() Note: this patch is for 5.6. Detected by ASAN. The patch fixes the cleanup of parser stack pointers. Reviewed-by: Guilhem Bichot <guilhem.bichot@oracle.com>	7 years ago
Igor Babaev	8540fa83bb	MDEV-19421 Basic 3-way join queries are not parsed. The parser returned a syntax error message for the queries with join expressions like this t1 JOIN t2 [LEFT \| RIGHT] JOIN t3 ON ... ON ... when the second operand of the outer JOIN operation with ON clause was another join expression with ON clause. In this expression the JOIN operator is right-associative, i.e. expression has to be parsed as the expression t1 JOIN (t2 [LEFT \| RIGHT] JOIN t3 ON ... ) ON ... Such join expressions are hard to parse because the outer JOIN is left-associative if there is no ON clause for the first outer JOIN operator. The patch implements the solution when the JOIN operator is always parsed as right-associative and builds first the right-associative tree. If it happens that there is no corresponding ON clause for this operator the tree is converted to left-associative. The idea of the solution was taken from the patch by Martin Hansson "WL#8083: Fixed the join_table rule" from MySQL-8.0 code line. As the grammar rules related to join expressions in MySQL-8.0 and MariaDB-5.5+ are quite different MariaDB solution could not borrow any code from the MySQL-8.0 solution.	6 years ago
Alexander Barkov	4dc85973b4	MDEV-19994 Add class Function_collection	6 years ago
Alexander Barkov	bf5a144e16	MDEV-19639 + MDEV-19640 fix + preparatory changes for WL#4179 This patch includes: - MDEV-19639 sql_mode=ORACLE: Wrong SHOW PROCEDURE output for sysvar:=expr - MDEV-19640 Wrong SHOW PROCEDURE output for SET GLOBAL sysvar1=expr, sysvar2=expr - Preparatory refactoring for MySQL WL#4179 Detailed change list: 1. Changing sp_create_assignment_lex() to accept the position in the exact query buffer instead of a "bool no_lookahead". This actually fixes MDEV-19639. In the previous reduction sp_create_assignment_lex() was called too late, when the parser went far the from beginning of the statement, so only a part of the statement got into sp_instr_stmt. 2. Generating "SET" or "SET GLOBAL" inside sp_create_assignment_instr() depending on the option type. This fixes MDEV-19640. In the previous reduction the code passed (through no_lookahead) the position of the word GLOBAL inside sp_create_assignment_lex(), which worked only for the left-most assignment. 3. Fixing the affected rules to use: - ident_cli instead of ident - ident_cli_set_usual_case instead of ident_set_usual_case 4. Changing the input parameter in: - LEX::set_system_variable() - LEX::call_statement_start() - LEX::set_variable() from just LEX_CSTRING to Lex_ident_sys_st for stricter data type constrol: to make sure that noone passes an ident_cli (a fragment of the original query in the client character set) instead of server-side identifier (utf8 identifier allocated on THD when needed). 5. Adding Lex_ident_sys() in places where the affected functions are called. 6. Moving all calls of sp_create_assignment_lex() to the places just before parsing set_expr_or_default. This makes the grammar clearer, because sp_create_assignment_lex() and sp_create_assignment_instr() now stay near each other, so the balance of LEX's push/pop can be read easier. This will also help to WL#4179. 7. Adding class sp_lex_set_var Moving the initialization code from sp_create_assignment_lex() to the constructor of sp_lex_set_var. This will also help to WL#4179. 8. Moving a part of the "set" grammar rule into a separate rule "set_param". This makes the grammar easier to read and removes one shift/reduce conflict.	6 years ago
Alexander Barkov	9f23f8e598	MDEV-19599 Change db_name, table_name to LEX_CSTRING in Item_ident and Send_field	7 years ago
Alexander Barkov	8164bd24a6	MDEV-19535 sql_mode=ORACLE: 'SELECT INTO @var FOR UPDATE' does not lock the table	7 years ago
Alexander Barkov	ed39181a27	MDEV-19533 Add methods make() and append_uniq() to Row_definition_list	7 years ago
Sujatha	5a2110e7cf	MDEV-19076: rpl_parallel_temptable result mismatch '-33 optimistic' Problem: ======== The test now fails with the following trace: CURRENT_TEST: rpl.rpl_parallel_temptable --- /mariadb/10.4/mysql-test/suite/rpl/r/rpl_parallel_temptable.result +++ /mariadb/10.4/mysql-test/suite/rpl/r/rpl_parallel_temptable.reject @@ -194,7 +194,6 @@ 30 conservative 31 conservative 32 optimistic -33 optimistic Analysis: ========= The part of test which fails with result content mismatch is given below. CREATE TEMPORARY TABLE t4 (a INT PRIMARY KEY) ENGINE=InnoDB; INSERT INTO t4 VALUES (32); INSERT INTO t4 VALUES (33); INSERT INTO t1 SELECT a, "optimistic" FROM t4; slave_parallel_mode=optimistic The expectation of the above test script is, INSERT FROM SELECT should read both 32, 33 and populate table 't1'. But this expectation fails occasionally. All three INSERT statements are handed over to three different slave parallel workers. Temporary tables are not safe for parallel replication. They were designed to be visible to one thread only, so have no table locking. Thus there is no protection against two conflicting transactions committing in parallel and things like that. So anything that uses temporary tables will be serialized with anything before it, when using parallel replication by using a "wait_for_prior_commit" function call. This will ensure that the each transaction is executed sequentially. But there exists a code path in which the above wait doesn't happen. Because of this at times INSERT from SELECT doesn't wait for the INSERT (33) to complete and it completes its executes and enters commit stage. Hence only row 32 is found in those cases resulting in test failure. The wait needs to be added within "open_temporary_table" call. The code looks like this within "open_temporary_table". Each thread tries to open temporary table in 3 different ways: case 1: Find a temporary table which is already in use by using find_temporary_table(tl) && wait_for_prior_commit() case 2: If above failed then try to look for temporary table which is marked for free for reuse. This internally calls "wait_for_prior_commit()" if table is found. find_and_use_tmp_table(tl, &table) case 3: If none of the above open a new table handle from table share. if (!table && (share= find_tmp_table_share(tl))) { table= open_temporary_table(share, tl->get_table_name(), true); } At present the "wait_for_prior_commit" happens only in case 1 & 2. Fix: ==== On slave add a call for "wait_for_prior_commit" for case 3. The above wait on slave will solve the issue. A more detailed fix would be to mark temporary tables as not safe for parallel execution on the master side. In order to do that, on the master side, mark the Gtid_log_event specific flag FL_TRANSACTIONAL to be false all the time. So that they are not scheduled parallely.	7 years ago
Oleksandr Byelkin	dafe41edea	Removing of dead code.	7 years ago
Vicențiu Ciorbaru	5543b75550	Update FSF Address * Update wrong zip-code	7 years ago
Igor Babaev	09aa5d3f69	MDEV-17894 Assertion `(thd->lex)->current_select' failed in MYSQLparse(), query with VALUES() A table value constructor can be used in all contexts where a select can be used. In particular an ORDER BY clause or a LIMIT clause or both of them can be attached to a table value constructor to produce a new query. Unfortunately execution of such queries was not supported. This patch fixes the problem.	7 years ago
Varun Gupta	cb9fa1a08b	MDEV-9959: A serious MariaDB server performance bug If a derived table has SELECT DISTINCT, provide index statistics for it so that the join optimizer in the upper select knows that ref access to the table will produce one row.	7 years ago
Sergei Golubchik	5057d46375	bugfix: multi-update checked privileges on views incorrectly it always required UPDATE privilege on views, not being able to detect when a views was not actually updated in multi-update. fix: instead of marking all tables as "updating" by default, only set "updating" on tables that will actually be updated by multi-update. And mark the view "updating" if any of the view's tables is.	7 years ago
Alexander Barkov	c2a2e72164	MDEV-19142 sql_mode=MSSQL: Bracket identifiers	7 years ago
Igor Babaev	d2013e7328	MDEV-18982 Partition pruning with column list causes syntax error in 10.4 A syntax error was reported for any INSERT statement with explicit partition selection it if i used a column list. Fixed by saving the parsing place before parsing the clause for explicit partition selection and restoring it when the clause has been parsed.	7 years ago
Galina Shalygina	ae15f91f22	MDEV-18769 Assertion `fixed == 1' failed in Item_cond_or::val_int This bug is caused by pushdown from HAVING into WHERE. It appears because condition that is pushed wasn't fixed. It is also discovered that condition pushdown from HAVING into WHERE is done wrong. There is no need to build clones for some conditions that can be pushed. They can be simply moved from HAVING into WHERE without cloning. build_pushable_cond_for_having_pushdown(), remove_pushed_top_conjuncts_for_having() methods are changed. It is found that there is no transformation made for fields of pushed condition. field_transformer_for_having_pushdown transformer is added. New tests are added. Some comments are changed.	7 years ago
Alexander Barkov	2d825e97df	Cleanup: removing unused type LEX_TYPE and #include	7 years ago
Eugene Kosov	53216091dd	remove dead code	8 years ago
Eugene Kosov	a523444eda	remove dead code	8 years ago
Sergey Vojtovich	3568427d11	MDEV-18450 Slaves wait shutdown The patches features an optional shutdown behavior to hold on until after all connected slaves have been sent the last binlogged event. The connected slave is one whose START SLAVE has been acknowledged and that was not stopped since that though it could be technically reconnecting in background. The solution therefore disallows killing the dump thread until is has found EOF of the latest binlog file. It is up to the shutdown requester (DBA) to set up a sufficiently large shutdown timeout value for shudown to wait patiently until lagging behind slaves have been synchronized. On the other hand if a specific slave needs exclusion from synchronization the DBA would have to stop it manually which would terminate its dump thread. `mysqladmin shutdown' is extended with a `--wait_for_all_slaves' option which translates to `SHUTDOW WAIT FOR ALL SLAVES' sql query to enable the feature on the client side. The patch also performs a small refactoring of the server shutdown around close_connections() to introduce kill thread phases which are two as of current.	7 years ago
Oleksandr Byelkin	6d68a3464e	MDEV-18701: Wrong result from query that uses INTERSECT after UNION ALL Recalculate distinct pointer if we cut chain of SELECTs	7 years ago
Alexander Barkov	5f34513c2a	MDEV-18813 PROCEDURE and anonymous blocks silently ignore FETCH GROUP NEXT ROW Part#2 (final): rewritting the code to pass the correct enum_sp_aggregate_type to the sp_head constructor, so sp_head never changes its aggregation type later on. The grammar has been simplified and defragmented. This allowed to check aggregate specific instructions right after a routine body has been scanned, by calling new LEX methods: sp_body_finalize_{procedure\|function\|trigger\|event}() Moving some C++ code from *.yy to a few new helper methods in LEX.	7 years ago
Alexander Barkov	a71d185a9a	MDEV-18813 PROCEDURE and anonymous blocks silently ignore FETCH GROUP NEXT ROW Part#1: moving opt_if_not_exists from "sf_tail" and "sp_tail" to "create".	7 years ago
Alexander Barkov	1bcb66c597	MDEV-18806 Synchronize ALTER TABLE EXCHANGE PARTITION and PURGE grammar in sql_yacc.yy and sql_yacc_ora.yy	7 years ago
Alexander Barkov	47b7ca629f	MDEV-18796 Synchronize PS grammar between sql_yacc.yy and sql_yacc_ora.yy	7 years ago
Alexander Barkov	3b47587f41	MDEV-18789 Port "MDEV-7773 Aggregate stored functions" to sql_yacc_ora.yy	7 years ago
Alexander Barkov	01d7727b76	MDEV-18779 Port sp_suid implementation from sql_yacc_ora.yy to sql_yacc.yy	7 years ago
Oleksandr Byelkin	cb11b3fbe9	MDEV-17055: Server crashes in find_order_in_list upon 2nd (3rd) execution of SP with UPDATE 1. Always drop merged_for_insert flag on cleanup (there could be errors which prevent TABLE to be assigned) 2. Make more precise cleanup of select parts which was touched	7 years ago
Alexander Barkov	0ad598a00b	A cleanup in derived table handling: removing duplicate code from st_select_lex::handle_derived() st_select_lex::handle_derived() and mysql_handle_list_of_derived() had exactly the same implementations. - Adding a new method LEX::handle_list_of_derived() instead - Removing public function mysql_handle_list_of_derived() - Reusing LEX::handle_list_of_derived() in st_select_lex::handle_derived()	7 years ago
Alexander Barkov	09d29dfc76	MDEV-18767 Port "MDEV-16294: INSTALL PLUGIN IF NOT EXISTS / UNINSTALL PLUGIN IF EXISTS" to sql_yacc_ora.yy	7 years ago
Sergei Golubchik	1e6210161d	MDEV-7597 Expiration of user passwords post-merge changes: * handle password expiration on old tables like everything else - make changes in memory, even if they cannot be done on disk * merge "debug" tests with non-debug tests, they don't use dbug anyway * only run rpl password expiration in MIXED mode, it doesn't replicate anything, so no need to repeat it thrice * restore update_user_table_password() prototype, it should not change ACL_USER, this is done in acl_user_update() * don't parse json twice in get_password_lifetime and get_password_expired * remove LEX_USER::is_changing_password, see if there was any auth instead * avoid overflow in expiration calculations * don't initialize Account_options in the constructor, it's bzero-ed later * don't create ulong sysvars - they're not portable, prefer uint or ulonglong * misc simplifications	7 years ago
Robert Bindar	90ad4dbd17	MDEV-7597 Expiration of user passwords This patch adds support for expiring user passwords. The following statements are extended: CREATE USER user@localhost PASSWORD EXPIRE [option] ALTER USER user@localhost PASSWORD EXPIRE [option] If no option is specified, the password is expired with immediate effect. If option is DEFAULT, global policy applies according to the default_password_lifetime system var (if 0, password never expires, if N, password expires every N days). If option is NEVER, the password never expires and if option is INTERVAL N DAY, the password expires every N days. The feature also supports the disconnect_on_expired_password system var and the --connect-expired-password client option. Closes #1166	7 years ago
Sergei Golubchik	81e4b9b3bb	misc cleanups	7 years ago
Nikita Malyavin	6294516a56	MDEV-16975 Application-time periods: ALTER TABLE * implicit period constraint is hidden and cannot be dropped independently * create...like and create...select support	7 years ago

... 2 3 4 5 6 ...

2868 Commits (6340c239334005c8dddf697c9af53a68b1e5a83b)