mariadb

Tree: 633417308f

Author	SHA1	Message	Date
mariadb-DebarunBanerjee	77bebe9eb0	MDEV-36226 Stall and crash when page cleaner fails to generate free pages during Async flush During regular iteration the page cleaner does flush from flush list with some flush target and then goes for generating free pages from LRU tail. When asynchronous flush is triggered i.e. when 7/8 th of the LSN margin is filled in the redo log, the flush target for flush list is set to innodb_io_capacity_max. If it could flush all, the flush bandwidth for LRU flush is currently set to zero. If the LRU tail has dirty pages, page cleaner ends up freeing no pages in one iteration. The scenario could repeat across multiple iterations till async flush target is reached. During this time the DB system is starved of free pages resulting in apparent stall and in some cases dict_sys latch fatal error. Fix: In page cleaner iteration, before LRU flush, ensure we provide enough flush limit so that freeing pages is no blocked by dirty pages in LRU tail. Log IO and flush state if double write flush wait is long. Reviewed by: Marko Mäkelä	7 months ago
Sergei Golubchik	51cc77f212	Merge branch '10.5' into 10.6	7 months ago
Sergei Golubchik	da9d575516	MDEV-35653 Assertion `commit_trx' failed in int innobase_commit(handlerton, THD, bool) cherry-pick `adc1beb868` from 11.7	7 months ago
Sergei Golubchik	402595f138	fix main.timezone test for DST	7 months ago
Marko Mäkelä	31c06951c6	MDEV-36420 Assertion failure in SET GLOBAL innodb_ft_aux_table innodb_ft_aux_table_validate(): If the table is found in InnoDB but not valid for the parameter, only invoke dict_sys.unlock() once. This fixes a regression due to MDEV-36122.	7 months ago
Marko Mäkelä	1b9d5cdb83	MDEV-35813: Valgrind test fixup log_checkpoint(): In cmake -DWITH_VALGRIND=ON builds, let us wait for all outstanding writes to complete, in order to avoid an unexpectedly large number of innodb_log_writes in the test innodb.page_cleaner.	7 months ago
Vladislav Vaintroub	da20e4d8a5	Fix PCRE2 10.45 build on Windows as an external project PCRE2 10.45 sets cmake_minimum_required to version 3.15. With that, on MSVC, compile flags for choosing C runtime (/MT, /MD, etc.) are ignored. Instead, CMAKE_MSVC_RUNTIME_LIBRARY must be passed when building an external project for consistent linkage, if it creates a static library.	7 months ago
Sergei Golubchik	bc13c8e4ae	MDEV-36078 PCRE2 10.45 breaks main.func_regexp_pcre due to change in PCRE 10.45 is correct, update test results to match. allow builds with <10.45 too (for old distros) but remove the buggy test	7 months ago
Sergei Golubchik	04771ff6b1	MDEV-28209 New mysql_upgrade message on minor-only upgrades is confusing	7 months ago
Sergei Golubchik	bca07a6f88	cleanup: mysql_upgrade.test make it strict, don't just ignore all the pesky numbers it shows, replace the current mariadb version with X.Y.Z, replace first two components of the current version with X.Y replace the first component (or first-1, if the second is 0) with X fix perl to write mysql_upgrade_info files in binary mode, otherwise mariadb-upgrade reads them incorrectly on Windows.	7 months ago
Sergei Golubchik	1cc138958e	MDEV-35727 main.mysql-interactive fails in buildbot on debian fix failing main.mysql-interactive * increase socat EOF timeout from 0.5s to 10s * add an explicit exit to not wait 10s (or even 0.5s - the test now finishes in 0.15s) * enable it for libedit	7 months ago
Sergei Golubchik	6aa860be27	MDEV-36268 mariadb-dump used wrong quoting character use ' not " and use quote_for_equal()	7 months ago
Sergei Golubchik	992d85025c	cmake CMP0177 policy, no dot in the install destination path	8 months ago
Marko Mäkelä	191209d8ab	Merge 10.5 into 10.6	7 months ago
Marko Mäkelä	6066e5d13c	MDEV-36122: Work around missing MDL in purge prepare_inplace_alter_table_dict(): If an unexpected reference to the table exists, wait for the purge subsystem to release its table handle, similar to how we would do in case FULLTEXT INDEX existed. This function is supposed to be protected by MDL_EXCLUSIVE on the table name. If purge is going to access the table again later during is ALTER TABLE operation, it will have access to an MDL compatible name for it and therefore should conflict with any MDL_EXCLUSIVE that would cover ha_innobase::commit_inplace_alter_table(commit=true). This change should prevent race conditions where purge had initially looked up a table for which row-level undo log records had been written by ALTER IGNORE TABLE, and purge did not finish before a subsequent ALTER TABLE is trying to rebuild the table. trx_purge_attach_undo_recs(), purge_sys_t::batch_cleanup(): Clear purge_sys.m_active only after all table handles have been released. ha_innobase::truncate(): Before locking the data dictionary, ensure that the purge subsystem is not holding a reference to the table due to insufficient metadata locking related to an earlier ALTER IGNORE TABLE operation. Reviewed by: Debarun Banerjee	7 months ago
Marko Mäkelä	67caeca284	MDEV-36122: Protect table references with a lock dict_table_open_on_id(): Simplify the logic. dict_stats: A helper for acquiring MDL and opening the tables mysql.innodb_table_stats and mysql.innodb_index_stats. innodb_ft_aux_table_validate(): Contiguously hold dict_sys.latch while accessing the table that we open with dict_table_open_on_name(). lock_table_children(): Do not hold a table reference while invoking dict_acquire_mdl_shared<false>(), which may temporarily release and reacquire the shared dict_sys.latch that we are holding. With these changes, no caller of dict_acquire_mdl_shared<false> should be holding a table reference. All remaining calls to dict_table_open_on_name(dict_locked=false) except the one in fts_lock_table() and possibly in the DDL recovery predicate innodb_check_version() should be protected by MDL, but there currently is no assertion that would enforce this. Reviewed by: Debarun Banerjee	7 months ago
Marko Mäkelä	337bf8ac4b	MDEV-36122 Assertion ctx0->old_table->get_ref_count() == 1 trx_purge_close_tables(): Before releasing any metadata locks (MDL), release all table references, in case an ALTER TABLE…ALGORITHM=COPY operation has confused our logic. trx_purge_table_acquire(), trx_purge_table_open(): Do not acquire any table reference before successfully acquiring a necessary metadata lock. In this way, if purge is waiting for MDL, a concurrent ha_innobase::commit_inplace_alter_table(commit=true) that is holding a conflicting MDL_EXCLUSIVE will only observe its own reference on the table that it may need to replace. dict_acquire_mdl_shared<false>(): Unless we hold an MDL or one is not needed, do not hold a table reference when releasing dict_sys.latch. After loading a table into the dictionary cache, we will look up the table again, because the table could be evicted or dropped while we were not holding any dict_sys.latch. Reviewed by: Debarun Banerjee	7 months ago
Thirunarayanan Balathandayuthapani	1f4a901576	MDEV-36281 DML aborts during online virtual index Reason: ======= - InnoDB DML commit aborts the server when InnoDB does online virtual index. During online DDL, concurrent DML commit operation does read the undo log record and their related current version of the clustered index record. Based on the operation, InnoDB do build the old tuple and new tuple for the table. If the concurrent online index can be affected by the operation, InnoDB does build the entry for the index and log the operation. Problematic case is update operation, InnoDB does build the update vector. But while building the old row, InnoDB fails to fill the non-affected virtual column. This lead to server abort while build the entry for index. Fix: === - First, fill the virtual column entries for the new row. Duplicate the old row based on new row and change only the affected fields in old row based on the update vector.	7 months ago
Thirunarayanan Balathandayuthapani	a390aaaf23	MDEV-36180 Doublewrite recovery of innodb_checksum_algorithm=full_crc32 page_compressed pages does not work - InnoDB fails to recover the full crc32 page_compressed page from doublewrite buffer. The reason is that buf_dblwr_t::recover() fails to identify the space id from the page because the page has compressed from FIL_PAGE_FILE_FLUSH_LSN_OR_KEY_VERSION bytes. Fix: === recv_dblwr_t::find_deferred_page(): Find the page which has the same page number and try to decompress/decrypt the page based on the tablespace metadata. After the decompression/decryption, compare the space id and write the recovered page back to the file. buf_page_t::read_complete(): Page read from disk is corrupted then try to read the page from deferred pages in doublewrite buffer.	7 months ago
Marko Mäkelä	19c4e1abe4	MDEV-24035 fixup: GCC 4.8.5 CMAKE_BUILD_TYPE=Debug	7 months ago
Daniel Black	85ecb80fa3	MDEV-36229: Remove CAP_DAC_OVERRIDE CAP_AUDIT_WRITE from AmbientCapabilities In resolving MDEV-33301 (`76a27155b4`) we moved all the capabilities from CapabilityBoundingSet to AmbientCapabilities where only add/moving CAP_IPC_LOCK was intended. The effect of this is the defaulting running MariaDB HAS the capabiltiy CAP_DAC_OVERRIDE CAP_AUDIT_WRITE allowing it to access any file, even while running as a non-root user. Resolve this by making CAP_IPC_LOCK apply to AmbientCapabilities and leave the remaining CAP_DAC_OVERRIDE CAP_AUDIT_WRITE to CapabilityBoundingSet for the use by auth_pam_tool.	8 months ago
Thirunarayanan Balathandayuthapani	2469963f05	MDEV-36270 mariabackup.incremental_compressed fails in 10.11+ - During prepare of incremental backup, mariabackup does create new file in target directory with default file size of 4 * innodb_page_size. While applying .delta file to corresponding data file, it encounters the FSP_SIZE modification on page0 and tries to extend the file to the size which is 4 in our case. Since the table is in compressed row format, page_size for the table is 8k. This lead to shrinking of tablespace file from 65536 to 32768. This issue happens only in windows because os_file_set_size() doesn't check for the current size and shrinks the file. Solution: ======== xtrabackup_apply_delta(): Check for the current size before doing setting size for the file.	7 months ago
Marko Mäkelä	d84ceb586a	MDEV-36378 Recognize innodb_purge_rseg_truncate_frequency In commit `bda40ccb85` (MDEV-34803) there was a spelling mistake that somehow causes the deprecated parameter innodb_purge_rseg_truncate_frequency to be rejected at server startup.	7 months ago
Daniel Black	3d54cd6cf5	update C/C	7 months ago
Jan Lindström	1277f9b451	MDEV-36372: Compilation is broken with the PLUGIN_PARTITION=NO Fixed a compilation error caused by MDEV-27861 that occurs when building with cmake -DPLUGIN_PARTITION=NO, because the default_part_plugin variable is only visible when WITH_PARTITION_STORAGE_ENGINE is defined. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	7 months ago
Brad Smith	05be1865a9	Fix building with Clang and GCC on RISC-V Clang does not have the builtin __builtin_riscv_pause().	8 months ago
Thirunarayanan Balathandayuthapani	f1deebbb0b	MDEV-35420 Server aborts while deleting the record in spatial index - This issue caused by commit a032f14b342c782b82dfcd9235805bee446e6fe8(MDEV-33559). In MDEV-33559, matched_rec::block was changed to pointer and assinged with the help of buf_block_alloc(). But patch fails to check for the block can be nullptr in rtr_check_discard_page(). rtr_cur_search_with_match(): Acquire rtr_match_mutex before creating shadow block for the matched records rtr_pcur_move_to_next(): Copy the shadow block to page cursor block under rtr_match_mutex	7 months ago
Dmitry Shulga	56bc6901d6	MDEV-34501: SIGSEGV in pfs_start_mutex_wait_v1, __strlen_avx2, or __strlen_evex from safe_mutex_lock on CREATE DEFINER when using skip-grant-tables Attempt to create a procedure with the DEFINER clause resulted in abnormal server termination in case the server run with the option --skip-grant-tables=1. The reason of abnormal termination is that on handling of the DEFINER clause, not initialized data members of acl_cache is accessed, that led to server crash. Behaviour of the server for considered use case must be the same as for embedded server. Than means, if a security subsytem wasn't initialized (server is started with the option --skip-grant-tables=1) return success from get_current_user() without further access to the acl_cache that obviously not initialized. Additionlly, AUTHID::is_role was modified to handle the case when a host part of the user name isn't provided. Treat this case as if the empty host name is provided.	7 months ago
Aleksey Midenkov	64ea539f76	MDEV-36208 dbug_print_table_row is broken: prints empty rows in debugger	7 months ago
Alexander Barkov	2ae721f2ad	MDEV-36179 Assertion `0' failed in virtual bool Type_handler_row::Item_save_in_value(THD, Item, st_value*) const sp_head::execute_procedure() and sp_head::execute_function() did not check that Item_param could be passed as an actual parameter to a ROW type formal parameter of a stored routine. Example: CREATE PROCEDURE p0(OUT a ROW(a INT,b INT)) ...; PREPARE s0 'CALL p0(?)'; EXECUTE p0 USING @a; In case of passing a user variable as an OUT parameter it led to a crash after executing routine instructions, when copying formal OUT parameters to the bound actual parameters. Fix: Check cases when Item_param is being bound to a ROW type formal parameter. Raise an error if so. The new check is done for all parameter modes: IN, OUT, INOUT, for a consistent error message. The new check is done before executing the routine instructions.	7 months ago
Marko Mäkelä	1756b0f37d	MDEV-35813: more robust test case Let us integrate the test case with innodb.page_cleaner so that there will be less interference from log writes due to checkpoints. Also, make the test compatible with ./mtr --cursor-protocol.	7 months ago
Marko Mäkelä	0e8e0065d6	MDEV-35813 test case	7 months ago
Kristian Nielsen	d931bb8174	MDEV-36287: Server crash in SHOW SLAVE STATUS concurrent with STOP SLAVE In SHOW SLAVE STATUS, do not access members of the SQL thread's THD without holding mi->run_lock. Otherwise the THD can go away in case of concurrent STOP SLAVE, leading to invalid memory references and server crash. Reviewed-by: Monty <monty@mariadb.org> Reviewed-by: Brandon Nesterenko <brandon.nesterenko@mariadb.com> Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	7 months ago
Kristian Nielsen	acaf07daed	Add --source include/long_test.inc to some tests This will make mysql-test-run.pl try to schedule these long-running (> 60 seconds) tests early in --parallel runs, which helps avoid that the testsuite gets stuck with a few long-running tests at the end while most other test workers are idle. This speed up mtr --parallel=96 with 25 seconds for me. Reviewed-by: Brandon Nesterenko <brandon.nesterenko@mariadb.com> Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	7 months ago
Kristian Nielsen	b6b6bb8d36	Fix sporadic failures of rpl.rpl_gtid_crash - Suppress a couple errors the slave can get as the master crashes. - The mysql-test-run occasionally takes 120 seconds between crashing the master and starting it back up for some (unknown) reason. For now, work-around that by letting the slave try for 500 seconds to connect to master before giving up instead of only 100 seconds. Reviewed-by: Brandon Nesterenko <brandon.nesterenko@mariadb.com> Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	8 months ago
Marko Mäkelä	c3c5cd9377	MDEV-35813 Unnecessary InnoDB log writes in INSERT…SELECT ha_innobase::extra(): Conditionally avoid a log write that had been added in commit `e5b9dc1536` (MDEV-25910) because it may be invoked as part of select_insert::prepare_eof() and not only during DDL operations. Reviewed by: Sergei Golubchik	7 months ago
Kristian Nielsen	04e114aec0	Fix sporadic failure of rpl.parallel_backup_xa_debug The test case set debug_sync=RESET without waiting for the server thread to receive the prior signal. This can cause the signal to be lost, the thread to not wake up, and thus the test to time out. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	7 months ago
Kristian Nielsen	6810cdae1b	Add --source include/long_test.inc to a few long-running tests Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	7 months ago
Kristian Nielsen	2641409731	Fix redundant ER_PRIOR_COMMIT_FAILED in parallel replication wait_for_prior_commit() can be called multiple times per event group, only do my_error() the first time the call fails. Remove redundant set_overwrite_status() calls. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org> Reviewed-by: Monty <monty@mariadb.org>	8 months ago
Monty	eef94c9d46	MDEV-36248 Connect crashes server because of duplicate 'free()' in GetUser If connect engineis not able to allocate connect_work_space memory for GetUser() it will call free() twice with the same value (g). g was freed first in user_connect::user_init() which calls PlugExit() on errors and then again in ~user_connect() which also calls PlugExit(). Fixed by setting g to 0 in user_init() after calling PlugExit() This code was tested 'by hand' by setting connect.work_space=600G Other things: - Removed some very old not relevant comments in touched code - Added comments to clarify how some memory was freed - Fixed indentation in changed functions.	7 months ago
Monty	64a1458847	Ensure that ER_CONNECTION_KILLED error message is not lost my_real_read() detects if the connection was killed and sets error to ER_CONNECTION_KILLED. However net_real_write() overrides the error with ER_NET_READ_INTERRUPTED or ER_NET_READ_ERROR when it tries to send the 'Connection was killed' to the user on a closed connection. Fixed by not overwriting the original error code if the connection was shutdown. Rewiewed-by: Kristian Nielsen <knielsen@knielsen-hq.org>	8 months ago
Monty	b12e8d9095	MENT-2235 Aria engine: log initialization failed Some thing causes the aria_log_control file to be larger than the expected 52 bytes. The control file has the correct information but somehow it is filled up with ox00 bytes up to 512 bytes. This could have happened in case of a file system crash that enlarged the file to the sector boundary. Fixed that aria will ignore bytes outside of it's expected Other things: - Fixed wrong DBUG_ASSERT() in my_malloc_size_cb_func() that could cause crashes in debug binaries during Aria recovery.	8 months ago
Monty	1331c73243	Moved server_threads.erase(thd) to end of handle_slave_sql() The effect is that 'show processlist' will show the Slave SQL thread until the thread ends. This may help finding cases where the Slave SQL thread could hang for some time during the cleanup part. The Slave SQL thread will have the state "Slave SQL thread ending' during this stage. Reviewed-by: Kristian Nielsen <knielsen@knielsen-hq.org>	8 months ago
Monty	cc4d9200c4	MDEV-33813 ERROR 1021 (HY000): Disk full (./org/test1.MAI); waiting for someone to free some space... (errno: 28 "No space left on device") The problem with MariaDB waiting was fixed earlier. However the server still gives the old error,in case of disk full, that includes "waiting for someone to free some space" even if there is now wait. This commit changes the error message for the non waiting case to: Disk got full writing 'db.table' (Errcode: 28 "No space left on device") Disk got full writing 'test.t1' (Errcode: 28 "No space left on device")Disk got full writing 'test.t1' (Errcode: 28 "No space left on device")Disk got full writing 'test.t1' (Errcode: 28 "No space left on device")	8 months ago
Akshat Nehra	868bc463c0	MDEV-4151 Mixed MySQL/MariaDB references in RPM upgrade error message Update pre-install script to fix package detection and standardize MariaDB/MySQL terminology in messages for improved upgrade reliability and reduced user confusion. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.	9 months ago
Julius Goryavsky	15139c88a8	Merge branch '10.5' into '10.6'	8 months ago
Julius Goryavsky	3a4c0295ae	galera: synchronization between branches and editions	8 months ago
Oleksandr Byelkin	7544fd4cae	fix problem of reallocated string	8 months ago
Julius Goryavsky	3deac2ea77	galera_inject_bf_log_wait mtr test: more stable test Added explicit checkpoint wait instead of implicit assumption that statement sent via --send will already be executed when lock-contesting statement is started in another session.	8 months ago
Daniel Black	e95a8f84de	MDEV-36156: MSAN Compile and Link flags needed for compile/run checks When MSAN adds the -fsantize=memory this significantly affects compile and link tests. Whether this is a compile/run/or looking for a symbol in a library these cmake tests require the same flags be set. Ideally the minimum invocation of cmake to create a MSAN build as investigated in MDBF-793 should be: -DWITH_MSAN=ON \ -DCMAKE_{EXE,MODULE}_LINKER_FLAGS="-L${MSAN_LIBDIR} -Wl,-rpath=${MSAN_LIBDIR}" On the assumption that the compiler supports msan and the instrumented libraries are in MSAN_LIBDIR (maybe later can be made a cmake option). Without cmake policy below, the checking of everything from libc++ to libfmt will not have the supplied linker flags or the compile options that WITH_MSAN=ON invokes. Many try_compile and CMake functions that wrapped this and headers failed to be recognised due to missing msan symbols when linking. Also without the -L path, they where applying a link test to the default path libraries rather than the MSAN instrumented ones. The CMake policy enabled is CMP0056, added CMake 3.2, applies CMAKE_EXE_LINKER_FLAGS to try_compile. With this change the MY_CHECK_AND_SET_COMPILER_FLAG remove explict build types resulting in just CMAKE_{C,CXX}_FLAGS being set rather than CMAKE_{C,CXX}_FLAGS_{DEBUG,RELWITHDEBINFO}. These are needed for the default CMP0066 policy to be correctly applied and the msan flags of -fsanitizer=memory are applied to all compile checks. Likewise with MY_CHECK_AND_SET_LINKER_FLAG for CMAKE_{EXE,MODULE,SHARED}_LINKER_FLAGS for those check that involve full linking and CHECK_CXX_SOURCE_RUNS for example.	8 months ago

... 3 4 5 6 7 ...

199566 Commits (633417308f163141a822398fcf8e7f281bcda38b) All Branches Search

199566 Commits (633417308f163141a822398fcf8e7f281bcda38b)

All Branches