mariadb

Tree: 627707e2f8

Author	SHA1	Message	Date
Magne Mahre	ebd24626ca	Remove configuration preprocessor symbols 'THREAD' and 'THREAD_SAFE_CLIENT'. As of MySQL 5.5, we no longer support non-threaded builds. This patch removes all references to the obsolete THREAD and THREAD_SAFE_CLIENT preprocessor symbols. These were used to distinguish between threaded and non-threaded builds.	15 years ago
Davi Arnaut	e81506971f	WL#5498: Remove dead and unused source code Remove workarounds for ancient systems.	16 years ago
Davi Arnaut	9fd9857e0b	WL#5498: Remove dead and unused source code Remove code that has been disabled for a long time.	16 years ago
Davi Arnaut	0b83096be5	Bug#48327: Some crashes specific to FreeBSD ("embedded") Bug#47139: Test "merge" crashes in "embedded" run Backport patch for Bug#47139	16 years ago
Davi Arnaut	a10ae35328	Bug#34043: Server loops excessively in _checkchunk() when safemalloc is enabled Essentially, the problem is that safemalloc is excruciatingly slow as it checks all allocated blocks for overrun at each memory management primitive, yielding a almost exponential slowdown for the memory management functions (malloc, realloc, free). The overrun check basically consists of verifying some bytes of a block for certain magic keys, which catches some simple forms of overrun. Another minor problem is violation of aliasing rules and that its own internal list of blocks is prone to corruption. Another issue with safemalloc is rather the maintenance cost as the tool has a significant impact on the server code. Given the magnitude of memory debuggers available nowadays, especially those that are provided with the platform malloc implementation, maintenance of a in-house and largely obsolete memory debugger becomes a burden that is not worth the effort due to its slowness and lack of support for detecting more common forms of heap corruption. Since there are third-party tools that can provide the same functionality at a lower or comparable performance cost, the solution is to simply remove safemalloc. Third-party tools can provide the same functionality at a lower or comparable performance cost. The removal of safemalloc also allows a simplification of the malloc wrappers, removing quite a bit of kludge: redefinition of my_malloc, my_free and the removal of the unused second argument of my_free. Since free() always check whether the supplied pointer is null, redudant checks are also removed. Also, this patch adds unit testing for my_malloc and moves my_realloc implementation into the same file as the other memory allocation primitives.	16 years ago
Sergey Vojtovich	356d075418	BUG#51868 - crash with myisam_use_mmap and partitioned myisam tables Queries following TRUNCATE of partitioned MyISAM table may crash server if myisam_use_mmap is true. Internally this is MyISAM bug, but limited to partitioned tables, because MyISAM doesn't use ::delete_all_rows() method for TRUNCATE, but goes via table recreate instead. MyISAM didn't properly fall back to non-mmaped I/O after mmap() failure. Was not repeatable on linux before, likely because (quote from man mmap): SUSv3 specifies that mmap() should fail if length is 0. However, in kernels before 2.6.12, mmap() succeeded in this case: no mapping was created and the call returned addr. Since kernel 2.6.12, mmap() fails with the error EINVAL for this case.	16 years ago
Sergey Vojtovich	55a3e3a0b0	BUG#49628 - corrupt table after legal SQL, LONGTEXT column Bulk REPLACE or bulk INSERT ... ON DUPLICATE KEY UPDATE may break dynamic record MyISAM table. The problem is limited to bulk REPLACE and INSERT ... ON DUPLICATE KEY UPDATE, because only these operations may be done via UPDATE internally and may request write cache. When flushing write cache, MyISAM may write remaining cached data at wrong position. Fixed by requesting write cache to seek to a correct position.	16 years ago
Marc Alff	57fd11788e	WL#2360 Performance schema Part II, engines instrumentation	16 years ago
Konstantin Osipov	4cff617c25	Backport of: ---------------------------------------------------------------------- ChangeSet@1.2571, 2008-04-08 12:30:06+02:00, vvaintroub@wva. +122 -0 Bug#32082 : definition of VOID in my_global.h conflicts with Windows SDK headers VOID macro is now removed. Its usage is replaced with void cast. In some cases, where cast does not make much sense (pthread_*, printf, hash_delete, my_seek), cast is ommited.	16 years ago
Alexey Botchkov	643419754c	Bug #47139 Test "merge" crashes in "embedded" run In fact this crashes in normal (not embedded) run also. The problem is in the memory mapping. Handling the ha_myisammrg::extra(MMAP) the MERGE engine tries to mmap all the tables it unites. Though some can be empty and then in the mi_dynmap_file() we call the my_mmap(0). Normally this call returns MAP_FAILED, but not on FreeBSD. There it returns like a 'normal' value, and after the consequitive munmap systems gets unstable and crashes on some system call later. per-file comments: storage/myisam/mi_dynrec.c Bug #47139 Test "merge" crashes in "embedded" run don't try to mmap zero-length area, just return at once.	16 years ago
Narayanan V	9b1076b471	Bug#38848 myisam_use_mmap causes widespread myisam corruption on windows Currently the memory map is being created with a size that is greater than the size of the underlying datafile. This can cause varying behaviour, e.g. In windows the size of the datafile is increased, while on linux it remains the same. This fix removes the increment margin to the size that is used while creating the memory map.	17 years ago
guilhem@gbichot4.local	9e2b31b026	Fix for server bug experienced in Maria (wrong "Truncated incorrect <var_name> value" error even though the value was correct): a C function in my_getopt.c was taking bool* in parameter and was called from C++ sql_plugin.cc, but on some Mac OS X sizeof(bool) is 1 in C and 4 in C++, giving funny mismatches. Fixed, all other occurences of bool in C are removed, future ones are blocked by a "C-bool-catcher" in my_global.h (use my_bool).	18 years ago
istruewing@stella.local	f126800b35	Bug#33222 - myisam-table drops rows when column is added and a char-field > 128 exists CHECK TABLE (non-QUICK) and any form of repair table did wrongly rate records as corrupted under the following conditions: 1. The table has dynamic row format and 2. it has a CHAR like column > 127 bytes (but not VARCHAR) (for multi-byte character sets this could be less than 127 characters) and 3. it has records with > 127 bytes significant length in that column (a byte beyond byte position 127 must be non-space). Affected were the statements CHECK TABLE, REPAIR TABLE, OPTIMIZE TABLE, ALTER TABLE. CHECK TABLE reported and marked the table as crashed if any record was present that fulfilled condition 3. The other statements deleted these records. The problem was a signed/unsigned compare in MyISAM code. A char to uchar change became necessary after the big byte to uchar change.	18 years ago
monty@mysql.com/narttu.mysql.fi	7887babe69	Moved a lot of old bug fixes and safe cleanups from Maria 5.1 tree to 5.1 - Reserver namespace and place in frm for TABLE_CHECKSUM and PAGE_CHECKSUM create options - Added syncing of directory when creating .frm files - Portability fixes - Added missing cast that could cause bugs - Code cleanups - Made some bit functions inline - Moved things out of myisam.h to my_handler.h to make them more accessable - Renamed some myisam variables and defines to make them more globaly usable (as they are used outside of MyISAM) - Fixed bugs in error conditions - Use compiler time asserts instead of run time - Fixed indentation HA_EXTRA_PREPARE_FOR_DELETE -> HA_EXTRA_PREPARE_FOR_DROP as the old name was wrong (Added a define for old value to ensure we don't break any old code) Added HA_EXTRA_PREPARE_FOR_RENAME as a signal for rename (before we used a DROP signal which is wrong) - Initialize error messages early to get better errors when mysqld or an engine fails to start - Fix windows bug that query_performance_frequency was not initialized if registry code failed - thread_stack -> my_thread_stack_size	18 years ago
monty@mysql.com/nosik.monty.fi	e53a73e26c	Fixed a lot of compiler warnings and errors detected by Forte C++ on Solaris Faster thr_alarm() Added 'Opened_files' status variable to track calls to my_open() Don't give warnings when running mysql_install_db Added option --source-install to mysql_install_db I had to do the following renames() as used polymorphism didn't work with Forte compiler on 64 bit systems index_read() -> index_read_map() index_read_idx() -> index_read_idx_map() index_read_last() -> index_read_last_map()	19 years ago
monty@mysql.com/narttu.mysql.fi	088e2395f1	WL#3817: Simplify string / memory area types and make things more consistent (first part) The following type conversions was done: - Changed byte to uchar - Changed gptr to uchar* - Change my_string to char * - Change my_size_t to size_t - Change size_s to size_t Removed declaration of byte, gptr, my_string, my_size_t and size_s. Following function parameter changes was done: - All string functions in mysys/strings was changed to use size_t instead of uint for string lengths. - All read()/write() functions changed to use size_t (including vio). - All protocoll functions changed to use size_t instead of uint - Functions that used a pointer to a string length was changed to use size_t* - Changed malloc(), free() and related functions from using gptr to use void * as this requires fewer casts in the code and is more in line with how the standard functions work. - Added extra length argument to dirname_part() to return the length of the created string. - Changed (at least) following functions to take uchar* as argument: - db_dump() - my_net_write() - net_write_command() - net_store_data() - DBUG_DUMP() - decimal2bin() & bin2decimal() - Changed my_compress() and my_uncompress() to use size_t. Changed one argument to my_uncompress() from a pointer to a value as we only return one value (makes function easier to use). - Changed type of 'pack_data' argument to packfrm() to avoid casts. - Changed in readfrm() and writefrom(), ha_discover and handler::discover() the type for argument 'frmdata' to uchar** to avoid casts. - Changed most Field functions to use uchar* instead of char* (reduced a lot of casts). - Changed field->val_xxx(xxx, new_ptr) to take const pointers. Other changes: - Removed a lot of not needed casts - Added a few new cast required by other changes - Added some cast to my_multi_malloc() arguments for safety (as string lengths needs to be uint, not size_t). - Fixed all calls to hash-get-key functions to use size_t. (Needed to be done explicitely as this conflict was often hided by casting the function to hash_get_key). - Changed some buffers to memory regions to uchar to avoid casts. - Changed some string lengths from uint to size_t. - Changed field->ptr to be uchar* instead of char*. This allowed us to get rid of a lot of casts. - Some changes from true -> TRUE, false -> FALSE, unsigned char -> uchar - Include zlib.h in some files as we needed declaration of crc32() - Changed MY_FILE_ERROR to be (size_t) -1. - Changed many variables to hold the result of my_read() / my_write() to be size_t. This was needed to properly detect errors (which are returned as (size_t) -1). - Removed some very old VMS code - Changed packfrm()/unpackfrm() to not be depending on uint size (portability fix) - Removed windows specific code to restore cursor position as this causes slowdown on windows and we should not mix read() and pread() calls anyway as this is not thread safe. Updated function comment to reflect this. Changed function that depended on original behavior of my_pwrite() to itself restore the cursor position (one such case). - Added some missing checking of return value of malloc(). - Changed definition of MOD_PAD_CHAR_TO_FULL_LENGTH to avoid 'long' overflow. - Changed type of table_def::m_size from my_size_t to ulong to reflect that m_size is the number of elements in the array, not a string/memory length. - Moved THD::max_row_length() to table.cc (as it's not depending on THD). Inlined max_row_length_blob() into this function. - More function comments - Fixed some compiler warnings when compiled without partitions. - Removed setting of LEX_STRING() arguments in declaration (portability fix). - Some trivial indentation/variable name changes. - Some trivial code simplifications: - Replaced some calls to alloc_root + memcpy to use strmake_root()/strdup_root(). - Changed some calls from memdup() to strmake() (Safety fix) - Simpler loops in client-simple.c	19 years ago
istruewing@chilla.local	1b35f19223	Bug#25460 - High concurrency MyISAM access causes severe mysqld crash. Under high load it was possible that memory mapping was started on a table while other threads were working with the table. I fixed the start of memory mapping so that it is done at the first table open or when the requesting thread is using the table exclusively only.	19 years ago
svoj@april.(none)	afdb3faae1	after merge fix	20 years ago
vtkachenko@quadxeon.mysql.com	ab301016f2	myisamdef.h, mi_locking.c, mi_dynrec.c: Fix insert performance with mmap	20 years ago
vtkachenko@quadxeon.mysql.com	045747f23d	Many files: Added mmap support for MyISAM engine	20 years ago
brian@zim.(none)	2a7c71e309	Changes to create storage directory for storage engines.	21 years ago
serg@serg.mylan	0294339b9c	don't check record's checksum in REPAIR	21 years ago
monty@mysql.com	3fb088a075	Add 0x before pointers (to help with debugging) Add support for VARCHAR with 1 or 2 length bytes Enable VARCHAR packing in MyISAM files (previous patch didn't pack data properly) Give error if we got problems in temporary tables during a SELECT Don't use new table generated by ALTER TABLE if index generation fails Fixed wrong call by range_end() (Could cause an ASSERT in debug mode)	21 years ago
konstantin@mysql.com	f08bbd1f12	assert.h needed for my_dbug.h now is included in my_dbug.h, where it for some reason wasn't included before. A lot of files cleaned up from #include <assert.h>	22 years ago
guilhem@mysql.com	7d575447ed	A DBUG_RETURN to match a DBUG_ENTER	22 years ago
ram@gw.mysql.r18.ru	f231d9826b	just tried to find all 'skipp' and replace it with 'skip'.	22 years ago
serg@serg.mylan	4f845f4c12	two bugs in parallel repair fixed	22 years ago
monty@mysql.com	d4543818b0	Fixed table crash bug when updating row > 16M (Bug #2159 )	22 years ago
monty@narttu.mysql.fi	dfd981505a	More explicit error messages from myisamchk	22 years ago
monty@narttu.mysql.fi	a2a1e97226	Portability fixes	23 years ago
serg@serg.mylan	d09626d9d6	post-merge fixes	23 years ago
monty@narttu.mysql.fi	cd25e1691c	ixed overflow bug in MyISAM and ISAM when using packed tables with a lot of fields and blobs	23 years ago
monty@narttu.mysql.fi	8a77f97079	Add detection of in_addr_t Add pack_bits to pack_reclength for dynamic rows. This solves buffer a possible buffer overflow on update. (This will probably solve bug #563) Fix test for available file descriptors in mysqltest Fixed core dump bug in replication tests when running without transactional table support	23 years ago
monty@mashka.mysql.fi	4bde719df7	Safety fix to enable RAID in max binaries Better fix for format('nan') Fix for HAVING COUNT(DISTINCT...)	23 years ago
Sinisa@sinisa.nasamreza.org	a496daf777	A fix for a bug in MyISAM with large number of NULL columns and at least one BLOB column.	23 years ago
Sinisa@sinisa.nasamreza.org	e6a724fd83	A fix for a bug when INSERT is attempted into a table with a BLOB and many NULL columns. It could be ported back to 3.23 too ....	23 years ago
monty@butch.	a2bdf9265f	Portability fixes for Fortre C++ 5.0 (on Sun) in 32 and 64 bit modes.	23 years ago
monty@hundin.mysql.fi	c99c1fd384	Changed IF(expr, column, NULL) to take type from column Fixed some windows portability problems and removed some compiler warnings Cleaned up QUOTE() function and fixed bug in \0 and \Z handling.	24 years ago
serg@sergbook.mysql.com	43ef1198e9	MyISAM: always store alloced_rec_buff_length with the buffer itself	24 years ago
monty@mashka.mysql.fi	c702a1f8fd	Removed wrong implementation of CUBE/ROLLUP Fixed bugfix of INSERT ... SET db_name.table_name.column_name Changed locking to external-locking Fix client hangup for some invalid SQL queries.	24 years ago
serg@sergbook.mysql.com	2fe3fec4e4	parallel repair needs rec_buff local for thread !!!	24 years ago
serg@sergbook.mysql.com	3f6491e3eb	yet another generalization for rec_buff handling, MI_INFO doesn't need rec_alloc anymore	24 years ago
serg@sergbook.mysql.com	0ae810ae85	mi_fix_rec_buff_for_blob() generalized a bit	24 years ago
monty@hundin.mysql.fi	b44b485491	Ensure that share->tot_locks s updated correctly This fixes that mysamchk --sort-records works on windows.	24 years ago
monty@hundin.mysql.fi	9ca9fc2283	Fix for MyISAM records > 16M	24 years ago
monty@hundin.mysql.fi	b658662ae4	Update copyright Fixed memory leak on shutdown (Affects the embedded version & MyODBC)	24 years ago
monty@hundin.mysql.fi	4c60b41954	Portability fix Cleanup typos (like SKIPP -> SKIP)	24 years ago
monty@tramp.mysql.fi	abb7df2de1	Fixed error message when opening a not-MyISAM file. Extended MODIFY and CHANGE in ALTER TABLE to accept the AFTER keyword. Extended MyISAM to handle records > 16M.	24 years ago
monty@hundin.mysql.fi	880026ccf6	Cleaned up SSL documentation Fixes for embedded server Made key_cache more configurable Fixed that one can change key blocksize in MyISAM A lot of optimizations to make MyISAM slightly faster	24 years ago
monty@hundin.mysql.fi	0b2af6bdfd	Ensure that libmysqlclient doesn't use raid Fix problem with MyISAM and rows of length 65517-65520	25 years ago

42 Commits (627707e2f8bc40c43b7f1ac04f12dbc3f65992f2)