mariadb

Tree: 589a1235b6

Author	SHA1	Message	Date
Sergei Petrunia	86167e908f	MDEV-20611: MRR scan over partitioned InnoDB table produces "Out of memory" error Fix partitioning and DS-MRR to work together - In ha_partition::index_end(): take into account that ha_innobase (and other engines using DS-MRR) will have inited=RND when initialized for DS-MRR scan. - In ha_partition::multi_range_read_next(): if the MRR scan is using HA_MRR_NO_ASSOCIATION mode, it is not guaranteed that the partition's handler will store anything into range_info. - In DsMrr_impl::choose_mrr_impl(): ha_partition will inquire partitions about how much memory their MRR implementation needs by passing buffer_size=0. DS-MRR code didn't know about this (actually it used uint for buffer size calculation and would have an under-flow). Returning buffer_size=0 made ha_partition assume that partitions do not need MRR memory and pass the same buffer to each of them. Now, this is fixed. If DS-MRR gets buffer_size=0, it will return the amount of buffer space needed, but not more than about @@mrr_buffer_size. * Fix ha_{innobase,maria,myisam}::clone. If ha_partition uses MRR on its partitions, and partition use DS-MRR, the code will call handler->clone with TABLE (NOT partition) name as an argument. DS-MRR has no way of knowing the partition name, so the solution was to have the ::clone() function for the affected storage engine to ignore the name argument and get it elsewhere.	6 years ago
Michal Schorm	17b4f99928	Update FSF address This commit is based on the work of Michal Schorm, rebased on the earliest MariaDB version. Th command line used to generate this diff was: find ./ -type f \ -exec sed -i -e 's/Foundation, Inc., 59 Temple Place, Suite 330, Boston, /Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, /g' {} \; \ -exec sed -i -e 's/Foundation, Inc. 59 Temple Place.* Suite 330, Boston, /Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, /g' {} \; \ -exec sed -i -e 's/MA......-1307.USA/MA 02110-1335 USA/g' {} \; \ -exec sed -i -e 's/Foundation, Inc., 59 Temple/Foundation, Inc., 51 Franklin/g' {} \; \ -exec sed -i -e 's/Place, Suite 330, Boston, MA.02111-1307.USA/Street, Fifth Floor, Boston, MA 02110-1335 USA/g' {} \; \ -exec sed -i -e 's/MA.*.....-1307/MA 02110-1335/g' {} \;	7 years ago
Marko Mäkelä	2a3fe45dd2	Remove XtraDB The XtraDB storage engine was already replaced by InnoDB and disabled in MariaDB Server 10.2. Let us remove it altogether to avoid dragging dead code around. Replace some references to XtraDB with references to InnoDB. rpl_get_position_info(): Remove. Remove the mysql-test-run --suite=percona, because it only contains tests specific to XtraDB, many of which were disabled already in earlier MariaDB versions.	8 years ago
iangilfillan	f0ec34002a	Correct FSF address	9 years ago
Sergey Petrunya	9cb002b359	MDEV-6878: Use of uninitialized saved_primary_key in Mrr_ordered_index_reader::resume_read() (Backport to 5.3) (variant #2, with fixed coding style) - Make Mrr_ordered_index_reader::resume_read() restore index position only if it was saved before with Mrr_ordered_index_reader::interrupt_read().	11 years ago
Sergey Petrunya	8925b4a935	MDEV-6878: Use of uninitialized saved_primary_key in Mrr_ordered_index_reader::resume_read() - Make Mrr_ordered_index_reader::resume_read() restore index position only if it was saved before with Mrr_ordered_index_reader::interrupt_read().	11 years ago
Sergey Petrunya	422c55a240	MDEV-5037: Server crash on a JOIN on a derived table with join_cache_level > 2 - The crash was caused because the optimizer called handler->multi_range_read_info() on a derived temporary table. That table has been created, but not opened yet. Because of that, handler::table was NULL, which caused crash. Fixed by changing DS-MRR methods to use handler::table_share instead. handler::table_share is set in handler ctor, so this should be safe.	12 years ago
Michael Widenius	1d0f70c2f8	Temporary commit of merge of MariaDB 10.0-base and MySQL 5.6	13 years ago
Sergei Golubchik	5bf311e1e8	fix the include guards and add missing gplv2 headers	14 years ago
Sergey Petrunya	997445bc8e	Make EXPLAIN better at displaying MRR/BKA: - "Using MRR" is no longer shown with range access. - Instead, both range and BKA accesses will show one of the following: = "Rowid-ordered scan" = "Key-ordered scan" = "Key-ordered Rowid-ordered scan" depending on whether DS-MRR implementation will do scan keys in order, rowids in order, or both. - The patch also introduces a way for other storage engines/MRR implementations to pass information to EXPLAIN output about the properties of employed MRR scans.	15 years ago
Sergey Petrunya	e6bd643c75	MRR interface: change range_info's type from char* to range_id_t typedef. The goals are: - cleaner code - ability to change from using pointers to offsets at some point	15 years ago
Sergey Petrunya	8ef094fe4f	BUG#707925: Wrong result with join_cache_level=6 optimizer_use_mrr = force (incremental, BKA join) - The problem was that Mrr_ordered_index_reader's interrupt_read() and resume_read() would save and restore 1) index tuple 2) the rowid (as bytes returned by handler->position()). Clustered primary key columns were not saved/restored. They are not explicitly present in the index tuple (i.e. table->key_info[secondary_key].key_parts doesn't list them), but they are actually there, in particular table->field[clustered_primary_key_member].part_of_key(secondary_key) == 1. Index condition pushdown code [correctly] uses the latter as inidication that pushed index condition can refer to clustered PK members. The fix was to make interrupt_read()/resume_read() to save/restore clustered primary key members as well, so that we get correct values for them when evaluating pushed index condition. [3rd attempt: remove the debugging aids, fix comments in testcase]	15 years ago
Sergey Petrunya	9d480f6af3	BUG#670417: Diverging results in maria-5.3-mwl128-dsmrr-cpk with join buffer - Fixes for the second fix: take into account case where we don't need to save/restore the scan.	15 years ago
Sergey Petrunya	09a84dc470	BUG#670417: Diverging results in maria-5.3-mwl128-dsmrr-cpk with join buffer Switch from "Disable identical key handling optimization when IndexConditionPushdown is used" approach To an approach where we save/restore index tuple and so can use index condition pushdown.	15 years ago
Sergey Petrunya	80cbf3a1c2	Small code cleanups	15 years ago
Sergey Petrunya	c696fb6ef3	Better comments	15 years ago
Sergey Petrunya	3e633eea66	MWL#121-125 DS-MRR improvements - Address Monty's review feedback, portion 2	15 years ago
Sergey Petrunya	802db7a64b	- Fix compiler warning - Better warnings	15 years ago
Sergey Petrunya	a86599e1e4	BUG#671340: Diverging results in with mrr_sort_keys=ON\|OFF and join_cache_level=5 - Make Mrr_ordered_index_reader() save the rowid across scan interruptions Also - Fix compiler warning for setup_buffer_sizes() - Add commented key_copy/key_restore for better handling of a similar issue with index record being destroyed by scan interruption (which causes incorrect evaluation of pushed index condition later on).	15 years ago
Sergey Petrunya	1c7c67d584	MWL#121-125 DS-MRR improvements - Address Monty's review feedback, part 6: rename "handler *h" variable in all DS-MRR classes to something else.	15 years ago
Sergey Petrunya	44be131cd3	MWL#121-125 DS-MRR improvements - Address Monty's review feedback, part 5	15 years ago
Sergey Petrunya	40822c8149	Fix buildbot failure	15 years ago
Sergey Petrunya	92442fc598	Merge MWL#121-125 DS-MRR improvements - Address Monty's review feedback, part 4	15 years ago
Sergey Petrunya	a6c1d56e08	MWL#121-125 DS-MRR improvements - Address Monty's review feedback, part 1 - Fix buildbot failure	15 years ago
Sergey Petrunya	2ec43747f5	Merge MWL#121-125 DS-MRR improvements - Address Monty's review feedback, part 1	15 years ago
Sergey Petrunya	0fb342ba56	BUG#670417: Diverging results in maria-5.3-mwl128-dsmrr-cpk with join buffer, attempt 4 - Disable identical key handling optimization when IndexConditionPushdown is used	15 years ago
Sergey Petrunya	197c99427d	DS-MRR improvements - Code cleanup - Always propagate the error code we got from storage engine all the way up	15 years ago
Sergey Petrunya	c46450de72	Code cleanup	15 years ago
Sergey Petrunya	1654780f2d	Code cleanup	15 years ago
Sergey Petrunya	b76a8595c6	Re-initialization reworked	15 years ago
Sergey Petrunya	d9a8dd22b2	DS-MRR/CPK improvements: correct buffer exhaustion handling	15 years ago
Sergey Petrunya	1e82320d27	DS-MRR improvements - buildbot test failure fixes: don't try to get more records from SimpleIndexReader if we've already got EOF for it.	15 years ago
Sergey Petrunya	a88bd5cf56	DS-MRR improvements: - address the review feedback (class/var renames) - fix wrong test result (bug in buffer refill logic)	15 years ago
Sergey Petrunya	d8efc3b155	DS-MRR improvements: address review feedback for R3 version of the patch	15 years ago
Sergey Petrunya	ac8a79b944	Code cleanup	15 years ago
Sergey Petrunya	5156457506	Address review feedback - One iterator class - Switch back from state automaton into two-nested-iterators approach..	15 years ago
Sergey Petrunya	22d5323fac	DS-MRR/CPK improvements: more of addressing review feedback	15 years ago
Sergey Petrunya	61f26f0c62	DS-MRR improvements: address review feedback - change dsmrr_next_from_index() to a switch-based state automaton-like structure.	15 years ago
Sergey Petrunya	4f56acb676	Better comments, move Lifo_buffer to separate file.	15 years ago
Sergey Petrunya	3066c37718	DS-MRR improvements: review feedback - Switch from one bi-directional buffer class to two virtual inheritance-based forward and backward buffer classes.	15 years ago
Sergey Petrunya	51f9097608	More comments	15 years ago
Sergey Petrunya	2121ab1eb4	DS-MRR improvements: remove write_size/read_size, have the same size for writing and reading	15 years ago
Sergey Petrunya	189555f39a	DS-MRR improvements: more code cleanup - better comments - rename variables to better reflect their meaning	15 years ago
Sergey Petrunya	18a348503a	DS-MRR improvements: better comments, use symbolic name instead of +1/-1 constants.	15 years ago
Sergey Petrunya	499b142ad5	BUG#628785: multi_range_read.cc:430: int DsMrr_impl::dsmrr_init(): Assertion `do_sort_keys \|\| do_rowid_fetch' failed - Make Ds_MrrImpl::check_cpk_scan() follow the execution code' logic: don't do MRR scans on clustered PK when mrr_sort_keys=off.	15 years ago
Sergey Petrunya	188de43db1	- Fixed BUG#623285: Crash in quick_range_seq_next() in maria-5.3-dsmrr-cpk - Relax overly-strict assert added in previous commit - Run generic MRR testsuite for Maria engine, too.	15 years ago
Sergey Petrunya	ac3756a1d0	Debug measure: trash unused buffer space	15 years ago
Sergey Petrunya	9b04caffd4	Commit for buildbot checks	15 years ago
Sergey Petrunya	dbc63bed22	MWL#121-125: DS-MRR improvements - Address review feedback, step 1	15 years ago
Sergey Petrunya	937db4bff4	- Remove out-of-date comments - Make testcase stable	15 years ago

1 2

66 Commits (589a1235b64866c7bbe85da2a6f6bf19ee8282fe)