mariadb

Tree: 5018b998a7

Author	SHA1	Message	Date
Marko Mäkelä	84129fb1b5	After-merge fix for commit `98eb9518db` The merge only covered 10.1 up to commit `4d248974e0`. Actually merge the changes up to commit `0a534348c7`. Also, remove the unused InnoDB field trx_t::abort_type.	8 years ago
Sergey Vojtovich	0a534348c7	MDEV-14265 - RPMLint warning: shared-lib-calls-exit Eliminated last exit() call from libmysqld.	8 years ago
Thirunarayanan Balathandayuthapani	ff909acfa4	MDEV-14545 Backup fails due to MLOG_INDEX_LOAD record Problem: ======= Mariabackup exits during prepare phase if it encounters MLOG_INDEX_LOAD redo log record. MLOG_INDEX_LOAD record informs Mariabackup that the backup cannot be completed based on the redo log scan, because some information is purposely omitted due to bulk index creation in ALTER TABLE. Solution: ======== Detect the MLOG_INDEX_LOAD redo record during backup phase and exit the mariabackup with the proper error message.	8 years ago
Marko Mäkelä	54765aaa4d	MDEV-15524 Do not disable page checksums for temporary tables buf_flush_init_for_writing(): Remove the parameter skip_checksum.	8 years ago
Sergey Vojtovich	131d9a5d0c	Allocate lock_sys statically There is only one lock_sys. Allocate it statically in order to avoid dereferencing a pointer whenever accessing it. Also, align some members to their own cache line in order to avoid false sharing. lock_sys_t::create(): The deferred constructor. lock_sys_t::close(): The early destructor.	8 years ago
Vladislav Vaintroub	56e7b7eaed	Make possible to use clang on Windows (clang-cl) -DWITH_ASAN can be used as well now, on x64 Fix many clang-cl warnings.	8 years ago
Marko Mäkelä	947efe17ed	MDEV-15158 On commit, do not write to the TRX_SYS page This is based on a prototype by Thirunarayanan Balathandayuthapani <thiru@mariadb.com>. Binlog and Galera write-set replication information was written into TRX_SYS page on each commit. Instead of writing to the TRX_SYS during normal operation, InnoDB can make use of rollback segment header pages, which are already being written to during a commit. The following list of fields in rollback segment header page are added: TRX_RSEG_BINLOG_OFFSET TRX_RSEG_BINLOG_NAME (NUL-terminated; empty name = not present) TRX_RSEG_WSREP_XID_FORMAT (0=not present; 1=present) TRX_RSEG_WSREP_XID_GTRID TRX_RSEG_WSREP_XID_BQUAL TRX_RSEG_WSREP_XID_DATA trx_sys_t: Introduce the fields recovered_binlog_filename, recovered_binlog_offset, recovered_wsrep_xid. To facilitate upgrade from older mysql or mariaDB versions, we will read the information in TRX_SYS page. It will be overridden by the information that we find in rollback segment header pages. Mariabackup --prepare will read the metadata from the rollback segment header pages via trx_rseg_array_init(). It will still not read any undo log pages or recover any transactions.	8 years ago
Vladislav Vaintroub	2129eab7e2	MDEV-15071 backup does not store xtrabackup_info in the --extra-lsndir directory	8 years ago
Vladislav Vaintroub	a08121c978	MDEV-14997 mariabackup crashes with invalid --innodb-flush-method Avoid NULL pointer dereference when shutting down after invalid parameters were parsed.	8 years ago
Marko Mäkelä	00f0c039d2	MDEV-15270 Mariabackup should not try to use doublewrite buffer When Mariabackup gets a bad read of the first page of the system tablespace file, it would inappropriately try to apply the doublewrite buffer and write changes back to the data file (to the source file)! This is very wrong and must be prevented. The correct action would be to retry reading the system tablespace as well as any other files whose first page was read incorrectly. Fixing this was not attempted. xb_load_tablespaces(): Shorten a bogus message to be more relevant. The message can be displayed by --backup or --prepare. xtrabackup_backup_func(), os_file_write_func(): Add a missing space to a message. Datafile::restore_from_doublewrite(): Do not even attempt the operation in Mariabackup. recv_init_crash_recovery_spaces(): Do not attempt to restore the doublewrite buffer in Mariabackup (--prepare or --export), because all pages should have been copied correctly in --backup already, and because --backup should ignore the doublewrite buffer. SysTablespace::read_lsn_and_check_flags(): Do not attempt to initialize the doublewrite buffer in Mariabackup. innodb_make_page_dirty(): Correct the bounds check. Datafile::read_first_page(): Correct the name of the parameter.	8 years ago
Vladislav Vaintroub	6c279ad6a7	MDEV-15091 : Windows, 64bit: reenable and fix warning C4267 (conversion from 'size_t' to 'type', possible loss of data) Handle string length as size_t, consistently (almost always:)) Change function prototypes to accept size_t, where in the past ulong or uint were used. change local/member variables to size_t when appropriate. This fix excludes rocksdb, spider,spider, sphinx and connect for now.	8 years ago
Marko Mäkelä	d7d910d08b	Fix a warning about possibly unused variable xtrabackup_init_temp_log(): Remove a redundant variable and limit scope.	8 years ago
Daniel Black	7eb084fe2c	MariaBackup: gcc7 - snprintf output overflow warning extra/mariabackup/xtrabackup.cc: In function ‘ulint xb_process_datadir(const char, const char, handle_datadir_entry_func_t)’: extra/mariabackup/xtrabackup.cc:4534:1: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=] xb_process_datadir( ^~~~~~~~~~~~~~~~~~ mariabackup/xtrabackup.cc:4607:11: note: ‘snprintf’ output 2 or more bytes (assuming 4001) into a destination of size 4000 snprintf(dbpath, sizeof(dbpath), "%s/%s", path, dbinfo.name); ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~	8 years ago
Marko Mäkelä	8d1d38f953	Simplify access to the TRX_SYS page trx_sysf_t: Remove. trx_sysf_get(): Return the TRX_SYS page, not a pointer within it. trx_sysf_rseg_get_space(), trx_sysf_rseg_get_page_no(): Remove a parameter, and merge the declaration and definition. Take the TRX_SYS page as a parameter. TRX_SYS_N_RSEGS: Correct the comment. trx_sysf_rseg_find_free(), trx_sys_update_mysql_binlog_offset(), trx_sys_update_wsrep_checkpoint(): Take the TRX_SYS page as a parameter. trx_rseg_header_create(): Add a parameter for the TRX_SYS page. trx_sysf_rseg_set_space(), trx_sysf_rseg_set_page_no(): Remove; merge to the only caller, trx_rseg_header_create().	8 years ago
Vladislav Vaintroub	7cdf759c86	MDEV-14485 Server hangs on startup in THD::init Solve 3 way deadlock between plugin_initialiaze(), THD::init() and mysql_sys_var_char(). The deadlock exists because of the lock order inversion between LOCK_global_system_variables mutex and LOCK_system_variables_hash read-write lock- In this case, it is enough to change LOCK_system_variables_hash to prefer reads to fix the deadlock, i.e change it to mysql_prlock_t	8 years ago
Daniel Black	12f900228f	mariadbbackup: use defaults-group-suffix even if no --defaults-file Signed-off-by: Daniel Black <daniel@linux.vnet.ibm.com>	8 years ago
Vladislav Vaintroub	87db5eb813	MDEV-13825 mariabackup --lock-ddl-per-table does not properly lock FULLTEXT auxiliary tables Change the logic to take mdl lock on all tables before tablespaces are copied, rather than lock every single tablespace just before it is copied.	8 years ago
Vladislav Vaintroub	30b1fbda28	MDEV-14746 : read [mariabackup] section from config file.	8 years ago
Vladislav Vaintroub	054051bb76	MDEV-14150 - backup should fail early if rsync is missing check availability of rsync utility early , when starting backup with --rsync. Fail if it is not there.	8 years ago
Vladislav Vaintroub	e30cdb68e5	mariabackup : improve help text	8 years ago
Marko Mäkelä	2281fcf38a	Follow-up fix to MDEV-14952 for Mariabackup innodb_init_param(): Initialize btr_ahi_parts=1 for Mariabackup. btr_search_enabled: Let the adaptive hash index be disabled in Mariabackup. This would potentially only matter during --export, and --export performs a table scan, not many index lookups.	8 years ago
Marko Mäkelä	16d308e21d	MDEV-14874 innodb_encrypt_log corrupts the log when the LSN crosses 32-bit boundary This bug affects both writing and reading encrypted redo log in MariaDB 10.1, starting from version 10.1.3 which added support for innodb_encrypt_log. That is, InnoDB crash recovery and Mariabackup will sometimes fail when innodb_encrypt_log is used. MariaDB 10.2 or Mariabackup 10.2 or later versions are not affected. log_block_get_start_lsn(): Remove. This function would cause trouble if a log segment that is being read is crossing a 32-bit boundary of the LSN, because this function does not allow the most significant 32 bits of the LSN to change. log_blocks_crypt(), log_encrypt_before_write(), log_decrypt_after_read(): Add the parameter "lsn" for the start LSN of the block. log_blocks_encrypt(): Remove (unused function).	8 years ago
Monty	83a8b0e9d3	Fixed compiler warning	8 years ago
Sergey Vojtovich	2cd3169113	MDEV-14265 - RPMLint warning: shared-lib-calls-exit find_type_or_exit() client helper did exit(1) on error, exit(1) moved to clients. mysql_read_default_options() did exit(1) on error, error is passed through and handled now. my_str_malloc_default() did exit(1) on error, replaced my_str_ allocator functions with normal my_malloc()/my_realloc()/my_free(). sql_connect.cc did many exit(1) on hash initialisation failure. Removed error check since my_hash_init() never fails. my_malloc() did exit(1) on error. Replaced with abort(). my_load_defaults() did exit(1) on error, replaced with return 2. my_load_defaults() still does exit(0) when invoked with --print-defaults.	8 years ago
Vladislav Vaintroub	f32063c513	MDEV-13620 - improve help message for 'plugin-dir' and 'plugin-load' options.	8 years ago
Marko Mäkelä	a9a4089175	Plug a small memory leak in mariabackup --backup	8 years ago
Monty	60df17e95a	Remove compiler warnings	8 years ago
Vladislav Vaintroub	f59a1826f8	MDEV-14536 : during backup, retry read of log blocks, if there is (possibly intermittent) checksum mismatch.	8 years ago
Vladislav Vaintroub	bf6d11c4d6	MDEV-14536 : In mariabackup, reread redo log blocks , if checksum mismatch is detected. The checksum mismatch can be due to partial write, thus retry the read	8 years ago
Marko Mäkelä	23d2dae5f0	Fix some integer type mismatch warnings	8 years ago
Vladislav Vaintroub	414d3a3e17	Fix warning.	8 years ago
Marko Mäkelä	6979d20426	MDEV-14499 Mariabackup 10.2 fails to back up a multi-file InnoDB system tablespace When Mariabackup is invoked on an instance that uses a multi-file InnoDB system tablespace, it may fail to other files of the system tablespace than the first one. This was revealed by the MDEV-14447 test case. The offending code is assuming that the first page of each data file is page 0. But, in multi-file system tablespaces that is not the case. xb_fil_cur_open(): Instead of re-reading the first page of the file, rely on the fil_space_t metadata that already exists in memory. xb_get_space_flags(): Remove.	8 years ago
Vladislav Vaintroub	316f0d8fe3	MDEV-14447 mariabackup incremental incorrectly extends system tablespace for multi-file innodb_data_file_path. Use fil_extend_space_to_desired_size() to correctly extend system tablespace. Make sure to get tablespace size from the first tablespace part.	8 years ago
Marko Mäkelä	c19ef508b8	InnoDB: Remove ut_snprintf() and the use of my_snprintf(); use snprintf()	8 years ago
Marko Mäkelä	909cdafd35	MDEV-13496 Use "mariabackup" rather than "xtrabackup" in console output Replace the remaining "xtrabackup:" references in the code.	8 years ago
Vladislav Vaintroub	72407e544e	MDEV-13496 Use "mariabackup" rather than "xtrabackup" in console output	8 years ago
Vladislav Vaintroub	125ce6f82f	MDEV-14102 restore --remove-original options for mariabackup	8 years ago
Sergei Golubchik	2aa51f528f	Various compier warnings gcc 5.4 and 7.1, Debug and Release builds	8 years ago
Marko Mäkelä	9ee840cd0a	mariabackup: Properly call os_thread_exit() with detach=true There is no call to os_thread_join(), so we should detach the thread handles in order to avoid any resource leaks.	8 years ago
Marko Mäkelä	1b478a7aba	MDEV-13311 Presence of old logs in 10.2.7 will corrupt restored instance (change in behavior) Mariabackup 10.2.7 would delete the redo log files after a successful --prepare operation. If the user is manually copying the prepared files instead of using the --copy-back option, it could happen that some old redo log file would be preserved in the restored location. These old redo log files could cause corruption of the restored data files when the server is started up. We prevent this scenario by creating a "poisoned" redo log file ib_logfile0 at the end of the --prepare step. The poisoning consists of simply truncating the file to an empty file. InnoDB will refuse to start up on an empty redo log file. copy_back(): Delete all redo log files in the target if the source file ib_logfile0 is empty. (Previously we did this if the source file is missing.) SRV_OPERATION_RESTORE_EXPORT: A new variant of SRV_OPERATION_RESTORE when the --export option is specified. In this mode, we will keep deleting all redo log files, instead of truncating the first one. delete_log_files(): Add a parameter for the first file to delete, to be passed as 0 or 1. innobase_start_or_create_for_mysql(): In mariabackup --prepare, tolerate an empty ib_logfile0 file. Otherwise, require the first redo log file to be longer than 4 blocks (2048 bytes). Unless --export was specified, truncate the first log file at the end of --prepare.	8 years ago
Vladislav Vaintroub	fe18e6b064	MDEV-13822 mariabackup incremental prepare incorrectly sets file size. MDEV-13310 Preparing an incremental backup twice can corrupt data	8 years ago
Vladislav Vaintroub	b731a5bcf2	Innodb : Refactor os_file_set_size() to be compatible 10.1 The last parameter to this function is now,"bool is_sparse", like in 10.1 rather than the unused/useless "bool is_readonly", merged from MySQL 5.7 Like in 10.1, this function now supports sparse files, and efficient platform specific mechanisms for file extension os_file_set_size() is now consistenly used in all places where innodb files are extended.	8 years ago
Vladislav Vaintroub	bb3f4fbb59	MDEV-13310 Preparing an incremental backup twice can corrupt data Remove .delta file after it was successfully applied	8 years ago
Vladislav Vaintroub	0f8295d7d5	MDEV-13822 mariabackup incremental prepare incorrectly sets file size. Fix incremental prepare to change file size while applying delta file, if delta file contains page 0 with the new size.	8 years ago
Vladislav Vaintroub	eba44874ca	MDEV-13844 : Fix Windows warnings. Fix DBUG_PRINT. - Fix win64 pointer truncation warnings (usually coming from misusing 0x%lx and long cast in DBUG) - Also fix printf-format warnings Make the above mentioned warnings fatal. - fix pthread_join on Windows to set return value.	8 years ago
Vladislav Vaintroub	d1253e19a1	Fix compilation in mariabackup Compilation got confused about 2 wsrep.h headers in include path Rename backup's wsrep.h to backup_wsrep.h to fixO	8 years ago
Vladislav Vaintroub	ad17e8e518	MDEV-13821 : mariabackup sometimes could lose ib_logf(FATAL) messages, The messages are getting lost because they are written with fprintf() but without fflush(), so abort() would lose buffered text. Applied fix from 10.2, which makes in_logf() use sql_print_information(), which in turn does proper flush after each message	8 years ago
Vladislav Vaintroub	74f677fcc2	MDEV-13802 mariabackup --lock-ddl-per-table fails when table names contain backticks use ut_get_name() for formatting database/table names.	8 years ago
Vladislav Vaintroub	bb7ab40521	mariabackup : Fix enumerate_ibd_files() to include .isl	8 years ago
Marko Mäkelä	66a09bd6ab	MDEV-13318 Crash recovery failure after the server is killed during innodb_encrypt_log startup This fixes several InnoDB bugs related to innodb_encrypt_log and two Mariabackup --backup bugs. log_crypt(): Properly derive the initialization vector from the start LSN of each block. Add a debug assertion. log_crypt_init(): Note that the function should only be used when creating redo log files and that the information is persisted in the checkpoint pages. xtrabackup_copy_log(): Validate data_len. xtrabackup_backup_func(): Always use the chosen checkpoint buffer. log_group_write_buf(), log_write_up_to(): Only log_crypt() the redo log payload, not the padding bytes. innobase_start_or_create_for_mysql(): Do not invoke log_crypt_init() or initiate a redo log checkpoint. recv_find_max_checkpoint(): Return the contents of LOG_CHECKPOINT_NO to xtrabackup_backup_func() in log_sys->next_checkpoint_no.	8 years ago

... 2 3 4 5 6 ...

395 Commits (5018b998a76b99a30efe96ca007a95a5a1c83bb5)