mariadb

Tree: 4c50120d14

Author	SHA1	Message	Date
Marko Mäkelä	4c50120d14	MDEV-23474 InnoDB fails to restart after SET GLOBAL innodb_log_checksums=OFF Regretfully, the parameter innodb_log_checksums was introduced in MySQL 5.7.9 (the first GA release of that series) by mysql/mysql-server@af0acedd885eb7103e319f79d25fda7386ef1506 which partly replaced a parameter that had been introduced in 5.7.8 mysql/mysql-server@22ba38218e1d76c24f69b5a5595ad3bf5933acb0 as innodb_log_checksum_algorithm. Given that the CRC-32C operations are accelerated on many processor implementations (AMD64 with SSE4.2; since MDEV-22669 also on IA-32 with SSE4.2, POWER 8 and later, ARMv8 with some extensions) and by lookup tables when only generic SISD instructions are available, there should be no valid reason to disable checksums. In MariaDB 10.5.2, as a preparation for MDEV-12353, MDEV-19543 deprecated and ignored the parameter innodb_log_checksums altogether. This should imply that after a clean shutdown with innodb_log_checksums=OFF one cannot upgrade to MariaDB Server 10.5 at all. Due to these problems, let us deprecate the parameter innodb_log_checksums and honor it only during server startup. The command SET GLOBAL innodb_log_checksums will always set the parameter to ON.	5 years ago
Thirunarayanan Balathandayuthapani	8268f26605	MDEV-22934 Table disappear after two alter table command Problem: ======= InnoDB drops the column which has foreign key relations on it. So it tries to load the foreign key during rename process of copy algorithm even though the foreign_key_check is disabled. Solution: ======== During alter copy algorithm, InnoDB ignores the error while loading the foreign key constraint if foreign key check is disabled. It should throw the warning about failure of the foreign key constraint when foreign key check is disabled.	5 years ago
Thirunarayanan Balathandayuthapani	362b18c536	MDEV-23380 InnoDB reads a page from disk despite parsing MLOG_INIT_FILE_PAGE2 record This problem is caused by `6697135c6d` (MDEV-21572). During recovery, InnoDB prefetches the siblings of change buffer index leaf page. It does asynchronous page read and recovery scenario wasn't handled in buf_read_page_background(). It leads to the refusal of startup of the server. Solution: ========= InnoDB shouldn't allow the change buffer index page siblings to be prefetched.	5 years ago
Marko Mäkelä	3e617b8bef	Merge 10.1 into 10.2	5 years ago
Marko Mäkelä	7c2aad6be2	MDEV-23463 fil_page_decompress() debug check wastes 128KiB of stack fil_page_decompress(): Remove a rather useless debug check. We should have test coverage for reading page_compressed pages from files, either due to buffer pool page eviction or due to server restarts. A similar check was removed from fil_space_encrypt() in commit `0b36c27e0c` (MDEV-20307).	5 years ago
Marko Mäkelä	182e2d4a6c	Merge 10.1 into 10.2	5 years ago
Marko Mäkelä	101ce10d0d	MDEV-20672 Inconsistent usage message for innodb_compression_algorithm The usage message for the innodb_compression_algorithm system variable did not list snappy, which was added as an optional compression algorithm in MariaDB 10.1.3 and might actually work since commit `90c52e5291` (MDEV-12615) in MariaDB 10.1.24. Unfortunately, we will include also unavailable compression algorithms in the list, because ENUM parameters allow numeric values, and we do not want innodb_compression_algorithm=3 to change meaning depending on the way how the source code was compiled.	5 years ago
Marko Mäkelä	efd8af535a	MDEV-19526 heap number overflow on innodb_page_size=64k InnoDB only reserves 13 bits for the heap number in the record header, limiting the heap number to be at most 8191. But, when using innodb_page_size=64k and secondary index records of 7 bytes each, it is possible to exceed the maximum heap number. btr_cur_optimistic_insert(): Let the operation fail if the maximum number of records would be exceeded. page_mem_alloc_heap(): Move to the same compilation unit with the only caller, and let the operation fail if the maximum heap number has been allocated already.	5 years ago
Marko Mäkelä	18f374cb20	MDEV-23439 Assertion size == space->size failed in buf_read_ahead_random The debug assertion is bogus, and we had removed it in commit `b1ab211dee` (MDEV-15053) in the MariaDB Server 10.5 branch. For a small data file, fil_space_extend_must_retry() would always allocate a minimum size of 4*innodb_page_size. It is possible that random read-ahead will be triggered for a smaller file than this. In the observed case, the read-ahead was triggered for a 6-page file that used ROW_FORMAT=COMPRESSED with 8KiB page size. So, the desired file size was 49152 bytes, but the actual size was 65536 bytes.	5 years ago
Marko Mäkelä	4387e3a13b	Use DBUG_ASSERT(ptr != NULL) to ease merging to 10.3 In 10.3, DBUG_ASSERT() may expand to something that includes __builtin_expect(), which expects integer arguments, not pointers. To avoid any compiler warnings, let us use an explicit rather than implicit comparison to the null pointer.	5 years ago
Eugene Kosov	5a4ae142f4	replace assert() with DBUG_ASSERT()	5 years ago
Eugene Kosov	01738d08f3	add debug assertion to ilist	5 years ago
Marko Mäkelä	c96be848d3	MDEV-14119 Assertion cmp_rec_rec() in ALTER TABLE innobase_pk_order_preserved(): Treat an added AUTO_INCREMENT column in the same way as an added existing column. In either case, the column values are not guaranteed to be constant, and thus the ordering may change if such a column is added before any existing PRIMARY KEY columns. prepare_inplace_alter_table_dict(): Initialize dict_table_t::persistent_autoinc before invoking innobase_pk_order_preserved().	5 years ago
Marko Mäkelä	de8d57e522	MDEV-23447 SIGSEGV in fil_system_t::keyrotate_next() fil_system_t::keyrotate_next(): If space && space->is_in_rotation_list does not hold, iterate from the start of the list. In debug builds, we would typically have hit SIGSEGV because the iterator would have wrapped a null pointer. It might also be that we are dereferencing a stale pointer. There is no test case, because the encryption is very nondeterministic in nature, due to the use of background threads. This scenario can be hit by setting the following: SET GLOBAL innodb_encryption_threads=5; SET GLOBAL innodb_encryption_rotate_key_age=0;	5 years ago
Marko Mäkelä	31aef3ae99	Fix GCC 10.2.0 -Og -Wmaybe-uninitialized For some reason, GCC emits more -Wmaybe-uninitialized warnings when using the flag -Og than when using -O2. Many of the warnings look genuine.	5 years ago
Julius Goryavsky	7ad4709a3b	MDEV-21526: mysqld_multi no longer works with different server binaries The problem is caused by the fact that adding the --defaults-group-suffix option to fix MDEV-18863 causes mysqld to read all options from the appropriate sections of the config file, including options specific to mysqld_multi. Reading unknown options (which are not supported by mysqld) causes mysqld to terminate with an error. However, the MDEV-18863 problem has been completely fixed by passing options on the command line, and now there is no need to specify the --defaults-group-suffix option (we just need to give priority to options passed through the command line, so as not to break MDEV-18863).	5 years ago
Jan Lindström	57d1a5fa8e	MDEV-22543 : Galera SST donation fails, FLUSH TABLES WITH READ LOCK times out During SST we need to let FTWRL to use normal timeout method even when client is disconnected.	5 years ago
Alexander Barkov	caf105905a	Fixing sporading builtbot test failures happening at '00:00:00' sharp Some tests relied on the fact that DATETIME->DATE conversion always produce a truncation (with a warning). This is not the case when the SQL statement is executed at current time '00:00:00' sharp. Adding a new SET TIMESTAMP statements to make sure time is not '00:00:00'.	5 years ago
Vladislav Vaintroub	78ea8ad425	MDEV-23378 - fix an alleged memory "leak" in threadpool. Implement a workaround to shut the "memory not freed" message.	5 years ago
Marko Mäkelä	3b6dadb5eb	Merge 10.1 into 10.2	5 years ago
Marko Mäkelä	0460d42b94	Merge mariadb-10.2.33	5 years ago
Daniel Bartholomew	debd36c880	bump the VERSION	5 years ago
Marko Mäkelä	7f67ef1485	MDEV-16115 Hang after reducing innodb_encryption_threads The test encryption.create_or_replace would occasionally fail, because some fil_space_t::n_pending_ops would never be decremented. fil_crypt_find_space_to_rotate(): If rotate_thread_t::should_shutdown() holds due to innodb_encryption_threads having been reduced, do release the reference. fil_space_remove_from_keyrotation(), fil_space_next(): Declare the functions static, simplify a little, and define in the same compilation unit with the only caller, fil_crypt_find_space_to_rotate(). fil_crypt_key_mutex: Remove (unused).	5 years ago
Daniel Bartholomew	3e3da1642d	bump the VERSION	5 years ago
Oleksandr Byelkin	b350ef4cf4	Merge remote-tracking branch 'bb-10.1-release' into 10.1	5 years ago
Daniel Black	deb365581b	MDEV-23386: mtr: main.mysqld--help autosized table{-open,}-cach and max-connections Example of the failure: http://buildbot.askmonty.org/buildbot/builders/bld-p9-rhel7/builds/4417/steps/mtr/logs/stdio ``` main.mysqld--help 'unix' w17 [ fail ] Test ended at 2020-06-20 18:51:45 CURRENT_TEST: main.mysqld--help --- /opt/buildbot-slave/bld-p9-rhel7/build/mysql-test/main/mysqld--help.result 2020-06-20 16:06:49.903604179 +0300 +++ /opt/buildbot-slave/bld-p9-rhel7/build/mysql-test/main/mysqld--help.reject 2020-06-20 18:51:44.886766820 +0300 @@ -1797,10 +1797,10 @@ sync-relay-log-info 10000 sysdate-is-now FALSE system-versioning-alter-history ERROR -table-cache 421 +table-cache 2000 table-definition-cache 400 -table-open-cache 421 -table-open-cache-instances 1 +table-open-cache 2000 +table-open-cache-instances 8 tc-heuristic-recover OFF tcp-keepalive-interval 0 tcp-keepalive-probes 0 mysqltest: Result length mismatch ``` mtr: table_open_cache_basic autosized: Lets assume that >400 are available and that we can set the result back to the start value. All of these system variables are autosized and can generate MTR output differences. Closes #1527	6 years ago
Jan Lindström	845e3c9801	Replaced infinite loop in procedure with limited loop to avoid hang.	5 years ago
Jan Lindström	1dec60c795	MDEV-22626: mysql_tzinfo_to_sql not replicates timezone to galeranodes if only 1 timezone will be loaded. Move alter to InnoDB earlier to more correct place to handle also if only a one timezone file is loaded.	5 years ago
Sergei Golubchik	fbcae42c2a	Merge branch '10.1' into 10.2	5 years ago
Varun Gupta	caa474f8e3	MDEV-15180: server crashed with NTH_VALUE() fix_fields for the arguments of the NTH_VALUE function was updating the same reference, so for the second argument (or after the first argument) the items were not resolved to their corresponding field from the view as they were updating the reference to the first argument.	5 years ago
Sergei Golubchik	c0ac310e3e	link failure on fulltest (xenial) depending on build config the error might be hidded, in particular liblz4.so and libjemalloc.so make it to disappear, but with -DWITH_INNODB_LZ4=NO -DWITH_JEMALLOC=NO it reappears.	5 years ago
Sergei Petrunia	85bd5314c5	Better comment about TABLE::maybe_null	5 years ago
Varun Gupta	ab578bdf45	MDEV-9513: Assertion `join->group_list \|\| !join->is_in_subquery()' failed in create_sort_index Removing the ORDER BY clause from the UNION when UNION is inside an IN/ALL/ANY/EXISTS subquery. The rewrites are done for subqueries but this rewrite is not done for the fake_select of the UNION.	5 years ago
Varun Gupta	1e31d74833	MDEV-17066: Bytes lost or Assertion `status_var.local_memory_used == 0 after DELETE with subquery with ROLLUP The issue here is when records are read from the temporary file (filesort result in this case) via a cache(rr_from_cache). The cache is initialized with init_rr_cache. For correlated subquery the cache allocation is happening at each execution of the subquery but the deallocation happens only once and that was when the query execution was done. So generally for subqueries we do two types of cleanup 1) Full cleanup: we should free all resources of the query(like temp tables). This is done generally when the query execution is complete or the subquery re-execution is not needed (case with uncorrelated subquery) 2) Partial cleanup: Minor cleanup that is required if the subquery needs recalculation. This is done for all the structures that need to be allocated for each execution (example SORT_INFO for filesort is allocated for each execution of the correlated subquery). The fix here would be free the cache used by rr_from_cache in the partial cleanup phase.	5 years ago
Alexander Barkov	0e80f5a693	MDEV-23105 Cast number string with many leading zeros to decimal gives unexpected result Skip leading zeros when converting a string to decimal_t.	5 years ago
Sergei Golubchik	a09a06d597	Merge branch 'merge/merge-tokudb-5.6' into 10.1	5 years ago
Sergei Golubchik	2adaaeba83	5.6.49-89.0	5 years ago
Marko Mäkelä	91caf130b7	MDEV-23101 fixup: Remove redundant code lock_rec_has_to_wait_in_queue(): Remove an obviously redundant assertion that was added in commit `a8ec45863b` and also enclose a Galera-specific condition in #ifdef WITH_WSREP.	5 years ago
Sachin	e3c18b8e84	MDEV-23089 rpl_parallel2 fails in 10.5 Problem:- rpl_parallel2 was failing non-deterministically Analysis:- When FLUSH TABLES WITH READ LOCK is executed, it will allow all worker threads to complete their ongoing transactions and then it will pause them. At this state FTWRL will proceed to acquire global read lock. FTWRL first blocks threads from starting new commits, then upgrades the lock to block commit of existing transactions. Step1: FLUSH TABLES WITH READ LOCK - Blocks new commits Step2: * STOP SLAVE command enables 'force_abort=1' which unblocks workers, they continue to execute events. * T1: Waits in 'record_gtid' call to update 'gtid_slave_pos' table with its current GTID, but it is blocked becuase of Step1. * T2: Holds COMMIT lock and waits for T1 to commit. Step3: FLUSH TABLES WITH READ LOCK - Waiting to get BLOCK_COMMIT. This results in deadlock. When STOP SLAVE command allows paused workers to proceed, workers should skip the execution of all further events, similar to 'conservative' parallel mode. Solution:- We will assign 1 to skip_event_group when we are aborted in do_ftwrl_wait. rpl_parallel_entry->pause_sub_id is only reset when force_abort is off in rpl_pause_after_ftwrl.	5 years ago
Rucha Deodhar	5fb07d22f1	MDEV-23082: ER_TABLEACCESS_DENIED_ERROR error message is truncated, and inaccurately Analysis: The list of all privileges is 118 characters wide. However, the format of error message was: "%-.32s command denied to user...". get_length() sets the maximum width to 32 characters. As a result, only first 32 characters of list of privilege are stored. Fix: Changing the format to "%-.100T..." so that get_length() sets width to 100. Hence, first 100 characters of the list of privilege are stored and the type specifier 'T' appends '...' so that truncation can be seen.	5 years ago
Rucha Deodhar	745fa255ba	MDEV-14836: Assertion `m_status == DA_ERROR' failed in Diagnostics_area::sql_errno upon query from I_S with LIMIT ROWS EXAMINED open_normal_and_derived_table() fails because the query was already killed as rows examined by the query are more than the limit. However, this isn't a real error. Fix: Check if there is actually an error before calling thd->sql_errno() and later send a warning in handle_select() if no real error.	5 years ago
Jan Lindström	87b1625b5c	Test case MW-328A still fails, thus disable it until it is really fixed.	5 years ago
Jan Lindström	a8ec45863b	MDEV-23101: SIGSEGV in lock_rec_unlock() when Galera is enabled lock_rec_has_to_wait wsrep_kill_victim lock_rec_create_low lock_rec_add_to_queue DeadlockChecker::select_victim() THD can't change from normal transaction to BF (brute force) transaction here, thus there is no need to syncronize access in wsrep_thd_is_BF function. lock_rec_has_to_wait_in_queue Add condition that lock is not NULL and add assertions if we are in strong state.	5 years ago
Sergei Petrunia	8bca92c884	Fix the typo in fix for MDEV-21472	5 years ago
Sergei Golubchik	acfc500d03	compilation error on bintar-centos6-amd64-debug /home/buildbot/buildbot/build/storage/xtradb/mtr/mtr0mtr.cc:97:37: error: invalid access to non-static data member ‘fil_space_t::latch’ of NULL object [-Werror=invalid-offsetof]	5 years ago
Elena Stepanova	dc716da457	List of unstable tests for 10.2.33 release	5 years ago
Elena Stepanova	9c84b80f84	Merge branch '10.1' into 10.2	5 years ago
Elena Stepanova	dbb4572fe9	MDEV-23375 parts.partition_debug fails when it's run after another test Make sure system tables aren't open, as the test kills the server	5 years ago
Elena Stepanova	7a4287d421	List of unstable tests for 10.1.46 release	5 years ago
Oleksandr Byelkin	db2a217334	Fix for mac	5 years ago

1 2 3 4 5 ...

183729 Commits (4c50120d1400eab236af70d36f1c683d2b30d59a) All Branches Search

183729 Commits (4c50120d1400eab236af70d36f1c683d2b30d59a)

All Branches