mariadb

Tree: 4b6e5cf7d6

Author	SHA1	Message	Date
msvensson@neptunus.(none)	9d87db7767	Bug#21813 An attacker has the opportunity to bypass query logging, part2 - Use the "%.*b" format when printing prepared and exeuted prepared statements to the log. - Add test case to check that also prepared statements end up in the query log Bug#14346 Prepared statements corrupting general log/server memory - Use "stmt->query" when logging the newly prepared query instead of "packet"	20 years ago
msvensson@neptunus.(none)	aa944afbe7	Remove debug printout from mysql_client_test	20 years ago
iggy@rolltop.ignatz42.dyndns.org	39a8fe6e44	Bug#21757: mysql_client_test fails in testcase when reading master.log file	20 years ago
msvensson@shellback.(none)	2b2985e0ea	Print lines from log file to see what's in them	20 years ago
rburnett@production.mysql.com	0199dda5a6	My previous change of replacing the call to sprintf with some memcpy type routines was not correct. This patch reverts that. mysql_client_test.c: reverting my previous change	20 years ago
Reggie@xgeek.	e26aef9f64	Some small cleanups that will help get mysql_client_test passing on Windows	20 years ago
msvensson@neptunus.(none)	dee4105ce0	Remove extra whitespace	20 years ago
msvensson@neptunus.(none)	862d5626a5	Add some more code to analyze why the fgets fails.	20 years ago
msvensson@neptunus.(none)	419e4dd46f	Add printouts in test case for bug17667	20 years ago
msvensson@neptunus.(none)	68168c8e8f	Change the 'sleep' into an explicit FLUSH LOGS command	20 years ago
msvensson@neptunus.(none)	2e4dbadf9f	fflush(NULL) before abort so that all pending writes are performed	20 years ago
msvensson@neptunus.(none)	e33bd1a309	Flush stderr before calling abort()	20 years ago
Reggie@xgeek.	7a8a33a941	please don't call methods that should always execute inside assert()	20 years ago
rburnett@production.mysql.com	a73a9da34b	mysql_client_test.c: Moving call that processes select results out of the assert	20 years ago
kroki/tomash@moonlight.intranet	cc98d26a23	Fix after manual merge.	20 years ago
kroki/tomash@moonlight.intranet	1917a99270	BUG#21206: memory corruption when too many cursors are opened at once Too many cursors (more than 1024) could lead to memory corruption. This affects both, stored routines and C API cursors, and the threshold is per-server, not per-connection. Similarly, the corruption could happen when the server was under heavy load (executing more than 1024 simultaneous complex queries), and this is the reason why this bug is fixed in 4.1, which doesn't support cursors. The corruption was caused by a bug in the temporary tables code, when an attempt to create a table could lead to a write beyond allocated space. Note, that only internal tables were affected (the tables created internally by the server to resolve the query), not tables created with CREATE TEMPORARY TABLE. Another pre-condition for the bug is TRUE value of --temp-pool startup option, which, however, is a default. The cause of a bug was that random memory was overwritten in bitmap_set_next() due to out-of-bound memory access.	20 years ago
kostja@bodhi.local	2ce1a07c89	A fix and a test case for Bug#15752 "Lost connection to MySQL server when calling a SP from C API" The bug was caused by lack of checks for misuse in mysql_real_query. A stored procedure always returns at least one result, which is the status of execution of the procedure itself. This result, or so-called OK packet, is similar to a result returned by INSERT/UPDATE/CREATE operations: it contains the overall status of execution, the number of affected rows and the number of warnings. The client test program attached to the bug did not read this result and ivnoked the next query. In turn, libmysql had no check for such scenario and mysql_real_query was simply trying to send that query without reading the pending response, thus messing up the communication protocol. The fix is to return an error from mysql_real_query when it's called prior to retrieval of all pending results.	20 years ago
holyfoot/hf@mysql.com/deer.(none)	00f56da9af	merging	20 years ago
cmiller@zippy.(none)	e62e730020	A patch to Bug#17667 didn't take into consideration that the vardir, which contains the server's binlog file, might be set to a different directory. This adds a new "vardir" parameter, which takes the name of the directory as a value, so that the test_bug17667() test can find the binlog.	20 years ago
guilhem@gbichot3.local	0594e1b84b	WL#3146 "less locking in auto_increment": this is a cleanup patch for our current auto_increment handling: new names for auto_increment variables in THD, new methods to manipulate them (see sql_class.h), some move into handler::, causing less backup/restore work when executing substatements. This makes the logic hopefully clearer, less work is is needed in mysql_insert(). By cleaning up, using different variables for different purposes (instead of one for 3 things...), we fix those bugs, which someone may want to fix in 5.0 too: BUG#20339 "stored procedure using LAST_INSERT_ID() does not replicate statement-based" BUG#20341 "stored function inserting into one auto_increment puts bad data in slave" BUG#19243 "wrong LAST_INSERT_ID() after ON DUPLICATE KEY UPDATE" (now if a row is updated, LAST_INSERT_ID() will return its id) and re-fixes: BUG#6880 "LAST_INSERT_ID() value changes during multi-row INSERT" (already fixed differently by Ramil in 4.1) Test of documented behaviour of mysql_insert_id() (there was no test). The behaviour changes introduced are: - LAST_INSERT_ID() now returns "the first autogenerated auto_increment value successfully inserted", instead of "the first autogenerated auto_increment value if any row was successfully inserted", see auto_increment.test. Same for mysql_insert_id(), see mysql_client_test.c. - LAST_INSERT_ID() returns the id of the updated row if ON DUPLICATE KEY UPDATE, see auto_increment.test. Same for mysql_insert_id(), see mysql_client_test.c. - LAST_INSERT_ID() does not change if no autogenerated value was successfully inserted (it used to then be 0), see auto_increment.test. - if in INSERT SELECT no autogenerated value was successfully inserted, mysql_insert_id() now returns the id of the last inserted row (it already did this for INSERT VALUES), see mysql_client_test.c. - if INSERT SELECT uses LAST_INSERT_ID(X), mysql_insert_id() now returns X (it already did this for INSERT VALUES), see mysql_client_test.c. - NDB now behaves like other engines wrt SET INSERT_ID: with INSERT IGNORE, the id passed in SET INSERT_ID is re-used until a row succeeds; SET INSERT_ID influences not only the first row now. Additionally, when unlocking a table we check that the thread is not keeping a next_insert_id (as the table is unlocked that id is potentially out-of-date); forgetting about this next_insert_id is done in a new handler::ha_release_auto_increment(). Finally we prepare for engines capable of reserving finite-length intervals of auto_increment values: we store such intervals in THD. The next step (to be done by the replication team in 5.1) is to read those intervals from THD and actually store them in the statement-based binary log. NDB will be a good engine to test that.	20 years ago
kroki@mysql.com	79ca4c1d55	bug #20152 : mysql_stmt_execute() overwrites parameter buffers When using a parameter bind MYSQL_TYPE_DATE in a prepared statement, the time part of the MYSQL_TIME buffer was written to zero in mysql_stmt_execute(). The param_store_date() function in libmysql.c worked directly on the provided buffer. Changed to use a copy of the buffer.	20 years ago
gluh@eagle.intranet.mysql.r18.ru	f9214221fc	Bug#19671 mysql_list_fields returns incorrect table name for VIEWs After view onening real view db name and table name are placed into table_list->view_db & table_list->view_name. Item_field class does not handle these names properly during intialization of Send_field. The fix is to use new class 'Item_ident_for_show' which sets correct view db name and table name for Send_field.	20 years ago
holyfoot@deer.(none)	7a1c9459b3	bug #19983 (mysql_client_test_embedded fails)	20 years ago
kent@mysql.com	97674810b0	don't let bugfix for bug#8303 break the bugfix for bug#8378 revert the fix for bug#8303 correct the test for bug#8378	20 years ago
serg@serg.mylan	cce88f7a5b	don't let bugfix for bug#8303 break the bugfix for bug#8378 revert the fix for bug#8303 correct the test for bug#8378	20 years ago
cmiller@zippy.(none)	230b52a835	Manually merged	20 years ago
knielsen@mysql.com	f0341ac431	Fix a bunch of non-Linux compile failures.	20 years ago
cmiller@zippy.(none)	85ffd9640e	SECURITY FIX Bug#17667: An attacker has the opportunity to bypass query logging. This adds a new, local-only printf format specifier to our *printf functions that allows us to print known-size buffers that must not be interpreted as NUL-terminated "strings." It uses this format-specifier to print to the log, thus fixing this problem.	20 years ago
sergefp@mysql.com	c67ed1ee8c	Fix incorrect merge: put '/*' comment start back.	20 years ago
monty@mysql.com	c04660e85e	Cleanup during review of new pushed code	20 years ago
konstantin@mysql.com	2ea0b9b72c	Revert the changeset for Bug#16144 "mysql_stmt_attr_get type error": it breaks binary compatibility. The patch will be left intact in 5.1.	20 years ago
konstantin@mysql.com	951943c22a	Undo the patch for Bug#16144 "mysql_stmt_attr_get type error", it breaks binary compatibility. The patch will be left intact in 5.1. Warning: this changeset should be null-merged into 5.1. A separate commit in order to push into the release clone of 5.0.19.	20 years ago
evgen@moonbone.local	0ce39664b6	Fixed bug#14169: type of group_concat() result changed to blob if tmp_table was used In a simple queries a result of the GROUP_CONCAT() function was always of varchar type. But if length of GROUP_CONCAT() result is greater than 512 chars and temporary table is used during select then the result is converted to blob, due to policy to not to store fields longer than 512 chars in tmp table as varchar fields. In order to provide consistent behaviour, result of GROUP_CONCAT() now will always be converted to blob if it is longer than 512 chars. Item_func_group_concat::field_type() is modified accordingly.	20 years ago
guilhem@mysql.com	0071749595	WL#2977 and WL#2712 global and session-level variable to set the binlog format (row/statement), and new binlog format called "mixed" (which is statement-based except if only row-based is correct, in this cset it means if UDF or UUID is used; more cases could be added in later 5.1 release): SET GLOBAL\|SESSION BINLOG_FORMAT=row\|statement\|mixed\|default; the global default is statement unless cluster is enabled (then it's row) as in 5.1-alpha. It's not possible to use SET on this variable if a session is currently in row-based mode and has open temporary tables (because CREATE TEMPORARY TABLE was not binlogged so temp table is not known on slave), or if NDB is enabled (because NDB does not support such change on-the-fly, though it will later), of if in a stored function (see below). The added tests test the possibility or impossibility to SET, their effects, and the mixed mode, including in prepared statements and in stored procedures and functions. Caveats: a) The mixed mode will not work for stored functions: in mixed mode, a stored function will always be binlogged as one call and in a statement-based way (e.g. INSERT VALUES(myfunc()) or SELECT myfunc()). b) for the same reason, changing the thread's binlog format inside a stored function is refused with an error message. c) the same problems apply to triggers; implementing b) for triggers will be done later (will ask Dmitri). Additionally, as the binlog format is now changeable by each user for his session, I remove the implication which was done at startup, where row-based automatically set log-bin-trust-routine-creators to 1 (not possible anymore as a user can now switch to stmt-based and do nasty things again), and automatically set --innodb-locks-unsafe-for-binlog to 1 (was anyway theoretically incorrect as it disabled phantom protection). Plus fixes for compiler warnings.	20 years ago
monty@mysql.com	dd1d40f8f8	Fixed new introduced bug in binlog.test with --ps-protocol	20 years ago
msvensson@devsrv-b.mysql.com	eb97818627	Bug#16143 mysql_stmt_sqlstate returns an empty string instead of '00000' - Init sql_state in mysql_stmt_init	20 years ago
serg@serg.mylan	63cfd11859	dbug changes: 1. dbug state is now local to a thread 2. new macros: DBUG_EXPLAIN, DBUG_EXPLAIN_INITIAL, DBUG_SET, DBUG_SET_INITIAL, DBUG_EVALUATE, DBUG_EVALUATE_IF 3. macros are do{}while(0) wrapped 4. incremental modifications to the dbug state (e.g. "+d,info:-t") 5. dbug code cleanup, style fixes 6. _db_on_ and DEBUGGER_ON/OFF removed 7. rest of MySQL code fixed because of 3 (missing ;) and 6 8. dbug manual updated 9. server variable @@debug (global and local) to control dbug from SQL! a. -#T to print timestamps in the log	20 years ago
brian@zim.tangent.org	0a5a30bef3	This patch removes the remaining TYPE= code from MySQL. It cleans up a number of tests where it was being called still (and failing). Also I cleaned up all of the extra scripts so that they now work.	20 years ago
msvensson@neptunus.(none)	5000951ab4	Bug#14013 mysql_stmt_store_result() bombs if a cursor is open - Add code to 'mysql_stmt_store_result' to allow it to be called on a prepared statement with open server side cursor. - Add tests to mysql_client_test that uses 'mysql_stmt_store_result'	20 years ago
andrey@lmy004.	bdf0f9a2d9	fix test of bug 12744 on OSX	20 years ago
konstantin@mysql.com	303ad65fb2	Post-merge fixes.	20 years ago
andrey@lmy004.	736faf4730	fix for bug #12744 (MYSQL_STMT operations cause seg fault after connection reset)	20 years ago
msvensson@neptunus.(none)	41c6fee874	Bug #15719 MYSQL_OPT_RECONNECT option is modified by mysql_real_connect - Move init of "reconnect" variable to mysql_init - Add test case to mysql_client_test.	20 years ago
konstantin@mysql.com	4ca48591f1	A fix and a test case for Bug#15613 "libmysqlclient API function mysql_stmt_prepare returns wrong field length"	20 years ago
konstantin@mysql.com	19fd36e254	A fix and a test case for Bug#16144 "mysql_stmt_attr_get type error": use the right type in mysql_stmt_attr_get	20 years ago
jimw@mysql.com	e228b43946	Fix value returned by mysql_warning_count() after fetching a prepared statement that generated a warning. (Bug #15510)	20 years ago
ingo@mysql.com	6b18dbef31	Bug#10932 - Building server with key limit of 128, makes test cases fail Allow for configuration of the maximum number of indexes per table. Added and used a configure.in macro. Replaced fixed limits by the configurable limit. Limited MyISAM indexes to its hard limit. Fixed a bug in opt_range.cc for many indexes with InnoDB. Tested for 2, 63, 64, 65, 127, 128, 129, 255, 256, and 257 indexes. Testing this part of the bugfix requires rebuilding of the server with different options. This cannot be done with our test suite. Therefore I added the necessary test files to the bug report. If you repeat the tests, please note that the ps_* tests fail for everything but 64 indexes. This is because of differences in the meta data, namely field lengths for index names etc.	20 years ago
konstantin@mysql.com	159bf8832e	A test case for Bug#14845 "mysql_stmt_fetch returns MYSQL_NO_DATA when COUNT(*) is 0". The bug itself cannot be repeated.	20 years ago
konstantin@mysql.com	85f5263284	A fix and a test case for Bug#13524 "lock timeout gives incorrect warning on open cursor"	20 years ago
konstantin@mysql.com	b318ed1768	A fix and a test case for Bug#13488 "Left outer join query incorrectly gives MYSQL_DATA_TRUNCATED"	20 years ago

... 2 3 4 5 6 ...

449 Commits (4b6e5cf7d652ea6a32803f26e41dfbca2eb325db)