mariadb

Tree: 45ed9dd957

Author	SHA1	Message	Date
Jan Lindström	29847a3736	MDEV-23751 : galera_3nodes test failures on ipv6 sst tests Fix assertion text it was too tight for some systems.	5 years ago
Vladislav Vaintroub	ade782c001	MDEV-23741 Windows : error when renaming file in ALTER TABLE The presumed reason for the error is that the file was opened by 3rd party antivirus or backup program, causing ERROR_SHARING_VIOLATION on rename. The fix, actually a workaround, is to retry MoveFileEx couple of times before finally giving up. We expect 3rd party programs not to hold file for extended time.	5 years ago
Vladislav Vaintroub	bfe612b738	MDEV-23663 - Add HAVE_INTEL_RDRAND flag for building WolfSSL, where appropiate	5 years ago
Vladislav Vaintroub	ccbe6bb6fc	MDEV-19935 Create unified CRC-32 interface Add CRC32C code to mysys. The x86-64 implementation uses PCMULQDQ in addition to CRC32 instruction after Intel whitepaper, and is ported from rocksdb code. Optimized ARM and POWER CRC32 were already present in mysys.	5 years ago
Marko Mäkelä	ab56cbcd81	Stabilize and clean up a test The counter buffer_flush_background_total_pages may be unreliable, because pages can be flushed in different means. So, let us only check INNODB_BUFFER_POOL_PAGES_FLUSHED.	5 years ago
Marko Mäkelä	d61c5696fa	Make a test more robust Change buffering will occasionally happen if other pages are not flushed quickly enough.	5 years ago
Marko Mäkelä	00cd53d39a	MDEV-23719: Make lock_sys use page_id_t Since commit `8ccb3caafb` it should be more efficient to use page_id_t rather than two separate variables for tablespace identifier and page number. lock_rec_fold(): Replaced with page_id_t::fold(). lock_rec_hash(): Replaced with lock_sys.hash(page_id). lock_rec_expl_exist_on_page(), lock_rec_get_first_on_page_addr(), lock_rec_get_first_on_page(): Replaced with lock_sys.get_first().	5 years ago
Marko Mäkelä	852771ba1e	MDEV-23719: Remove buf_block_t::lock_hash_val The InnoDB buffer block page descriptor is caching a value buf_block_t::lock_hash_val that should be quick to compute in the first place, as suggested by commit `14be814380`. lock_rec_fold(): Define as page_id_t::fold() instead of ut_fold_ulint_pair().	5 years ago
Jan Lindström	f381e019b6	MDEV-23574 : galera_3nodes.galera_ipv6_mariabackup_section MTR failed: Could not open '../galera/include/have_mariabackup.inc' Test case and configuration cleanup.	5 years ago
Jan Lindström	e3e657373a	MDEV-21769 : `galera_3nodes.galera_safe_to_bootstrap` fails Add wait_condition to wait correct cluster configuration.	5 years ago
Jan Lindström	96426dac91	MDEV-21655 : galera.galera_wan_restart_ist MTR fails sporadically: WSREP did not transition to state READY Replace sleeps with proper wait_conditions to wait correct cluster configuration.	5 years ago
Sujatha	873cc1e77a	MDEV-21839: Handle crazy offset to SHOW BINLOG EVENTS Problem: ======= SHOW BINLOG EVENTS FROM <"random"-pos> caused a variety of failures as reported in MDEV-18046. They are fixed but that approach is not future-proof as well as is not optimal to create extra check for being constructed event parameters. Analysis: ========= "show binlog events from <pos>" code considers the user given position as a valid event start position. The code starts reading data from this event start position onwards and tries to map it to a set of known events. Each event has a specific event structure and asserts have been added to ensure that, read event data, satisfies the event specific requirements. When a random position is supplied to "show binlog events command" the event structure specific checks will fail and they result in assert. For example: https://jira.mariadb.org/browse/MDEV-18046 In the bug description user executes CREATE TABLE/INSERT and ALTER SQL commands. When a crazy offset like "SHOW BINLOG EVENTS FROM 365" is provided code assumes offset 365 as valid event begin and proceeds to EVENT_LEN_OFFSET reads some random length and comes up with a crazy event which didn't exits in the binary log. In this quoted example scenario, event read at offset 365 is considered as "Update_rows_log_event", which is not present in binary log. Since this is a random event its validation fails and code results in assert/segmentation fault, as shown below. mysqld: /data/src/10.4/sql/log_event.cc:10863: Rows_log_event::Rows_log_event( const char, uint, const Format_description_log_event): Assertion `var_header_len >= 2' failed. 181220 15:27:02 [ERROR] mysqld got signal 6 ; #7 0x00007fa0d96abee2 in __assert_fail () from /lib/x86_64-linux-gnu/libc.so.6 #8 0x000055e744ef82de in Rows_log_event::Rows_log_event (this=0x7fa05800d390, buf=0x7fa05800d080 "", event_len=254, description_event=0x7fa058006d60) at /data/src/10.4/sql/log_event.cc:10863 #9 0x000055e744f00cf8 in Update_rows_log_event::Update_rows_log_event Since we are reading random data repeating the same command SHOW BINLOG EVENTS FROM 365 produces different types of crashes with different events. MDEV-18046 reported 10 such crashes. In order to avoid such scenarios user provided starting offset needs to be validated for its correctness. Best way of doing this is to make use of checksums if they are available. MDEV-18046 fix introduced the checksum based validation. The issue still remains in cases where binlog checksums are disabled. Please find the following bug reports. MDEV-22473: binlog.binlog_show_binlog_event_random_pos failed in buildbot, server crashed in read_log_event MDEV-22455: Server crashes in Table_map_log_event, binlog.binlog_invalid_read_in_rotate failed in buildbot Fix: ==== When binlog checksum is disabled, perform scan(via reading event by event), to validate the requested FROM <pos> offset. Starting from offset 4 read the event_length of next_event in the binary log. Using the next_event length advance current offset to point to next event. Repeat this process till the current offset is less than or equal to crazy offset. If current offset is higher than crazy offset provide appropriate invalid input offset error.	5 years ago
Jan Lindström	de76bebc57	MDEV-23659 : Update Galera disabled.def file	5 years ago
Jan Lindström	b69e980a38	MDEV-20581 Fix MTR test wsrep.variables Made the test work with --repeat option by adding galera_wait_ready.inc at the end of test. Recorded the test output.	5 years ago
Jan Lindström	7730b7bace	MDEV-23617 : galera_sr.galera_sr_rollback_retry MTR failed: 1213: Deadlock found when trying to get lock Add corrected wait_condition to wait until rows are in streaming replication log.	5 years ago
Sergei Golubchik	2bac9782aa	make install: don't assume $DESTDIR exists WORKING_DIRECTORY \$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX} means that this path already exists, which is not necessarily the case for make install. Create it `mkdir -p` style.	5 years ago
Daniel Black	5768f57d24	mtr: main.mysql_upgrade - record after correcting error message	5 years ago
Jan Lindström	fd5cbbb91e	MDEV-23591 : galera_3nodes.GCF-354 MTR failed: 1047: WSREP has not yet prepared node for application use Stabilize test.	5 years ago
Vlad Lesin	80075ba011	MDEV-19264 Better support MariaDB GTID for Mariabackup's --slave-info option Parse SHOW SLAVE STATUS output for the "Using_Gtid" column. If the value is "No", then old log file and position is backed up, otherwise gtid_slave_pos is backed up.	5 years ago
Nikita Malyavin	ae8ff3a067	MDEV-20396 Server crashes after DELETE with SEL NULL Foreign key and a virtual column in index Problem: row_ins_foreign_fill_virtual was unconditionally set virtual fields to NULL even though the field is not a part of a foreign key (but a part of an index) Solution: The new virtual value should be computed with regard to cascade updates.	5 years ago
Daniel Black	269f9c948c	mysql_upgrade: fix error text	5 years ago
Sachin	c3a3b4596c	MDEV-17438 rpl.show_status_stop_slave_race-7126 fails with timeout on Windows Problem:- Test case uses socket which does not work on windows, So mysqlslap falls back to default connection which is defined in my.cnf and connects to master instead of slave. Since start slave/stop slave is executed on master we get error MASTER_HOST was not set Solution:- Use Port instead of socket	5 years ago
Jan Lindström	bc2dbdb601	MDEV-23587 : galera_3nodes.galera_var_dirty_reads2 MTR failed: 1047: WSREP has not yet prepared node for application use Add wait_condition tomake sure insert is replicated and server is after isolation back on ready state.	5 years ago
Thirunarayanan Balathandayuthapani	af834c218a	MDEV-23199 page_compression flag is missing for full_crc32 tablespace - Changed the fil_space_set_recv_size_and_flags() to set the tablespace size when size is not zero.	5 years ago
Thirunarayanan Balathandayuthapani	bfd1ed5a13	MDEV-18867 Long Time to Stop and Start - Addressing ASAN failure in fts_check_aux_table()	5 years ago
Erol Guven	5f2728d594	Define variable to override endpoint url	5 years ago
Sergei Golubchik	897b51db43	make S3 tests to run when S3 is statically linked * use the environment variable HA_S3_SO, not a literal ha_s3 in cnf files * make ConfigFactory to support empty option values * update no_s3.result after MDEV-11412	5 years ago
Sergei Golubchik	5ad36aa3b8	de-virtualize redundantly virtual Item method and remove a couple of useless MY_TEST's	5 years ago
Sergei Golubchik	d2bf1ed030	MDEV-23492 performance_schema_digests_size changing from default to 5000 when enabling performance_schema max allowed value limit should be larger than any auto-sized value	5 years ago
Jan Lindström	8993e40dde	MDEV-23709 : Galera test failure on galera_fk_cascade_delete_debug Add wait_condition so that inserts to parent and child are replicated and applied before we set debug sync point.	5 years ago
Jan Lindström	224c950462	MDEV-23101 : SIGSEGV in lock_rec_unlock() when Galera is enabled Remove incorrect BF (brute force) handling from lock_rec_has_to_wait_in_queue and move condition to correct callers. Add a function to report BF lock waits and assert if incorrect BF-BF lock wait happens. wsrep_report_bf_lock_wait Add a new function to report BF lock wait. wsrep_assert_no_bf_bf_wait Add a new function to check do we have a BF-BF wait and if we have report this case and assert as it is a bug. lock_rec_has_to_wait Use new wsrep_assert_bf_wait to check BF-BF wait. lock_rec_create_low lock_table_create Use new function to report BF lock waits. lock_rec_insert_by_trx_age lock_grant_and_move_on_page lock_grant_and_move_on_rec Assert that trx is not Galera as VATS is not compatible with Galera. lock_rec_add_to_queue If there is conflicting lock in a queue make sure that transaction is BF. lock_rec_has_to_wait_in_queue Remove incorrect BF handling. If there is conflicting locks in a queue all transactions must wait. lock_rec_dequeue_from_page lock_rec_unlock If there is conflicting lock make sure it is not BF-BF case. lock_rec_queue_validate Add Galera record locking rules comment and use new function to report BF lock waits. All attempts to reproduce the original assertion have been failed. Therefore, there is no test case on this commit.	5 years ago
Thirunarayanan Balathandayuthapani	f19da4a05a	MDEV-23199 page_compression flag is missing for full_crc32 tablespace Problem: ====== Making the tablespace as page_compressed doesn't do table rebuild. It does change only the FSP_SPACE_FLAGS. During recovery: 1) InnoDB encounters FILE_CREATE redo log and opens the tablespace with old FSP_SPACE_FLAGS value. 2) Only parsing of redo log has been finished. Now InnoDB tries to load the table. If the existing tablespace flags doesn't match with table flags then InnoDB should read page0. But in fsp_flags_try_adjust(), skips the page read for full_crc32 format. 3) After that, InnoDB tries to open the clustered index and it leads to failure of page validation. Fix: === While parsing the redo log record, track FSP_SPACE_FLAGS in recv_spaces for the respective space id. Assign the flags for the tablespace when it is loaded. recv_parse_set_size_and_flags(): Parse the redo log to set the tablespace recovery size and flags. fil_space_set_recv_size_and_flags(): Changed from fil_space_set_recv_size(). To set the recovery size and flags of the tablespace. Introduce flags variable in file_name_t to maintain the tablespace flag which we encountered during parsing of redo log. is_flags_full_crc32_equal(), is_flags_non_full_crc32_equal(): Rename the variable page_ssize and space_page_ssize with fcrc32_psize and non_fcrc32_psize.	5 years ago
Thirunarayanan Balathandayuthapani	75e82f71f1	MDEV-18867 Long Time to Stop and Start fts_drop_orphaned_tables() takes long time to remove the orphaned FTS tables. In order to reduce the time, do the following: - Traverse fil_system.space_list and construct a set of table_id,index_id of all FTS_*.ibd tablespaces. - Traverse the sys_indexes table and ignore the entry from the above collection if it exist. - Existing elements in the collection can be considered as orphaned fts tables. construct the table name from (table_id,index_id) and invoke fts_drop_tables(). - Removed DICT_TF2_FTS_AUX_HEX_NAME flag usage from upgrade. - is_aux_table() in dict_table_t to check whether the given name is fts auxiliary table fts_space_set_t is a structure to store set of parent table id and index id - Remove unused FTS function in fts0fts.cc - Remove the fulltext index in row_format_redundant test case. Because it deals with the condition that SYS_TABLES does have corrupted entry and valid entry exist in SYS_INDEXES.	5 years ago
Geert Hendrickx	1bb3ad6dfc	MDEV-23589: Portability: use `uname -n` instead of `hostname` Closes PR #1663	5 years ago
Marko Mäkelä	3421223363	Merge 10.4 into 10.5	5 years ago
Jan Lindström	cf9b3b25b4	MDEV-23608 : galera_sr.GCF-597 MTR failed: query 'ROLLBACK' succeeded - should have failed with errno 1213 Added wait_condition to wait correct streaming state.	5 years ago
Jan Lindström	44e7e1f0d3	MDEV-23611 : galera_sr.galera_sr_kill_query MTR failed: 15 instead of 0 on "SELECT COUNT(*) AS EXPECT_0 FROM mysql.wsrep_streaming_log;" Add wait_condition to stabilize test.	5 years ago
Jan Lindström	90bea7c32c	MDEV-23613 : galera_sr.galera_sr_kill_slave MTR failed: query 'LOCK TABLE t2 WRITE' failed: 1146: Table 'test.t2' doesn't exist Remove unnecessary sleeps from test and replace them with proper wait_conditions.	5 years ago
Jan Lindström	5c07ce406b	MDEV-23706 : Galera test failure on galera_autoinc_sst_mariabackup Remove infinite procedure and use direct INSERTs.	5 years ago
Marko Mäkelä	66ae50a564	Merge 10.3 into 10.4	5 years ago
Jan Lindström	a569dc55fb	MDEV-23592 : galera_3nodes.inconsistency_shutdown MTR failed: Could not open '../galera/include/galera_have_debug_sync.inc' for reading, errno: 2 Correct include path.	5 years ago
Jan Lindström	e17d0eb6d2	MDEV-23593 : galera_3nodes.GCF-376 MTR failed: Table 'test.t1' doesn't exist Add wait_condition to make sure table is there.	5 years ago
Marko Mäkelä	7e07e38cf6	Merge 10.2 into 10.3	5 years ago
Marko Mäkelä	0eb38243ce	MDEV-23456 fixup: Simplify a comparison	5 years ago
Marko Mäkelä	040ae4c59b	MDEV-22924 fixup: Replace C++11 auto	5 years ago
Marko Mäkelä	d44c0f46c5	MDEV-22924 fixup: Replace C++11 nullptr Only starting with MariaDB Server 10.4 we may depend on C++11.	5 years ago
Marko Mäkelä	64c8fa58a8	MDEV-23685 SIGSEGV on ADD FOREIGN KEY after failed ADD KEY dict_foreign_qualify_index(): Reject corrupted or garbage indexes. For index stubs that are created on virtual columns, no dict_field_t::col would be assign. Instead, the entire table definition would be reloaded on a successful operation.	5 years ago
Marko Mäkelä	c26eae0cc0	MDEV-23456 fixup: Fix mtr_t::get_fix_count() Before commit `05fa4558e0` (MDEV-22110) we have slot->type == MTR_MEMO_MODIFY that are unrelated to incrementing the buffer-fix count. FindBlock::operator(): In debug builds, skip MTR_MEMO_MODIFY entries. Also, simplify the code a little. This fixes an infinite loop in the tests innodb.innodb_defragment and innodb.innodb_wl6326_big.	5 years ago
Thirunarayanan Balathandayuthapani	b1009ae5c1	MDEV-23456 fil_space_crypt_t::write_page0() is accessing an uninitialized page buf_page_create() is invoked when page is initialized. So that previous contents of the page ignored. In few cases, it calls buf_page_get_gen() is called to fetch the page from buffer pool. It should take x-latch on the page. If other thread uses the block or block io state is different from BUF_IO_NONE then release the mutex and check the state and buffer fix count again. For compressed page, use the existing free block from LRU list to create new page. Retry to fetch the compressed page if it is in flush list fseg_create(), fseg_create_general(): Introduce block as a parameter where segment header is placed. It is used to avoid repetitive x-latch on the same page Change the assert to check whether the page has SX latch and X latch in all callee function of buf_page_create() mtr_t::get_fix_count(): Get the buffer fix count of the given block added by the mtr FindBlock is added to find the buffer fix count of the given block acquired by the mini-transaction	5 years ago
Sergei Petrunia	d252f44c5d	Update libmarias3 to PR#92: updated PR#91, adds capability to support port number	5 years ago

... 4 5 6 7 8 ...

190995 Commits (45ed9dd957eebc7fc84feb2509f4aa6baa908a95) All Branches Search

190995 Commits (45ed9dd957eebc7fc84feb2509f4aa6baa908a95)

All Branches