mariadb

Tree: 42af2b1d8b

Author	SHA1	Message	Date
Anel Husakovic	42af2b1d8b	MDEV-22263: main.func_debug fails on a valgrind build with wrong result Patches of interest:374dae3ecc49, `374dae3ecc`	6 years ago
Alexander Barkov	e978efd96b	MDEV-20273 Add class Item_sum_min_max	6 years ago
Oleksandr Byelkin	f90040fd9c	MDEV-19429: Wrong query result with EXISTS and LIMIT 0 Check EXISTS LIMIT before rewriting.	6 years ago
Oleksandr Byelkin	490dcfd5d7	MDEV-19698: Cleanup READ_RECORD::record https://github.com/MariaDB/server/pull/777#issuecomment-496469366	7 years ago
Vladislav Vaintroub	374dae3ecc	MDEV-19452 - fix incorrect push_warning_printf String is not guaranteed to be null-terminated, thus push_warning_printf also needs to specify the length.	7 years ago
Vicențiu Ciorbaru	5543b75550	Update FSF Address * Update wrong zip-code	7 years ago
Igor Babaev	09aa5d3f69	MDEV-17894 Assertion `(thd->lex)->current_select' failed in MYSQLparse(), query with VALUES() A table value constructor can be used in all contexts where a select can be used. In particular an ORDER BY clause or a LIMIT clause or both of them can be attached to a table value constructor to produce a new query. Unfortunately execution of such queries was not supported. This patch fixes the problem.	7 years ago
Oleksandr Byelkin	4e01bc8c96	MDEV-16240: Assertion `0' failed in row_sel_convert_mysql_key_to_innobase Set table in row ID position mode before using this function.	7 years ago
Alexander Barkov	f4484dfdbf	MDEV-19008 Slow EXPLAIN SELECT ... WHERE col IN (const1,const2,(subquery))	7 years ago
Oleksandr Byelkin	54b2e1c1be	MDEV-16697: Fix difference between 32bit/windows and 64bit systems in allowed select nest level	7 years ago
Sergei Petrunia	b62ac16185	MDEV-6439: Server crashes in Explain_union::print_explain with explain in slow log, tis620 charset Item_subselect::is_expensive() used to return FALSE (Inexpensive) whenever it saw that one of SELECTs in the Subquery's UNION is degenerate. It ignored the fact that other parts of the UNION might not be inexpensive, including the case where pther parts of the UNION have no query plan yet. For a subquery in form col >= ANY (SELECT 'foo' UNION SELECT 'bar') this would cause the query to be considered inexpensive when there is no query plan for the second part of the UNION, which in turn would cause the SELECT 'foo' to compute and free itself while still inside JOIN::optimize for that SELECT (See MDEV comment for full description).	7 years ago
Oleksandr Byelkin	6b8802e8dd	MDEV-11071: Assertion `thd->transaction.stmt.is_empty()' failed in Locked_tables_list::unlock_locked_table fix_length_and_dec now return result (error/OK)	8 years ago
Alexander Barkov	106f0b5798	MDEV-16385 ROW SP variable is allowed in unexpected context The problem described in the bug report happened because the code did not test check_cols(1) after fix_fields() in a few places. Additionally, fix_fields() could be called multiple times for SP variables, because they are all fixed at a early stage in append_for_log(). Solution: 1. Adding a few helper methods - fix_fields_if_needed() - fix_fields_if_needed_for_scalar() - fix_fields_if_needed_for_bool() - fix_fields_if_needed_for_order_by() and using it in many cases instead of fix_fields() where the "fixed" status is not definitely known to be "false". 2. Adding DBUG_ASSERT(!fixed) into Item_splocal*::fix_fields() to catch double execution. 3. Adding tests. As a good side effect, the patch removes a lot of duplicate code (~60 lines): if (!item->fixed && item->fix_fields(..) && item->check_cols(1)) return true;	8 years ago
Sergei Golubchik	445ac662c3	MDEV-15755 Query crashing MariaDB in cleanup_after_query set the pointer to NULL to avoid double-free when the item is cleaned up many times (once in JOIN_TAB::cleanup(): tmp->jtbm_subselect->cleanup() and once at the end of the query, with all other items)	8 years ago
Sergei Golubchik	531acda484	MDEV-14820 System versioning is applied incorrectly to CTEs Make sure that SELECT_LEX_UNIT::derived, behaves as documented (points to the "TABLE_LIST representing this union in the embedding select"). For recursive CTE this was not necessarily the case, it could've pointed to the TABLE_LIST inside the CTE, not in the embedding select. To fix: * don't update unit->derived in mysql_derived_prepare(), pass derived as an argument to st_select_lex_unit::prepare() * prefer to set unit->derived in TABLE_LIST::init_derived() to the TABLE_LIST in the embedding select, not to the recursive reference. Fail if there are many TABLE_LISTs in the embedding select with conflicting FOR SYSTEM_TIME clauses. cleanup: * remove redundant THD* argument from st_select_lex_unit::prepare()	8 years ago
Sergei Golubchik	0f956a0676	cleanup: hide HA_ERR_RECORD_DELETED in ha_rnd_next() it's internal storage engine error, don't let it leak into the upper layer.	8 years ago
Monty	30ebc3ee9e	Add likely/unlikely to speed up execution Added to: - if (error) - Lex - sql_yacc.yy and sql_yacc_ora.yy - In header files to alloc() calls - Added thd argument to thd_net_is_killed()	8 years ago
Varun Gupta	2dd4e50d5f	MDEV-15555: select from DUAL where false yielding wrong result when in a IN For the query having an IN subquery with no tables, we were converting the subquery with an expression between the left part and the select list of the subquery . This can give incorrect results when we have a condition in the subquery with a dual table (as this is treated as a no table). The fix is that we don't do this conversion when we have conds in the subquery with a dual table.	8 years ago
Vladislav Vaintroub	6c279ad6a7	MDEV-15091 : Windows, 64bit: reenable and fix warning C4267 (conversion from 'size_t' to 'type', possible loss of data) Handle string length as size_t, consistently (almost always:)) Change function prototypes to accept size_t, where in the past ulong or uint were used. change local/member variables to size_t when appropriate. This fix excludes rocksdb, spider,spider, sphinx and connect for now.	8 years ago
Oleksandr Byelkin	96cb428b35	MDEV-14862: Server crashes in Bitmap<64u>::merge / add_key_field Do not unwrap view references to keep table info. (Row-IN subselect does not unwrap items so it does not need fix)	8 years ago
Monty	a7e352b54d	Changed database, tablename and alias to be LEX_CSTRING This was done in, among other things: - thd->db and thd->db_length - TABLE_LIST tablename, db, alias and schema_name - Audit plugin database name - lex->db - All db and table names in Alter_table_ctx - st_select_lex db Other things: - Changed a lot of functions to take const LEX_CSTRING* as argument for db, table_name and alias. See init_one_table() as an example. - Changed some function arguments from LEX_CSTRING to const LEX_CSTRING - Changed some lists from LEX_STRING to LEX_CSTRING - threads_mysql.result changed because process list_db wasn't always correctly updated - New append_identifier() function that takes LEX_CSTRING* as arguments - Added new element tmp_buff to Alter_table_ctx to separate temp name handling from temporary space - Ensure we store the length after my_casedn_str() of table/db names - Removed not used version of rename_table_in_stat_tables() - Changed Natural_join_column::table_name and db_name() to never return NULL (used for print) - thd->get_db() now returns db as a printable string (thd->db.str or "")	8 years ago
Igor Babaev	30289a2713	Fixed mdev-14969 Non-recursive Common Table Expressions used in view caused an error The function subselect_single_select_engine::print() did not print the WITH clause attached to a subselect with single select engine. As a result views using suqueries with attached WITH clauses lost these clauses when saved in frm files.	8 years ago
Sergei Golubchik	d31ee64da6	compiler warning	8 years ago
Alexander Barkov	590400f743	MDEV-14517 Cleanup for Item::with_subselect and Item::has_subquery()	8 years ago
Oleksandr Byelkin	c2c93fc6e4	MDEV-14164: Unknown column error when adding aggregate to function in oracle style procedure FOR loop Make differentiation between pullout for merge and pulout of outer field during exists2in transformation. In last case the field was outer and so we can safely start from name resolution context of the SELECT where it was pulled. Old behavior lead to inconsistence between list of tables and outer name resolution context (which skips one SELECT for merge purposes) which creates problem vor name resolution.	8 years ago
Galina Shalygina	a4ded0a9b5	Mistakes corrected. TVC can be used in IN subquery and in PARTITION BY struct now. Special variable to control working of optimization added.	8 years ago
Oleksandr Byelkin	235b68299b	MDEV-9619: Assertion `null_ref_table' failed in virtual table_map Item_direct_view_ref::used_tables() const on 2nd execution of PS Refer left expression indirectly in case it changes from execution to execution.	9 years ago
Vladislav Vaintroub	eba44874ca	MDEV-13844 : Fix Windows warnings. Fix DBUG_PRINT. - Fix win64 pointer truncation warnings (usually coming from misusing 0x%lx and long cast in DBUG) - Also fix printf-format warnings Make the above mentioned warnings fatal. - fix pthread_join on Windows to set return value.	8 years ago
Galina Shalygina	75370a58f4	New tests on errors added. Comments corrected. Some procedures corrected.	8 years ago
Eugene Kosov	5dd8e1bf2d	simplify READ_RECORD usage NFC READ_RECORD read_record; ... // this // read_record.read_record(&read_record); // becomes just read_record.read_record();	8 years ago
Galina Shalygina	91149bbd82	Mistakes corrected, new error messages added	8 years ago
Michael Widenius	cc77f9882d	Changed KEY names to use LEX_CSTRING	9 years ago
Michael Widenius	458d5ed8aa	Lots of small cleanups - Simplified use_trans_cache() to return at once if is_transactional is set - Indentation and spelling errors fixed - Don't call signal_update() if update_binlog_end_pos() is called as the function already calls signal_update() - Removed not used function wait_for_update_bin_log(), which would cause errors if ever used. - Simplified handler::clone() by always allocating 'ref' in ha_open(). To do this I added an optional MEM_ROOT argument to ha_open() to be used when allocating 'ref' - Changed arguments to get_system_var() from LEX_CSTRING to LEX_CSTRING* - Added THD as argument to create_select_for_variable(). Changed also char* argument to LEX_CSTRING to avoid strlen() call. - Change calls to append() to use LEX_CSTRING	9 years ago
Michael Widenius	4aaa38d26e	Enusure that my_global.h is included first - Added sql/mariadb.h file that should be included first by files in sql directory, if sql_plugin.h is not used (sql_plugin.h adds SHOW variables that must be done before my_global.h is included) - Removed a lot of include my_global.h from include files - Removed include's of some files that my_global.h automatically includes - Removed duplicated include's of my_sys.h - Replaced include my_config.h with my_global.h	9 years ago
Sergei Golubchik	be55bbc2b2	MDEV-7826 Server crashes in Item_subselect::enumerate_field_refs_processor upper->item can be NULL if we're referring to an aggregate function	8 years ago
Sergei Golubchik	c5975eaea1	MDEV-7339 Server crashes in Item_func_trig_cond::val_int Item_in_subselect::pushed_cond_guards[] array is allocated only when left_expr->maybe_null. And it is used (for row expressions) when left_expr->element_index(i)->maybe_null. For left_expr being a multi-column subquery, its maybe_null is always false when the subquery doesn't use tables (see Item_singlerow_subselect::fix_length_and_dec() and subselect_single_select_engine::fix_length_and_dec()), otherwise it's always true. But row elements can be NULL regardless, so let's always allocate pushed_cond_guards for multi-column subqueries, no matter whether its maybe_null was forced to true or false.	8 years ago
Sergei Golubchik	c917ba1d51	fix the comparison in st_select_lex::setup_ref_array() the array only needs to be reallocated if it's smaller than needed. Being larger is ok. also: remove a duplicated check (merge error)	9 years ago
Igor Babaev	5e9d651108	Fixed the bug mdev-12788. In some rare cases queries with UNION ALL using a derived table specified by a grouping select with a subquery in WHERE and impossible HAVING detected after constant row substitution could hang. The cause was not a proper return from the function subselect_single_select_engine::exec() in the case when the subquery was not optimized beforehand and the optimization performed in this function requested for a change of the subquery engine. This was fixed. Also a change was applied that avoided execution of a subquery if impossible having was detected for the main query at the optimization stage.	9 years ago
Igor Babaev	e0352fb079	Fixed the bug mdev-7599. At some conditions the function opt_sum_query() can apply MIN/MAX optimizations to to Item_sum objects of a select These optimizations becomes invalid if this select is the subquery of an IN subquery predicate that is converted to a EXISTS subquery. Thus in this case the MIX/MAX optimizations that have been applied in opt_sum_query() must be rolled back. This bug appeared in 5.3 when the code for the cost base choice between materialization and in-to-exists transformation of non-correlated IN subqueries was introduced. Before this code in-to-exists transformations were always performed before the call of opt_sum_query().	9 years ago
Igor Babaev	6b97fe067d	Fixed the bugs mdev-12670 and mdev-12675. The code that blocked conversion of a IN subselect pedicate to a semi-join if it occurred in the ON expression of an outer join did not do it correctly. As a result, the conversion was blocked for IN subselect predicates encountered in ON expressions of INNER joins or in WHERE conditions of mergeable views / derived tables. This patch fixes this problem.	9 years ago
Alexander Barkov	da63db1e3b	MDEV-12719 Determine Item::result_type() from Item::type_handler()	9 years ago
Alexander Barkov	4e9022b48b	MDEV-12718 Determine Item::cmp_type() from Item::type_handler()	9 years ago
Alexander Barkov	c898de84b7	MDEV-12714 Determine Item::field_type() from Item::type_handler()	9 years ago
Alexander Barkov	5a644e177f	Adding "const" qualifier to Item::cols(), and to the "Item *cmp" parameter to Type_handler::make_const_item_for_comparison()	9 years ago
Igor Babaev	0906dc49e8	Fixed the bug mdev-12564. Here's what started happening after the patch that fixed the bug mdev-10454 with query reported for the bug SELECT * FROM t t1 right JOIN t t2 ON (t2.pk = t1.pk) WHERE (t2.i, t2.pk) NOT IN ( SELECT t3.i, t3.i FROM t t3, t t4 ) AND t1.c = 'foo'; The patch added an implementation of propagate_equal_fields() for the class Item_row and thus opened the possibility of equal fields substitutions. At the prepare stage after setup_conds() called for WHERE condition had completed the flag of maybe_null of the Item_row object created for (t2.i, t2.pk) was set to false, because the maybe_null flags of both elements were set to false. However the flag of maybe_null for t1.pk from the ON condition were set to true, because t1 was an inner table of an outer join. At the optimization stage the outer join was converted to inner join, but the maybe_null flags were not corrected and remained the same. So after the substitution t2.pk/t1.pk. the maybe_null flag for the row remained false while the maybe_flag for the second element of the row was true. As a result, when the in-to_exists transformation was performed for the NOT IN predicate the guards variables were not created for the elements of the row, but a guard object for the second element was created. The object were not valid because it referred to NULL as a guard variable. This ultimately caused a crash when the expression with the guard was evaluated at the execution stage. The patch made sure that the guard objects are not created without guard variables. Yet it does not resolve the problem of inconsistent maybe_null flags. and it might be that the problem will pop op in other pieces of code. The resolution of this problem is not easy, but the problem should be resolved in future versions.	9 years ago
Monty	5a759d31f7	Changing field::field_name and Item::name to LEX_CSTRING Benefits of this patch: - Removed a lot of calls to strlen(), especially for field_string - Strings generated by parser are now const strings, less chance of accidently changing a string - Removed a lot of calls with LEX_STRING as parameter (changed to pointer) - More uniform code - Item::name_length was not kept up to date. Now fixed - Several bugs found and fixed (Access to null pointers, access of freed memory, wrong arguments to printf like functions) - Removed a lot of casts from (const char) to (char) Changes: - This caused some ABI changes - lex_string_set now uses LEX_CSTRING - Some fucntions are now taking const char* instead of char* - Create_field::change and after changed to LEX_CSTRING - handler::connect_string, comment and engine_name() changed to LEX_CSTRING - Checked printf() related calls to find bugs. Found and fixed several errors in old code. - A lot of changes from LEX_STRING to LEX_CSTRING, especially related to parsing and events. - Some changes from LEX_STRING and LEX_STRING & to LEX_CSTRING* - Some changes for char* to const char* - Added printf argument checking for my_snprintf() - Introduced null_clex_str, star_clex_string, temp_lex_str to simplify code - Added item_empty_name and item_used_name to be able to distingush between items that was given an empty name and items that was not given a name This is used in sql_yacc.yy to know when to give an item a name. - select table_name."' is not anymore same as table_name. - removed not used function Item::rename() - Added comparision of item->name_length before some calls to my_strcasecmp() to speed up comparison - Moved Item_sp_variable::make_field() from item.h to item.cc - Some minimal code changes to avoid copying to const char * - Fixed wrong error message in wsrep_mysql_parse() - Fixed wrong code in find_field_in_natural_join() where real_item() was set when it shouldn't - ER_ERROR_ON_RENAME was used with extra arguments. - Removed some (wrong) ER_OUTOFMEMORY, as alloc_root will already give the error. TODO: - Check possible unsafe casts in plugin/auth_examples/qa_auth_interface.c - Change code to not modify LEX_CSTRING for database name (as part of lower_case_table_names)	9 years ago
Igor Babaev	54a995cd22	Fixed the bug mdev-12519. This patch fixed some problems that occurred with subqueries that contained directly or indirectly recursive references to recursive CTEs. 1. A [NOT] IN predicate with a constant left operand and a non-correlated subquery as the right operand used in the specification of a recursive CTE was considered as a constant predicate and was evaluated only once. Now such a predicate is re-evaluated after every iteration of the process that produces the records of the recursive CTE. 2. The Exists-To-IN transformation could be applied to [NOT] IN predicates with recursive references. This opened a possibility of materialization for the subqueries used as right operands. Yet, materialization is prohibited for the subqueries if they contain a recursive reference. Now the Exists-To-IN transformation cannot be applied for subquery predicates with recursive references. The function st_select_lex::check_subqueries_with_recursive_references() is called now only for the first execution of the SELECT.	9 years ago
Oleksandr Byelkin	05d3c3d3f7	MDEV-10141: Add support for INTERSECT (and common parts for EXCEPT) MDEV-10140: Add support for EXCEPT	9 years ago
Oleksandr Byelkin	7aa09a5ed2	MDEV-10141: Add support for INTERSECT (and common parts for EXCEPT) MDEV-10140: Add support for EXCEPT	9 years ago
Varun Gupta	43903745e5	MDEV-11078: NULL NOT IN (non-empty subquery) should never return results Disabling the cond guards during the creation of Tricond Item for constant and NULL left expression items	9 years ago

1 2 3 4 5 ...

1454 Commits (42af2b1d8b8a8508c5aac5c2e0bcf4554c5200ce)